Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-02 Thread Michael Pyne
ult for new users (who use either of the 'quick config' schemes like kdesrc-build-setup or kdesrc-build --initial-setup), but to leave the built-in default unchanged. So in essence, existing kdesrc-build users (who had a folder-based layout by default unless they went out of their way to find the right option) saw no change, but new users would have that option pre-set for them in the config. Regards, - Michael Pyne

Re: Notice of upcoming changes to the behaviour of the anongit network

2020-04-11 Thread Michael Pyne
as explained at https://community.kde.org/Sysadmin/GitKdeOrgManual#Let_Git_rewrite_URL_prefixes). kdesrc-build configures git to understand this "kde:" prefix by default. Regards, - Michael Pyne

Re: Update on Status of Gitlab Migration

2020-04-11 Thread Michael Pyne
1 https://gitlab.com/ 344 kde: All of the kde: repositories use the kde:foo syntax, where the 'foo' comes from the 'repopath' parameter of the sysadmin/repo-metadata YAML files. We may need to do on-the-fly conversion of the kde: repo paths if they won't be expressible as 'kde:foo' in the future, but we should have the information needed to do this in kdesrc-build to make this happen on-the-fly. Regards, - Michael Pyne

Re: kdesrc-build messes with environment

2019-04-27 Thread Michael Pyne
nt.kde.org/kde/kdesrc-build/issues/29 for the bug report. I have built a patch that might work and would appreciate if you could test. Regards, - Michael Pyne

Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2017-10-21 Thread Michael Pyne
> On Dec. 13, 2016, 9:11 p.m., Albert Astals Cid wrote: > > I honestly can't see how this would count as "bugfix". > > Heiko Becker wrote: > I see it as a security fix, considering that even Qt5Webkit is probably > affected by a three digit number of security issues in its old Webkit and >

Re: kdesrc-build: git pre-commit hooks

2017-07-31 Thread Michael Pyne
you have an idea on what that would look like? Path a user-defined command to run? Path to a directory containing specially-named hooks? Something else? Regards, - Michael Pyne

Re: Branching retrospective question re KDE frameworks 5.x work from 2011 onwards.

2017-02-28 Thread Michael Pyne
a light on some of the factors a git-using developer should consider and helped us to better use our source control tools. But I don't think it really impacted that much for our development, at least in comparison to all of the many other best practices we need to be aware of. Regards, - Michael Pyne

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Michael Pyne
installed and ran `oxygen-demo5 -style oxygen`. Used the GUI Benchmark feature to automatically cycle through all the listed features -- no crashes or obvious rendering errors. Thanks, Michael Pyne

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Michael Pyne
e review for :-) No, code review isn't for every developer to review every single patch that comes across just to see if it introduces a dependency bump. The cyclomatic complexity of that kind of review graph would be quite extreme ;). Regards, - Michael Pyne

Re: Review Request 129806: Update the list of KCModules

2017-01-11 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129806/#review101960 --- Ship it! Ship It! - Michael Pyne On Jan. 11, 2017, 6

Re: Discontinuing repository tarballs

2016-11-23 Thread Michael Pyne
disabled in kdesrc-build for a few months now. Of course, kdesrc-build was using the snapshots by default out of an effort to be gentler to KDE source code repositories, so if it's easier for you all to forgo the snapshots entirely then I'm fully supportive. Regards, - Michael Pyne

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-06-07 Thread Michael Pyne
reasonable time (e.g. this week), drop > the review and commit my change instead (with proper credits where due). > Otherwise (because of me being too busy with other stuff), just commit this > review (once the problem mentionned above is fixed, though I could not > investigate y

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-30 Thread Michael Pyne
(and perhaps ask Qt to document more stringently that guarantee for QCache::insert). Still though, I think the QColor return type change would make sense even independent of this RR. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-21 Thread Michael Pyne
git.reviewboard.kde.org/r/127866/diff/ Testing --- Compiled without warnings, installed and ran `oxygen-demo5 -style oxygen`. Used the GUI Benchmark feature to automatically cycle through all the listed features -- no crashes or obvious rendering errors. Thanks, Michael Pyne

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-21 Thread Michael Pyne
; Or get rid of using QCache (because this absence of guarantee at the > > insertion stage is too much of a pain to handle) ? > > > > Or just commit and wait for bug reports about freezes ? (but with a happy > > coverty) ? > > Michael Pyne wrote: > For the mo

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-15 Thread Michael Pyne
at's a bug, but we're ignoring it" before. But it does seem to me that if a crash *is* possible (especially in underlying library code) we should do something to avoid it. Either way I'll see if I can work up a revised patch but I'd still appreciate advic

Review Request 127866: Oxygen: Fix QCache usage

2016-05-07 Thread Michael Pyne
git.reviewboard.kde.org/r/127866/diff/ Testing --- Compiled without warnings, installed and ran `oxygen-demo5 -style oxygen`. Used the GUI Benchmark feature to automatically cycle through all the listed features -- no crashes or obvious rendering errors. Thanks, Michael Pyne

Re: Review Request 127629: Fix KDateTime::isValid() for ClockTime values

2016-05-04 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127629/#review95194 --- Ship it! Ship It! - Michael Pyne On April 10, 2016, 6

Re: KRandom regression + fix

2016-04-27 Thread Michael Pyne
uire review like code changes do but just in case it is on RR at https://git.reviewboard.kde.org/r/127778/ Regards, - Michael Pyne

Re: Why is C90 enforced in KDE?

2015-12-09 Thread Michael Pyne
On the other hand even MSVC supports //comments in C code. I think there's some way to get CMake to add compiler flags for .c files in particular; another option is to have flex generate a .cpp file, assuming that the code being generated is safely in the common subset of C and C++. Regards, - Michael Pyne

Re: Problem investigating a heap-use-after-free in kwindowsystem

2015-10-02 Thread Michael Pyne
* byte array." (emphasis mine). I'm willing to bet you're running into a case where libxcb is sending a reply that doesn't contain '\0' (after all, the resultant QList<> contains only 1 item), which ends up in a QByteArray that is ::fromRawData()'d, but had the source of that data freed at "free(reply)". Regards, - Michael Pyne

Re: kde-workspace repository locked

2015-09-26 Thread Michael Pyne
branches to leave the readme in... but 'master' should suffice, I would think. Regards, - Michael Pyne

Re: Proposal to improving KDE Software Repository Organization

2015-08-16 Thread Michael Pyne
chy" is also a slightly different question. There's no reason even with our current build metadata that we'd *have* to have project hierarchies, as long as each underlying git repository name remains unique. It might even make things easier since there would be no way for a sub-path in our project hierarchy (such as kde/kdelibs/kactivities) to mask a git repository name (kdelibs in this case). If we got rid of this it would take away the ability to easily refer collectively to related modules though, and I don't think we'd want to reimplement that with the high-level "Project" scheme being talked about. Regards, - Michael Pyne

Re: Using nullptr instead of Q_NULLPTR

2015-08-15 Thread Michael Pyne
amer varargs function was turned into passing 0, which C++ treated as an (32-bit) int instead of a pointer due to its use as a varargs argument. This wouldn't have happened if nullptr had been used. Regards, - Michael Pyne

Re: Updating our tools

2015-08-09 Thread Michael Pyne
ild-metadata that can be used to help. I believe i18n tracks the 'unstable' and 'stable' branches for each module and 'unstable' might mean "KF5" by now. This information *is* available with the project data directly. But maybe Albert or Luigi could better explain how the i18n infra is setup and what we can conclude from these variables. Regards, - Michael Pyne

Re: Strigi usage in KF5 world

2015-04-07 Thread Michael Pyne
to port its users, not because of a positive decision to keep using strigi. But I don't know, I haven't done a lot of KF5 porting... Regards, - Michael Pyne

Re: Build dependency issues with kdesrc-build

2015-02-06 Thread Michael Pyne
On Fri, February 6, 2015 15:11:22 Kevin Funk wrote: > On Thursday 05 February 2015 22:16:54 Michael Pyne wrote: > > However as of now it only reorders modules you pull into the build list, > > so > > you still need to specify dependencies somehow. E.g. if you only asked

Re: Build dependency issues with kdesrc-build

2015-02-05 Thread Michael Pyne
5-*-build-include, you can make your own kdesrc-buildrc that does the same thing; you can consider them as maintained sample files. Regards, - Michael Pyne

Re: Proposal to improving KDE Software Repository Organization

2014-08-19 Thread Michael Pyne
On Wed, August 20, 2014 00:48:36 Àlex Fiestas wrote: > On Monday 18 August 2014 21:54:40 Michael Pyne wrote: > > We await your comments, suggestions, clarification requests, and other > > feedback. > > The proposed solution will clearly help to improve the situation, so +1! &

Re: Proposal to improving KDE Software Repository Organization

2014-08-19 Thread Michael Pyne
entire set of divisions in one fell swoop. I'm open to other ideas, but that's a topic for a separate thread in any event. Regards, - Michael Pyne

Proposal to improving KDE Software Repository Organization

2014-08-18 Thread Michael Pyne
ollows for those who like reading excessively wordy text. Regards, - Michael Pyne Improving KDE Project Organization: A Proposal == 18 Aug 2014 Michael Pyne and Ben Cooksley This is a proposal to evolve the current method of organizing our mas

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-08-04 Thread Michael Pyne
> The question (more to Michael ;-) is whether unconditionally closing > > all FDs is acceptable in general (there's hell lot of Q_OS_* items, incl. > > Q_OS_HURD ;-) or the check should be inverted to > > > > #ifdef Q_OS_LINUX > > Michael Pyne w

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-08-03 Thread Michael Pyne
This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119497/ > --- > > (Updated July 27, 2014, 9:15 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Runtime, kdelibs, and > Michael Pyne. > >

Re: Update needed to binary compatibility guide for Windows?

2014-04-15 Thread Michael Pyne
On Mon, April 14, 2014 18:28:14 Ian Monroe wrote: > On Sun, Apr 13, 2014 at 6:36 PM, Michael Pyne wrote: > > If it's true, do we want > > to adopt a constraint on our handling of virtual functions in leaf classes > > based on this? > > IMO we shouldn't worry

Update needed to binary compatibility guide for Windows?

2014-04-13 Thread Michael Pyne
to confirm this behavior on Windows? If it's true, do we want to adopt a constraint on our handling of virtual functions in leaf classes based on this? (Adding virtual methods is already not permitted for non-leaf classes) Regards, - Michael Pyne [1] http://techb

Re: Is kpovmodeler still valid or should it be removed

2014-04-10 Thread Michael Pyne
On Wed, April 9, 2014 23:50:15 Burkhard Lück wrote: > From my pov I'd like to file a sysadmin request to move these apps to > unmaintained4: > > kpovmodeler > kuickshow > kgrab I'll +1 the request if you want to go ahead and file it. Regards, - Michael Pyne

Re: Review Request 117157: Unlock session via DBus

2014-04-03 Thread Michael Pyne
On Fri, April 4, 2014 02:20:28 Valentin Rusu wrote: > On Sunday, March 30, 2014 05:25:58 PM Michael Pyne wrote: > > In fact the list of folders and keys present in KWallet (though > > not their values) can be queried without unlocking KWallet, or even > > causing >

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Michael Pyne
ess to a TTY login we are already screwed, especially if they have enough skill to manually hack the qdbus command line invocations needed. Regards, - Michael Pyne

Re: kdesrc-build complains about a dependency cycle in kdelibs..

2014-03-15 Thread Michael Pyne
;s hard to be sure. But uncommenting the "branch-group latest-qt4" in the sample-rc file does work to break the cycle(s) so I've gone that route for now. Regards, - Michael Pyne

Re: kdesrc-build complains about a dependency cycle in kdelibs..

2014-03-15 Thread Michael Pyne
re very different now between KDE4 and KF5 versions of some modules. It's possible those branch names haven't been updated in the sample config so I'll try and take a look at it today. Regards, - Michael Pyne

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-08 Thread Michael Pyne
> On Feb. 7, 2014, 5:14 a.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 387 > > <https://git.reviewboard.kde.org/r/115497/diff/1-2/?file=242022#file242022line387> > > > > Again, might want to add error-checking here. If the salt can&#x

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-08 Thread Michael Pyne
e it turns out to be the exact same number (448 / 8 == 56). Or maybe it's better to warn the future developer when the KEYSIZE macro is defined not to change the PBKDF2 key size without also looking at the Blowfish persist handler. - Michael P

Re: Repository rename and consequences

2014-02-07 Thread Michael Pyne
or kwalletmanager then you should be able to use something like options kwalletmanager # your-options-here end options somewhere in your kdesrc-buildrc (as of kdesrc-build git from last month), and kdesrc-build will use those options once the module shows up. Regards, - Michael Pyne

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-06 Thread Michael Pyne
alt can't be saved for whatever reason then we don't want to destroy an existing old-style wallet by mistake. It looks like it would be as simple as returning an empty QByteArray if an error is detected. - Michael Pyne On F

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-06 Thread Michael Pyne
> On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 129 > > <https://git.reviewboard.kde.org/r/115497/diff/1/?file=242022#file242022line129> > > > > libgcrypt supports the "scrypt" key derivation func

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-05 Thread Michael Pyne
f this fails and we overwrite the hashed passwords on disk, couldn't there be data loss when we try to re-open them (when the user can't guess the key)? - Michael Pyne On Feb. 5, 2014, 3:10 p.m., Àlex Fiestas wrote: > > --

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Michael Pyne
and master and then investigating whether QProcess would be suitable for master (this might also help with KF5 and Windows porting, not that I expect KInfoCenter to do great things on Windows). Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Review Request 113479: fix kshareddatacache on windows

2013-10-28 Thread Michael Pyne
matching counterpart in the Linux version, so I hope I didn't write the Windows code. ;) - Michael Pyne On Oct. 28, 2013, 10:07 a.m., Sune Vuorela wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-21 Thread Michael Pyne
> On Sept. 23, 2013, 9:12 a.m., Kevin Ottens wrote: > > Any reason why this patch isn't committed yet? Please do so ASAP. > > Kevin Ottens wrote: > Any news? > > I'll close it as discarded if I don't see any activity by next monday. I've integrated it, you don't have to worry about

Re: Review Request 113189: lower (a lot) warning noise caused by undefined macros

2013-10-10 Thread Michael Pyne
> On Oct. 10, 2013, 11:59 a.m., Bernd Buschinski wrote: > > This is a bit confussing... > > > > lets sum up the background story: > > - kjs(/wtf) loves gcc features > > - kjs-cmake filters out (gcc) pedantic > > > > now comes the problem... whats with other compilers? > > > > if you look at th

Re: kde-workspace master becomes Qt5-based

2013-09-25 Thread Michael Pyne
On Wed, September 25, 2013 13:55:57 Michael Pyne wrote: > On Thursday, September 19, 2013 19:24:51 Michael Pyne wrote: > > On Thu, September 19, 2013 19:30:52 Sebastian Kügler wrote: > > > We're planning to merge the frameworks-scratch branch of kde-workspace > > &g

Re: kde-workspace master becomes Qt5-based

2013-09-19 Thread Michael Pyne
sma2 ;)), you should switch to the > KDE/4.11 branch. The build will fail otherwise, so you will notice. > > This was a public service announcement. (And you can ask questions here.) Please don't forget to update kde-build-metadata! ;) I suppose I should go and update the samp

Re: Review Request 112458: Fix build with jpeg-9

2013-09-04 Thread Michael Pyne
commit. - Michael Pyne On Sept. 4, 2013, 5:49 a.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-30 Thread Michael Pyne
we can revert it later? We can at least be correct in KF5 while we wait for the rest of the frameworks to catch up. :) - Michael Pyne On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote: > > --- > This is an automatically generated e

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Michael Pyne
the hottest methods in KIconLoader that much slower). However I thought the KCM for the Desktop Theme Appearance already reset the cache as suggested by Aleix. Is this for situations where the theme is somehow changed via other means (such as direct edits to the rc files)? - Michael Pyne On

Update on git repository "logical" branch module groups

2013-08-12 Thread Michael Pyne
during the discussion at Akademy please let me know. You can find some further documentation on the Community Wiki: http://community.kde.org/Infrastructure/Project_Metadata. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Proposal for branching policy towards KF5

2013-07-29 Thread Michael Pyne
On Mon, July 29, 2013 22:09:38 Aurélien Gâteau wrote: > Le mercredi 24 juillet 2013 23:05:55 Michael Pyne a écrit : > > I didn't want to write another parser, but JSON has no native comment > > support, so the documentation [1] is on community.kde.org (though perhaps >

Re: Proposal for branching policy towards KF5

2013-07-26 Thread Michael Pyne
On Fri, July 26, 2013 21:11:21 Torgny Nyblom wrote: > On Thursday 25 July 2013 18.24.50 Michael Pyne wrote: > > The 'logical module groups' might play a role in the release process after > > a release is done, but shouldn't have any further role for tagging that

Re: Proposal for branching policy towards KF5

2013-07-25 Thread Michael Pyne
On Thu, July 25, 2013 22:44:47 Albert Astals Cid wrote: > El Dimecres, 24 de juliol de 2013, a les 23:05:55, Michael Pyne va escriure: > > On Fri, July 19, 2013 00:21:21 you wrote: > > > After more live discussion with Sebas and Marco plus Aaron over a video > > >

Re: Proposal for branching policy towards KF5

2013-07-24 Thread Michael Pyne
e them). [1]: http://community.kde.org/Infrastructure/Project_Metadata [2]: http://markmail.org/message/4l3yqerga7mfiit5 Anyways, thanks for your interest and please let me know if this will work to solve the problem at hand. If so I will start on integrating within kdesrc- build, and working with the sysadmins to support within the continuous integration infrastructure. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Proposal for branching policy towards KF5

2013-07-24 Thread Michael Pyne
On Tue, July 23, 2013 14:20:39 David Faure wrote: > On Saturday 20 July 2013 23:04:10 Michael Pyne wrote: > > This is a labor-intensive task, but it's easy to centrally-manage without > > having to rely on many different module maintainers or core developers for > > eac

Re: Supported Compilers / C++11 Support in KF5

2013-07-22 Thread Michael Pyne
as they can be used in normal code sections (even though that's probably a bad idea at this point). Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Proposal for branching policy towards KF5

2013-07-20 Thread Michael Pyne
en to be on vacation leave so I will try to be online to discuss on IRC, but failing that we can setup a separate thread on the relevant mailing lists to hash out details. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-17 Thread Michael Pyne
defect (and either way the script only uses dependency info to re-order modules you've asked to be built and warn if you've chosen the wrong branch). Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-15 Thread Michael Pyne
warning to the users that they have to adjust their config, if you want to coordinate something like that I'd be happy to put it in. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-15 Thread Michael Pyne
I try to fix it up for the users within kdesrc-build, but I don't see a way to assume that a user building kde- workspace master isn't actually doing it on purpose. Even if I check the kdelibs version they build, they could be using a self-built KF5. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-13 Thread Michael Pyne
g dev branch), until we're ready to cut over Qt5/KF5 to be the new 'master'? Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Releases in 3 months

2013-07-08 Thread Michael Pyne
se tags but that seems like it should work for all modules in the kde.org-released software. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-04 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111390/#review35587 --- Ship it! Change looks good to me, please commit. - Michael

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Michael Pyne
> On June 29, 2013, 8:31 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 45b7f137fbc0b942fd2c9b4e8d8c1f0293e64ba7 by Michael Pyne to branch KDE/4.10. I have also pushed to master to fix for KDE 4.11. Commit 194da6154375fc8103b8c4e29e385cd7ae2e.

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-26 Thread Michael Pyne
/checkpass_osfc2passwd.c appears to require the same guard on its strcmp(). Also I would prefer if ossi could +1/-1 the changes as he maintains the code but I can't figure out how to add people to a review request. - Michael Pyne On June 26, 2013, 5:18 p.m., mancha mancha

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Michael Pyne
ndency. It would not be acceptable to add or upgrade a dependency after the dep. freeze though. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-18 Thread Michael Pyne
possible. :) kdeui/dialogs/kjointhegamedialog_p.cpp <http://git.reviewboard.kde.org/r/110367/#comment24335> "activities do so" is wrong, I'm not sure what exactly is meant though. - Michael Pyne On May 9, 2013, 11:05 p.m., Albert Astals Cid wrote: > >

Re: filter unwated cflags? (-ffast-math)

2013-04-16 Thread Michael Pyne
ore, I can only +1 this about 1000 times or so. KJS with -ffast-math and friends is unsupportable so there's no reason to let the compile go on if we can detect it. That code should be considered completely miscompiled, if a user wants to use the flag anyways they can take it on themselves

Re: Review Request 109998: kjs: Fix CanvasImageData eating the color value by doing wrong alpha premultiply

2013-04-13 Thread Michael Pyne
that it's very difficult to "un-premultiply" the colors once you have an alpha of 0 introduced. Even without an alpha of 0, there is probably precision errors introduced with repeated changes to the color attributes the way we have it now, which would be a separate bug. - Michael Pyne

Re: Password strengh meter in KNewPasswordDialog

2013-04-03 Thread Michael Pyne
human generates [1]. In such a scenario it may be best to simply correlate "password strength" loosely with "password length". [1] http://reusablesec.blogspot.com/2010/10/new-paper-on-password-security-metrics.html Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Review Request 109814: bump workspace to require Qt 4.8.0

2013-04-01 Thread Michael Pyne
> On April 1, 2013, 10:18 p.m., Albert Astals Cid wrote: > > Qt 4.8 seems like it was released 1.5 years ago, if we need it for a > > feature I don't see why we should not increase the requirement I agree. Even RHEL 6.2 seems to be able to build Qt 4.8, so it doesn't seem like a severe require

Re: Downtime Notification: Git and Subversion

2013-03-26 Thread Michael Pyne
anongit.kde.org (not sure which one was selected), and there were no issues. I ran a "git fsck --full" on both as well to verify. I'm not sure what (if anything) changed in the meantime, but are you still having this error? Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: KDEReview: Nepomuk-Controller QML

2013-03-26 Thread Michael Pyne
ht be needed or desirable on their part to ensure a smooth transition for their users. The mailing list is moderated so expect that; your message will make it through regardless for this topic. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: KDEReview: Nepomuk-Controller QML

2013-03-25 Thread Michael Pyne
y the first time a new KDE 4.11 user logs in. Likewise it would be a good idea to ensure our Release Notes for 4.11 (if any are started) reflect the migration so that our packagers can ensure they change package dependencies if deemed appropriate. Not trying to discourage, but just some things t

Re: Interesting issue for kde-baseapps, Jenkins & kdesrc-build, proposed solution

2013-03-12 Thread Michael Pyne
y affects the module structure. Given the lack of opposition I have submitted a KDE Sysadmin bug [1] to request the move. I will update dependency-data and kdesrc-build after the move is complete. Thanks! [1] https://bugs.kde.org/show_bug.cgi?id=316629 Regards, - Michael Pyne

Interesting issue for kde-baseapps, Jenkins & kdesrc-build, proposed solution

2013-03-10 Thread Michael Pyne
stion? (And if so, I'd appreciate ideas for better ways to fix). Regards, - Michael Pyne [1] See kdesrc-build commit b48b7ed0db219f1d9e2b9cbb80b1be10fa238410; http://quickgit.kde.org/?p=kdesrc-build.git&a=commit&h=b48b7ed0db219f1d9e2b9cbb80b1be10fa238410 signature.asc Description: This is a digitally signed message part.

Re: kwalletmanager ui refactor

2013-02-03 Thread Michael Pyne
want to try --stat=120 to use more width, other you'll only see partial renames) Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Any chance to fix Bug 312320 in KDE 4.10?

2013-01-02 Thread Michael Pyne
hoot farther tonight. If no one else gets a chance to look I can commit and backport tomorrow night (~19 hours from now unfortunately). Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: Moving Trojitá to extragear

2012-11-22 Thread Michael Pyne
a no-effect wrapper when kdelibs isn't available. With other (non-KDE) translations systems it might also be possible to flag i18n() as the "translatable string" marker with a bit of extra work to make i18n() integrate with the alternative translation system. Regards, - Michael Pyne

Re: Review Request: Fix memory leak in KJSEmbed when connecting signals and slots through the QObject binding

2012-11-15 Thread Michael Pyne
). Assuming it still passes your Kross and script tests then please commit (since this is kdelibs, it should go to the KDE/4.9 branch only, it will be forward-ported for you). - Michael Pyne On Nov. 15, 2012, 10:42 a.m., Daniel Calviño Sánchez wrote

Re: Review Request: Fix memory leak in KJSEmbed when connecting signals and slots through the QObject binding

2012-11-14 Thread Michael Pyne
.constData() in order to use the QMetaObject::indexOfSignal and QMetaObject::indexOfSlot methods, and also for QObject::connect, but no other changes should be needed, and QByteArray will make sure the memory is properly deallocated when the function returns. - Michael Pyne On Nov. 14, 2012,

Re: Comparing KFileItems

2012-10-26 Thread Michael Pyne
ned version needs to exist. The compiler is still within its rights to actually inline the code if possible (unless you mark it as no_inline, which takes extra effort on your part). Or in other words, the compiler might do the right thing for you regardless. Regards, - Michael Pyne

Re: Comparing KFileItems

2012-10-18 Thread Michael Pyne
gh CPU usage as a possible con, even though it's what got you into troubleshooting this in the first place! I would recommend comparing the d-ptrs as done now as an early optimization and then falling back to KFileItem::cmp() (or the inlined equivalent) if the d-ptrs are different. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: CMake 2.8.8 will be required for kdelibs 4.10 starting October 30th

2012-10-18 Thread Michael Pyne
able in your distribution, simply wget and untar it: In a pinch, git versions of kdesrc-build can also build CMake (from git). Regards, - Michael Pyne

Re: [PATCH] kdecore: Fix a bug in KDateTime utc offset string parsing.

2012-10-08 Thread Michael Pyne
erience in the date/time code could review first. The fix makes sense to me, I just don't know if there are other affected areas or unintended breakage that would be experienced. I've CC'ed David Jarvie but anyone else with experience can chime in too. :P Regards, - Michael Pyne sig

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-09-29 Thread Michael Pyne
oing to bump the dependency to something that isn't broadly available from distro packages then we might as well bump the requirement to the latest release. But hopefully we only make these bumps when there are clear advantages. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

Re: How and what does (plasma theme) caching operate? / KSharedDataCache issue?

2012-09-16 Thread Michael Pyne
everybody else. Well, that's certainly the goal (or rather, the necessary I/O should be getting scheduled by the OS in a way that is satisfactory to the OS). In fact the only two msync() calls are made when the KSharedDataCache is finally destructed. Everything in between mmap and msync/munmap sh

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-15 Thread Michael Pyne
uot; perspective (I haven't looked at the code at all unfortunately), just need to make sure it's possible to lock screen and unlock without using the mouse. :) - Michael Pyne On Sept. 13, 2012, 12:17 p.m., Marco Martin wrote: > > -

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-13 Thread Michael Pyne
> On Sept. 13, 2012, 11:22 p.m., Michael Pyne wrote: > > Is there any documentation on how to port screensavers over to the > > QML-based framework? > > > > I'm also confused about something else, is there really no way to XEmbed a > > typical X

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-13 Thread Michael Pyne
to since I'm biased for obvious reasons ;), but I can't let this go without making my big public warning. Am I missing something? Is there an out so that "most" screensavers are still working that I'm not seeing? -

Re: When do we need to update GENERIC_LIB_VERSION / KDE_NON_GENERIC_LIB_VERSION ?

2012-09-06 Thread Michael Pyne
g around). :) > > Cool. And he uploaded it to... where? In the meantime the script I have for a similar purpose is attached. 4 hours ago it didn't so much as have comments or command-line options so be wary I guess. ;) Regards, - Michael Pyne cleanup-lib.pl Description: Perl program signature.asc Description: This is a digitally signed message part.

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-09-03 Thread Michael Pyne
. The review request is indeed based against master, which isn't a big problem. If rebasing to KDE/4.10 will be an issue just let me know and I'll integrate the latest diff myself to KDE/4.10. - Michael Pyne On Aug. 27, 2012, 6:54 p.m., Vad

Re: Review Request: Add spinlocks lock type, based on GCC intrisincs

2012-09-03 Thread Michael Pyne
ve a CMake check for that specific function even if the POSIX feature checks appear to support it being available. But that will need to be worked on in the 4.10 branch. - Michael Pyne On Aug. 26, 2012, 7:09 p.m., Vadim Zhukov wrote: > > ---

Re: Fwd: KActivities library optimizations

2012-09-03 Thread Michael Pyne
is sent and when the DBus slots are finally called and processed, naming the key for the memory segment, etc.), but the idea is sound. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.

  1   2   >