Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-12 Thread Max Brazhnikov
hall I open new request for extra-cmake-modules? Max - Max --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110271/#review32376 ---------

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-11 Thread Max Brazhnikov
other OSes. Thanks, Max Brazhnikov

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-05-05 Thread Max Brazhnikov
> > Ok, here's a patch for GetInfo_ReadfromPipe only: > > http://people.freebsd.org/~makc/patches/read_from_pipe.diff > > Looks good to me (although I have not tested it). Small note: there is > a contructor of QStringList taking a QString so if you have a list with > only one item you don't nee

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-05 Thread Max Brazhnikov
> Am 02.05.2013 15:49, schrieb Max Brazhnikov: > > > Use libusb-1 to query info about usb devices in kinfocenter. > > Remove *BSD specific code: it doesn't work on all supported FreeBSD > > versions. In principle it can be saved for NetBSD, but NetBSD could >

Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-02 Thread Max Brazhnikov
enter/Modules/usbview/usbdevices.cpp 9bd7033 Diff: http://git.reviewboard.kde.org/r/110271/diff/ Testing --- I've tested it only on FreeBSD. It would nice to test at least FindLibUSB-1.cmake on other OSes. Thanks, Max Brazhnikov

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-05-02 Thread Max Brazhnikov
On Wed, 01 May 2013 14:44:39 +0200 Rolf Eike Beer wrote: > > > On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: > > > > kinfocenter/Modules/base/info_fbsd.cpp, line 136 > > > > > > > ine136>> > > > > > Why not just u

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-30 Thread Max Brazhnikov
board.kde.org/r/110091/diff/1/?file=139990#file139990line12> > > > > Please read Modules/readme.txt from CMake about how to name such > > variables. Short: this should be DEVINFO_INCLUDE_DIR, and you should have a > > DEVINFO_INCLUDE_DIRS later, which is n

Re: Review Request 110090: Clean up kickoff from stale bits

2013-04-30 Thread Max Brazhnikov
Hi, Can anybody review this patch? Thanks, Max On Fri, 19 Apr 2013 22:13:46 + Max Brazhnikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-30 Thread Max Brazhnikov
/CMakeLists.txt dba6bc7 Diff: http://git.reviewboard.kde.org/r/110091/diff/ Testing --- Thanks, Max Brazhnikov

Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-19 Thread Max Brazhnikov
://git.reviewboard.kde.org/r/110091/diff/ Testing --- Thanks, Max Brazhnikov

Review Request 110090: Clean up kickoff from stale bits

2013-04-19 Thread Max Brazhnikov
strigiqtdbusclient, but Strigi is not used since svn r1018482. Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt e9e2888 plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake cecf380 Diff: http://git.reviewboard.kde.org/r/110090/diff/ Testing --- Thanks, Max