Re: KDM + ConsoleKit + Logind

2014-02-18 Thread Martin Briza
On Mon, 17 Feb 2014 14:49:07 +0100, Harald Sitter wrote: On Mon, Feb 17, 2014 at 2:09 PM, Matthias Klumpp wrote: 2014-02-17 13:55 GMT+01:00 Lukáš Tinkl : Dne 17.2.2014 11:51, Harald Sitter napsal(a): Ahoys I was looking for some input on KDM+CK in a Logind world. When a system is using L

Re: KDM + ConsoleKit + Logind

2014-02-18 Thread Martin Briza
On Mon, 17 Feb 2014 11:51:33 +0100, Harald Sitter wrote: Ahoys I was looking for some input on KDM+CK in a Logind world. When a system is using Logind I guess KDM+CK doesn't do much useful, so the question arose whether distributions with such a lineup should build without CK support. In short

KTcpSocket SslHandshakeFailedError mapping and KIMAP::SessionThread infinite recursion

2013-06-06 Thread Martin Briza
Hi, recently there were loads of crash reports for akonadi_imap_resource in Fedora (seems it was crashing only on x86_64 architecture but this isn't what I'm writing about). Basically, what happened: 1) The socket was disconnected by the server side 2) Attempts to reconnect

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-16 Thread Martin Briza
On Tue, 07 May 2013 22:47:09 +0200, Rolf Eike Beer wrote: Am Dienstag, 7. Mai 2013, 22:21:46 schrieb Àlex Fiestas: Would be nice to have some kind of unittests on this, that will make a different with the current implementation (which afaik it has none) Even better would be to have them fi

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-06 Thread Martin Briza
Well, as I said last week, I started working on it. First few commits are in branch mbriza/kdisplaymanager-split. Currently, PLEASE, don't judge me for the KDMBackendPrivate class stuff. :) I have just cut that out of KDisplayManager, not really knowing what to do with it further. I'll try to

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-02 Thread Martin Briza
On Thu, 02 May 2013 13:12:55 +0200, Martin Briza wrote: On Tue, 30 Apr 2013 17:33:57 +0200, Aaron J. Seigo wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: - The KDisplayManager class is used only on a few places so replacing its constructions with calls to the factory

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-02 Thread Martin Briza
On Tue, 30 Apr 2013 17:35:01 +0200, Aaron J. Seigo wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: - The KDisplayManager class is used only on a few places so replacing its constructions with calls to the factory will be easy. oh, btw.. the LightDM code there is also

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-02 Thread Martin Briza
On Tue, 30 Apr 2013 17:33:57 +0200, Aaron J. Seigo wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: I would leave creating the CK module to somebody who is experienced with how exactly the whole system works and knows if it is safe. if it is a refactor, this should be a

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Martin Briza
Hi, On Mon, 29 Apr 2013 09:17:15 +0200, Oswald Buddenhagen wrote: On Thu, Apr 25, 2013 at 03:11:25PM +0200, Martin Bříza wrote: To provide reasons why to do it: - The current state is nearly unmaintainable that tiny file? you have a low threshold. ;) Yeah, that's true :) But thinking

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Martin Briza
Hi, On Fri, 26 Apr 2013 23:30:43 +0200, Albert Astals Cid wrote: El Dijous, 25 d'abril de 2013, a les 15:11:25, Martin Briza va escriure: after fixing a bit in the $subj Which repo is that? Are we installing that file header? The systemd support fix is now in master branch, i

libs/kworkspace/kdisplaymanager.cpp mess

2013-04-26 Thread Martin Briza
Hi everyone, after fixing a bit in the $subj file I've realized it (in my opinion) should be split into one abstract class with a factory handling the back-ends provided by the current session managers such as ConsoleKit and systemd-logind while providing one module for the legacy DMs with