Hi,
By batching i mean send a bunch of data to the IO slave.
I hoped KIO::BatchRenameJob would be a start for me as the name does imply
batching, but doesn't seem to be doing just that. It's merely that you call
it with a list of url's which then sequentially get processed inside
KIO::BatchRenameJ
On Thu, Jul 14, 2016 at 8:17 PM, Harald Sitter wrote:
> On Thu, Jul 14, 2016 at 8:06 PM, Andreas Hartmetz
> wrote:
> > On Donnerstag, 14. Juli 2016 16:19:15 CEST Harald Sitter wrote:
> >> On Thu, Jul 14, 2016 at 3:43 PM, Andreas Hartmetz
> > wrote:
> >> > Hello,
> >> >
> >> > Am Donnerstag, 14.
!
liboxygen/oxygenhelper.h (line 118)
<https://git.reviewboard.kde.org/r/127866/#comment64795>
Is a fifo cache really what you'd want here? I think you would want a LRU
cache instead.. But yeah, that adds quite a bit complexity.
- Mark Gaiser
On mei 22, 2016, 4:20 a.m., Michael
> On mei 15, 2016, 8:51 a.m., Hugo Pereira Da Costa wrote:
> > To be honest, I am quite puzzle by this whole thing.
> > Now, every insertion in the cache requires at least two searches in there
> > and (in many case) at least one copy constructor being called. This is
> > quite expansive ... (e
On Wed, Mar 2, 2016 at 9:42 AM, Martin Graesslin wrote:
> On Monday, February 29, 2016 9:42:11 PM CET Sven Brauch wrote:
> > Hey,
> >
> > On 02/28/2016 03:58 PM, Luigi Toscano wrote:
> > > This is what I use:
> > > export QT_QPA_PLATFORMTHEME=kde
> > >
> > > and you need the integration plugin i
On Tue, Mar 1, 2016 at 7:42 PM, Sven Brauch wrote:
> Hey,
>
> On 03/01/2016 07:37 PM, Mark Gaiser wrote:
> > but there is
> > undoubtedly going to be a point in time where the plugin only works when
> > some very specific plasma part is required for it to function
>
Op 29 feb. 2016 11:10 p.m. schreef "Thiago Macieira" :
>
> On segunda-feira, 29 de fevereiro de 2016 21:42:11 PST Sven Brauch wrote:
> > Hey,
> >
> > On 02/28/2016 03:58 PM, Luigi Toscano wrote:
> > > This is what I use:
> > > export QT_QPA_PLATFORMTHEME=kde
> > >
> > > and you need the integratio
On Mon, Aug 17, 2015 at 3:10 PM, Sebastian Kügler wrote:
> I think we should be peachy now. Can plasma-pa be moved from kdereview to
> kde/workspace?
>
Just my opinion as a plasma 5 user.
Yes, please! Kmix was great under KDE 4.xx, not so much under 5.xx. This
"feels" much better and cleaner to
On Tue, Jul 28, 2015 at 4:28 PM, David Faure wrote:
> On Tuesday 14 July 2015 19:28:58 Thomas Lübking wrote:
> > On Dienstag, 14. Juli 2015 19:00:14 CEST, Milian Wolff wrote:
> > > On Tuesday, July 14, 2015 11:49:25 AM David Faure wrote:
> > >> On Friday 26 June 2015 18:03:00 Frank Reininghaus wr
On Fri, Jul 24, 2015 at 10:23 AM, Milian Wolff wrote:
> On Thursday, July 23, 2015 10:15:20 PM Mark Gaiser wrote:
> > On Sun, Jul 19, 2015 at 11:11 PM, Mark Gaiser wrote:
> > > Hi,
> > >
> > > I just pushed 3 UDSEntry changes to gerrit for your
On Sun, Jul 19, 2015 at 11:11 PM, Mark Gaiser wrote:
> Hi,
>
> I just pushed 3 UDSEntry changes to gerrit for your reviewing pleasure:
>
> 1: https://gerrit.vesnicky.cesnet.cz/r/#/c/473/
> 2: https://gerrit.vesnicky.cesnet.cz/r/#/c/474/
> 3: https://gerrit.vesnick
Hi,
I just pushed 3 UDSEntry changes to gerrit for your reviewing pleasure:
1: https://gerrit.vesnicky.cesnet.cz/r/#/c/473/
2: https://gerrit.vesnicky.cesnet.cz/r/#/c/474/
3: https://gerrit.vesnicky.cesnet.cz/r/#/c/475/
The end result is a faster UDSEntry in every way. The benchmark result
> Add QQC clone of KColorButton
This is not a comment for David, but more in general for changelog messages.
This specific massage is quite vague, you really need to have knowledge
about QQuick classes to know what that line means.
A message like: "Added QML ColorButton component to KQuickC
On Sun, Jun 28, 2015 at 7:27 PM, Eike Hein wrote:
>
>
> On 06/28/2015 11:10 AM, Martin Gräßlin wrote:
> > In opposite KSnapshot is a very mature application with a decade
> > of development behind it.
>
> It's also a rather stagnant one, and a new developer with
> the desire to improve upon the s
On Fri, Jun 26, 2015 at 10:51 PM, Alexander Potashev
wrote:
> Hi everyone,
>
> 2015-06-26 18:46 GMT+03:00 Martin Gräßlin :
> > Thus I think the question about compiler requirement and Qt requirement
> are
> > not coupled. Just because we raise the one or the other doesn't mean we
> should
> > rai
Hi,
If Qt's plans progress according to what they post on the mailinglist then
Qt 5.6 will be LTS, 5.7 will up the compiler requirements to the following:
GCC 4.7
Clang 3.2
MSVC 2012
Framework currently requires:
GCC 4.5
Clang 3.1
MSVC 2012
When frameworks started it had slightly less strict co
Hi,
A few days ago i started profiling and debugging the KIO SMB slave to
figure out why a simple task as listing a directory (in dolphin) is so
utterly slow. It's been like that for as long as i remember but never had
attempted to debug it before.
Do this for example:
Mount a samba network share
yway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets
another release. Either way, KIO frameworks [1] is where this should be applied
to when you get a ship it.
[1] http://quickgit.kde.org/?p=kio.git
- Mark Gaiser
On feb 20, 2015, 9:28 p.m.
>
>
> http://kde.org/announcements/kde-frameworks-5.7.0.php
>
>
That link gives me a very white page, no source either.
I think you have to re-upload that file.
On Wed, Feb 4, 2015 at 11:53 PM, Martin Sandsmark
wrote:
> On Wed, Feb 04, 2015 at 09:51:53PM +0100, Albert Astals Cid wrote:
> > Even if it's an upstream bug, in my opinion the
> BugOfTheMonth+GardeningEffort
> > is showing the users that we care, and if they are affected by a severe
> bug
> > w
On Wed, Jan 14, 2015 at 8:35 PM, Martin Klapetek
wrote:
> On Wed, Jan 14, 2015 at 8:08 PM, Mark Gaiser wrote:
>
>> On Wed, Jan 14, 2015 at 7:36 PM, Martin Klapetek <
>> martin.klape...@gmail.com> wrote:
>>
>>> On Wed, Jan 14, 2015 at 7:31 PM, Mark Gaise
On Wed, Jan 14, 2015 at 7:36 PM, Martin Klapetek
wrote:
> On Wed, Jan 14, 2015 at 7:31 PM, Mark Gaiser wrote:
>
>> Hi,
>>
>> Kdesrc-build uses (right?) projects.kde.org to get a list of frameworks
>> and compile them. That works great :)
>>
>> H
Hi,
Kdesrc-build uses (right?) projects.kde.org to get a list of frameworks and
compile them. That works great :)
However, a few hours ago David Faure pushed something rather cool in KIO
[1] that i would like to play with. It adds the KIOCORE_ONLY cmake define.
Sure, i can compile KIO without kde
On Fri, Jan 9, 2015 at 5:34 PM, Ivan Čukić wrote:
> Hi,
>
> Because of the short release cycle for the frameworks, it is hard to
> have bigger new features included into one of them. Slowly evolving
> APIs while developing stuff leaves a lot of crud and deprecated
> methods later.
>
> What is our
tList should be changed into a qstringlist
> > rather than a url list...
> >
> > It would also be interesting to check if this works in the KIO framework
> > (Qt5), where I ported it to QUrl...
>
> Mark Gaiser wrote:
> Just tried it out on KF5. The iss
tList should be changed into a qstringlist
> > rather than a url list...
> >
> > It would also be interesting to check if this works in the KIO framework
> > (Qt5), where I ported it to QUrl...
>
> Mark Gaiser wrote:
> Just tried it out on KF5. The iss
ly one line."
a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
<https://git.reviewboard.kde.org/r/116481/#comment45844>
curly braces..
- Mark Gaiser
On feb 28, 2014, 1:53 p.m., Joschi Brauchle wrote:
>
>
pen a default dialog and be done
with it, no?
Sorry if i'm totally wrong since i don't know this code. In that case, please
do elaborate on why KIO works the way it does.
- Mark Gaiser
On July 12, 2014, 9:55 a.m., Mar
m not quite sure if it's even possible since this is in a private class. You
might be able to test this using KNewFileMenu::checkUpToDate?
KIO has very few unittests for KNewFileMenu, they can be found in
knewfilemenutest.cpp. More is welcome there.
- Mark Gaiser
On jul 5, 2014, 1:26 p.m.,
> On jul 5, 2014, 1:11 p.m., Mark Gaiser wrote:
> > src/filewidgets/knewfilemenu.cpp, lines 875-878
> > <https://git.reviewboard.kde.org/r/119130/diff/1/?file=287354#file287354line875>
> >
> > You should be able to replace this with:
> >
. If that doesn't work
then you also have the option of doing:
files += dir.entryList(QStringList() << "*.desktop", QDir::Files);
Cool huh, one liners? :)
- Mark Gaiser
On jul 5, 2014, 12:50 p.m., Eike Hein wrote:
>
> --
> On July 2, 2014, 6:06 p.m., Mark Gaiser wrote:
> > May i suggest to replace those new lines with a QScopedPointer
> > (documentation for it: http://qt-project.org/doc/qt-5/qscopedpointer.html)
> > objects? It kinda takes away the need for you to delete since it will
QScopedPointer (documentation
for it: http://qt-project.org/doc/qt-5/qscopedpointer.html) objects? It kinda
takes away the need for you to delete since it will simply run out of scope
(and be deleted).
Or go the C++11 way and use std::unique_ptr:
http://en.cppreference.com/w/cpp/memory/unique_ptr
- Mark
ntTextList should be changed into a qstringlist
> > rather than a url list...
> >
> > It would also be interesting to check if this works in the KIO framework
> > (Qt5), where I ported it to QUrl...
>
> Mark Gaiser wrote:
> Just tried it out on KF5. The iss
ntTextList should be changed into a qstringlist
> > rather than a url list...
> >
> > It would also be interesting to check if this works in the KIO framework
> > (Qt5), where I ported it to QUrl...
>
> Mark Gaiser wrote:
> Just tried it out on KF5. The iss
ntTextList should be changed into a qstringlist
> > rather than a url list...
> >
> > It would also be interesting to check if this works in the KIO framework
> > (Qt5), where I ported it to QUrl...
>
> Mark Gaiser wrote:
> Just tried it out on KF5. The iss
> On June 14, 2014, 8:54 a.m., David Faure wrote:
> > What if the file isn't local?
> >
> > Sounds to me like the bug is elsewhere.
> >
> > Of course for local files, showing a local path looks better than a
> > file:/// URL, so this could be improved, but in a way that doesn't break
> > remo
tps://git.reviewboard.kde.org/r/117789/#comment39696>
Please update this link since it doesn't exist anymore.
http://qt-project.org/doc/qt-5/qregexp.html ?
- Mark Gaiser
On April 26, 2014, 1:15 p.m., Milian Wolff wrote:
>
> ---
On Sat, Mar 15, 2014 at 10:50 PM, Michael Pyne wrote:
> On Sat, March 15, 2014 21:47:39 Mark Gaiser wrote:
>> > Can you try setting up separate builds?
>>
>> Hi Ben,
>>
>> At first i was indeed trying to build both under the same user (but
>> different
On Sat, Mar 15, 2014 at 9:04 PM, Ben Cooksley wrote:
> On Sun, Mar 16, 2014 at 6:18 AM, Mark Gaiser wrote:
>> Hi,
>
> Hi Mark,
>
>>
>> If i use the default config[1] i get this[2] error.
>> This is in an attempt to build parts of KDE 4.13 git.
&g
Hi,
If i use the default config[1] i get this[2] error.
This is in an attempt to build parts of KDE 4.13 git.
My kdesrc-build is at git branch
598ad6225ddf1fa1d9701eaa0eb350b57eb337fc (fresh clone).
Any idea what might be causing this?
Cheers,
Mark
[1]
http://quickgit.kde.org/?p=kdesrc-build.
On Tue, Feb 4, 2014 at 2:51 PM, Aaron J. Seigo wrote:
> On Saturday, February 1, 2014 16:24:57 Sebastian Kügler wrote:
>> > For a real hardware accelerates canvas you should open up Chrome and
>> > go to this link: http://fhtr.org/gravityring/sprites.html I doubt that
>> > would be possible with t
> Canvas based: I have no experience with that but I guess performance is should
> be better than with QPaintedItem, since it directly renders to a GPU
> framebuffer and painting can be done in an separate thread.
As far as i know both (canvas and qpainter) are software rendered.
However, canvas
On Fri, Jan 31, 2014 at 5:34 AM, Bhushan Shah wrote:
> To people from kde-core-devel: please keep me and plasma-devel in CC,
> I am not subscribed to list
>
> Hello,
>
> Currently I am working on a QML Canvas based SignalPlotter, to replace
> the old Plasma1SignalPlotter which is KSignalPlotter an
> On Jan. 24, 2014, 8:44 a.m., David Faure wrote:
> > For KDE 4.x, a "special" command is the only way, so IMHO this can go in.
> >
> > At the same time, it would indeed be nice to write a proper Job class for
> > this in KIO (don't make it part of KDiskFreeSpaceInfo, that one has a sync
> > A
On Wed, Dec 18, 2013 at 11:07 PM, Jos Poortvliet
wrote:
> On Tuesday 17 December 2013 12:22:26 Todd wrote:
>> On Dec 12, 2013 6:36 PM, "Vishesh Handa" wrote:
>> > > i’ll say it again here so that it is at least on record: i really
>>
>> disagree
>>
>> > > with renaming Nepomuk. call it Nepomuk 2
ed testing this on an actual samba
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm
hoping that is a local issue here. If someone else could try this out and
verify that it's either working or broken.
Thanks,
Mark Gaiser
ed testing this on an actual samba
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm
hoping that is a local issue here. If someone else could try this out and
verify that it's either working or broken.
Thanks,
Mark Gaiser
sed at all. Will take a
look at it and remove it if possible.
- Mark
-------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45466
. If there still is
nothing by next friday (13th dec.) then i will go ahead and push.
- Mark Gaiser
On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
Bump.. Ok to push it?
On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> Review request for KDE Runtime and KDE Frameworks.
> By Mark Gaiser.
>
> *Updated Dec.
either working or broken.
Thanks,
Mark Gaiser
Bump.
Can anyone look at this?
On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> Review request for KDE Runtime and KDE Frameworks.
> By Mark Gaiser.
>
> *Updat
/
Testing
---
It compiles and gets loaded just fine. I tried testing this on an actual samba
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm
hoping that is a local issue here. If someone else could try this out and
verify that it's either working or broken.
Thanks,
Mark Gaiser
> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote:
> > It's been stalled for almost three months now, any chance to see progress
> > or should it be discarded?
>
> Mark Gaiser wrote:
> No, it should most certainly not be disgarded. It was even working when
--
On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
>
On Mon, Nov 25, 2013 at 5:41 PM, Aurélien Gâteau wrote:
> Le lundi 25 novembre 2013 13:54:38 Mark Gaiser a écrit :
>> On Mon, Nov 25, 2013 at 10:45 AM, Aurélien Gâteau wrote:
>> > Le dimanche 24 novembre 2013 19:42:25 Mark Gaiser a écrit :
>> >> On Sun, Nov 24, 2013
On Mon, Nov 25, 2013 at 10:45 AM, Aurélien Gâteau wrote:
> Le dimanche 24 novembre 2013 19:42:25 Mark Gaiser a écrit :
>> On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid wrote:
>> > In Okular we just got bug
>> > https://bugs.kde.org/show_bug.cgi?id=327846
>>
On Sun, Nov 24, 2013 at 10:09 PM, Albert Astals Cid wrote:
> El Diumenge, 24 de novembre de 2013, a les 19:42:25, Mark Gaiser va escriure:
>> On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid wrote:
>> > In Okular we just got bug
>> > https://bugs.kde.org/show_bug.cg
On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid wrote:
> In Okular we just got bug
> https://bugs.kde.org/show_bug.cgi?id=327846
> PDF Render time is unreasonably slow over cifs on high latency (WAN) network
> connections
>
> Basically the issue is that poppler is quite read-intensive over file
On Tue, Nov 19, 2013 at 4:53 PM, Kevin Ottens wrote:
> Hello everyone,
>
> This is the minutes of the Week 47 KF5 meeting. As usual it has been held on
> #kde-devel at 4pm Paris time.
>
> Were present: afiestas, agateau, apol, jpwhiting, mgraesslin, randomguy3,
> sebas, teo and myself.
>
> Announc
On Sat, Nov 9, 2013 at 12:42 PM, Martin Klapetek
wrote:
> On Fri, Nov 8, 2013 at 3:47 PM, Allen Winter wrote:
>>
>> > Do you guys know if we can make the search better?
>> >
>> Try now.
>> Michael and I made some improvements.
>
>
> Much much better, thank you!!
It looks like it finds more indee
> On Oct. 31, 2013, 2:41 p.m., Frank Reininghaus wrote:
> > I see now that I have tried to put too much stuff into a single patch -
> > it's too hard to digest and to understand, and the number of possibilities
> > to modify different aspects of UDSEntry in a different way is just too
> > larg
e.
kurlmimetest output:
* Start testing of KUrlMimeTest *
Config: Using QTest library 4.8.4, Qt 4.8.4
PASS : KUrlMimeTest::initTestCase()
PASS : KUrlMimeTest::testURLList()
PASS : KUrlMimeTest::testOneURL()
PASS : KUrlMimeTest::testFromQUrl()
PASS : KUrlMimeTest::testMostLo
visit:
http://git.reviewboard.kde.org/r/111050/#review42488
-------
On June 23, 2013, 9:21 p.m., Mark Gaiser wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ob you did here and the results thereof. Just
awesome!
I initially had an idea to drop the hash completely and use QVector, but i
didn't see how to properly implement that. I knew it would be possible, just
not how. Looking at your code is also teaching me a thing or .. 10 .. :)
- Mark Gais
windows 8 for their fugly
themes). I disagree with the change, but understand it if you would push it
regardless. The general design theme these days seems to be heading back to 16
color monitors anyway.
- Mark Gaiser
On Oct. 24, 2013, 2:32 p.
ks 5. You might need to change the signal/slot to the old syntax
though, most certainly for KDE 4.x. It's not much but it will show you the
memory usage of those entries. Here storing them is obviously useless, but in
reality - in dolphin - this is done as well only enca
ysis-Weiss-ebook/dp/B00DESYHRC
and am reading it right now :)
- Mark Gaiser
On Oct. 20, 2013, 5:27 p.m., Frank Reininghaus wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.review
s/src/lib/jobs/kjob.h d663530
tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f
Diff: http://git.reviewboard.kde.org/r/113205/diff/
Testing
---
Works just fine.
Thanks,
Mark Gaiser
s an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41714
-------
On Oct. 14, 2013, 12:46 p.m., Mark Gaiser wrote:
>
> ---
> This
his signal if it isn't public.
Diffs (updated)
-
tier1/kcoreaddons/src/lib/jobs/kjob.h d663530
tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f
Diff: http://git.reviewboard.kde.org/r/113205/diff/
Testing
---
Works just fine.
Thanks,
Mark Gaiser
ortly.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41670
---
On Oct. 12, 2013, 6:30 p.m., Ma
ewboard.kde.org/r/113205/diff/
Testing
---
Works just fine.
Thanks,
Mark Gaiser
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote:
> > We are here making a 'hole' for people to do 'bad things' that wasn't
> > possible in the past. I'm not sure we want that.
>
> Mark Gaiser wrote:
> Interesting.
> So that mean we
s/kjob.h d663530
Diff: http://git.reviewboard.kde.org/r/113205/diff/
Testing
---
Works just fine.
Thanks,
Mark Gaiser
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote:
> > We are here making a 'hole' for people to do 'bad things' that wasn't
> > possible in the past. I'm not sure we want that.
Interesting.
So that mean we simply can't use the new signal/slo
ase i wanted to use the new syntax and directly use a lambda as
slot. Which isn't possible on this signal if it isn't public.
Diffs
-
tier1/kcoreaddons/src/lib/jobs/kjob.h d663530
Diff: http://git.reviewboard.kde.org/r/113205/diff/
Testing
---
Works just fine.
Thanks,
Mark Gaiser
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote:
> > Tested it.
> > PRE patch: ~17MB/s
> > POST patch: ~27MB/s
> >
> > So in functionality terms this patch makes a file copy from a windows share
> > (note: a linux machine sharing through samba, not an a
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote:
> > Tested it.
> > PRE patch: ~17MB/s
> > POST patch: ~27MB/s
> >
> > So in functionality terms this patch makes a file copy from a windows share
> > (note: a linux machine sharing through samba, not an a
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote:
> > Tested it.
> > PRE patch: ~17MB/s
> > POST patch: ~27MB/s
> >
> > So in functionality terms this patch makes a file copy from a windows share
> > (note: a linux machine sharing through samba, not an a
about equal in speed compared to cifs?
- Mark Gaiser
On Oct. 5, 2013, 3:07 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
out and report my findings
later today. I guess this is the long awaited patch that improves the file copy
speed from SMB to local.
- Mark Gaiser
On Sept. 29, 2013, 4:10 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an auto
istentry_improvement.patch
Thanks,
Mark Gaiser
/112702/#review40016
---
On Sept. 12, 2013, 6:26 p.m., Mark Gaiser wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://
ne. The few tests that are there are passing
> though i doubt they test this case. the KIO file slave also works just fine.
> Compilation does give me new (expected_ deprecated errors for at least the
> http slave. I don't know how to test that one. It should just work fine
> though.
>
>
> Thanks,
>
> Mark Gaiser
>
>
ings :)
Diffs
-
kioslave/file/file_unix.cpp 48bd0ba
staging/kio/src/core/slavebase.h b46631e
staging/kio/src/core/slavebase.cpp 2e46985
Diff: http://git.reviewboard.kde.org/r/112702/diff/
Testing
---
Thanks,
Mark Gaiser
tests that are there are passing though
i doubt they test this case. the KIO file slave also works just fine.
Compilation does give me new (expected_ deprecated errors for at least the http
slave. I don't know how to test that one. It should just work fine though.
Thanks,
Mark Gaiser
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review39463
---
On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
>
> ---
would have to give a
ship it.
- Mark Gaiser
On Sept. 6, 2013, 1:04 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
ttp://git.reviewboard.kde.org/r/112529/#comment29075>
You forgot to remove this one?
- Mark Gaiser
On Sept. 6, 2013, 12:35 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.rev
few days ago when porting it to Qt5/KF5 - which is still waiting
for someone to review it btw ;)
- Mark Gaiser
On Sept. 5, 2013, 1:32 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically ge
g/r/112463/#comment28914>
This will obviously go once i commit.
- Mark Gaiser
On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboar
f someone else could try this out and
verify that it's either working or broken.
Thanks,
Mark Gaiser
- Mark
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111870/#review37241
---
On Aug. 6, 2013, 7:46 p.m., Mark Gai
i specially note the following:
kdirwatchtest
kdirlistertest
kdirmodeltest
Thanks,
Mark Gaiser
mment like: "i can't review this, it's a
new function" ;) But i will put it in it's own inotify function.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r
:
kdirwatchtest
kdirlistertest
kdirmodeltest
Thanks,
Mark Gaiser
> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote:
> > kdecore/io/kdirwatch.cpp, line 372
> > <http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line372>
> >
> > the indentation is broken here, no? should be two spaces like the rest
tertest
kdirmodeltest
Thanks,
Mark Gaiser
1 - 100 of 166 matches
Mail list logo
