/jsonstringify.cpp
<http://git.reviewboard.kde.org/r/105057/#comment13456>
You don't want to be keying by UString here, but rather than Identifier,
since they guarantee reference equality of equal strings, unlike UString.
CommonIdentifiers.h has the traits for them.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review16241
---
Ship it!
Ship It!
- Maks Orlovich
On July 6, 2012, 7:11
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105387/#review16230
---
Ship it!
Ship It!
- Maks Orlovich
On July 6, 2012, 6:30
056/#comment12091>
What about two commas in a row?
kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment12093>
what if this puts you past the end of the string?
- Maks Orlovich
On July 5, 2012, 12:50 p.m., Bernd Busc
ttp://git.reviewboard.kde.org/r/105391/#comment12090>
I was thinking you could get rid of the if (element->isObject())
conditional as well.
- Maks Orlovich
On July 4, 2012, 10:27 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105388/#review15460
---
Ship it!
Ship It!
- Maks Orlovich
On June 29, 2012, 6:06
386/#comment12089>
what if hour becomes negative here?
- Maks Orlovich
On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.rev
387/#comment12087>
Same fix here? (And perhaps in other spots?)
Really, this probably needs some cleanup to not dupe this chunk of code;
the spec
defines one in terms of the other, after all.
- Maks Orlovich
On June 29, 2012, 6:06 p.m., Bernd Buschinski
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105122/#review15457
---
Ship it!
Ship It!
- Maks Orlovich
On June 18, 2012, 10:23
Again, I am pretty sure this is supposed to only list array properties, and
not symbolic ones, which you would get via getPropertyNames.
- Maks Orlovich
On June 1, 2012, 1:30 p.m., Bernd Buschinski wrote:
>
> ---
> This is
iewboard.kde.org/r/105057/#comment11269>
Does this do the right thing if it's shorter than 10?
- Maks Orlovich
On June 1, 2012, 1:30 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically
nt11974>
I don't think this is needed anymore.
kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11975>
Again, please fix this to not be needlessly recursive.
- Maks Orlovich
On June 18, 2012, 10:25
391/#comment11970>
I think you can just use toString regardless of whether it's an object or
not.
(But don't forget to check hadException, of course)
- Maks Orlovich
On June 30, 2012, 2:10 a.m., Bernd
/kjs_events.cpp
<http://git.reviewboard.kde.org/r/104946/#comment11540>
5, not 7
khtml/ecma/kjs_window.h
<http://git.reviewboard.kde.org/r/104946/#comment11541>
Add HashChangeEventCtor as well?
- Maks Orlovich
On May 15, 2012, 12:56 p.m., Martin Tobias Holmedahl San
kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11537>
Where did the -? go?
kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11538>
Comment method?
- Maks Orlovich
On May 28, 2012, 7:52 p.m., Bernd Buschinski wrote:
&g
= function foo()) as well?
The constructor is used for stuff like x = new Function(), if I get what you
were referring to.
- Maks Orlovich
On May 31, 2012, 9 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105099/#review14587
---
Ship it!
Ship It!
- Maks Orlovich
On May 29, 2012, 6:05
hat if all valid characters in the buffer are whitespace? You'll run
past the end of it. Also, this code isn't robust if ::next() is called at
end-of-file more than once. I would suggest something like:
while(true) {
if (m_pos >= m_code.size()) {
m_
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104858/#review14238
---
Ship it!
Ship It!
- Maks Orlovich
On May 21, 2012, 12:42
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104906/#review14237
---
Ship it!
Ship It!
- Maks Orlovich
On May 10, 2012, 7:01
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104908/#review13781
---
Ship it!
Ship It!
- Maks Orlovich
On May 10, 2012, 7:01
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104906/#review13780
---
Any performance effect?
- Maks Orlovich
On May 10, 2012, 7
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104907/#review13779
---
Ship it!
Ship It!
- Maks Orlovich
On May 10, 2012, 7:01
board properly.
- Maks Orlovich
On May 4, 2012, 5:40 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard
g/r/104857/#comment10935>
Could you use a const pointer here to make this look less scary?
- Maks Orlovich
On May 4, 2012, 5:40 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply
you want to
change it in ustring.cpp so it affects
the implicit conversions as well. Testcase:
"\u180e6"*7
(See also 9.3.1)
- Maks Orlovich
On May 4, 2012, 5:40 p.m., Bernd Buschinski wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104855/#review13775
---
Ship it!
- Maks Orlovich
On May 4, 2012, 5:40 p.m., Bernd
855/#comment10934>
This needs a bit of a comment tweak --- it's not in Zs but rather Cf, but
ES 5th edition treats it specially.
(And differently from the rule in 3rd edition, which no-one implemented).
- Maks Orlovich
On May 4, 2012, 5:40 p.m., Bernd Busch
for the
foo == bar || (foo && bar && sameValue(exec, m_value, other.value())
pattern, too.
kjs/propertydescriptor.cpp
<http://git.reviewboard.kde.org/r/104515/#comment10195>
I think parentheses would be helpful here.
kjs/propertydescri
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104747/#review13096
---
Ship it!
Again, ->toString, but nothing else.
- M
ion messages being risky.
- Maks Orlovich
On April 26, 2012, 8:53 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.k
?
- Maks Orlovich
On April 26, 2012, 4:34 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
ing which will be coming with
the big important review. And, of course, the prereqs.
- Maks Orlovich
On April 16, 2012, 11:02 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
ust pass in jso->prototype to constructor above?
- Maks Orlovich
On April 16, 2012, 11:03 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://gi
ttp://git.reviewboard.kde.org/r/104676/#comment9978>
Again, can just call getObject and check is vs. NULL to make this
marginally faster.
- Maks Orlovich
On April 19, 2012, 7:41 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically g
in the ether: I
meant number of shift/reduce conflicts in the parser, as reported
by bison. I am ashamed to admit that I am not able to detect LALR parsing
ambiguities by inspection..
- Maks Orlovich
On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote
handy to include DontEnum properties as well..)
kjs/property_map.cpp
<http://git.reviewboard.kde.org/r/104511/#comment9977>
This needs to be inline in the header file.
- Maks Orlovich
On April 20, 2012, 11:48 a.m., Bernd Buschinski
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104678/#review12763
---
Ship it!
Ship It!
- Maks Orlovich
On April 19, 2012, 7:41
the attributes { [[Writable]]: true, [[Enumerable]]: false,
[[Configurable]]: true } unless otherwise specified"
Looks good other than, so please just fix your changelog :)
- Maks Orlovich
On April 19, 2012, 7:41 p.m., Bernd Buschinski wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104104/#review12474
---
Ship it!
Ship It!
- Maks Orlovich
On March 21, 2012, 11:55
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104076/#review12473
---
Ship it!
Ship It!
- Maks Orlovich
On March 21, 2012, 11:52
tEnumProperties) is
possible? It's just a hair too ugly for the number of places it's in.
- Maks Orlovich
On April 13, 2012, 9:38 a.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically genera
> On April 10, 2012, 2:38 a.m., Maks Orlovich wrote:
> > kjs/function.cpp, line 308
> > <http://git.reviewboard.kde.org/r/104511/diff/1/?file=56157#file56157line308>
> >
> > Why convert to ident when isMapped will convert back to number again?
> >
656>
There is an explicit isUndefined check, but what about the ways in which
toObject can fail?
kjs/operations.cpp
<http://git.reviewboard.kde.org/r/104515/#comment9657>
Please point out how this isn't the same as strictEquals (due to the spec
having two almost identical
ion with the above; the only
difference is what gets passed to getOwnPropertyNames as last argument, isn't
it? This is way too much to duplicate..
- Maks Orlovich
On April 8, 2012, 9:14 p.m., Bernd Buschinski wrote:
>
> ---
>
ent9268>
args[1]->toInteger() here, per 15.4.4.12 step 7
- Maks Orlovich
On Feb. 28, 2012, 3:12 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
licts?
kjs/grammar.y
<http://git.reviewboard.kde.org/r/104243/#comment9264>
Do we have a bug here with numeric setters/getters? (Unrelated to your CL)
- Maks Orlovich
On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote:
>
> ---
mitting this recovery (testcase: "\x")?
- Maks Orlovich
On Feb. 25, 2012, 4:31 p.m., Bernd Buschinski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
48 matches
Mail list logo
