Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-22 Thread Maarten De Meyer
ng this to KConfig and KIO? Diffs - src/widgets/kdesktopfileactions.cpp 9486015 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarten De Meyer

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/#review64952 ----------- On Aug. 21, 2014, 1:15 p.m., Maarten De Meyer wrote: > > --- > This is an

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
2190051 src/core/kdesktopfile.cpp 6278309 Diff: https://git.reviewboard.kde.org/r/119868/diff/ Testing --- Thanks, Maarten De Meyer

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread Maarten De Meyer
rc/widgets/kdesktopfileactions.cpp 9486015 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarten De Meyer

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-20 Thread Maarten De Meyer
Diff: https://git.reviewboard.kde.org/r/119868/diff/ Testing --- Thanks, Maarten De Meyer

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-20 Thread Maarten De Meyer
rc/widgets/kdesktopfileactions.cpp 9486015 src/widgets/kpropertiesdialog.cpp 346cbe8 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarten De Meyer

Re: Review Request 113607: Install all user agent desktop files

2014-01-24 Thread Maarten De Meyer
by GLOBING for *.desktop Diffs - konqueror/settings/kio/uasproviders/CMakeLists.txt 6c49f42 Diff: https://git.reviewboard.kde.org/r/113607/diff/ Testing --- Builds. Nobody gets left behind! Thanks, Maarten De Meyer

Re: Review Request 113607: Install all user agent desktop files

2014-01-11 Thread Maarten De Meyer
this kind of stuff in the future instead of letting it rot for weeks? - Maarten De Meyer On Nov. 4, 2013, 5:19 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 110388: Change default thumbnail cache directory

2014-01-11 Thread Maarten De Meyer
Repeated with XDG_CACHE_HOME=~/.cachetestdir/ Thumbnails in .cachetestdir/thumbnails/ Not tested: gwenview and digikam. Thanks, Maarten De Meyer

Review Request 113608: Add modern user agents for common browsers

2013-11-04 Thread Maarten De Meyer
iders/firefox_latest.desktop PRE-CREATION konqueror/settings/kio/uasproviders/ie_latest.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113608/diff/ Testing --- Thanks, Maarten De Meyer

Review Request 113607: Install all user agent desktop files

2013-11-04 Thread Maarten De Meyer
6c49f42 Diff: http://git.reviewboard.kde.org/r/113607/diff/ Testing --- Builds. Nobody gets left behind! Thanks, Maarten De Meyer

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-28 Thread Maarten De Meyer
hortcut. File Attachments (updated) Berfore vs After http://git.reviewboard.kde.org/media/uploaded/files/2013/05/21/before-After2.png Alternative look http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/After3.png Thanks, Maarten De Meyer

Re: Review Request 110388: Change default thumbnail cache directory

2013-05-21 Thread Maarten De Meyer
. Some thumbnailers need to be recompiled but there is no breakage if they use the old cache for now. If this change is to intrusive for frozen kdelibs I could make it frameworks only. (although it is a bugfix imho) - Maarten De Meyer On May 11, 2013, 2:40 p.m., Maarten De Meyer wrote

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-21 Thread Maarten De Meyer
ter code in the new version - Maarten --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/#review32716 ------- On May 21,

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-21 Thread Maarten De Meyer
After screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/before-After.png Berfore vs After http://git.reviewboard.kde.org/media/uploaded/files/2013/05/21/before-After2.png Thanks, Maarten De Meyer

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-14 Thread Maarten De Meyer
/uploaded/files/2013/05/14/before-After.png Thanks, Maarten De Meyer

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-14 Thread Maarten De Meyer
er.png Thanks, Maarten De Meyer

Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-14 Thread Maarten De Meyer
dle. Modified a shortcut. File Attachments Before - After screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/before-After.png Thanks, Maarten De Meyer

Review Request 110388: Change default thumbnail cache directory

2013-05-11 Thread Maarten De Meyer
: gwenview and digikam. Thanks, Maarten De Meyer

Review Request 110277: Fix broken web shortcuts

2013-05-06 Thread Maarten De Meyer
roviders/vivisimo.desktop 291150e kurifilter-plugins/tests/kurifiltertest.cpp dd18eba Diff: http://git.reviewboard.kde.org/r/110277/diff/ Testing --- Tried every search at least once. Thanks, Maarten De Meyer

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

2013-05-05 Thread Maarten De Meyer
ting a new provider: 0 Please correct me if I'm wrong. - Maarten --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110313/#review32045 -------------

Proposed web shortcut changes

2013-05-02 Thread Maarten De Meyer
fer revenue sharing with KDE. Can a developer not associated with KDE ev. make these 'deals'? I think amazon offers something like that.. Thank you Maarten De Meyer

Re: Review Request 110247: New web shortcut. Copy link from clipboard

2013-05-02 Thread Maarten De Meyer
----- On May 2, 2013, 11:53 a.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110247/ >

Review Request 110259: Fix kurifiltertest to use the new google query

2013-05-01 Thread Maarten De Meyer
: http://git.reviewboard.kde.org/r/110259/diff/ Testing --- All tests pass. Thanks, Maarten De Meyer

Review Request 110247: New web shortcut. Copy link from clipboard

2013-04-30 Thread Maarten De Meyer
clipboard. Thanks, Maarten De Meyer

Re: Review Request 109841: Use https for web shortcuts

2013-04-22 Thread Maarten De Meyer
/ikws/searchproviders/wolfram_alpha.desktop 6a8bda6 kurifilter-plugins/ikws/searchproviders/youtube.desktop 0549216 Diff: http://git.reviewboard.kde.org/r/109841/diff/ Testing --- All shortcuts use https and have a valid ssl certificate. Thanks, Maarten De Meyer

Review Request 109841: Use https for web shortcuts

2013-04-03 Thread Maarten De Meyer
/ikws/searchproviders/youtube.desktop 0549216 Diff: http://git.reviewboard.kde.org/r/109841/diff/ Testing --- All shortcuts use https and have a valid ssl certificate. Thanks, Maarten De Meyer

Re: Review Request: Rename Samba Shares to Windows Shares (SMB)

2012-06-22 Thread Maarten De Meyer
se this review and the bug. It was more a personal attempt to get used to bug fixing workflow. - Maarten ----------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/#review14969 -

Review Request: Rename Samba Shares to Windows Shares (SMB)

2012-06-21 Thread Maarten De Meyer
amp;w=2 Since we are past string freeze this is probably for 4.10 I can not commit this myself, thanks This addresses bug 141257. http://bugs.kde.org/show_bug.cgi?id=141257 Diffs - kioslave/smb/smb-network.desktop a121a31 Diff: http://git.reviewboard.kde.org/r/105318/diff/ Test

Review Request: UDisks mount vfat filesystems with flush option.

2012-06-12 Thread Maarten De Meyer
--- Compiled without error, mounted multiple devices without problems. Thanks, Maarten De Meyer

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

2012-04-19 Thread Maarten De Meyer
only matters on first run. I do not have commit access, could somebody pleas submit? Thanks - Maarten --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104662/#review12635 -----

Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

2012-04-18 Thread Maarten De Meyer
configuration, run again Thanks, Maarten De Meyer

Re: Review Request: Change Online help icon KHelpcenter

2012-04-18 Thread Maarten De Meyer
visit: http://git.reviewboard.kde.org/r/104621/#review12573 --- On April 16, 2012, 5:28 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To re

Review Request: Change Online help icon KHelpcenter

2012-04-16 Thread Maarten De Meyer
Testing (updated) --- compiled and run, works fine Thanks, Maarten De Meyer