Re: Review Request 109624: Resize the shutdown dialog when the qml view inside changes size

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109624/#review29637 --- Ship it! Ship It! - Lamarque Vieira Souza On March 21

Re: Review Request: Device notifier: show mounted device and path

> On Oct. 12, 2012, 1:34 p.m., Sebastian Kügler wrote: > > Screenshot: Tooltip with mounted device > > > > > > This tooltip looks really odd and out of place this way.:/ The transparency effect does not look good here. I would like to know how to disable it

Re: Review Request: Config cleanup on removeActivity

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/#review18065 --- Ship it! Ship It! - Lamarque Vieira Souza On Aug. 20, 2012

Re: Review Request: Fix Calculator keyboard key not working

> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > <http://git.reviewboard.kde.org/r/105909/diff/1/?file=76478#file76478line358> > > > > I think this will break calculator key for other users. This cha

Re: Review Request: Fix Calculator keyboard key not working

org/r/105909/#comment13375> I think this will break calculator key for other users. This change also does not make sense, Key_Calculator is a better name for this key than Key_Launch1. My guess is that the keyboard is sending the wrong keysym to Xorg. - Lamarque Vieira Souza On Aug. 7

Re: Review Request: Allow symlink creation for kio protocols that support it

> > were copying the full hierarchy including the target files then you would > > probably want the symlinks to stay as symlinks...) > > > > Maybe the solution lies in offering more choices to the user, yet again... > > i.e. when dragging a symlink, offer "copy target&q

Re: Review Request: Allow symlink creation for kio protocols that support it

> supports symlinks, otherwise it wouldn't be there in the first place :-) > > Lamarque Vieira Souza wrote: > I meant supports *creating* symlinks, not only *showing* symlinks. ftp > kio protocol does not support creating symlinks according to its ftp.protocol > file. >

Re: Review Request: Allow symlink creation for kio protocols that support it

> > were copying the full hierarchy including the target files then you would > > probably want the symlinks to stay as symlinks...) > > > > Maybe the solution lies in offering more choices to the user, yet again... > > i.e. when dragging a symlink, offer "copy target&q

Re: Review Request: Allow symlink creation for kio protocols that support it

> supports symlinks, otherwise it wouldn't be there in the first place :-) > > Lamarque Vieira Souza wrote: > I meant supports *creating* symlinks, not only *showing* symlinks. ftp > kio protocol does not support creating symlinks according to its ftp.protocol > file. >

Re: Review Request: Allow symlink creation for kio protocols that support it

> > were copying the full hierarchy including the target files then you would > > probably want the symlinks to stay as symlinks...) > > > > Maybe the solution lies in offering more choices to the user, yet again... > > i.e. when dragging a symlink, offer "copy target&q

Re: Review Request: Allow symlink creation for kio protocols that support it

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105831/#review16814 ------- On Aug. 2, 2012, 9:31 p.m., Lamarque Vieira Souza wrote: > > -

Re: Review Request: Allow symlink creation for kio protocols that support it

in archiving the directory itself and currently kio creates an empty file everytime it copies a symlink to a directory (it treats symlinks to directory like symlinks to a file), so nothing is actually copied. - Lamarque Vieira -------

Re: Review Request: Allow symlink creation for kio protocols that support it

hanks, Lamarque Vieira Souza

Review Request: Allow symlink creation for kio protocols that support it

ature. Diffs - kio/kio/copyjob.cpp 8dde763 Diff: http://git.reviewboard.kde.org/r/105831/diff/ Testing --- Thanks, Lamarque Vieira Souza

Re: Review Request: Support for GRUB2 submenus

> On Aug. 1, 2012, 11:49 a.m., Konstantinos Smanis wrote: > > Btw I see that they have bumped the version to 4.8.5 (no tag yet). Maybe we > > should drop the ksmserver part? It doesn't apply on the 4.9 branch. We still need to port the part that deals with submenu separator to ksmserver 4.9.x.

Re: Review Request: Support for GRUB2 submenus

g/r/105563/#comment13014> Ah ok, I see it now. - Lamarque Vieira Souza On July 31, 2012, 5:54 p.m., Konstantinos Smanis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Support for GRUB2 submenus

g/r/105563/#comment13012> "const char *sep;" just declares a pointer called sep, it does not allocate memory to store any char in it. - Lamarque Vieira Souza On July 31, 2012, 5:54 p.m., Konstantinos Smanis wrote: > > --

Re: Review Request: Support for GRUB2 submenus

g/r/105563/#comment13010> I think the memory for *sep has not been allocated yet at this point, so you should use something like strdup here instead of a simple assignment. - Lamarque Vieira Souza On July 31, 2012, 5:54 p.m., Konstantinos Smanis

Re: Review Request: Support for GRUB2 submenus

an.c <http://git.reviewboard.kde.org/r/105563/#comment12956> Maybe you should print a kWarning() saying that we only support up to 5 submenu levels. - Lamarque Vieira Souza On July 29, 2012, 6:06 p.m., Konstantinos Smanis wrote: > > --

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Add submenu support to QML shutdown dialog.

n the menu titles without creating > > submenus. See the ksmserver part of the other patch I am submitting for > > branch KDE/4.8 (https://git.reviewboard.kde.org/r/105563/). > > Lamarque Vieira Souza wrote: > I will fix that tonight. I need to go now. > > Oswald Buddenhage

Re: Review Request: Add submenu support to QML shutdown dialog.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review16022 --- On July 14, 2012, 6:53 p.m., Lamarque Vieira Souza wrote: > > ---

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 5:33 p.m., Lamarque Vieira Souza wrote: > > Ship It! > > Konstantinos Smanis wrote: > Should I commit this? The KDM maintainer hasn't replied yet. Plus, will > the 4.8 branch get the fix eventually? Noone else has commented... I am giving m

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16017 --- Ship it! Ship It! - Lamarque Vieira Souza On July 14, 2012

Re: Review Request: Support for GRUB2 submenus

change only to 4.9 and master. - Lamarque Vieira Souza On July 14, 2012, 8:16 a.m., Konstantinos Smanis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Add submenu support to QML shutdown dialog.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review15841 --- On July 14, 2012, 6:53 p.m., Lamarque Vieira Souza wrote: > > -

Re: Review Request: Add submenu support to QML shutdown dialog.

http://git.reviewboard.kde.org/r/105568/diff/ Testing --- Submenus are created and it emits rebootRequested2 signal with the correct index. Screenshots --- http://git.reviewboard.kde.org/r/105568/s/635/ Thanks, Lamarque Vieira Souza

Re: Review Request: Add submenu support to QML shutdown dialog.

nd it emits rebootRequested2 signal with the correct index. Screenshots --- http://git.reviewboard.kde.org/r/105568/s/635/ Thanks, Lamarque Vieira Souza

Re: Review Request: Add submenu support to QML shutdown dialog.

board.kde.org/r/105568/s/635/ Thanks, Lamarque Vieira Souza

Re: Review Request: Add submenu support to QML shutdown dialog.

://bugs.kde.org/show_bug.cgi?id=297209 Diffs - ksmserver/themes/default/main.qml 7e78761 Diff: http://git.reviewboard.kde.org/r/105568/diff/ Testing --- Submenus are created and it emits rebootRequested2 signal with the correct index. Thanks, Lamarque Vieira Souza

Review Request: Add submenu support to QML shutdown dialog.

- ksmserver/themes/default/main.qml 7e78761 Diff: http://git.reviewboard.kde.org/r/105568/diff/ Testing --- Submenus are created and it emits rebootRequested2 signal with the correct index. Thanks, Lamarque Vieira Souza

Re: Review Request: fix for some typos

> On June 16, 2012, 4:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/actions/kaction.cpp, line 408 > > <http://git.reviewboard.kde.org/r/105278/diff/1/?file=68027#file68027line408> > > > > Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one t

Re: Review Request: Rename Samba Shares to Windows Shares (SMB)

> On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: > > I don't really know if we should do this.. I do understand why you want to > > rename it. From a user point of view the user probably wants to either > > access windows shares or make shares accessible for windows. Either way, > > it's don

Re: Review Request: fix for some typos

oes not need to be initialized. It is used just because QString::toInt requires a pointer-to-bool parameter. ok2 value is not tested anywhere too. I guess the compiler can issue a warning if it is not initialized, right? - Lamarque Vieira Souza On June 16, 2012, 3:37 p.m., Jaime Torres

Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2/#comment10369> replace tab to spaces. - Lamarque Vieira Souza On May 1, 2012, 4:37 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://gi

Re: Review Request: Make nepomuk runner remove undesired matches

that out we > > can fix it properly. > > Lamarque Vieira Souza wrote: > I have no idea why nepomuk returns those items, it also does it in Plasma > Desktop 4.8.2 (search for the word 'document'). I am not an expert in nepomuk > and it is very complicate

Re: Review Request: Make nepomuk runner remove undesired matches

that out we > > can fix it properly. > > Lamarque Vieira Souza wrote: > I have no idea why nepomuk returns those items, it also does it in Plasma > Desktop 4.8.2 (search for the word 'document'). I am not an expert in nepomuk > and it is very complicate

Re: Review Request: Make nepomuk runner remove undesired matches

- On April 9, 2012, 10:29 p.m., Lamarque Vieira Souza wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104526/ >

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

patch is good to go from my part. - Lamarque Vieira Souza On April 11, 2012, 8:27 p.m., makis marimpis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

ttp://git.reviewboard.kde.org/r/104428/#comment9678> There is a missing "watcher->deleteLater()" here. Awesome, now we are moving forward :-) - Lamarque Vieira Souza On April 11, 2012, 8:06 p.m., makis marimpis wrote: > > -

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

, this, SLOT(realInit())); } According to Plugin.h the "virtual init()" should be explictitly called and the way you did you are doing it automatically. - Lamarque Vieira Souza On April 11, 2012, 5:41 p.m., makis marimpis wrote: > > --

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

> On April 4, 2012, 5:13 p.m., Lamarque Vieira Souza wrote: > > service/plugins/globalshortcuts/globalshortcuts.cpp, line 41 > > <http://git.reviewboard.kde.org/r/104428/diff/4/?file=55580#file55580line41> > > > > Maybe the slowness has nothing to do with yo

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9660> same here. Besides, callWithArgumentList is synchronous and since you do not care about the returned valued then it's better change this to asynchronous call. - Lamarqu

Re: Review Request: Add cmake config for kdeclarative library.

NSTALL_DIR set ? > > Is it done by via find_package(KDE4) ? > > In this case, INCLUDE_INSTALL_DIR is a relative path under Windows, so > > the config file wouldn't work properly under Windows. > > Lamarque Vieira Souza wrote: > I do not know, INCLUDE_INST

Re: Review Request: Copy files instead of moving if parent dir is not writable

/r/104417/#review12037 --- On March 30, 2012, 6:57 p.m., Lamarque Vieira Souza wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Review Request: Make nepomuk runner remove undesired matches

6/diff/ Testing --- Works in my Plasma Active installation. Thanks, Lamarque Vieira Souza

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

es the whole desktop freezes. Usually the splash screen hides this problem, in my case there were no splash screen since I restarted only kded4. - Lamarque Vieira Souza On April 4, 2012, 6:56 a.m., makis marimpis wrote: > > -

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

quot;, activity) connect(watcher, SIGNAL(finished(QDBusPendingCallWatcher*)), this, SLOT(updateNextActivityName(QDBusPendingCallWatcher*))); } - Lamarque Vieira Souza On March 31, 2012, 7:48 p.m., makis marimpis wrote: > >

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

> In my old review I asked to normalize this connect statement. Read my old review to know how to do that. - Lamarque Vieira Souza On March 31, 2012, 6:15 p.m., makis marimpis wrote: > > --- > This is an automatically genera

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

o activity \"%1\"", reply.value())); service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9507> Normalize this connect statement (just remove "const" word, "&" char and any space inside the paren

Re: Review Request: Copy files instead of moving if parent dir is not writable

> On March 30, 2012, 8:18 p.m., Thomas Lübking wrote: > > service/jobs/nepomuk/Move.cpp, line 352 > > <http://git.reviewboard.kde.org/r/104417/diff/5/?file=55320#file55320line352> > > > > "!QUrl::isLocalFile()"? > > Lamarque Vieira Souza wrot

Re: Review Request: Copy files instead of moving if parent dir is not writable

gt; Diff: http://git.reviewboard.kde.org/r/104417/diff/ > > > Testing > --- > > Works for resources of type "app", it does not work for "image" yet because > Move::canMove receives the nepomuk's uri instead of the file url when the > resource type is "image". > > > Thanks, > > Lamarque Vieira Souza > >

Re: Review Request: Copy files instead of moving if parent dir is not writable

/r/104417/diff/ Testing --- Works for resources of type "app", it does not work for "image" yet because Move::canMove receives the nepomuk's uri instead of the file url when the resource type is "image". Thanks, Lamarque Vieira Souza

Re: Review Request: Copy files instead of moving if parent dir is not writable

s addresses bug 296808. http://bugs.kde.org/show_bug.cgi?id=296808 Diffs (updated) - service/jobs/nepomuk/Move.h 8a8afd1 service/jobs/nepomuk/Move.cpp 08a3cc2 Diff: http://git.reviewboard.kde.org/r/104417/diff/ Testing --- Works on Meego devel image. The file is copied and no error message is shown. Thanks, Lamarque Vieira Souza

Re: Review Request: Copy files instead of moving if parent dir is not writable

canMove receives the nepomuk's uri instead of the file url when the resource type is "image". Thanks, Lamarque Vieira Souza

Re: Review Request: Copy files instead of moving if parent dir is not writable

one in their > > original location (and for everyone else) > > This does not sound as if the current move has a problem, but the design of > > those private activities has (single user approach -> fix that by logging > > him in as root and watch the project fail ;-)

Re: Review Request: Copy files instead of moving if parent dir is not writable

one in their > > original location (and for everyone else) > > This does not sound as if the current move has a problem, but the design of > > those private activities has (single user approach -> fix that by logging > > him in as root and watch the project fail ;-)

Re: Review Request: Copy files instead of moving if parent dir is not writable

c2 > > Diff: http://git.reviewboard.kde.org/r/104417/diff/ > > > Testing > --- > > Works on Meego devel image. The file is copied and no error message is shown. > > > Thanks, > > Lamarque Vieira Souza > >

Re: Review Request: Copy files instead of moving if parent dir is not writable

Move.h 8a8afd1 service/jobs/nepomuk/Move.cpp 08a3cc2 Diff: http://git.reviewboard.kde.org/r/104417/diff/ Testing --- Works on Meego devel image. The file is copied and no error message is shown. Thanks, Lamarque Vieira Souza

Re: Review Request: Copy files instead of moving if parent dir is not writable

ail. To reply, visit: http://git.reviewboard.kde.org/r/104417/#review11899 ------- On March 26, 2012, 6:04 p.m., Lamarque Vieira Souza wrote: > > --- > This is an automat

Review Request: Copy files instead of moving if parent dir is not writable

ice/jobs/nepomuk/Move.cpp 08a3cc2 Diff: http://git.reviewboard.kde.org/r/104417/diff/ Testing --- Works on Meego devel image. The file is copied and no error message is shown. Thanks, Lamarque Vieira Souza

Re: Review Request: Remember current desktop when changing activity

ce/ActivityManager.cpp <http://git.reviewboard.kde.org/r/104261/#comment9102> remove trailing whitespace. - Lamarque Vieira Souza On March 13, 2012, 6:53 p.m., makis marimpis wrote: > > --- > This is an automaticall

Re: Review Request: Add cmake config for kdeclarative library.

; KDeclarative_SOURCE_DIR, which is defined if there is a project call > > like > > project(KDeclarative) > > in the KDeclarative CMakeLists.txt. You could then also check whether > > this variable is actually set, and error out if not. > >

Re: Review Request: Add cmake config for kdeclarative library.

rd.kde.org/r/104140/diff/ Testing --- I can now compile kde-workspace/ksmserver without using the custom made FindKDeclarative.cmake. Thanks, Lamarque Vieira Souza

Re: Review Request: Add cmake config for kdeclarative library.

/#review11090 --- On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Add cmake config for kdeclarative library.

visit: http://git.reviewboard.kde.org/r/104140/#review11151 --- On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request: Add cmake config for kdeclarative library.

e kde-workspace/ksmserver without using the custom made FindKDeclarative.cmake. Thanks, Lamarque Vieira Souza

Review Request: Add cmake config for kdeclarative library.

Testing --- Thanks, Lamarque Vieira Souza

Re: Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

/diff/ Testing --- Tested using Plasma Active devel image. Thanks, Lamarque Vieira Souza

Re: Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

- ksmserver/startup.cpp e166286 Diff: http://git.reviewboard.kde.org/r/104051/diff/ Testing (updated) --- Tested using Plasma Active devel image (no kcminit installed) and in my notebook (kcminit installed). Both work as expected and without delays. Thanks, Lamarque Vieira Souza

Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

Active devel image. Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

kde-runtime 4.8's declarative imports. TODO: . test right to left language support. Screenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ New version with label accelerator working http://git.reviewboard.kde.org/r/103621/s/407/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10238 ------- On Jan. 30, 2012, 5:08 p.m., Lamarque Vieira Souza wrote: > &g

Re: Review Request: Port shutdown dialog to QML

<http://git.reviewboard.kde.org/r/103621/diff/7/?file=48371#file48371line1> > > > > As picky as it may seem, doesn't this file need a license? I will add one. - Lamarque Vieira --- This is an automatically

Re: Review Request: Port shutdown dialog to QML

time 4.8's declarative imports. TODO: . test right to left language support. Screenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ New version with label accelerator working http://git.reviewboard.kde.org/r/103621/s/407/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

clarative imports. TODO: . test right to left language support. Screenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ New version with label accelerator working http://git.reviewboard.kde.org/r/103621/s/407/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

/103621/s/400/ New version with label accelerator working http://git.reviewboard.kde.org/r/103621/s/407/ Thanks, Lamarque Vieira Souza

Re: Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

> On Jan. 4, 2012, 10:22 p.m., Lamarque Vieira Souza wrote: > > ksmserver/shutdown.cpp, line 469 > > <http://git.reviewboard.kde.org/r/103593/diff/1/?file=45171#file45171line469> > > > > As long as ksmserver is not multi-threaded the race wil

Re: Review Request: Port shutdown dialog to QML

ould be solved by this patch. . test right to left language support. Screenshots (updated) --- http://git.reviewboard.kde.org/r/103621/s/400/ New version with label accelerator working http://git.reviewboard.kde.org/r/103621/s/407/ Thanks, Lamarque Vieira Souza

Re: Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

second logoutSoundFinished signal will test the state in logoutSoundFinished slot and return. - Lamarque Vieira Souza On Dec. 31, 2011, 3:16 a.m., Peter OGorman wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request: Port shutdown dialog to QML

ires kde-runtime 4.8's declarative imports. TODO: . implement something equivalent to QLabel's accelerators. . check if there are bugs in bugs.kde.org that could be solved by this patch. Screenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > ksmserver/CMakeLists.txt, line 57 > > <http://git.reviewboard.kde.org/r/103621/diff/1/?file=45363#file45363line57> > > > > no variable for kdeclarative? > > Lamarque Vieira Souza wrote: &g

Re: Review Request: Port shutdown dialog to QML

org/r/103621/s/400/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

ived > > testing in master), but that will only work when translation files do not > > change. > > Lamarque Vieira Souza wrote: > Some strings changed because no QML component supports QLabel's > accelerators, for example i18n("&Cancel")

Re: Review Request: Port shutdown dialog to QML

vates the navigation, you still need a second press to actually move focus to the next element. Screenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9537 --- On Jan. 4, 2012, 5:03 p.m., Lamarque Vieira Souza wrote: > > --

Re: Review Request: Port shutdown dialog to QML

avigation, you still need a second press to actually move focus to the next element. Screenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

e/fix it where > > appropiate) I tried to do that, but the font size became smaller than the rest of the desktop. - Lamarque Vieira --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.

Re: Review Request: Port shutdown dialog to QML

keyboard not working seems like a huge regression for my own > > usecase ;-) > > Lamarque Vieira Souza wrote: > All QtQuick imports in Contour theme are 1.0, all QtQuick imports in > default theme are 1.1. Why Contour theme should use 1.1 if it is not > required? They ar

Re: Review Request: Port shutdown dialog to QML

? There is one in shutdowndlg.cpp, in KSMShutdownDlg's constructor. - Lamarque Vieira --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9516 --------

Re: Review Request: Port shutdown dialog to QML

reenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ Thanks, Lamarque Vieira Souza

Re: Review Request: Port shutdown dialog to QML

Thanks, Lamarque Vieira Souza

Review Request: Port shutdown dialog to QML

E SC 4.8. It does not work in 4.7.x because the patch requires kde-runtime 4.8's declarative imports. Thanks, Lamarque Vieira Souza

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

, Lamarque Vieira Souza

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

n automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9078 ------- On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira Souza wrote: > > --- > Th

Re: Review Request: Reset time format upon user request

all emitChange. Thanks, Lamarque Vieira Souza

Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

--- Thanks, Lamarque Vieira Souza

Re: Review Request: Reset time format upon user request

omatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9031 --- On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote: > > --- > This

Re: Review Request: Reset time format upon user request

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9030 --- On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote: > > ---

  1   2   >