Re: Review Request 112575: KMenuedit documentation - improve introduction chapter and add use case section

2013-09-24 Thread Julien Borderie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112575/#review40706 --- Ship it! Ship It! - Julien Borderie On Sept. 21, 2013, 3

Re: Review Request 112575: KMenuedit documentation - improve introduction chapter and add use case section

2013-09-11 Thread Julien Borderie
existence of the contextual menu can be mentioned somewhere, in addition of the toolbar and menu (but just once to remain clear). - Julien Borderie On Sept. 7, 2013, 11:26 a.m., Burkhard Lück wrote: > > --- > This is an automat

Re: Review Request 109060: [KMenuEdit] Ability to move up/down items

2013-03-08 Thread Julien Borderie
e > > toolbar in addition to the menu and the contextual menu. Seems like the > > toolbar is getting bigger and bigger. What do you think? > > Julien Borderie wrote: > Albert, > > I think these both actions have their place in the toolbar for a quick >

Re: Review Request 109060: [KMenuEdit] Ability to move up/down items

2013-03-08 Thread Julien Borderie
------ On March 5, 2013, 5:48 p.m., Julien Borderie wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109060/ > ---

Re: Review Request 109060: [KMenuEdit] Ability to move up/down items

2013-03-06 Thread Julien Borderie
own" action enabled - Apply "Move down" action --> item moved down 2) Move up - Select the last item on a given tree node --> "move up" action enabled, "move down" action disabled - Apply "Move up" action --> item moved up Thanks, Julien Borderie

Re: Review Request 109060: [KMenuEdit] Ability to move up/down items

2013-03-04 Thread Julien Borderie
own" action enabled - Apply "Move down" action --> item moved down 2) Move up - Select the last item on a given tree node --> "move up" action enabled, "move down" action disabled - Apply "Move up" action --> item moved up Thanks, Julien Borderie

Re: Review Request 109084: [KMenuEdit] fix potential bugs

2013-02-22 Thread Julien Borderie
Diff: http://git.reviewboard.kde.org/r/109084/diff/ Testing --- Thanks, Julien Borderie

Review Request 109084: [KMenuEdit] fix potential bugs

2013-02-22 Thread Julien Borderie
/r/109084/diff/ Testing --- Thanks, Julien Borderie

Review Request 109060: [KMenuEdit] Ability to move up/down items

2013-02-22 Thread Julien Borderie
; action --> item moved down 2) Move up - Select the last item on a given tree node --> "move up" action enabled, "move down" action disabled - Apply "Move up" action --> item moved up Thanks, Julien Borderie

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-02-11 Thread Julien Borderie
(and kbuildsycoca4) --> kmenu displays sorted items 4) Sort all by description - Choose "sort all by description" --> all items sorted - Now save (and kbuildsycoca4) --> kmenu displays sorted items Thanks, Julien Borderie

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-02-11 Thread Julien Borderie
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/#review27152 ------- On Jan. 30, 2013, 10:40 p.m., Julien Borderie wrote: > > -

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-31 Thread Julien Borderie
name - Choose "sort all by name" --> all items sorted - Now save (and kbuildsycoca4) --> kmenu displays sorted items 4) Sort all by description - Choose "sort all by description" --> all items sorted - Now save (and kbuildsycoca4) --> kmenu displays sorted items Thanks, Julien Borderie

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-31 Thread Julien Borderie
s is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/#review26215 --- On Jan. 29, 2013, 8:48 p.m., Julien Borderie wrote: > > --- > Thi

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-29 Thread Julien Borderie
w save (and kbuildsycoca4) --> kmenu displays sorted items 4) Sort all by description - Choose "sort all by description" --> all items sorted - Now save (and kbuildsycoca4) --> kmenu displays sorted items Thanks, Julien Borderie

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-25 Thread Julien Borderie
> On Jan. 19, 2013, 5 p.m., Albert Astals Cid wrote: > > kmenuedit/treeview.h, line 147 > > <http://git.reviewboard.kde.org/r/107409/diff/2/?file=107707#file107707line147> > > > > This should be SortType not and int > > Julien Borderie wrote: >

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-19 Thread Julien Borderie
lly generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/#review25800 --- On Jan. 19, 2013, 10:09 p.m., Julien Borderie wrote: > > --- > This is an automa

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-19 Thread Julien Borderie
rted - Now save (and kbuildsycoca4) --> kmenu displays sorted items Thanks, Julien Borderie

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-19 Thread Julien Borderie
orrectly uploaded now. - Julien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/#review25734 --- On Jan. 18, 2013, 9:27 a.m.,

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-18 Thread Julien Borderie
e". - Choose "sort all by description". - Select an empty menu or a simple element -> selection sorting disabled. Thanks, Julien Borderie

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-18 Thread Julien Borderie
ption". - Select an empty menu or a simple element -> selection sorting disabled. File Attachments http://git.reviewboard.kde.org/media/uploaded/files/2013/01/17/patch.diff Thanks, Julien Borderie

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-17 Thread Julien Borderie
ection sorting disabled. File Attachments (updated) http://git.reviewboard.kde.org/media/uploaded/files/2013/01/17/patch.diff Thanks, Julien Borderie

Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-17 Thread Julien Borderie
rting disabled. File Attachments (updated) http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/patch_3.diff Thanks, Julien Borderie