Re: Dropping kdelibs4-based applications in KDE Applications 17.12

2016-11-17 Thread Josef Weidendorfer
Hi all, sorry for reading the mailing list very rarely nowadays. On 17.11.2016 10:25, Kevin Funk wrote: On Thursday, 17 November 2016 00:51:50 CET Sven Brauch wrote: On 11/11/16 16:45, Dominik Haumann wrote: What do you think about having a Randa meeting (or similar) with focus on finishing p

Re: Review Request: little faster sycoca

2011-09-29 Thread Josef Weidendorfer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102723/#review6919 --- Ship it! - Josef Weidendorfer On Sept. 29, 2011, 6:25 p.m

Re: Review Request: little faster sycoca

2011-09-29 Thread Josef Weidendorfer
On Wednesday 28 September 2011, Rolf Eike Beer wrote: > What happens if inPos is -1? pos becomes 0 then. Then we iterate over the > whole list just to do "if (... && pos != 0)" which will never be true. So for > this case (inPos == -1) the whole function can be avoided at all as it will > never

Re: Review Request: little faster sycoca

2011-09-28 Thread Josef Weidendorfer
On Wednesday 28 September 2011, Jaime Torres Amate wrote: > > > On Sept. 28, 2011, 8:59 a.m., Josef Weidendorfer wrote: > > > I would expect that the ->constEnd() method completely gets inlined with > > > compiler optimization turned on. So are you sure your change

Re: Review Request: little faster sycoca

2011-09-28 Thread Josef Weidendorfer
ets inlined with compiler optimization turned on. So are you sure your change improves anything for a release build? Anything performance related always needs to be backed by numbers from a release build. Numbers from a debug build are useless. - Josef Weidendorfer On Sept. 27, 2011, 8:42 p.m., Ja