a "files only" mode, in the same way as "directories
only" is currently supported? If it turns out that KDirOperator::setMode()
is intended to be have that effect, then I'd be happy to investigate why
it doesn't.
Best regards,
--
Jonathan Marten
used
to be called Extragear (now Self Released?).
I'll start to work through the review process checklist
(https://community.kde.org/ReleasingSoftware), and then try to submit
Kooka to kdereview - although that probably won't be able to be until
after the summer holidays.
Best regards, Jo
marked as submitted.
Review request for Dolphin and KDE Base Apps.
Changes
---
Submitted with commit 16db90c7938d09bfa8916afef8cce8dd258fa00d by Jonathan
Marten to branch master.
Bugs: 369523
https://bugs.kde.org/show_bug.cgi?id=369523
Repository: dolphin
Description
---
When
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129448/#review101299
---
Ping anyone?
- Jonathan Marten
On Nov. 20, 2016, 3:23
marked as submitted.
Review request for KDE Base Apps and David Faure.
Changes
---
Submitted with commit 7adf64addec6c9ca62dec8277e164c3ba93f837c by Jonathan
Marten to branch master.
Repository: konqueror
Description
---
This settings was originally commented out in the sources
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129518/#review101013
-------
On Nov. 21, 2016, 12:25 p.m., Jonathan Marten wrote:
>
>
f the preferred
association for the HTML MIME types.
Thanks,
Jonathan Marten
ons. Also verified by bug submitter.
Thanks,
Jonathan Marten
marked as submitted.
Review request for KDE Base Apps.
Changes
---
Submitted with commit aa247198f16179cf86768cfdeed94e7c557e864c by Jonathan
Marten to branch master.
Repository: keditbookmarks
Description
---
These actions are created by QUndoStack in order that it can manage the
/commandhistory.cpp 53a8931
Diff: https://git.reviewboard.kde.org/r/129423/diff/
Testing
---
Built keditbookmarks (split repository master version) with this change,
observed correct appearance and operation of Undo/Redo actions.
Thanks,
Jonathan Marten
marked as submitted.
Review request for kde-workspace and Plasma.
Changes
---
Submitted with commit 226401862f2c68f9bd37e95f6fae241b2d41e733 by Jonathan
Marten to branch master.
Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666
Repository: plasma-integration
Description
en overwriting an existing file,
unless the QFileDialog::DontConfirmOverwrite option is specified.
Thanks,
Jonathan Marten
Diff: https://git.reviewboard.kde.org/r/127944/diff/
Testing
---
Built plasma-intergration with this change, confirmed correct operation of file
dialogues and that confirmation is requested when overwriting an existing file,
unless the QFileDialog::DontConfirmOverwrite option is specified.
Thanks,
Jonathan Marten
ed in build/autotests. The
> relevant one would be kfiledialog_unittest and kfiledialogqml_unittest
>
> Jonathan Marten wrote:
> Ok, found them and how - thanks.
>
> It doesn't appear to be possible to just check that the QFileDialog
> option is passed correct
his is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95535
-------
On May 17, 2016, 3:20 p.m., Jonathan Marten wrote:
>
> ---
rg/r/127944/#review95535
---
On May 17, 2016, 3:20 p.m., Jonathan Marten wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127944/
> --
visit:
https://git.reviewboard.kde.org/r/127944/#review95532
---
On May 17, 2016, 3:20 p.m., Jonathan Marten wrote:
>
> ---
> This is an automatically generated e-mail. To
oard.kde.org/r/127944/diff/
Testing
---
Built plasma-intergration with this change, confirmed correct operation of file
dialogues and that confirmation is requested when overwriting an existing file,
unless the QFileDialog::DontConfirmOverwrite option is specified.
Thanks,
Jonathan Marten
ration of file
dialogues and that confirmation is requested when overwriting an existing file,
unless the QFileDialog::DontConfirmOverwrite option is specified.
Thanks,
Jonathan Marten
marked as submitted.
Review request for KDE Base Apps and David Faure.
Changes
---
Submitted with commit f868ba3b34b4f55111c3b6fb1ff0e6bcaa1d2797 by Jonathan
Marten to branch frameworks.
Repository: kde-baseapps
Description
---
This happens when a local file URL which ends in
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127138/#review92652
---
On Feb. 22, 2016, 3:12 p.m., Jonathan Marten wrote:
&
iew.cpp 3707c7a
Diff: https://git.reviewboard.kde.org/r/127138/diff/
Testing
---
Built kde-baseapps with these changes, observed correct display of base name in
Konqueror window title while navigating.
Thanks,
Jonathan Marten
marked as submitted.
Review request for KDE Base Apps.
Changes
---
Submitted with commit fc5e0160d81c4fad2e54e2cf31e09395634d7783 by Jonathan
Marten to branch frameworks.
Repository: kde-baseapps
Description
---
These changes to Konqueror's setting up of actions eliminat
e compiler and
runtime error messages, checked correct operation of key shortcuts.
Thanks,
Jonathan Marten
unner/interfaces/default/interface.cpp 505e0aa
Diff: https://git.reviewboard.kde.org/r/115183/diff/
Testing
---
Built kde-workspace with this change, verified operation of runner history.
Also verified by another bug reporter.
Thanks,
Jonathan Marten
/diff/
Testing
---
Built kde-workspace with this change, verified operation of runner history.
Also verified by another bug reporter.
Thanks,
Jonathan Marten
rly.
Regards, Jonathan
--
Jonathan Marten http://www.keelhaul.demon.co.uk
Twickenham, UK j...@keelhaul.demon.co.uk
---
Built kde-baseapps with these changes. Checked no crash when switching view
mode both by toolbar and menu, and that the correct items in each case are
checked.
Thanks,
Jonathan Marten
mode both by toolbar and menu, and that the correct items in each case are
checked.
Thanks,
Jonathan Marten
> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote:
> > I'm not totally happy with this change. Yes, the internal viewer is
> > limited in functionality, but it has advantages: (1) it is fast to open
> > and can be closed again with a single keystroke; (2) it r
e external
application), or a context menu with options View (in the internal viewer),
Open (in the default application) or Open With... (any other application).
- Jonathan Marten
On Oct. 8, 2013, 3:23 p.m., Sven Brauch wrote:
>
>
ail. To reply, visit:
http://git.reviewboard.kde.org/r/111093/#review40425
---
On Sept. 18, 2013, 8:37 a.m., Jonathan Marten wrote:
>
> ---
> This is an automatically genera
age box is displayed.
Click on another action, correctly enter the password and observe that there is
no message and policies are displayed as expected.
Thanks,
Jonathan Marten
ocalDir, QStringList( "kshorturifilter"
) );
to make the coverage complete?
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111390/#review35635
change. Checked correct results for '~' and
'~user', where the user both exists and does not, in konqueror and krunner.
Ran the kurifiltertest with all passes.
Thanks,
Jonathan Marten
ard.kde.org/r/110964/#review34250
---
On June 12, 2013, 12:15 p.m., Jonathan Marten wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
command 'foo'
$
Thanks,
Jonathan Marten
message output.
$ kioclient exec
kioclient: Syntax error, not enough arguments
$ kioclient exec a b c
kioclient: Syntax error, too many arguments
$ kioclient foo
kioclient: Syntax error, unknown command 'foo'
$
Thanks,
Jonathan Marten
d device
http://git.reviewboard.kde.org/r/106755/s/769/
Thanks,
Jonathan Marten
s an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106755/#review20057
---
On Oct. 8, 2012, 9:31 a.m., Jonathan Marten wrote:
>
> ---
>
> On Oct. 4, 2012, 4:28 p.m., Christoph Feck wrote:
> > Causes a regression. When using "Save Image As..." in Konqueror, the file
> > dialog starts at "Custom Path" (and lists root folder), without remembering
> > the previously used path.
Doing the test as follows appears to work, for both lo
Screenshots
---
Device notifier with mounted device
http://git.reviewboard.kde.org/r/106755/s/756/
Thanks,
Jonathan Marten
--
Device notifier with mounted device
http://git.reviewboard.kde.org/r/106755/s/756/
Thanks,
Jonathan Marten
ce it turned out
that there was still a a lot of work going on in this area, it got
put on ice.
What do you think is unusable or needs to be addressed in the KCM?
Regards, Jonathan
--
Jonathan Marten http://www.keelhaul.demon.co.uk
Twickenham, UK j...@keelhaul.demon.co.uk
d Faure writes:
> We really need a FHS addition for libexec.
> Due to the current mess, QStandardPaths::findExe can't look into libexec, so
> the only way to find stuff there is to compile the install prefix into the
> library (that's what I do in KF5 fo
#x27;m pretty sure this patch will massively conflict with
> > http://git.reviewboard.kde.org/r/106124/
> >
> > please use kdelibs (or even better qt, as far as i'm concerned) coding
> > style for new code. at the very least stay consistent with yourself.
>
50>
> >
> > endsWith
endsWith won't work here because some savers' Exec= lines have additional
arguments.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.k
ving of settings in the config file and operation of the
random saver.
Screenshots
---
kcmshell4 screensaver
http://git.reviewboard.kde.org/r/106524/s/733/
Thanks,
Jonathan Marten
Kevin Krammer writes:
> Do you mean $PREFIX/libexec, where $PREFIX will often be /usr (for
> distribution packages)?
Yes, that's what I meant - in theory equivalent, since $KDEDIR will be
set to the same at runtime.
--
Jonathan Marten http://www.keelhaul.
ion for that purpose.
Thanks for the clarification Kevin. Perhaps a better place for those
Akonadi executables would then be $KDEDIR/libexec - this location
isn't in the LSB/FHS but many packages which still use GNU Autoconf
use it. IIRC KDE3 had the same.
--
Jonathan Marten
pomukindexer
nepomukserver
nepomukservicestub
nspluginscan
plasma-remote-helper
rdfindexer
servicemenudeinstallation
servicemenuinstallation
sopranod
strigidaemon
xmlindexer
--
Jonathan Marten http://www.keelhaul.demon.co.uk
Twickenham, UK j...@keelhaul.demon.co.uk
--
Built Konqueror with these changes, tested with file management and web
browsing profiles with various window splits.
Thanks,
Jonathan Marten
> On Oct. 14, 2011, 12:05 a.m., Christoph Feck wrote:
> > Nice, work, as always :) Only one question: Do the port spin boxes need the
> > "Port:" labels, as seen in the ASCII drawings from bug 147340? Or would it
> > clutter the interface? Maybe a "Hostname" and "Port" headline for the two
> >
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101312/#review3233
-------
On May 8, 2011, 3:42 p.m., Jonathan Marten wrote:
>
> --
wing it, with much negative publicity (some of it
justified).
KDE 5.0 has to be ready, reliable and usable if that is to be avoided.
--
Jonathan Marten http://www.keelhaul.demon.co.uk
Twickenham, UK j...@keelhaul.demon.co.uk
t.reviewboard.kde.org/r/101312/#review3210
---
On May 8, 2011, 3:42 p.m., Jonathan Marten wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101312/
---
(Updated May 8, 2011, 3:42 p.m.)
Review request for kdelibs.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101312/
---
Review request for kdelibs.
Summary
---
This dialogue - used, for exa
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100821/
---
(Updated March 8, 2011, 5:23 p.m.)
Review request for KDE Base Apps and kw
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100821/
---
Review request for KDE Base Apps.
Summary
---
Some of the still avail
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100528/
---
Review request for KDEPIM-Libraries.
Summary
---
In the KAddressBook
> On 11/02/2010 09:26 AM, Jonathan Marten wrote:
>> c) use a KServiceTypeTrader query (which hopefully ignores hidden
>> desktop files) instead of listing them.
Thanks to Sebastian and David for your comments. I've recoded
KDEDConfig::load() and KDEDConfig::save() to use a
ad of listing them.
Even if we say that (a) is the solution for this particular instance,
it still leaves an unexpected catch in this systemsettings module
(desktop files here cannot be hidden in the same way as others). So
should one of (b) or (c) be implemented also?
Regards
63 matches
Mail list logo
