Re: Review Request 127823: Allow building without strigi on Linux

2016-05-23 Thread Johannes Huber
> On Mai 3, 2016, 2:58 nachm., Aleix Pol Gonzalez wrote: > > Why touch the `if(WIN32)` though? If needed, just make it optional on all > > platforms. > > Antonio Rojas wrote: > That's what I'm doing... Currently it's only optional on WIN32, I'm > changing it to be optional regardless of th

Review Request 113987: tier3/kpty: Improve dependency specifications

2013-11-20 Thread Johannes Huber
--- Improve dependency specifications Depends only on Qt5 core for src. Move Qt test dependency spec to subdir. Diffs - tier3/kpty/CMakeLists.txt 12d977e tier3/kpty/autotests/CMakeLists.txt aa28cfc Diff: http://git.reviewboard.kde.org/r/113987/diff/ Testing --- Thanks, Johannes

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-09 Thread Johannes Huber
sit: http://git.reviewboard.kde.org/r/103631/#review9676 --- On Jan. 8, 2012, 4:35 p.m., Johannes Huber wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-08 Thread Johannes Huber
/FindXine.cmake 37c58c6 Diff: http://git.reviewboard.kde.org/r/103631/diff/diff Testing --- Thanks, Johannes Huber

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-06 Thread Johannes Huber
/diff Testing --- Thanks, Johannes Huber

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Johannes Huber
Testing --- Thanks, Johannes Huber

Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Johannes Huber
downstream patch, see bug https://bugs.gentoo.org/show_bug.cgi?id=397595 for cause. Diffs - cmake/modules/FindXine.cmake 37c58c6 Diff: http://git.reviewboard.kde.org/r/103631/diff/diff Testing --- Thanks, Johannes Huber