Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

2013-07-05 Thread Jekyll Wu
org/r/111402/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-06-05 Thread Jekyll Wu
reject disabled versions (revised edition) http://git.reviewboard.kde.org/media/uploaded/files/2013/05/30/bugzilla-version-cheking-improved.png Thanks, Jekyll Wu

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-05-30 Thread Jekyll Wu
iles/2013/05/28/drkonqi-version-checking.png reject disabled versions (revised edition) http://git.reviewboard.kde.org/media/uploaded/files/2013/05/30/bugzilla-version-cheking-improved.png Thanks, Jekyll Wu

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-05-28 Thread Jekyll Wu
on-checking.png Thanks, Jekyll Wu

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-05-28 Thread Jekyll Wu
enshot soon. - Jekyll --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110687/#review33274 --- On May 28, 2013, 8:

Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-05-28 Thread Jekyll Wu
rt against a outdated version is still useless. This addresses bug 315073. http://bugs.kde.org/show_bug.cgi?id=315073 Diffs - Diff: http://git.reviewboard.kde.org/r/110687/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Jekyll Wu
> On May 24, 2013, 9:44 p.m., Jekyll Wu wrote: > > Bugzilla itself (since 4.2.5) already rejects any attempt against disabled > > versions. So even without this patch, DrKonqi users won't be able to create > > crash report against disabled versions in the end

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Jekyll Wu
> On May 24, 2013, 9:44 p.m., Jekyll Wu wrote: > > Bugzilla itself (since 4.2.5) already rejects any attempt against disabled > > versions. So even without this patch, DrKonqi users won't be able to create > > crash report against disabled versions in the end

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Jekyll Wu
> On May 24, 2013, 9:44 p.m., Jekyll Wu wrote: > > Bugzilla itself (since 4.2.5) already rejects any attempt against disabled > > versions. So even without this patch, DrKonqi users won't be able to create > > crash report against disabled versions in the end

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-24 Thread Jekyll Wu
uest today or tomorrow. [1] https://bugs.kde.org/show_bug.cgi?id=315073#c3 [2] https://bugs.kde.org/show_bug.cgi?id=318769#c1 - Jekyll Wu On May 24, 2013, 2:54 p.m., Martin Gräßlin wrote: > > --- > This is an automatically gen

Re: Login for bug reporting

2013-02-10 Thread Jekyll Wu
On 2013年02月07日 19:02, Jan Kundrát wrote: Are most of these reports coming from DrKonqi? If so, have it fetch the list of "supported versions" from somewhere and tell the user to upgrade when their version is too old, then. (And don't accidentally prevent the automated reporting when the version i

Re: Login for bug reporting

2013-02-09 Thread Jekyll Wu
On 2013年02月07日 18:29, Martin Gräßlin wrote: Also spend a moment and look at the report. There is multiple times written that we don't want any further comments on the bug and that doesn't help anything. Still attachements, still duplicates. I guess you are talking about https://bugs.kde.org/sh

Re: Login for bug reporting

2013-02-09 Thread Jekyll Wu
On 2013年02月07日 17:21, Kevin Krammer wrote: It was definitely the process of creating an account, the developer was explicitly stating that providing an email address isn't the problem. Does the crash report dialog offer the option of creating an account? Does it store the password so that it can

Re: Login for bug reporting

2013-02-09 Thread Jekyll Wu
On 2013年02月07日 01:56, Kevin Krammer wrote: Hi at FOSDEM I was approached by a person who asked me to relay his dissatisfaction with the requirement of having a KDE Bugzilla account to report crashes via the KDE crash handler dialog. The issue in his case was kind of made worse by having this ob

Review Request 108541: KBugReport should open enter_bug.cgi directly instead of wizard.cgi on bugs.kde.org

2013-01-22 Thread Jekyll Wu
//projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/drkonqi/systeminformation.cpp This addresses bug 291346. http://bugs.kde.org/show_bug.cgi?id=291346 Diffs - kdeui/dialogs/kbugreport.cpp 2e72828 Diff: http://git.reviewboard.kde.org/r/108541/diff/ Testing --- Thanks, Jekyll Wu

Re: KDEREVIEW: Mangonel

2013-01-09 Thread Jekyll Wu
On 2013年01月09日 08:09, Martin Sandsmark wrote: >Any reason not to use bugs.kde.org? Fixed. Hi, I see you made the change : -aboutData->setBugAddress(QByteArray("bugs.mango...@tarmack.eu")); +aboutData->setBugAddress(QByteArray("https://bugs.kde.org/";)); Hmm, that is not going to wo

Re: Review Request: ksysguard - Add rowspan/colspan support for displays

2013-01-06 Thread Jekyll Wu
> On Jan. 4, 2013, 8:13 p.m., John Tapsell wrote: > > Ship It! Well, I will push this patch with the assumption that you are busy and Arnav doesn't have commit access yet. - Jekyll --- This is an automatically generated e-mail. To rep

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2013-01-06 Thread Jekyll Wu
> On Jan. 5, 2013, 7:49 a.m., Erwan MATHIEU wrote: > > Well, what am I supposed to do now ? I don't have a write access to the > > git, so do I have to wait for someone to include the patch ? You need to first get a "Ship It!" approval of the patch from some maintainer. Only then should you wo

Re: Review Request: Make Dr.Konqi remember and show&use the time when the crash happend

2013-01-03 Thread Jekyll Wu
pp 59f3b35 drkonqi/drkonqidialog.cpp f2e4edf Diff: http://git.reviewboard.kde.org/r/107775/diff/ Testing --- Screenshots --- show crash in "General" tab http://git.reviewboard.kde.org/r/107775/s/905/ Thanks, Jekyll Wu

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-23 Thread Jekyll Wu
proposed change (timeout adjusted to 15min) tomorrow so that it can catch 4.9.5 - Jekyll Wu On Dec. 10, 2012, 8:16 a.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboa

Review Request: Make Dr.Konqi remember and show&use the time when the crash happend

2012-12-17 Thread Jekyll Wu
creenshots --- show crash in "General" tab http://git.reviewboard.kde.org/r/107775/s/905/ Thanks, Jekyll Wu

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread Jekyll Wu
于 2012年12月10日 19:27, Rolf Eike Beer 写道: The only downside is some backtrace might be lost. But I don't think that is a big deal. Crashes during shutdown are rare cases nowadays(I hope I'm right), and users noticing those crashes only hours later are the rare case in rare cases (but very annoying)

Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread Jekyll Wu
http://git.reviewboard.kde.org/r/107657/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-09 Thread Jekyll Wu
d wait to see how many users will notice and complain this rare case not working any more. - Jekyll --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/#review21816 ---

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-09 Thread Jekyll Wu
#x27;t know whether it make senses to support all combinations . This addresses bug 242760. http://bugs.kde.org/show_bug.cgi?id=242760 Diffs (updated) - ksmserver/server.cpp a65b35a Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-11-11 Thread Jekyll Wu
242760. http://bugs.kde.org/show_bug.cgi?id=242760 Diffs (updated) - ksmserver/server.cpp eb3ac18 Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu

Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-11-11 Thread Jekyll Wu
http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu

Review Request: Remove the mimetype "application/x-konsole"

2012-11-01 Thread Jekyll Wu
bug report. Put a simple patch here just in case that bug report gets forgotten. This addresses bug 292378. http://bugs.kde.org/show_bug.cgi?id=292378 Diffs - mimetypes/kde.xml f72eb2f Diff: http://git.reviewboard.kde.org/r/107167/diff/ Testing --- Thanks, Jekyll Wu

Review Request: Make "New File -> Text File" create empty file

2012-08-06 Thread Jekyll Wu
97003 Diffs - lib/konq/Templates/TextFile.txt 8d1c8b6 Diff: http://git.reviewboard.kde.org/r/105888/diff/ Testing --- "Create New -> Text File" now creates a empty "TextFile.txt". I haven't noticed the problem mentioned in comment #1 in that bug report. Thanks, Jekyll Wu

Review Request: Add CamelCase wrapper for kcodecaction.h

2012-08-01 Thread Jekyll Wu
wrapper for kcodecaction.h. I guess that is an omission. This simple patch adds it. Diffs - includes/CMakeLists.txt 157d321 includes/KCodecAction PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105818/diff/ Testing --- Thanks, Jekyll Wu

Review Request: Add CamelCase wrapper for kcodecaction.h

2012-08-01 Thread Jekyll Wu
wrapper for kcodecaction.h. I guess that is an omission. This simple patch adds it. Diffs - includes/CMakeLists.txt 157d321 includes/KCodecAction PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105818/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request: Only show KSysguard & SystemSettings in menus when running KDE

2012-07-16 Thread Jekyll Wu
p for KDE environment and kdesystemsettings.desktop for non-KDE environment. So I think this review can be closed now. - Jekyll Wu On July 21, 2011, 10:39 p.m., Jeremy Bicha wrote: > > --- > This is an automatically generat

Re: Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-09 Thread Jekyll Wu
crashes of kactivitymanagerd to the "kactivies" product. Diffs - drkonqi/data/mappings 147bcdc Diff: http://git.reviewboard.kde.org/r/105483/diff/ Testing --- Thanks, Jekyll Wu

Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-08 Thread Jekyll Wu
147bcdc Diff: http://git.reviewboard.kde.org/r/105483/diff/ Testing --- Thanks, Jekyll Wu

Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-08 Thread Jekyll Wu
147bcdc Diff: http://git.reviewboard.kde.org/r/105483/diff/ Testing --- Thanks, Jekyll Wu

Review Request: [dolphin] Fix the warning generated by desktop-file-validate for dolphin.desktop

2012-06-18 Thread Jekyll Wu
n.desktop cd9da17 Diff: http://git.reviewboard.kde.org/r/105288/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request: update the outdated documention and sample code of kde_terminal_interface

2012-06-07 Thread Jekyll Wu
rd.kde.org/r/105155/diff/ Testing --- The sample code works fine with kdelibs/4.8 and konsole built from master. Thanks, Jekyll Wu

[Help] Is this wrong usage or a bug of global shortcut?

2011-12-25 Thread Jekyll Wu
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, I am trying to fix bug 259539. The real problem is some global shortcuts of klipper keep resetting to 'None' after it restarts. Here is one problematic line: action->setGlobalShortcut(KShortcut(.), KAction::DefaultShortcut); The inte