Re: A question about "signals" in qt-nm

2017-09-01 Thread Jan Grulich
Hi, On pátek 1. září 2017 12:46:54 CEST Shaheed Haque wrote: > Hi all, > > The Python bindings effort recently ran into the need for > https://phabricator.kde.org/D5185 to prevent clashes between Qt's use > of "signals" and libnm via networkmanager-qt's ipconfig.h. However, it > seems to me that

Re: kdereview - xdg-desktop-portal-kde

2017-05-12 Thread Jan Grulich
27;t be able to call it with less parameters. If you do, you will get an error from dbus that the signature is wrong. Jan > > Lamarque V. Souza > Linux User #57137 - https://www.linuxcounter.net/user/57137 > > On Fri, May 12, 2017 at 6:23 AM, Jan Grulich wrote: > > Hi, &

Re: kdereview - xdg-desktop-portal-kde

2017-05-12 Thread Jan Grulich
n On pátek 21. dubna 2017 8:10:36 CEST Jan Grulich wrote: > Hi, > > I would like to request review of xdg-desktop-portal-kde [1]. We would like > to make it part of Plasma releases, see [2]. > > What is xdg-desktop-portal-kde: > It's a KDE implementation of Flatpak port

Re: kdereview - xdg-desktop-portal-kde

2017-05-03 Thread Jan Grulich
On středa 3. května 2017 11:28:45 CEST Elvis Angelaccio wrote: > On mercoledì 3 maggio 2017 07:00:14 CEST Jan Grulich wrote: > > > > > > Do you have xdg-desktop-portal installed? > > > > > > > > > > Yes. > > > > > > &

Re: kdereview - xdg-desktop-portal-kde

2017-05-02 Thread Jan Grulich
On úterý 2. května 2017 23:58:20 CEST you wrote: > On martedì 2 maggio 2017 17:26:41 CEST Jan Grulich wrote: > > On úterý 2. května 2017 15:22:23 CEST Elvis Angelaccio wrote: > > > On Tue, May 2, 2017 at 3:09 PM, Jan Grulich wrote: > > > > On úterý 2. května 2017

Re: kdereview - xdg-desktop-portal-kde

2017-05-02 Thread Jan Grulich
On úterý 2. května 2017 15:22:23 CEST Elvis Angelaccio wrote: > On Tue, May 2, 2017 at 3:09 PM, Jan Grulich wrote: > > On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote: > >> On Tue, May 2, 2017 at 12:36 PM, Jan Grulich wrote: > >> > On úterý 2. květn

Re: kdereview - xdg-desktop-portal-kde

2017-05-02 Thread Jan Grulich
On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote: > On Tue, May 2, 2017 at 12:36 PM, Jan Grulich wrote: > > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: > >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid wrote: > >> > El dimarts, 2 de ma

Re: kdereview - xdg-desktop-portal-kde

2017-05-02 Thread Jan Grulich
On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: > On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid wrote: > > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va escriure: > >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote: > >>

Re: kdereview - xdg-desktop-portal-kde

2017-05-01 Thread Jan Grulich
On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote: > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va escriure: > > Hi, > > > > I would like to request review of xdg-desktop-portal-kde [1]. We would > > like > > to make i

kdereview - xdg-desktop-portal-kde

2017-04-20 Thread Jan Grulich
https://cgit.kde.org/xdg-desktop-portal-kde.git/ [2] - https://mail.kde.org/pipermail/plasma-devel/2017-April/069506.html [3] - http://flatpak.org/xdg-desktop-portal/portal-docs.html#idm140258860052032 Regards, Jan -- Jan Grulich, Software Engineer, Desktop Team Red Hat

Re: qca-qt5 (qt5 branch) merge into qca (master branch)

2015-09-24 Thread Jan Grulich
27;s qt5 branch into master and > replacing the qt5 tarball with a new release that supports both qt4 > and qt5? > + 1, we added qca as dependency for plasma-nm and to be able to build it you need the latest fix I pushed to qca thus new release of qca before Plasma 5.5.0 release is needed. Regards, Jan -- Jan Grulich Software Engineer, Desktop team Red Hat Czech

Re: Plasma 5.2 bits for kdereview

2015-01-07 Thread Jan Grulich
On Tuesday 06 of January 2015 14:10 Jonathan Riddell wrote: > Updates on this.. > > I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, > libmm-qt and ksshaskpass to be moved. I see some comments that the > libraries may be used outside of Plasma but there's no problem with > tha

Re: [Kde-hardware-devel] Solid BoF at Akademy

2014-08-27 Thread Jan Grulich
On Tuesday 26 of August 2014 02:29 Àlex Fiestas wrote: > On Monday 25 August 2014 11:25:29 Jan Grulich wrote: > > I didn't make it in time (I was on vacation) and there is already "KDE > > India" BoF before lunch, so we can't move it one slot down, but I believ

Re: [Kde-hardware-devel] Solid BoF at Akademy

2014-08-25 Thread Jan Grulich
On Wednesday 13 of August 2014 14:04 Àlex Fiestas wrote: > On Wednesday 13 August 2014 13:32:18 Kevin Ottens wrote: > > Hello, > > > > On Wednesday 13 August 2014 12:15:18 Jan Grulich wrote: > > > I would like to inform that we decided to arrange a Solid BoF at &

Solid BoF at Akademy

2014-08-13 Thread Jan Grulich
/Akademy/2014/Tuesday#Room_2_-_9_September[1] Cheers, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com [1] https://community.kde.org/Akademy/2014/Tuesday#Room_2_-_9_September

Re: Moving plasma-nm to extragear

2014-06-11 Thread Jan Grulich
Hi, the two week period for review has passed, so I guess we are able to move plasma-nm to kde-workspace. Is there anyone who disagree with this? I'll wait for a few days and then fill a new ticket. Thanks. Cheers, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com On Tuesd

Re: Moving plasma-nm to extragear

2014-06-07 Thread Jan Grulich
Hi, thanks for the quick review. On Friday 06 of June 2014 22:01 you wrote: > El Dimarts, 27 de maig de 2014, a les 20:41:23, Jan Grulich va escriure: > > Hi, > > > > we would like to move plasma-nm to extragear/base and ask you for a > > review. > > Looks li

Re: Moving plasma-nm to extragear

2014-05-30 Thread Jan Grulich
Hi, I agree too, it would be probably better be part of kde/workspace, also plasma-nm is not changing that much these days, so it should be fine. Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com On Friday 30 of May 2014 10:31 Lamarque Souza wrote: > Hi all, > > I a

Moving plasma-nm to extragear

2014-05-28 Thread Jan Grulich
://projects.kde.org/projects/kdereview/plasma-nm Please review 0.9.3 branch, which is the current version for KDE 4. Frameworks branch was merged to master today, so if you want to take a look at KF5/Plasma Next port, use master branch then. Thanks a lot. Cheers, Jan -- Jan Grulich Red Hat Czech

Re: Review Request 116117: Place new panels to bottom by default

2014-03-04 Thread Jan Grulich
d when executing a script for default panel layout. I'm not much sure with the javascript part, but it works. Diffs - plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js 356e689 Diff: https://git.reviewboard.kde.org/r/116117/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 116117: Place new panels to bottom by default

2014-03-04 Thread Jan Grulich
s. Diffs (updated) - plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js 356e689 Diff: https://git.reviewboard.kde.org/r/116117/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 116117: Place new panels to bottom by default

2014-03-01 Thread Jan Grulich
t.reviewboard.kde.org/r/116117/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 116117: Place new panels to bottom by default

2014-03-01 Thread Jan Grulich
#x27;m not much sure with the javascript part, but it works. Diffs - plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js 47f635c plasma/desktop/shell/desktopcorona.cpp d3635d9 Diff: https://git.reviewboard.kde.org/r/116117/diff/ Testing --- Thanks, Jan Grulich

Review Request 116117: Place new panels to bottom by default

2014-02-27 Thread Jan Grulich
sma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js 47f635c plasma/desktop/shell/desktopcorona.cpp d3635d9 Diff: https://git.reviewboard.kde.org/r/116117/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-13 Thread Jan Grulich
e not initialized yet. And changed() signal is connected to soon so that's the reason why this KCM is always set as changed. Diffs - phonon/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-11 Thread Jan Grulich
eason why this KCM is always set as changed. Diffs (updated) - phonon/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-11 Thread Jan Grulich
- phonon/kcm/audiosetup.h 4887efe phonon/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.h 277adfe phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390/diff/ Testing --- Thanks, Jan Grulich

Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-11 Thread Jan Grulich
/kcm/audiosetup.cpp 35dc4ca phonon/kcm/main.h 277adfe phonon/kcm/main.cpp 5d75cba Diff: http://git.reviewboard.kde.org/r/110390/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-24 Thread Jan Grulich
this issue https://bugzilla.redhat.com/show_bug.cgi?id=877021 Diffs (updated) - plasma/private/packages.cpp 2519341 Diff: http://git.reviewboard.kde.org/r/107413/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-24 Thread Jan Grulich
widgets is not downloaded every time you open it. Should fix this issue https://bugzilla.redhat.com/show_bug.cgi?id=877021 Diffs (updated) - plasma/private/packages.cpp 2519341 Diff: http://git.reviewboard.kde.org/r/107413/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-22 Thread Jan Grulich
=877021 Diffs - plasma/private/packages.cpp 2519341 plasma/private/packages_p.h 15fde41 Diff: http://git.reviewboard.kde.org/r/107413/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-21 Thread Jan Grulich
- plasma/private/packages.cpp 2519341 plasma/private/packages_p.h 15fde41 Diff: http://git.reviewboard.kde.org/r/107413/diff/ Testing --- Thanks, Jan Grulich

Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-21 Thread Jan Grulich
2519341 plasma/private/packages_p.h 15fde41 Diff: http://git.reviewboard.kde.org/r/107413/diff/ Testing --- Thanks, Jan Grulich