Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Jakob Gruber
On 08/04/2012 10:02 AM, Laszlo Papp wrote: >> It *should* work logically and correctly until a new refactor, thus I >> cannot buy this argument, I am afraid. This is a few-liner change to >> make this operation right... > > Just to clarify, this statement means that you either support the old > kd

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Jakob Gruber
On 08/04/2012 09:24 AM, Laszlo Papp wrote: >> Are there any objections or requested changes before Picmi can proceed >> to kdegames? > > Yes, you have ignored my comments for more than a week with a > cross-platform issue, and not just on Windows. Support for the old libkdegames will be removed s

Re: playground/games/picmi moved to KDE Review

2012-08-03 Thread Jakob Gruber
On 07/20/2012 11:53 AM, Jakob Gruber wrote: > Hi all, > > > I'd like to announce the move of Picmi to KDE Review [1] with the > intended destination being kdegames. Picmi has been in KDE Review for 2 weeks, and according to the application lifecycle the initial review pe

Re: playground/games/picmi moved to KDE Review

2012-07-26 Thread Jakob Gruber
On 07/26/2012 05:43 AM, Andrius da Costa Ribas wrote: > add_definitions(${KDE4_ENABLE_EXCEPTIONS}) seems to interfere with RC.exe > when I try to add a kde4_add_app_icon. > fatal error RC1106: invalid option: -EHsc > > any hint with that? Googling turns up www.cmake.org/pipermail/cmake/2008-June/

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Jakob Gruber
On 07/25/2012 11:44 PM, Laszlo Papp wrote: >> KERNELBASE.dll!RaiseException() [[unknown] @ -1] at 0x75f7b727 >> MSVCR100.dll!CxxThrowException() [[unknown] @ -1] at 0x64617819 >> picmi.exe!Renderer::loadResources() >> [c:\projects\picmi\src\gui\renderer.cpp @ 73] at 0xec028f >> picmi.exe!GetCommand

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Jakob Gruber
I spent this morning setting up KDE Windows (thanks SaroEngels for all the help). The good news is that picmi compiles and runs without any changes to the source code (mingw and KDE 4.8). I have not set up a build with MSVC or KDE trunk, so I can't say anything about these yet. On to specific iss

Re: playground/games/picmi moved to KDE Review

2012-07-24 Thread Jakob Gruber
On 07/24/2012 11:35 PM, Laszlo Papp wrote: >> Does the game work on Windows? > > I have just put some effort into testing this, but it is quite broken. > I would like to see improvements in this front since Windows is an > important platform for Qt and KDE. I am here for helping with that, if > ne

Re: playground/games/picmi moved to KDE Review

2012-07-23 Thread Jakob Gruber
On 07/22/2012 07:10 PM, Albert Astals Cid wrote: > My comments: > * You think you could give it a somehow bigger initial size? It starts very > small the first time > * Do you have a bigger res icon? Otherwise looks quite bad in my alt+tab > switcher > * Can you disable the "..." in the settin

Re: playground/games/picmi moved to KDE Review

2012-07-22 Thread Jakob Gruber
On 07/22/2012 07:10 PM, Albert Astals Cid wrote: > My comments: > * You think you could give it a somehow bigger initial size? It starts very > small the first time A default size of 700x560 is now set (I had it at at first 800x650 but tsdgeos reminded me about netbooks). > * Do you have a big

Re: playground/games/picmi moved to KDE Review

2012-07-22 Thread Jakob Gruber
On 07/21/2012 09:38 PM, Raphael Kubo da Costa wrote: > Jakob Gruber writes: > >> I've replaced all std::shared_pointers with QSharedPointers this morning >> and removed the -std=c++11 flag. > > I'm now getting a few errors and warnings when trying to build picmi

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Jakob Gruber
On 07/21/2012 11:16 AM, Adriaan de Groot wrote: > On Saturday, July 21, 2012 10:48:47 AM Jakob Gruber wrote: >> One other question: three of the included levels are small pictograms of >> Disney characters up to 31x32 px in size. I'm not sure if that could be >> a leg

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Jakob Gruber
On 07/21/2012 12:02 AM, Raphael Kubo da Costa wrote: > Jakob Gruber writes: > >> Building with KDE trunk will require the patch from >> http://lists.kde.org/?l=kde-games-devel&m=134201653803914&w=2. > > BTW, the "config.h" part of the patch should g

playground/games/picmi moved to KDE Review

2012-07-20 Thread Jakob Gruber
Hi all, I'd like to announce the move of Picmi to KDE Review [1] with the intended destination being kdegames. Picmi is a nonogram logic game [2] I've been working on for around two years. It includes both a random mode (with low completion times as the goal) and 51 preset puzzles which turn int