Re: Review Request 113216: some little performance improvement for network kio

work/ioslave/networkslave.cpp a548f1a Diff: https://git.reviewboard.kde.org/r/113216/diff/ Testing --- Thanks, Jaime Torres Amate

Review Request 121935: Compile with -Werror=return-true -Wno-variadic-macros

g.cpp be55ff5 src/workspace/settings/MainConfigurationWidget.cpp e130d1d Diff: https://git.reviewboard.kde.org/r/121935/diff/ Testing --- It compiles with gcc 4.9 and clang++ (without those flags) Thanks, Jaime Torres Amate

Re: Review Request 116097: No longer use strlcpy in kstartupconfig

WIN32, you have my ship it!. - Jaime Torres Amate On Feb. 26, 2014, 6:11 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 113216: some little performance improvement for network kio

diff/ Testing --- Thanks, Jaime Torres Amate

Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

> On Sept. 21, 2013, 6:40 p.m., Jaime Torres Amate wrote: > > I've tried to apply it to today master head and it does not apply clean. > > Some previous patch has done something similar to your patch. (sorry, not > > much time to check it all). > > Jon

Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

s not apply clean. Some previous patch has done something similar to your patch. (sorry, not much time to check it all). - Jaime Torres Amate On Sept. 18, 2013, 8:37 a.m., Jonathan Marten wrote: > > --- > This is an automatically ge

Re: release schedule BoF

Why not the other direction? 4 months to develop new features, 2 months freeze and fixing? Jonathan Riddell escribió: > >Albert Astals Cid: >idea is to shorten release >we have now lots of freezes and a branch >alex wants something shorter, suggested 3 months between release with >only 1

Re: Releases in 3 months

How would the release schedule ( http://techbase.kde.org/Schedules/KDE4/4.11_Release_Schedule) be in a 3 or 4 mounths release? 1 month for new features, 2 or 3 for bugfixing, translating, language bindings? Or like linux kernel, allways develop new features in other branches, and 1 month to me

Re: Review Request: favicon local cache

Diffs (updated) - kdecore/services/kmimetype.cpp 955bf62 Diff: http://git.reviewboard.kde.org/r/107358/diff/ Testing --- In my tests, there are more than 5 thousands requests for a favicon answered by the local cache vs. less than new 50 favicons inserted. Thanks, Jaime Torres Amate

Review Request: favicon local cache

Diffs - kdecore/services/kmimetype.cpp 955bf62 Diff: http://git.reviewboard.kde.org/r/107358/diff/ Testing --- In my tests, there are more than 5 thousands requests for a favicon answered by the local cache vs. less than new 50 favicons inserted. Thanks, Jaime Torres Amate

Re: Review Request: parenthesis and not null checking

) ^ b (what gcc produces) vs. !(a ^ b) (what the author wanted?) - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107213/#review21785 ----------

Re: Review Request: remove an assert

o calling rootDir, not only setRootDir. > > > Diffs > - > > kdecore/io/karchive.cpp 43539e3 > > Diff: http://git.reviewboard.kde.org/r/107211/diff/ > > > Testing > --- > > avoid an unnecesary debug crash. > > > Thanks, > > Jaime Torres Amate > >

Review Request: parenthesis and not null checking

khtml/rendering/render_object.cpp f37627c solid/solid/backends/wmi/wmiopticaldisc.cpp c6e390f Diff: http://git.reviewboard.kde.org/r/107213/diff/ Testing --- I've been using this code several weeks. Thanks, Jaime Torres Amate

Review Request: remove an assert

crash. Thanks, Jaime Torres Amate

Re: Review Request: missing initializations in plasma

/declarativewidget.cpp 93d0438 Diff: http://git.reviewboard.kde.org/r/106781/diff/ Testing --- Thanks, Jaime Torres Amate

Re: Review Request: miscelaneous things for kdelibs/plasma

Thanks, Jaime Torres Amate

Review Request: miscelaneous things

rivate/applethandle.cpp f6d51a2 Diff: http://git.reviewboard.kde.org/r/106782/diff/ Testing --- This has helped me to know more about bug 297684 (that I still suffer :-( ) Thanks, Jaime Torres Amate

Review Request: missing initializations in plasma

://git.reviewboard.kde.org/r/106781/diff/ Testing --- Thanks, Jaime Torres Amate

Re: Review Request: proper fix for my inexcusable commit without review

364/#review15666 >--- > >Ship it! > > >Ship It! > >- David Faure > > >On June 29, 2012, 4:22 p.m., Jaime Torres Amate wrote: >> >> ---

Re: Review Request: proper fix for my inexcusable commit without review

it this afternoon. Thanks, Jaime Torres Amate

Review Request: one assigment and one duplicated test

/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: Fix KCategorizedView race

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8815 --- It works for me. You have my ship it. - Jaime Torres Amate

Re: Review Request: fix infinite recurssion in kcategorizedview

lector.cpp) and as a bonus kpluginselector resizes faster > > (resize/geometryUpdate came in pairs here before, not tested with the patch > > but it feels faster ;-) > > > > Can please anyone attempt to confirm or deny the approach? If your patch includes your

Re: Review Request: fix infinite recurssion in kcategorizedview

Diff: http://git.reviewboard.kde.org/r/103313/diff/diff Testing --- Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug). Please, test with other programs. Thanks, Jaime Torres Amate

Review Request: three trivial fixes and one not so trivial

plasma/popupapplet.cpp c363503 plasma/private/associatedapplicationmanager.cpp cf8bbe5 plasma/private/style.cpp e3449f5 Diff: http://git.reviewboard.kde.org/r/103323/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: fix infinite recurssion in kcategorizedview

with break; to exit from them to do binary search. You are free to create a patch for them. - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8683 -----

Review Request: fix infinite recurssion in kcategorizedview

(neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug). Please, test with other programs. Thanks, Jaime Torres Amate

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

e causing a behaviour > > change. > > Jaime Torres Amate wrote: > Could you explain more about the problems you've noticed or fill a bug > report? > Do I have some time to try to fix the problem you've found in KRunner, > instead of reverting the code to a w

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

e causing a behaviour > > change. > > Jaime Torres Amate wrote: > Could you explain more about the problems you've noticed or fill a bug > report? > Do I have some time to try to fix the problem you've found in KRunner, > instead of reverting the code to a w

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

e developer) again? - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8503 --- On Nov. 17, 2011

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

/modules/form.cpp 5e260c1 kutils/kemoticons/kemoticonstheme.cpp c145741 kutils/kpluginselector.cpp 0a39fcc Diff: http://git.reviewboard.kde.org/r/103165/diff/diff Testing --- Still compiles with g++ Thanks, Jaime Torres Amate

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

eview8262 --- On Nov. 17, 2011, 11:41 a.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

Testing --- Still compiles with g++ Thanks, Jaime Torres Amate

Review Request: limit the amount of columns & rows of any layer

also unable to open that file. This addresses bug 234030. http://bugs.kde.org/show_bug.cgi?id=234030 Diffs - kimgio/xcf.cpp 2a03d03 Diff: http://git.reviewboard.kde.org/r/102800/diff/diff Testing --- not oom killer in action. Thanks, Jaime Torres Amate

Re: Review Request: Avoid possible null pointer dereferences in khtml

ff: http://git.reviewboard.kde.org/r/102794/diff/diff Testing --- no regressions in kdelibs tests. Thanks, Jaime Torres Amate

Review Request: Avoid possible null pointer dereferences in khtml

iff/diff Testing --- no regressions in kdelibs tests. Thanks, Jaime Torres Amate

Review Request: fix sycoca off by one

kde session (linking all the .so and programs again). None of the kde programs crashes, nor any protocol is missing. No valgrind errors (except fontconfig). Thanks, Jaime Torres Amate

Re: Review Request: little faster sycoca

faster than light, but it is only a four lines patch. Diffs (updated) - kdecore/sycoca/ksycocadict.cpp 17ed9ac Diff: http://git.reviewboard.kde.org/r/102723/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: little faster sycoca

wboard.kde.org/r/102723/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: little faster sycoca

//git.reviewboard.kde.org/r/102723/#review6881 ------- On Sept. 27, 2011, 8:42 p.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To

Review Request: little faster sycoca

/102723/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: new kded daemon to check .thumbnail directory space usage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/ --- (Updated Sept. 21, 2011, 7:37 p.m.) Review request for kdelibs. Changes

Review Request: show a warning message when there are more sessions to close

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102588/ --- Review request for kdelibs. Summary --- This is not a proper fix for

Re: Review Request: new kded daemon to check .thumbnail directory space usage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/ --- (Updated Sept. 2, 2011, 3:35 p.m.) Review request for kdelibs. Changes -

Re: Review Request: Do not crash because a badly servicetype_profilerc is found

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101914/ --- (Updated Aug. 20, 2011, 4:51 p.m.) Review request for kdelibs. Summary (

Re: Review Request: new kded daemon to check .thumbnail directory space usage

l:// kioslave, next version. (You could talk about the specs in Berlin... I can not go this year also, but I've been closer). - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/#review5389

Re: Review Request: faster kmd5

tomatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102165/#review5284 ------- On July 31, 2011, 5:28 p.m., Jaime Torres Amate wrote: > > --- > This i

Review Request: faster kmd5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102165/ --- Review request for kdelibs. Summary --- I think the private methods c

Review Request: new kded daemon to check .thumbnail directory space usage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/ --- Review request for kdelibs. Summary --- This is not yet complete, it

Review Request: Do not crash because a badly servicetype_profilerc is found

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101914/ --- Review request for kdelibs. Summary --- Should I commit to origin? ac

Re: Review Request: a very little fix

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101433/#review3485 --- kdecore/config/kconfigdata.h