Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
p 8ab5a1d Diff: http://git.reviewboard.kde.org/r/106902/diff/ Testing --- Builds fine. Thanks, Ignat Semenov

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20456 ----------- On Oct. 16, 2012, 4:15 p.m., Ignat Semenov wrote: > > --- > This

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
g/r/106902/#comment16158> I was actually thinking about url.isEmpty(), but probably got confused by your solution :) - Ignat Semenov On Oct. 16, 2012, 4:15 p.m., Ignat Semenov wrote: > > --- > This is an automatically gener

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
726 Diffs (updated) - kio/kio/kfileitem.cpp 8ab5a1d Diff: http://git.reviewboard.kde.org/r/106902/diff/ Testing --- Builds fine. Thanks, Ignat Semenov

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
726 Diffs (updated) - kio/kio/kfileitem.cpp 8ab5a1d Diff: http://git.reviewboard.kde.org/r/106902/diff/ Testing --- Builds fine. Thanks, Ignat Semenov

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
ug.cgi?id=299726 Diffs (updated) - kio/kio/kfileitem.cpp 8ab5a1d Diff: http://git.reviewboard.kde.org/r/106902/diff/ Testing --- Builds fine. Thanks, Ignat Semenov

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
p 8ab5a1d Diff: http://git.reviewboard.kde.org/r/106902/diff/ Testing --- Builds fine. Thanks, Ignat Semenov

Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
7; objects that are default-constructed and then returned in the case of d == 0 can be checked for validity, looked it up in the code. Diffs - kio/kio/kfileitem.cpp 8ab5a1d Diff: http://git.reviewboard.kde.org/r/106902/diff/ Testing --- Builds fine. Thanks, Ignat Semenov

Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2011-12-26 Thread Ignat Semenov
button. - Ignat Semenov On Dec. 24, 2011, 5:35 p.m., Nikita Churaev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: KDE Frameworks Documentation

2011-09-29 Thread Ignat Semenov
whatever is used instead of it. I think there was something else, that was a year ago :) I probably got lost in the stack, there were too many layers. Next, how can I debug asynchronous calls, like those in the Job API? Regards, Ignat Semenov P.S. Could you please add me to the whitelist? I woul

KDE Frameworks Documentation

2011-09-28 Thread Ignat Semenov
ron and other KDE code devs aka gods, please, treat this proposal constructively. I might even go as far as creating a blog and posting this to raise public awareness of the issue. Best regards, Ignat Semenov aka thorGT