Re: Information regarding upcoming Gitlab Migration

2020-04-28 Thread Ian Wadham
wanted. My 2 cents, Ian Wadham. > On 28 Apr 2020, at 2:46 pm, Bhushan Shah wrote: > > Hi Olivier, > > On Mon, Apr 27, 2020 at 10:49:46PM +0200, Olivier Churlaud wrote: >>> Because in order to search for something, you need to know it exists. >>> >>> I

Re: Input from OS X developers wanted

2015-09-13 Thread Ian Wadham
Hi Kevin, Luca and Alex, On 14/09/2015, at 1:56 AM, Kevin Funk wrote: > On Sunday, September 13, 2015 12:28:30 PM Ian Wadham wrote: >> For most of last year and some of this year, a few of us tried hard to make >> KDE 4 apps run better on OS X, but we were crying out fo

Re: building kio on Mac

2015-06-08 Thread Ian Wadham
On 08/06/2015, at 5:13 PM, David Faure wrote: > On Monday 08 June 2015 15:22:20 Ben Cooksley wrote: >> The maintainer(s) of >> the QStandardPaths class never reviewed our patch > > That would be me, and since I don't know how things should work on OSX, a) https://developer.apple.com/library/mac/d

Re: Moving KDots to KDE Review

2015-04-09 Thread Ian Wadham
Hi Minh, On 06/04/2015, at 11:30 PM, Minh Ngo wrote: > Here is the patch. Checked with clang 3.5.0, qt 4.8.6, KDE Development > Platform 4.14.6 Thanks very much for the patch, Minh. I tried it, but unfortunately the same errors persisted. > In file included from /kdedev/kde4m/kdesrc/kde/kdegam

Re: Moving KDots to KDE Review

2015-04-06 Thread Ian Wadham
Hi MInh, On 06/04/2015, at 12:37 AM, Minh Ngo wrote: > > Thanks, but it should not be. You seem to have skipped > > https://techbase.kde.org/Policies/Application_Lifecycle#Stage_1:_The_start > > … :-) > > i.e. I do not think anybody in the KDE Games group has seen your code or, > > more > > im

Re: Moving KDots to KDE Review

2015-04-05 Thread Ian Wadham
Hello Minh, This should go to the KDE Games list, not kde-core-devel. Please reply on kde-games-devel _only_, where I am also a member. On 04/04/2015, at 4:12 AM, Minh Ngo wrote: > Hi folks, > > I would like to move my project [1] to KDE Reviews and receive some feedback > to make it become a

Re: [KDE/Mac] Multiplatform frameworks

2015-03-02 Thread Ian Wadham
Hi Jeremy, On 02/03/2015, at 11:42 PM, Jeremy Whiting wrote: > I read that KDEInstallDirs documentation [2], and it seems it's a bit outdated Well, it is part of the official documentation for ECM, in api.kde.org, so it *ought* to be up-to-date, but there is no date or version number AFAICS. What

Re: [KDE/Mac] Multiplatform frameworks

2015-03-01 Thread Ian Wadham
Hi René, On 01/03/2015, at 8:17 PM, René J.V. Bertin wrote: > On Sunday March 01 2015 17:37:35 Ian Wadham wrote: >> Let me kick off by saying that I am not necessarily in favour of "doing what >> the Romans do"… ;-) > > Heh, I got that! :) Yeah, but I am keeping

Re: [KDE/Mac] Multiplatform frameworks

2015-03-01 Thread Ian Wadham
low. > > On Sat, Feb 28, 2015 at 7:56 PM, Ian Wadham wrote: > > Note that the code could have said '(QStandardPaths::DataLocation, > > "arenas", '. So no > > way for a "kf5" suffix to get in there. Maybe it comes from $XDG_DATA_DIRS >

Re: [KDE/Mac] Multiplatform frameworks

2015-02-28 Thread Ian Wadham
Apple citizen… On 28/02/2015, at 8:15 PM, René J.V. Bertin wrote: > On Saturday February 28 2015 18:12:40 Ian Wadham wrote: >> One problem is that these are NOT exactly like "~/.local/share", >> "/usr/local/share", >> "~/.local/share/" and "/us

Re: [KDE/Mac] Multiplatform frameworks

2015-02-28 Thread Ian Wadham
Hello Ralf, On 28/02/2015, at 7:32 PM, Ralf Habacker wrote: > Am 28.02.2015 um 08:12 schrieb Ian Wadham: >> But I do not know how or when this could be done. Clearly, we cannot >> hard-wire that into >> the QSP code, because there are other apps that use Qt but do not

Re: [KDE/Mac] Multiplatform frameworks

2015-02-28 Thread Ian Wadham
Hi Jeremy, On 28/02/2015, at 11:20 PM, Jeremy Whiting wrote: > On Sat, Feb 28, 2015 at 4:51 AM, René J.V. wrote: > On Saturday February 28 2015 22:00:07 Ian Wadham wrote: > > > We could change GenericDataDir in QStandardPaths to be: > > > > > > "~/Libra

Re: [KDE/Mac] Multiplatform frameworks

2015-02-28 Thread Ian Wadham
Hi René, On 28/02/2015, at 8:15 PM, René J.V. Bertin wrote: > On Saturday February 28 2015 18:12:40 Ian Wadham wrote: > >> One problem is that these are NOT exactly like "~/.local/share", >> "/usr/local/share", >> "~/.local/share/" and &quo

Re: [KDE/Mac] Multiplatform frameworks

2015-02-27 Thread Ian Wadham
Hi Jeremy, On 27/02/2015, at 2:03 PM, Jeremy Whiting wrote: > Yeah, obviously to share with all users installing data files into > /Library/Application Support/ is better, I just didn't do that in my test > since my user doesn't own that folder and I didn't want to install with sudo > for a tes

Re: [Infrastructure] Identity account security

2015-02-22 Thread Ian Wadham
Hi Ben, On 23/02/2015, at 9:13 AM, Ben Cooksley wrote: > Due to a series of unfortunate incidents it has become all to clear > that unknown parties appear to be getting hold of people's Identity > credentials. These are subsequently used by spammers to relay spam > messages through postbox.kde.org

Re: Holes in KDE (fork of "Changes in Git Infra" thread)

2015-01-10 Thread Ian Wadham
On 10/01/2015, at 8:49 PM, Luca Beltrame wrote: > For reference, I'm one of the KDE Community Forum adminstrators (aka the > "green guys"). > In reply to what Ian Wadham wrote: >> So what CAN I do? This needs major re-phrasing --- hopefully as positives >&

Re: Holes in KDE (fork of "Changes in Git Infra" thread)

2015-01-09 Thread Ian Wadham
Hello Valorie, On 10/01/2015, at 1:56 PM, Valorie Zimmerman wrote: > Comment often heard: we've lost $person / we're missing people to > maintain/lead/do $project. This is understandable, and to be expected > in a large, mature project such as KDE. > > However, in #kde and #kde-devel IRC channels

Re: Plasma 5.2 bits for kdereview

2015-01-09 Thread Ian Wadham
Hello Vishesh, On Thu, Jan 8, 2015 at 11:54 AM, Kåre Särs wrote: >> Is there something stopping Baloo from becoming a "thin" wrapper around the >> native solutions when used on those platforms? (Except man power ;) On 10/01/2015, at 7:01 AM, Vishesh Handa wrote: > On Fri, Jan 9, 2015 at 5:12 PM,

Re: Plasma 5.2 bits for kdereview

2015-01-09 Thread Ian Wadham
Hello Vishesh, On 10/01/2015, at 3:18 AM, Vishesh Handa wrote: > On Thu, Jan 8, 2015 at 11:52 AM, Ian Wadham wrote: > On 08/01/2015, at 9:40 PM, Vishesh Handa wrote: > > On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham wrote: > >>> - I don't think Windows has anything li

Re: Review Request 121930: [OS X] improvements to KSharedData

2015-01-08 Thread Ian Wadham
> On Jan. 8, 2015, 6:12 p.m., Milian Wolff wrote: > > personally, I also think that if you tested and it works, and Allan has no > > objections, that you can go ahead and push this. but please don't comment > > out code, just remove it. > > René J.V. Bertin wrote: > OK, will do. > >

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Ian Wadham
On 08/01/2015, at 9:40 PM, Vishesh Handa wrote: > On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham wrote: > - I don't think Windows has anything like Baloo or KWallet, but Apple > OS X certainly has, and has had for years. We, on the KDE-Mac list, > are starting to inte

Re: Plasma 5.2 bits for kdereview

2015-01-07 Thread Ian Wadham
Hi guys, This discussion is about technology unfamiliar to me, so please excuse me if I top-post and speak off topic. All I want to say is please be aware of other platforms in your discussions. I refer to Windows, Apple OS X and Linux/Unix desktops other than Plasma. Those desktops may not be a

Re: Changes to our Git infrastructure

2015-01-06 Thread Ian Wadham
Hello Jan, On 06/01/2015, at 10:48 PM, Jan Kundrát wrote: > On Tuesday, 6 January 2015 07:40:01 CEST, Ian Wadham wrote: >> a) "I do not know anything about Dr K, but I will try and find someone who >> does." >> b) "Unfortunately there is nobody available a

Re: Changes to our Git infrastructure

2015-01-05 Thread Ian Wadham
First of all, Thomas, I forgive you (and others) for nit-picking, etc. but please don't do it again. And I thank you, Thomas, for two positive suggestions re fixing the Dr Konqi reporting failure, both before 10 October and during its resurgence, in a new guise, in November and December (see thre

Re: Changes to our Git infrastructure

2015-01-04 Thread Ian Wadham
On 05/01/2015, at 10:45 AM, Cornelius Schumacher wrote: > On Sunday 04 January 2015 13:38:09 Jeff Mitchell wrote: >> I do agree that we want the barrier to entry to be as low as possible. >> As is often the case, I think that may conflict somewhat with what some >> of the more/very experienced dev

Re: Dr Konqi still misbehaving - advice needed

2014-12-31 Thread Ian Wadham
ay season is closing, please could somebody give the change a quick test on Linux and KDE 4? See details below. My own tests on Apple OS X were inconclusive. I was unable to reproduce the problem with stale cookies. On 29/12/2014, at 5:31 PM, Ian Wadham wrote: > So could someone please do be

Re: Dr Konqi still misbehaving - advice needed

2014-12-28 Thread Ian Wadham
Hi Thomas and others, On 30/11/2014, at 10:19 AM, Thomas Lübking wrote: > On Samstag, 29. November 2014 22:13:30 CEST, Ian Wadham wrote: >> IOW, can I offer that as a workaround until we can release your fix? Or >> does BKO leave stale cookies in the jar? > > Had a stal

Re: Problems with infrastructure

2014-12-23 Thread Ian Wadham
On 23/12/2014, at 8:24 PM, Ben Cooksley wrote: > On Tue, Dec 23, 2014 at 10:19 PM, Ian Wadham wrote: >> Hello Jan, >> >> On 22/12/2014, at 12:01 AM, Jan Kundrát wrote: >>> On Friday, 19 December 2014 22:16:36 CEST, Scarlett Clark wrote: >>>> Jenkins

Re: Problems with infrastructure

2014-12-23 Thread Ian Wadham
Hello Jan, On 22/12/2014, at 12:01 AM, Jan Kundrát wrote: > On Friday, 19 December 2014 22:16:36 CEST, Scarlett Clark wrote: >> Jenkins is compatible and works with Gerrit, so I don't understand why >> another CI is being considered. > > Because when I started this effort this spring, build.kde.

Re: Dr Konqi still misbehaving - advice needed

2014-11-30 Thread Ian Wadham
On 01/12/2014, at 12:02 AM, Thomas Lübking wrote: > On Sonntag, 30. November 2014 06:26:19 CEST, Ian Wadham wrote: >> Lastly, how and when is a new KDE 4 kde-runtime patch likely to be released? > Wednesday, December 10, 2014: KDE Applications 14.12 Final Tag > I hope, thi

Re: Dr Konqi still misbehaving - advice needed

2014-11-30 Thread Ian Wadham
On 01/12/2014, at 10:56 AM, Thomas Lübking wrote: > On Montag, 1. Dezember 2014 00:45:29 CEST, Nicolás Alvarez wrote: >> 2014-11-30 20:26 GMT-03:00 Albert Astals Cid : >>> El Dilluns, 1 de desembre de 2014, a les 09:56:40, Ian Wadham va escriure: >>> ... >&g

Re: Dr Konqi still misbehaving - advice needed

2014-11-30 Thread Ian Wadham
On 01/12/2014, at 10:26 AM, Albert Astals Cid wrote: > El Dilluns, 1 de desembre de 2014, a les 09:56:40, Ian Wadham va escriure: >> On 01/12/2014, at 8:43 AM, Thomas Lübking wrote: >>> On Sonntag, 30. November 2014 15:37:22 CEST, Andrea Iacovitti wrote: >>>> If i u

Re: Dr Konqi still misbehaving - advice needed

2014-11-30 Thread Ian Wadham
On 01/12/2014, at 8:43 AM, Thomas Lübking wrote: > On Sonntag, 30. November 2014 15:37:22 CEST, Andrea Iacovitti wrote: > >> If i understand well the problem and the goal is to disable the use of >> cookies, may be it could be achieved by using kio METADATA (see doc >> file kdelibs/kio/DESIGN.me

Re: Dr Konqi still misbehaving - advice needed

2014-11-29 Thread Ian Wadham
Hi Thomas, Thank you very much for your help. On 30/11/2014, at 10:19 AM, Thomas Lübking wrote: > On Samstag, 29. November 2014 22:13:30 CEST, Ian Wadham wrote: >> IOW, can I offer that as a workaround until we can release your fix? Or >> does BKO leave stale cookies in the

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-29 Thread Ian Wadham
> On Nov. 29, 2014, 10:20 p.m., Pino Toscano wrote: > > drkonqi/backtracegenerator.cpp, line 97 > > > > > > Still hardcodes the debugger name; I'm not a drkonqui developer, so I > > cannot tell you exactly what t

Re: Dr Konqi still misbehaving - advice needed

2014-11-29 Thread Ian Wadham
Hi Thomas, On 29/11/2014, at 11:56 PM, Thomas Lübking wrote: > On Samstag, 29. November 2014 11:35:31 CEST, Ben Cooksley wrote: >> Blahblahblah ;-) > Reproducible here. Great!!! > Bugzilla version is 4.4.6, drkonqi uses token security. > I need to log into bugs.kde.org (w/ my password ;-) > And

Re: Dr Konqi still misbehaving - advice needed

2014-11-26 Thread Ian Wadham
Hi Ben, On 27/11/2014, at 8:05 AM, Ben Cooksley wrote: > On Wed, Nov 26, 2014 at 8:40 PM, Ian Wadham wrote: >> On 26/11/2014, at 12:49 PM, Ian Wadham wrote: >>> So far the log shows that my patch is definitely there, in the >>> distribution, but >>> Bugz

Re: Dr Konqi still misbehaving - advice needed

2014-11-25 Thread Ian Wadham
On 26/11/2014, at 12:49 PM, Ian Wadham wrote: > So far the log shows that my patch is definitely there, in the distribution, > but > Bugzilla still returns a 410 error, even though it has been given a token (as > required for version 4.4.6 of Bugzilla software). I have a feel

Re: Dr Konqi still misbehaving - advice needed

2014-11-25 Thread Ian Wadham
Hi Thomas, On 26/11/2014, at 10:19 AM, Thomas Lübking wrote: > On Montag, 24. November 2014 04:08:53 CEST, Ian Wadham wrote: > >> So my immediate and most urgent question is how can I get Germano to >> recover that log output from Dr Konqi? He is using Fedora 20, KDE 4.14.3.

Dr Konqi still misbehaving - advice needed

2014-11-25 Thread Ian Wadham
Hi guys, You may remember the recent fracas with Dr Konqi suddenly refusing to submit crash reports, because Bugzilla software (bugs.kde.org) had changed to a new version that no longer recognised cookies. The problem was fixed by me and the patch was released in KDE 4.14.2 and 4.14.3. It has als

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Ian Wadham
ourse > kded would need to have a reverse interface to a dictionary mapping WIds to > registered applications because of point 2 above. > > Sounds like a fun little project to get right, but somehow I doubt it > stands much chance to be accepted for KDE4. > >

Re: Review Request 120931: [OS X] improvements to KWindowSystem

2014-11-16 Thread Ian Wadham
> On Nov. 15, 2014, 2:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-28 Thread Ian Wadham
elp... :-) - Ian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review69367 --- On Oct. 9, 2014, 11:30 p.m.

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-10-17 Thread Ian Wadham
> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > >

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-10-16 Thread Ian Wadham
> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > >

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-10-10 Thread Ian Wadham
> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > >

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Ian Wadham
st the basic version-checking and feature-choosing algorithm. Tested submitting both full reports and attached reports, using both the token method and the passwords-only method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Ian Wadham
> suggest making Dr Konqi as capable as possible - although do remember that we > probably don't want to receive bug reports from extremely old versions of our > software, even if RHEL is supporting it. > > Ian Wadham wrote: > @Albert: I had to cherry-pick Revision 681446e1 f

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Ian Wadham
token-based security being discontinued in the future in Bugzilla software. - Ian Wadham On Oct. 9, 2014, 12:06 a.m., Ian Wadham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-08 Thread Ian Wadham
ed by KCookieJar not being found on Apple OS X. The third item has to go into the repository first, because the patch for this present review (which avoids using cookies) affects the same area of code. Sorry for the noise. - Ian ---------

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-08 Thread Ian Wadham
> > replacing this by "int version = KDE_MAKE_VERSION(major, minor, > > release);" and simple integer metricts for comparism should considerably > > lower complexity (thus make the patch easier to be accepted ;-) > > > > Yes, I know it's cra

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-08 Thread Ian Wadham
asswords-only method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-10-07 Thread Ian Wadham
> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > >

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-07 Thread Ian Wadham
t it? The Bugzilla version after 4.5.x might be 4.6.x or 5.0.x. Who can tell? - Ian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review68051

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-07 Thread Ian Wadham
> On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-07 Thread Ian Wadham
This was to test the basic version-checking and feature-choosing algorithm. Tested submitting both full reports and attached reports, using both the token method and the passwords-only method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Ian Wadham
and attached reports, using both the token method and the passwords-only method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Ian Wadham
> On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Ian Wadham
e and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Ian Wadham
> On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: > > As this is needed to restore the functionality of Dr Konqi, can someone > > familiar with the codebase please review it so we can get this in? > > Ian Wadham wrote: > Perhaps I am the person most familiar with

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67946 ------- On Oct. 5, 2014, 4:27 a.m., Ian Wadham wrote: > > ---

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-04 Thread Ian Wadham
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review67943 ------- On Oct. 5, 2014, 4:27 a.m., Ian Wadham wrote: > >

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-04 Thread Ian Wadham
. Tested submitting both full reports and attached reports, using both the token method and the passwords-only method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-03 Thread Ian Wadham
sted submitting both full reports and attached reports, using both the token method and the passwords-only method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-03 Thread Ian Wadham
1 > > <https://git.reviewboard.kde.org/r/120431/diff/1/?file=315733#file315733line461> > > > > This leaks authentication data to an on-disk log. Deleted. Also found another instance and fixed it. BTW, tokens are intentionally short-lived IIUC. You

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-03 Thread Ian Wadham
s-only method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-09-30 Thread Ian Wadham
method. Also tested with KWalletD supplying the username and password on Dr Konqi's login dialog. Thanks, Ian Wadham

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-09-26 Thread Ian Wadham
> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > >

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-09-26 Thread Ian Wadham
patch is also intended to be extendable, so that Dr Konqi can be updated and re-released, ahead of time, if any further feature change is announced by Bugzilla and could adversely affect Dr Konqi. - Ian Wadham On Sept. 26, 2014, 4:21 a.m., Frédéric

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

2014-09-24 Thread Ian Wadham
> On Sept. 24, 2014, 5:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-23 Thread Ian Wadham
> On Sept. 18, 2014, 10:28 p.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-23 Thread Ian Wadham
eral of the MacPorts developers, as well as the unfailing enthusiasm and encouragement of my friend Marko Käning. Thanks, Ian Wadham

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-23 Thread Ian Wadham
f Dr K ASSERT problem https://git.reviewboard.kde.org/media/uploaded/files/2014/07/30/a3f99f00-94df-4b10-bc47-66b1c966f893__DrKonqiASSERT.kcrash.txt Thanks, Ian Wadham

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-21 Thread Ian Wadham
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/#review66935 --- On Sept. 18, 2014, 10:57 a.m., Ian Wadham wrote: > > --

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-20 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/#review67098 --- Ship it! Ship It! - Ian Wadham On Sept. 18, 2014, 10:57

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-20 Thread Ian Wadham
ope. It can be set if the user has XQuartz installed and running, but > that shouldn't make a difference. > > In fact, $DISPLAY shouldn't be used on OS X because we wouldn't want > things like socket names change when the user starts or quits XQuartz with > K

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-20 Thread Ian Wadham
ope. It can be set if the user has XQuartz installed and running, but > that shouldn't make a difference. > > In fact, $DISPLAY shouldn't be used on OS X because we wouldn't want > things like socket names change when the user starts or quits XQuartz with > K

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-19 Thread Ian Wadham
e've to consider that drkonqi does not (require) to run > > suid, the test should be omitted if "geteuid()" (notice the "e"!) isn't 0. > > > > Skipping this altogether only makes sense for broken by design > > operating systems which fail

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-18 Thread Ian Wadham
e've to consider that drkonqi does not (require) to run > > suid, the test should be omitted if "geteuid()" (notice the "e"!) isn't 0. > > > > Skipping this altogether only makes sense for broken by design > > operating systems which fail

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-18 Thread Ian Wadham
e've to consider that drkonqi does not (require) to run > > suid, the test should be omitted if "geteuid()" (notice the "e"!) isn't 0. > > > > Skipping this altogether only makes sense for broken by design > > operating systems which fail

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2014-09-18 Thread Ian Wadham
the text actually changed before updating the role. > > René J.V. Bertin wrote: > The NULL alternative would be to modify the default KAction ctor to do > `setMenuRole(NoRole)`, which is the effective default on other platforms > (where `TextHeuristicRole` is unused). >

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-18 Thread Ian Wadham
onqiASSERT.kcrash.txt Thanks, Ian Wadham

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-18 Thread Ian Wadham
sit: https://git.reviewboard.kde.org/r/119498/#review66817 --- On Sept. 16, 2014, 11:08 a.m., Ian Wadham wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-17 Thread Ian Wadham
lla software version. All of this work will have benefits in Frameworks/KF5 as well as KDE 4. - Ian Wadham On Sept. 16, 2014, 11:08 a.m., Ian Wadham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2014-09-17 Thread Ian Wadham
> On Sept. 15, 2014, 12:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 149 > > > > > > what if > > KAction *foo = new KAction(this); > > foo->setText("Foo"); > > > > -> you ra

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-16 Thread Ian Wadham
ope. It can be set if the user has XQuartz installed and running, but > that shouldn't make a difference. > > In fact, $DISPLAY shouldn't be used on OS X because we wouldn't want > things like socket names change when the user starts or quits XQuartz with > K

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-16 Thread Ian Wadham
his far without help from Michael Pyne, Thomas Lübking and several of the MacPorts developers, as well as the unfailing enthusiasm and encouragement of my friend Marko Käning. Thanks, Ian Wadham

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-16 Thread Ian Wadham
my friend Marko Käning. File Attachments Log of Dr K ASSERT problem https://git.reviewboard.kde.org/media/uploaded/files/2014/07/30/a3f99f00-94df-4b10-bc47-66b1c966f893__DrKonqiASSERT.kcrash.txt Thanks, Ian Wadham

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-16 Thread Ian Wadham
can go unconditionally. > > > > Show really only shows the window. > > Becoming active and then raise for that is WM detail - and WMs have to > > deal with inadequate raise requests anyway ;-) > > Ian Wadham wrote: > I do not understand your co

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-16 Thread Ian Wadham
g/media/uploaded/files/2014/07/30/a3f99f00-94df-4b10-bc47-66b1c966f893__DrKonqiASSERT.kcrash.txt Thanks, Ian Wadham

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-15 Thread Ian Wadham
- On Sept. 15, 2014, 1:59 a.m., Ian Wadham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119497/ > --

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-14 Thread Ian Wadham
lp from Michael Pyne, Thomas Lübking and several of the MacPorts developers, as well as the unfailing enthusiasm and encouragement of my friend Marko Käning. Thanks, Ian Wadham

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-09-14 Thread Ian Wadham
> On July 28, 2014, 12:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > <https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line119> > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got &g

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-09-14 Thread Ian Wadham
ope. It can be set if the user has XQuartz installed and running, but > that shouldn't make a difference. > > In fact, $DISPLAY shouldn't be used on OS X because we wouldn't want > things like socket names change when the user starts or quits XQuartz with > K

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-09-14 Thread Ian Wadham
pers, as well as the unfailing enthusiasm and encouragement of my friend Marko Käning. Thanks, Ian Wadham

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-09-14 Thread Ian Wadham
rted directly from the crashing proc instead of via kdeinit. > > The check should probably remain on any POSIX-alike, in my opinion, as we > wouldn't want Dr. Konqi on Mac OS X accidentally having access to a crashing > application FDs if launched directly either. >

Re: Location of Dr Konqi in Frameworks/KF 5

2014-09-11 Thread Ian Wadham
Hi Alex, On 09/09/2014, at 7:48 PM, Aleix Pol wrote: > On Fri, Sep 5, 2014 at 8:36 AM, Ian Wadham wrote: > > I have heard that Dr Konqi source code for Frameworks/KF 5 > has been placed in plasma-workspace. > > Please could you consider keeping it in some location that

Location of Dr Konqi in Frameworks/KF 5

2014-09-08 Thread Ian Wadham
Hi guys, I have heard that Dr Konqi source code for Frameworks/KF 5 has been placed in plasma-workspace. Please could you consider keeping it in some location that is common to all platforms? This includes both Linux platforms and non-Linux platforms, such as Windows and Apple OS X, where Plasma

Working on Dr Konqi

2014-09-08 Thread Ian Wadham
Hi guys, This is to let you know that I am working on Dr Konqi on KDE 4.14, mainly to get it to work properly on the Apple OS X platform and allow crash reports to be submitted from there. But also, I am going to have a go at updating it to use tokens on Bugzilla 4.4.5 instead of cookies. I wou

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-04 Thread Ian Wadham
e test is pointless altogether (i do not know. no idea. no record > > on drkonqui) just remove it with the comment in the commit message, but > > ifdeffing a void statement makes us look silly ;-) > > Ian Wadham wrote: > The comments on lines 295-298 explain why I have comme

  1   2   >