Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/#review62595 --- Ship it! Ship It! - Hui Ni On 七月 12, 2014, 1:12 p.m

Re: Review Request: Remove image/x-wmf and image/x-xfig from image thumbnailer's supported mimetypes

> On July 11, 2012, 12:36 p.m., David Faure wrote: > > KMimeTypeTrader::query honours the sorting, so InitialPreference=10 should > > have been enough in your thumbnailer. > > > > preferredService() basically calls first() ;) > > > > Patch is OK however. > > Friedrich W. H. Kossebau wrote: >

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

tor into khtml. khtml is the only heavy user of it I have known. If we want to keep api, I am fine with moving to kde4support. - Hui --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/#revi

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

721c kdeui/actions/kcodecaction.cpp 97a8a90 kdeui/actions/kcodecaction.h 627d770 Diff: http://git.reviewboard.kde.org/r/105392/diff/ Testing --- Thanks, Hui Ni

Review Request: remove KEncodingDetector from tier1/kcodecs

ngdetector.h e6a0444 tier1/kcodecs/src/kencodingdetector.cpp 1d64bdd tier1/kcodecs/src/kencodingprober.h da4b958 tier1/kcodecs/src/kencodingprober.cpp 42beac0 tier1/kcoreaddons/src/text/kstringhandler.h b9b6c2e Diff: http://git.reviewboard.kde.org/r/105392/diff/ Testing --- Thanks, Hui Ni

Re: Review Request: show video previews according to file content instead of mimetype string

olphin/src/panels/information/phononwidget.cpp 5f0c111 Diff: http://git.reviewboard.kde.org/r/104988/diff/ Testing --- with no more regressions. Thanks, Hui Ni