for it
File Attachments
screenshot of the new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
- Gregor Mi
On Aug. 3, 2017, 1:25 nachm., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
menu item for it
File Attachments
screenshot of the new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
re is no menu item for it
File Attachments
screenshot of the new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
s
(C++14 might solve the issue)
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128854/#review103512
-------
On
s://git.reviewboard.kde.org/r/128854/#review103512
-------
On July 28, 2017, 12:20 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail.
automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128854/#review98994
-------
On July 28, 2017, 12:20 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generat
new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
files/2016/01/24/71ebdcea-a793-460a-adb5-f05a7706f8b0__screenshot_20160124_115024-with-tools.png
Thanks,
Gregor Mi
/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
files/2016/01/24/71ebdcea-a793-460a-adb5-f05a7706f8b0__screenshot_20160124_115024-with-tools.png
Thanks,
Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
read that tooltips are to be avoided where possible => this
patch factors some information out of a tooltip which in itself is desirable.
4. For the user, the discoverability of the feature after applying this patch
is better than before (though not perfect, sure).
- Gregor Mi
On Apr
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
t;End Process..." is the original
design. According to your explanation this was wrong in the first place. What
about removing the ellipses in both menu items so we will end up with "End
Process" and "Kill a specific window"?
- Gregor
-------
media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
new submenu
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/eeaecc88-20bc-46d6-9c65-50ba4a7c182a__submenu.png
Thanks,
Gregor Mi
>> skanlite - all - wants a framework KF5Sane (does this exist?)
>
>
>
> Gregor Mi ported both libksane and Skanlite to KF5 last year. They are both
> in the
> frameworks branch. libksane is not yet a framework, but I think he prepared
> libksane for it.
>
>
2a__submenu.png
new message box
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/5565e806-bf16-4ef2-89f2-ac122bf3421c__messagebox.png
Thanks,
Gregor Mi
> On April 17, 2015, 7:31 a.m., Martin Gräßlin wrote:
> > I'm still not sure about the text for the message box: could you please add
> > Thomas Pfeiffer from Usability team to the review to get him comment on it?
>
> Gregor Mi wrote:
> Sure. I'll add him.
name is
> > exported to the root window.
> >
> > Users might not know what "KWin" is.
>
> Gregor Mi wrote:
> I also would like that better. I tried
> - QApplication::desktop()->window()->windowTitle();
> - QApplication::de
dowTitle();
Any other hint on how access this information?
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79059
---------
27;ll add him.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79097
---
On April 17, 2015, 7
viewboard.kde.org/r/122249/#review79059
---
On April 17, 2015, 7:25 a.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
0ba4a7c182a__submenu.png
new message box
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/5565e806-bf16-4ef2-89f2-ac122bf3421c__messagebox.png
Thanks,
Gregor Mi
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
tps://git.reviewboard.kde.org/r/122249/#comment53290>
requires https://git.reviewboard.kde.org/r/122981/ to be submitted
- Gregor Mi
On March 13, 2015, 10:08 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail.
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
.kde.org/media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
do with the
> > KGlobalAccel API:
> > * create a KActionCollection for component "kwin"
> > * add a QAction with the shortcut name you want
> > * ask KGlobalAccel to load the shortcut for it.
>
> Gregor Mi wrote:
> Thanks for the hint
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review76861
---
On Feb. 27, 2015, 1:18 a.m., Gregor Mi wrote:
>
> ---
> This i
02-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
che5/ksycoca5"
ksysguard(3891)/default KNotificationManager::notify: Calling notify on "Sound"
Segmentation fault
I also wonder why I don't get a stack trace on console even though I build in
debug configuration. Any hint?
-
0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
demand for invoking such action (taskbar,
> dedicated plasmoid, ...) one could move the xkill functionality into
> KWindowSystem (option for portage) - invoking a kwin shortcut through a
> kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
> solution, but ea
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review76389
---
On Feb. 20, 2015, 11:35 p.m., Gregor Mi wrote:
>
> -
'' to
> > 'const QString&'
> > [ 451s]
> > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:
> > In function 'QUrl TaskManager::getServiceLauncherUrl(int, const QString&,
> > const QStringList&
QStringList&)':
> > [ 451s]
> > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:516:43:
> > error: 'proc->KSysGuard::Process::command' does not have class type
> > [ 451s] QString cmdline = pr
wboard.kde.org/media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831/#review76201
---
On Feb. 15, 2015, 4:35 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated
demand for invoking such action (taskbar,
> dedicated plasmoid, ...) one could move the xkill functionality into
> KWindowSystem (option for portage) - invoking a kwin shortcut through a
> kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
> solution, but ea
/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
> Before, we just wrote into the varialbes.
> >
> > Now, we use the setters, which also sets 'changes |= Process::Gids;'
> >
> > Is that maybe an issue? I myself don't know the code well enough to see
> > this here.
>
>
> On 01/31/2015 08:57 PM, Alexander Neundorf wrote:
>> hmm, looking back at our switch to git, I don't consider our standards for
>> documentation of the developer workflow as very high unfortunately. :-/
>
> Considering I wrote the majority of
> https://community.kde.org/Sysadmin/GitKdeOrgManual
> Before, we just wrote into the varialbes.
> >
> > Now, we use the setters, which also sets 'changes |= Process::Gids;'
> >
> > Is that maybe an issue? I myself don't know the code well enough to see
> > this here.
>
>
t; >
> > Not sure it's worth it, would be cool to have input from true KSysGuard
> > developers here.
>
> Gregor Mi wrote:
> In the current RR state there are some reference-getters left because it
> made the porting easier. Should they be converted t
demand for invoking such action (taskbar,
> dedicated plasmoid, ...) one could move the xkill functionality into
> KWindowSystem (option for portage) - invoking a kwin shortcut through a
> kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
> solution, but ea
files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
demand for invoking such action (taskbar,
> dedicated plasmoid, ...) one could move the xkill functionality into
> KWindowSystem (option for portage) - invoking a kwin shortcut through a
> kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
> solution, but ea
demand for invoking such action (taskbar,
> dedicated plasmoid, ...) one could move the xkill functionality into
> KWindowSystem (option for portage) - invoking a kwin shortcut through a
> kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
> solution, but ea
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831/#review74463
---
On Jan. 25, 2015, 10:27 p.m., Gregor Mi wrote:
>
> --
rent shortcut to
display it to the user?
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review74740
---
On Jan. 25
bfd9a
processcore/process.cpp a38b8be71da1a51cb87f636664ebac817b1d20ab
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
s.cpp 580df8db152040f1ad075430fdce08fe7ad4ae2d
.reviewboardrc PRE-CREATION
CMakeLists.txt cefc86f12be684e195bd148641483e9e1734e636
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
8a9b8
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
processui/scripting.cpp 76291b0ae0a26e486aa81a4ca3976ff4a47cb3c0
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
cessChanged is emitted.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831/#review74463
---
On Jan. 25, 2015, 12:01 p.m
> On Jan. 25, 2015, 5:28 p.m., Alex Richardson wrote:
> > processui/scripting.h, line 74
> > <https://git.reviewboard.kde.org/r/121831/diff/5/?file=344700#file344700line74>
> >
> > Isn't just changing the PROPERTY macro enough?
> > Or is it u
future
gregormi: see https://git.reviewboard.kde.org/r/122215/
?
- Gregor Mi
On Jan. 25, 2015, 6:21 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
35ffa81e48291420
tests/CMakeLists.txt 967b03fae1e460bfb22e1a07ef05cf7b49412546
tests/keyboardshortcututiltest.h PRE-CREATION
tests/keyboardshortcututiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
Thanks,
Gregor Mi
it.reviewboard.kde.org/r/121831/#review74713
-------
On Jan. 25, 2015, 12:01 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To rep
35ffa81e48291420
tests/CMakeLists.txt 967b03fae1e460bfb22e1a07ef05cf7b49412546
tests/keyboardshortcututiltest.h PRE-CREATION
tests/keyboardshortcututiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
Thanks,
Gregor Mi
35ffa81e48291420
tests/CMakeLists.txt 967b03fae1e460bfb22e1a07ef05cf7b49412546
tests/keyboardshortcututiltest.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
Thanks,
Gregor Mi
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
Thanks,
Gregor Mi
cceed.
Thanks,
Gregor Mi
s.cpp a38b8be71da1a51cb87f636664ebac817b1d20ab
processcore/processes.h d09c3265333fe7e2702deaa910c5fbe4bc3ac9e6
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
processui/ksysguardprocesslist.cpp 4dc142e864d8353ceafc3a6735ffa81e48291420
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
processui/ksysguardprocesslist.cpp 4dc142e864d8353ceafc3a6735ffa81e48291420
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
iewboard.kde.org/r/121831/#review74353
---
On Jan. 19, 2015, 6:17 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
6817f2493d40dc5ade0347
processui/ProcessModel.cpp 53bc041110c9cdb686fef783895104969b661889
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
0f6e9c5f349a3d70b0de9
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
/122072/ about
redesigning it with d_ptr to make process.h future-proof
- Gregor Mi
On Jan. 12, 2015, 2:30 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboa
g/r/121831/#comment51460>
Requires SOVERSION bump.
And: wouldn't it be better to move the now private variables behind a d_ptr?
- Gregor Mi
On Jan. 12, 2015, 2:30 p.m., Gregor Mi wrote:
>
> ---
> This is an autom
1 - 100 of 113 matches
Mail list logo
