Re: Haruna in kdereview

2021-08-09 Thread George Florea Banus
On 09.08.2021 22:22, Albert Astals Cid wrote: El dilluns, 9 d’agost de 2021, a les 16:23:27 (CEST), George Florea Banus va escriure: Or where to go from here. Which are your doubts? I'd like to get the review done so I can make a new release. Also, after review, how do I version th

Re: Haruna in kdereview

2021-08-09 Thread George Florea Banus
On 21.07.2021 19:38, Jonah Brüchert wrote: In AudioTube I've been using this FindYoutubeDl module. Maybe you can make use of it too. And if someone on the list finds a problem with it, let me know so I can also fix it in AudioTube. Sorry for ignoring. I already made a FindYouTubeDl module

Re: Haruna in kdereview

2021-08-09 Thread George Florea Banus
I have addressed everything that was brought to my attention. Let me know if there's more. Or where to go from here. On 19.07.2021 15:54, George Florea Banus wrote: Hello I would like to move Haruna to KDEReview. Haruna is a media player based on mpv, focus is on video playback.

Re: Haruna in kdereview

2021-07-25 Thread George Florea Banus
On 21.07.2021 18:42, Harald Sitter wrote: On Wed, Jul 21, 2021 at 4:38 PM George Florea Banus wrote: On 21.07.2021 13:53, Harald Sitter wrote: - the color-schemes dir seems to do nothing. it installs files that don't actually exist in the source. fix it or rm -rf? It had the Breeze

Re: Haruna in kdereview

2021-07-21 Thread George Florea Banus
On 21.07.2021 13:53, Harald Sitter wrote: It's an amazing app! Really awesome. Thank you. - you might want to consider using a newer version in your find_package call for ECM. ECM does enable more modern/useful features but only when used with a suitably high version. so, I'd put this at the

Re: Haruna in kdereview

2021-07-19 Thread George Florea Banus
Formatting of my first reply looks terrible in the web mailing list. Hopefully this one is better. Sorry. On 20.07.2021 00:39, Albert Astals Cid wrote: El dilluns, 19 de juliol de 2021, a les 14:54:26 (CEST), George Florea Banus va escriure: You need a KLocalizedString::setApplicationDomain

Re: Haruna in kdereview

2021-07-19 Thread George Florea Banus
On 20.07.2021 00:39, Albert Astals Cid wrote: El dilluns, 19 de juliol de 2021, a les 14:54:26 (CEST), George Florea Banus va escriure: You need a KLocalizedString::setApplicationDomain("haruna") just after creating your QApplication. Otherwise translations are not going to

Haruna in kdereview

2021-07-19 Thread George Florea Banus
Hello I would like to move Haruna to KDEReview. Haruna is a media player based on mpv, focus is on video playback. https://invent.kde.org/multimedia/haruna