Re: Review Request 127866: Oxygen: Fix QCache usage

probabaly doesn't matter much, because the runtime cost of re-generating the cached values is probably much larger. FIFOCache looks like a simple solution to the problems that Coverity found with QCache (at least if the max cost is bounded) - nice! - Frank Reininghaus On May 22, 2016, 4:2

Re: Review Request 127866: Oxygen: Fix QCache usage

> On May 15, 2016, 8:51 a.m., Hugo Pereira Da Costa wrote: > > To be honest, I am quite puzzle by this whole thing. > > Now, every insertion in the cache requires at least two searches in there > > and (in many case) at least one copy constructor being called. This is > > quite expansive ... (e

Re: Review Request 125995: Only install konqpopupmenuplugin.desktop in kde-baseapps if the KF5 version is less than 5.16

marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit b919367c8550024aca53c7f4d219a5b4c3317964 by Frank Reininghaus to branch frameworks. Repository: kde-baseapps Description --- KIO installs this file since version 5.16. Even if

Review Request 125995: Only install konqpopupmenuplugin.desktop in kde-baseapps if the KF5 version is less than 5.16

sions prior to 5.16 and install the file (which is needed to make the context menu for files work properly in Dolphin, FolderView, Konqueror, etc.). Thanks, Frank Reininghaus

Re: KSyCoca, Thread safety, and Cache invalidation

Hi, 2015-06-21 16:54 GMT+02:00 David Faure: > On Friday 19 June 2015 22:00:09 Vishesh Handa wrote: >> On Sat, Jun 13, 2015 at 9:26 PM, David Faure wrote: >> > 3 bis: >> > I assume the threads without an event loop have some way to get tasks, >> > right? So when the gui thread gets notified about k

Re: Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

> On Sept. 4, 2013, 2:38 nachm., Martin Gräßlin wrote: > > KGlobalSettings moved into KDE4Support in frameworks 5. I would suggest to > > not add new API to an already deprecated class. Maybe you want to provide a > > patch for the proper way in frameworks? Marin, could you explain what the pr

Re: Review Request 122556: Bump Qt version to 5.4

> On Feb. 13, 2015, 10:39 nachm., Marko Käning wrote: > > I'd vote for keeping it compatible to Qt 5.3, if that's possible. > > Inge Wallin wrote: > +1. Depending on 5.4 in applications already is bad enough even though it > can sometimes be necessary but I am against it for our base stuff.

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: > > IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > > safer. Or do you really think "dolphin nonexistentfile" should look up > > "nonexistentfile" over DNS? > > Thomas Lübking wrote: > +1, notably since http://

Re: Changes to our Git infrastructure

Hi, 2015-01-05 19:03 GMT+01:00 Jeff Mitchell: > On 5 Jan 2015, at 12:40, Boudewijn Rempt wrote: > >> All this back-and-forth about cli tools actually sounds weird to me. I >> know that the beginners who start hacking on Krita would never use any of >> them. Git on the command line is often already

Re: Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

> On Dez. 18, 2014, 9:41 vorm., David Faure wrote: > > Ship It! Do you have a KDE git account, Alberto? If not, please let us know. We can then push the commit to kdelibs and forward-port it to KF5 for you. - Frank --- This is an autom

Re: Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

still being committed to the KDE/4.14 branch, which would be pointless otherwise). If not, the patch can at least be used for the next KF5 release, to which it should be forward-ported anyway. - Frank Reininghaus On Nov. 25, 2014, 8:15 nachm., Alberto Sánchez Molero

Re: Review Request 119892: [Dolphin] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

or in that situation, i.e., move/copy/link the dropped items in the directory that contains the text file where the items are dropped. - Frank Reininghaus On Aug. 21, 2014, 9:11 p.m., Arjun Ak wrote: > > --- > This is an automatically g

Re: Review Request 119678: add a target named _doc for each project in the tree, to generate developer documention

e to every single repository? - Frank Reininghaus On Aug. 9, 2014, 12:43 a.m., Mathieu Tarral wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

KDE applications December 2014 release

Hello everyone, after KDE SC 4.14, the next release of the KDE applications that are part of the KDE SC is planned for December. It will contain not only applications that are still based on Qt4+kdelibs 4.x, but also applications that have the first stable release of their Qt5+KF5 ports [1]. All a

Re: Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

a tool tip) could be done directly in KCapacityBar though, such that all applications which use that class benefit from them. - Frank Reininghaus On Aug. 12, 2014, 5:28 a.m., Mathieu Tarral wrote: > > --- > This is an automatical

Re: KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hi, 2014-07-22 11:11 GMT+02:00 Todd: > On Jul 22, 2014 12:30 AM, "Frank Reininghaus" wrote: >> 2014-07-21 23:34 GMT+02:00 Albert Astals Cid: >> > El Dilluns, 21 de juliol de 2014, a les 13:26:32, Frank Reininghaus va >> > escriure: [...] >> >&g

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 20, 2014, 9:56 p.m., Frank Reininghaus wrote: > > Thank you very much for working on this, Arjun, and thanks also for your > > very good suggestions, Emmanuel! > > > > I apologize for not responding earlier. I was a bit busy at work recently > > an

Re: KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hi, 2014-07-21 23:34 GMT+02:00 Albert Astals Cid: > El Dilluns, 21 de juliol de 2014, a les 13:26:32, Frank Reininghaus va > escriure: >> Hello everyone, >> >> after KDE SC 4.14, the next release of the KDE applications that are >> part of the KDE SC is planned for

KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hello everyone, after KDE SC 4.14, the next release of the KDE applications that are part of the KDE SC is planned for December. It will contain not only applications that are still based on Qt4+kdelibs 4.x, but also applications that have the first stable release of their Qt5+KF5 ports [1]. All a

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

n/src/dolphinmainwindow.cpp <https://git.reviewboard.kde.org/r/118994/#comment43499> I would prefer setEnabled(count > 0) (because it makes it clear at first sight that the argument is a bool), but that might be a matter of taste. - Frank Reininghaus On July 6, 2014, 1:58 p.m.,

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

://git.reviewboard.kde.org/r/118858/diff/ Testing --- Cannot reproduce the crashes any more. The menus in KUrlNavigator still work fine for me. Thanks, Frank Reininghaus

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On June 29, 2014, 2:50 p.m., Emmanuel Pescosta wrote: > > Thanks for the patch! > > > > I really like the idea to implement CTRL+SHIFT+T to reopen the previously > > closed tab, makes Dolphin more browser like :) > > > > But please implement this feature in master, because: > > 1. Dolphins f

Re: Bug 92237: patch submitted, but... is anyone watching?

Hi, 2014-06-22 13:04 GMT+02:00 Simon Bachmann: > May I draw your attention to bug 92237? > (https://bugs.kde.org/show_bug.cgi?id=92237) > > No, this is not a please-get-this-issue-fixed-ASAP kind of message. > It's just that I submitted a patch to that bug a few weeks ago, and I'm > afraid no one

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

and return immediately in that case. Diffs (updated) - kfile/kurlnavigator.cpp f5dfc81 kfile/kurlnavigatorbutton.cpp 6cb40b1 Diff: https://git.reviewboard.kde.org/r/118858/diff/ Testing --- Cannot reproduce the crashes any more. The menus in KUrlNavigator still work fine for me. Thanks, Frank Reininghaus

Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

menus in KUrlNavigator still work fine for me. Thanks, Frank Reininghaus

Re: Review Request 118450: Add null-pointer safety check to KonqOperations::pasteInfo(const KUrl&) (to fix a crash on Wayland)

st if it fixes the crash, but I'm pretty sure that at least a crash with the reported backtrace will not happen any more. Thanks, Frank Reininghaus

Review Request 118450: Add null-pointer safety check to KonqOperations::pasteInfo(const KUrl&) (to fix a crash on Wayland)

ace will not happen any more. Thanks, Frank Reininghaus

Re: Review Request 117044: Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

! I propose to revert this patch - maybe a better solution which prevents automounting can be found for master/frameworks, but IMHO we should not take any further risks in KDE/4.13. Any objections? - Frank Reininghaus On May 6, 2014, 8:01 p.m., To

Re: Review Request 116522: Make KAboutDialog looks better under OSX

> On March 2, 2014, 12:07 a.m., Kai Uwe Broulik wrote: > > File Attachment: after-3.png - after-3.png > > > > > > There is no way to send an E-Mail anymore? > > > > Mabye use a text link instead for all platforms and get rid of

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

de.org/r/115408/ > --- > > (Updated Feb. 8, 2014, 10:02 a.m.) > > > Review request for kdelibs and Frank Reininghaus. > > > Repository: kdelibs > > > Description > --- > > The iconbutton a

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

ituation. > > Thomas Lübking wrote: > Yes, of course - but you're seeking approval of Peter Penz. > > kdeuser56 kdeuser56 wrote: > Is he still active? (http://ppenz.blogspot.co.at/2012/06/dolphin-21.html) > > Thomas Lübking wrote: > Ah, no - sorry

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

rd.kde.org/r/114686/#review47356 --- On Jan. 14, 2014, 8:30 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

behavior. Diffs - kdeui/widgets/kmessagewidget.cpp e5143cc Diff: https://git.reviewboard.kde.org/r/114686/diff/ Testing --- I don't get a dialog showing the "Ambiguous shortcut" message any more in the described use case. Thanks, Frank Reininghaus

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

. In any case, I don't have good knowledge of KCompletion, so I don't feel qualified to say "Ship It!" (at least not before waiting another week or two for possible comments from others). - Frank Reininghaus O

Re: Review Request 114956: Add support for getting a samba share's total size and free space through KIO

IMHO a bad idea. - Frank Reininghaus On Jan. 10, 2014, 6:07 p.m., Mathias Tillman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

.org/r/114686/diff/ Testing --- I don't get a dialog showing the "Ambiguous shortcut" message any more in the described use case. Thanks, Frank Reininghaus

Re: Review Request 114506: Create testcase for bookmark toolbar

7;t really comment on the XML stuff though because I'm not familiar with the format in which the bookmarks are stored. - Frank Reininghaus On Dec. 16, 2013, 6:44 p.m., Stefan Brüns wrote: > > --- > This is an automatically ge

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

> On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote: > > Thanks for looking into this, Dawit! I greatly appreciate this effort. > > > > > > Two questions come to my mind: > > > > 1. Why should these dialogs be modal at all? Everything that KIO does

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

s not a big problem any more), but also because it was a bit irritating that KIO dialogs would freeze all Dolphin windows. Some more information can be found in these threads: http://lists.kde.org/?t=13752968312&r=1&w=2 http://lists.kde.org/?t=13753723594&r=1&w=2 - Frank Re

Re: Review Request 113591: Reduce UDSEntry memory usage by sharing the contained QStrings if possible

oaded (see r3 of https://git.reviewboard.kde.org/r/113355/) runs in 234 ms instead of 266 ms on my machine - it seems that growing the heap to provide space for the non-shared QStrings is more expensive than comparing all loaded QStrings with the cached values. Thanks, Frank Reininghaus

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113355/diff/ Testing --- Old and new unit tests pass. The memory usage of Dolphin when loading a directory with 100,000 files in Icons View is reduced from 165.4 MB to 113.3 MB. Any application that uses a file dialog, a KDirLister, or anything else that uses a KIO::ListJob to list directory contents should benefit from similar savings. Thanks, Frank Reininghaus

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 31, 2013, 2:41 p.m., Frank Reininghaus wrote: > > I see now that I have tried to put too much stuff into a single patch - > > it's too hard to digest and to understand, and the number of possibilities > > to modify different aspects of UDSEntry in a

Review Request 113591: Reduce UDSEntry memory usage by sharing the contained QStrings if possible

on my machine - it seems that growing the heap to provide space for the non-shared QStrings is more expensive than comparing all loaded QStrings with the cached values. Thanks, Frank Reininghaus

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

clude in kdelibs 4.12. @dfaure: I took from our discussion on the mailing list that you agree with the idea to reduce UDSEntry's memory usage. What do you think? - Frank Reininghaus On Oct. 26, 2013, 5:56 p.m., Frank Reining

Re: Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

pen only with Frameworks 5? > > Frank Reininghaus wrote: > To my knowledge, kde-workspace is the only part of the KDE SC that will > not have a 4.12 release. > > About the "proper way" that Martin referred to: there was a discussion on > the frameworks ma

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

-CREATION Diff: http://git.reviewboard.kde.org/r/113355/diff/ Testing --- Old and new unit tests pass. The memory usage of Dolphin when loading a directory with 100,000 files in Icons View is reduced from 165.4 MB to 113.3 MB. Any application that uses a file dialog, a KDirLister, or anything else that uses a KIO::ListJob to list directory contents should benefit from similar savings. Thanks, Frank Reininghaus

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

is appended, then the performance would be horrible. - Frank --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42330 --------

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

s. The memory usage of Dolphin when loading a directory with 100,000 files in Icons View is reduced from 165.4 MB to 113.3 MB. Any application that uses a file dialog, a KDirLister, or anything else that uses a KIO::ListJob to list directory contents should benefit from similar savings. Thanks, Frank Reininghaus

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

enerated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42133 --- On Oct. 21, 2013, 6:23 p.m., Frank Reininghaus wrote: > > --- > This is an automat

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

capsulated in KFileItem objects. > > > > Good luck! > > If you need more, just ask. Thanks! I'll see if I can make a test case that works with both kdelibs master and frameworks out of this. The simplicity of your test case makes me look forward to the day when we can us

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

s OK since > UDSEntryPrivate _is_ sharing. Also, QString in Field is also shared (and with > this patch actually makes use of this). I'd be interested in the performance > of a (std::)vector/pair approach. > > Frank Reininghaus wrote: > I fully agree that big-O is

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

they are all stored next to each other, right? In a std::vector>, the different keys would be many bytes apart. - Frank --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

t; And for few items (which is the case here, if I understood correctly), it > > will also be faster than QHash. And thus probably also faster than the > > combined QHash + QVector lookup. > > > > The code would also become cleaner that way. > > Frank Reininghau

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

it tests pass. The memory usage of Dolphin when loading a directory with 100,000 files in Icons View is reduced from 165.4 MB to 113.3 MB. Any application that uses a file dialog, a KDirLister, or anything else that uses a KIO::ListJob to list directory contents should benefit from similar savings. Thanks, Frank Reininghaus

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42058 ----------- On Oct. 20, 2013, 5:27 p.m., Frank Reininghaus wrote: > > --

Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

iew is reduced from 165.4 MB to 113.3 MB. Any application that uses a file dialog, a KDirLister, or anything else that uses a KIO::ListJob to list directory contents should benefit from similar savings. Thanks, Frank Reininghaus

Re: Dolphin error

Hi, 2013/10/15 Jacson Rodrigues: > Hello KDE Developers, > when the /home permission is 0111, the dolphin doesn't show anything at > folders tab and the error is: > > QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: > Permissão negada > QFileSystemWatcher: failed to add pat

Re: Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

> On Sept. 4, 2013, 6:25 p.m., Eugene Shalygin wrote: > > I'm thankfull to all of you for lloking into this! Now I do not know what > > to do with these changes. If there will bee no new kdelibs 4.x releases, > > how these changes can be released? Will it happen only with Frameworks 5? To my k

Re: Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

nd it was not needed before? It's not obvious to me at first sight. - Frank Reininghaus On Aug. 29, 2013, 1:11 p.m., Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

le-line if/else blocks, see http://techbase.kde.org/Policies/Kdelibs_Coding_Style for details. Even if the existing code does not follow the style, you should format any new or changed lines correctly. - Frank Reininghaus On Aug. 9, 2013

Re: KDirWatch bug and the analysis. Help is welcome!

Hi, 2013/8/1 Thomas Lübking: > On Donnerstag, 1. August 2013 13:24:19 CEST, Frank Reininghaus wrote: >> >> Hi, >> >> 2013/8/1 Thomas Lübking: >>> >>> On Donnerstag, 1. August 2013 12:44:57 CEST, Frank Reininghaus wrote: ... >> >> >

Re: KDirWatch bug and the analysis. Help is welcome!

Hi, 2013/8/1 Thomas Lübking: > On Donnerstag, 1. August 2013 12:44:57 CEST, Frank Reininghaus wrote: >> >> Hi, >> >> 2013/8/1 Thomas Lübking: >>>> >>>> We could, however, fix this by filtering out hidden files ("dot files")

Re: KDirWatch bug and the analysis. Help is welcome!

Hi, 2013/8/1 Thomas Lübking: >> We could, however, fix this by filtering out hidden files ("dot files") in >> the KDirWatch inotify event handling, optionally. > > What doesn't help you when listing them as well. > > Questions: > 1. why does dolphin update the .directory file *intantly* and esp. w

Re: KDE/4.11 branched what to do with kde-workspace?

Hi, 2013/7/11 Sebastian Kügler: > Hi, > > On Tuesday, July 09, 2013 23:45:39 Martin Graesslin wrote: >> On Tuesday 09 July 2013 18:57:41 Albert Astals Cid wrote: >> > So the kde-workspace dudes decided they don't want a 4.12 release and that >> > they'll do a LTS 4.11, fine, how do we fix that bra

Re: Releases in 3 months

Hi, 2013/7/8 Àlex Fiestas: > Now that kde-workspace and kdelibs are going to be frozen (which in theory > means less work for everybody) I'd like to propose a new release schedule to > be applied starting with 4.12. > > Basically the idea is to cut testing time and compensate it by keeping master

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review35004 --- Ship it! Ship It! - Frank Reininghaus On June 24, 2013, 12

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

understand what's going on if anyone investigates the file's history at some point in the future. dolphin/src/dolphincontextmenu.cpp <http://git.reviewboard.kde.org/r/111206/#comment25591> kdelibs coding style: Add {...} even in single-line if/for/while statements. - Frank Rein

Re: K(Abstract)FileItemActionPlugin

Hi, 2013/6/20 Ivan Čukić: > >> implemented this at a time when Ivan still refused to acknowledge that >> there is a bug in his plugin at all. There was no real solution in > > From this point on, I'm ignoring this discussion. > > I have never said that the plugin is not the reason for the bug 3145

Re: K(Abstract)FileItemActionPlugin

Hi Sune, 2013/6/20 Sune Vuorela: >>> so Frank, please, pretty please, can you reconsider? >> >> I see that Ivan rewrote the plugin and that it does at least not do >> anything fishy any more before the context menu is shown. I also >> understand that people who do not have to deal with the bug rep

Re: K(Abstract)FileItemActionPlugin

Hi Sebastian, 2013/6/20 Sebastian Kügler: >> > Why not just ask to reproduce with plugins disabled, then enable plugin >> > for >> > plugin, and reassign the bug accordingly? >> >> I've tried that often enough. Most bug reporters never respond. >> Therefore, I think it's better to close the report

Re: K(Abstract)FileItemActionPlugin

Hi Sebastian, 2013/6/20 Sebastian Kügler: > Hi Frank, > > On Thursday, June 20, 2013 10:51:58 Frank Reininghaus wrote: >> Moreover, I will from now on: >> >> (a) Close all "Dolphin freezes/crashes/formats my hard drive when >> right-clicking a file&qu

Re: K(Abstract)FileItemActionPlugin

Hi, 2013/6/19 Sune Vuorela: > On 2013-06-19, Thomas Lübking wrote: >>> If I was a plugin developer here, I would of course think my plugin >>> should be enabled by default and thus in my ctor call >>> setEnabledByDefault(true) >> >> I would suggest to leave the path of plugin enabling as solution

Re: K(Abstract)FileItemActionPlugin

Hi, 2013/6/19 Thomas Lübking: > On Mittwoch, 19. Juni 2013 20:21:41 CEST, Sune Vuorela wrote: >> >> On 2013-06-17, Frank Reininghaus wrote: >>> >>> Yes, it can block for random reasons, and this is why making D-Bus >>> calls in the code that is ex

Re: Should fast mime detection use a stat call?

Hi, 2013/6/17 Mark: > On Mon, Jun 17, 2013 at 4:13 PM, David Faure wrote: >> Le lundi 17 juin 2013 09:54:02 Mark a écrit : [...] >>> However, that >>> stat data isn't send to KMimeType so another way would be to require a >>> "KFileItem" which knows more about a file instead of a KUrl (QUrl in >>>

Re: Should fast mime detection use a stat call?

Hi Mark, thanks for looking into these issues. Enabling us to load icons faster when entering a directory is appreciated :-) I can't say much about your proposed changes in kdelibs though - I think that David will be able to give more useful comments. 2013/6/17 Mark: > What's your opinion on thi

Re: K(Abstract)FileItemActionPlugin

Hi, 2013/6/14 Thomas Lübking: > On Donnerstag, 13. Juni 2013 16:36:31 CEST, Frank Reininghaus wrote: >> >> Hi, >> >> sorry for the late reply. > > > And sorry myself for similar reasons ;-) > >>> 2013/6/10, Frank Reininghaus: >> >> tim

Re: K(Abstract)FileItemActionPlugin

Hi, sorry for the late reply. 2013/6/10 Albert Astals Cid: > El Dilluns, 10 de juny de 2013, a les 15:56:16, Frank Reininghaus va escriure: > Was thinking yesterday that maybe we want to involve some of the usability > guys? Explain the problem and see if they come up with a nice idea

Re: K(Abstract)FileItemActionPlugin

Hi, sorry for the late reply. 2013/6/10 Thomas Lübking: > 2013/6/10, Frank Reininghaus: > >> It was indeed an *extremely* frustrating experience for me to find out >> that code which had (to my knowledge) been written without any kind of >> review could be installed a

Re: K(Abstract)FileItemActionPlugin

Hi Albert, thanks for the quick reply. 2013/6/9 Albert Astals Cid: > El Diumenge, 9 de juny de 2013, a les 09:22:10, Frank Reininghaus va escriure: >> Hi Albert, >> >> thanks for your comments. >> >> 2013/6/8 Albert Astals Cid: >> > El Divendres

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

rd to having one little annoyance less :-) The Dolphin side of the patch looks good to me, and I can confirm that it works nicely. - Frank Reininghaus On June 10, 2013, 9:22 a.m., Emmanuel Pescosta wrote: > > --- > This is an

Re: K(Abstract)FileItemActionPlugin

Hi Albert, thanks for your comments. 2013/6/8 Albert Astals Cid: > El Divendres, 7 de juny de 2013, a les 17:40:29, Frank Reininghaus va > escriure: >> Hi everyone, > > Hi > >> I've recently implemented a mechanism that allows developers of >> KAbstractFil

K(Abstract)FileItemActionPlugin

Hi everyone, I've recently implemented a mechanism that allows developers of KAbstractFileItemActionPlugins to state that their plugin should not be shown in file-management related context menus by default [1]. I've been thinking again about this approach again this week, and now I think that it

Review Request 110625: Make it possible to disable KAbstractFileItemActionPlugins by default

/r/110625/diff/ Testing --- Deleted kservicemenurc -> Activities not shown in Konqueror/Dolphin context menus, and the plugin is shown as disabled in the settings. Enabled the plugin in the settings dialog of either Konqueror or Dolphin -> plugin is shown, and disabling it in the dialog h

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

any more. dolphin/src/dolphinremoveaction.cpp <http://git.reviewboard.kde.org/r/108802/#comment24142> Not needed any more. - Frank Reininghaus On May 13, 2013, 1:02 p.m., Dawit Alemayehu wrote: > > --- &

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

eviewboard.kde.org/r/108802/#comment24102> #include dolphin/src/dolphinremoveaction.cpp <http://git.reviewboard.kde.org/r/108802/#comment24103> #include - Frank Reininghaus On May 13, 2013, 1:38 a.m., Dawit Alemayehu wrote: > >

Re: Review Request 110327: KMessageWidget: Remove decoration icon

, https://bugs.kde.org/show_bug.cgi?id=304775 can be closed when this is pushed. Thanks for the hint, Emmanuel! kdeui/widgets/kmessagewidget.cpp <http://git.reviewboard.kde.org/r/110327/#comment23939> I guess you can remove the variable 'icon' from this function now,

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

kdelibs > > releases? > > > > QList list = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; > > KRandomSequence pseudoRand( 123545 ); > > pseudoRand.randomize( list ); > > return list; > > > > > > > > Frank Reininghaus wrote: > I had thought abou

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

nk --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262/#review31855 ------- On May 1, 2013, 8:34 p.m., Frank Reininghaus wrote: &g

Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

hmark::randomSequenceBenchmark():"n=1": 0.85 msecs per iteration (total: 55, iterations: 64) RESULT : Benchmark::randomSequenceBenchmark():"n=3": 2.6 msecs per iteration (total: 86, iterations: 32) RESULT : Benchmark::randomSequenceBenchmark():"n=10": 10 msecs per iteration (total: 81, iterations: 8) Thanks, Frank Reininghaus

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

that and push the patch to KDE/4.10. - Frank --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/#review31698 --- On April 28, 2013

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

and found the right place in the code. This addresses bug 193298. http://bugs.kde.org/show_bug.cgi?id=193298 Diffs (updated) - kdecore/io/kmountpoint.cpp aa7a6b1 Diff: http://git.reviewboard.kde.org/r/110225/diff/ Testing --- Works for me. Thanks, Frank Reininghaus

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

s check out into a separate function to keep the code > readable. > > Many thanks to Jekyll Wu, who analyzed this bug and found the right place in > the code. > > > This addresses bug 193298. > http://bugs.kde.org/show_bug.cgi?id=193298 > > > Diffs > - > > kdecore/io/kmountpoint.cpp aa7a6b1 > > Diff: http://git.reviewboard.kde.org/r/110225/diff/ > > > Testing > --- > > Works for me. > > > Thanks, > > Frank Reininghaus > >

Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

ode. This addresses bug 193298. http://bugs.kde.org/show_bug.cgi?id=193298 Diffs - kdecore/io/kmountpoint.cpp aa7a6b1 Diff: http://git.reviewboard.kde.org/r/110225/diff/ Testing --- Works for me. Thanks, Frank Reininghaus

Re: ‘const class KFileItem’ has no member named ‘isFinalIconKnown’

2013/4/21 towelday: > I am not able to build kde-baseapps on lfs7.3 > > [ 4%] Building CXX object > dolphin/src/CMakeFiles/dolphinprivate.dir/kitemviews/kfileitemmodelrolesupdater.o > /sources/blfs/kde-baseapps-4.10.2/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp: > In member function ‘boo

Re: Review Request 109997: Tint selected icon in KFileItemDelegate by highlight color (as Dolphin 2.0)

> On April 13, 2013, 5 p.m., Christoph Feck wrote: > > Regarding the icon tinting, there are bugs filed against this Dolphin > > behavior, so I am not sure we should replicate it in kdelibs. > > Christoph Feck wrote: > bug 304643, bug 309722 to be more specific :) > > Eike Hein wrote: >

Re: Review Request 109538: port KFileMetaDataReader to QProcess

> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: > > But why? KFileMetadataReader and the other KFileMetadataStuff should just > > be marked as deprecated. Why are we porting them? We already have better > > alternatives in the nepomuk-widgets repository. > > Martin Tobias Holmedahl Sandsm

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

: the state of the modifiers only matters when the context menu is open (or just about to be opened), right? Couldn't one move the m_keyInfo-related code from the constructor to slotOpenContextMenu() and disconnect from the signal again at the end of that function? - Frank Reininghaus On F

Re: Review Request 108057: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

> On Jan. 7, 2013, 12:33 p.m., Frank Reininghaus wrote: > > Please run git pull --rebase before pushing any non-merge commits to > > prevent polluting the logs with commits like > > > > http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=94b38

Re: Login for bug reporting

2013/2/7 Kevin Krammer: > On Wednesday, 2013-02-06, Myriam Schweingruber wrote: >> Hi all, >> >> On Wed, Feb 6, 2013 at 10:20 PM, Frank Reininghaus >> >> wrote: > >> > considering that we get lots of duplicates for any reproducible bug, my >>

Re: Login for bug reporting

Am 06.02.2013 18:57 schrieb "Kevin Krammer": > > Hi folks, > > at FOSDEM I was approached by a person who asked me to relay his > dissatisfaction with the requirement of having a KDE Bugzilla account to > report crashes via the KDE crash handler dialog. > > The issue in his case was kind of made wo

  1   2   >