Re: KOpeningHours in kdereview

2020-12-10 Thread Rolf Eike Beer
parse some things then it is not worse than now where it it just an opaque string. Eike signature.asc Description: This is a digitally signed message part.

Re: KOpeningHours in kdereview

2020-12-10 Thread Rolf Eike Beer
se-cases as well. I was thinking about doing something similar for OSM2go, which currently also runs on the N900 and needs gcc 4.2 for it. Is there interest to have a C++98 STL only version of the main parser? Or is it so tied to Qt classes that there is no chance in that? Eike signature.asc De

Re: KOSMIndoorMap in kdereview

2020-10-22 Thread Rolf Eike Beer
to reserve(). The coding style for the remark-if in XmlParser::parse() is inconsistent. Or, if compared to the rest of the file, it's the only consistent one in that function. Eike signature.asc Description: This is a digitally signed message part.

Re: Information regarding upcoming Gitlab Migration

2020-04-26 Thread Rolf Eike Beer
, just a request for clarification: it looks like everything in extragear or playground was merged into there, right? Eike

Re: KDiff3 1.8 release.

2019-03-19 Thread Eike
emember off hand who created. 1.7.90 would be an older version of my > code not officially released. I uploaded an untagged 1.7.90 version to Debian so it could still make it in the next Debian release buster (which is supposed to get rid of QT4). => https://packages.debian.org/buster/kdiff3

Re: Installing qml caches

2018-06-07 Thread Rolf Eike Beer
ust a quick note: the quick compiler macros provided by Qt 5.11.0 are broken for cross-compilation (QTBUG-68724). Eike

Re: Symmy in kde-review

2017-12-04 Thread Rolf Eike Beer
eys, as we already have kgpg or > >> kleopatra for that. > > > > How hard would be to make that functionality to kgpg (simple > > encryption without public / private keys) instead of yet - > > another tool to handle file encryption? > > Not sure, perha

Re: Simple Menu (Plasma widget) now in kdereview

2017-11-02 Thread Eike Hein
, and this is intended to be distributed mainly through the Store. My main purpose in going through kdereview is to get Phabricator and Bugzilla entries for it, because users are asking for a better way to submit bug reports than Store comments. > David Cheers, Eike

Simple Menu (Plasma widget) now in kdereview

2017-11-02 Thread Eike Hein
nt blog: https://blogs.kde.org/2017/01/30/simple-menu-launcher-kde-store The Simple Menu codebase is QML-only, relying on C++ backends shipped with Plasma Desktop. It's had multiple tagged releases and is shipped as the default menu in several distros. Cheers, Eike

Re: Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

2017-07-20 Thread Rolf Eike Beer
from the else() and endif() calls. - Rolf Eike Beer On Juli 20, 2017, 7:59 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: kdereview: ksmtp

2017-05-16 Thread Rolf Eike Beer
sion, but just closes the socket. Is that properly handled? Greetings, Eike signature.asc Description: This is a digitally signed message part.

Re: Draft Policy: Dependency Changes and CI

2017-01-23 Thread Eike Hein
, and dissipate strong emotions by turning them away from people. Cheers, Eike

Draft Policy: Dependency Changes and CI

2017-01-19 Thread Eike Hein
calls for linking the new policy from the /Policies/ overview page at the start of February, thereby making it official and putting it into action. And then we live with it for some time and see if it serves us well going forward. Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-19 Thread Eike Hein
t; libxkbcommon made available to them. > > Implementing this also required changes to the general CI > infrastructure for all jobs, to handhold Autotools based builds. We > did something similar for CMake already. Thanks Ben! > Regards, > Ben Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-19 Thread Eike Hein
perhaps also give > feedback on issues. > Ideally it might even result in the new dependency already being available at > the time of the review request, so if the review itself is done quickly, CI > does not block the merge. > > IIRC this would also reflect what has been done now and then :) Sounds good, I'll add a small bit. > Cheers > Friedrich Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-18 Thread Eike Hein
rent situation with xkbcommon, it happened before we sat down to write this, and I'd say we don't try to shoehorn it into the framework after the fact. AIUI it sysadmin/packagers are working to procure the needed dependency, so we'll let them do so ... Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-16 Thread Eike Hein
uot; group on Phabricator. Please have a look. Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-16 Thread Eike Hein
g to codify a KDE-wide dependency policy here. Changes like this increase the barrier to participation in KDE (more rules to abide by, in this case, concretely more work to do that not all teams can equally afford to do). Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-16 Thread Eike Hein
ines are violated and maintaining a project on CI becomes unreasonable. This limits scope of enforcement (i.e. the consequences for falling out of line) to participation in CI instead of the community, which seems more pragmatic in hindsight. Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-13 Thread Eike Hein
On January 14, 2017 1:23:20 AM GMT+09:00, "Martin Gräßlin" wrote: >Am 2017-01-13 13:21, schrieb Eike Hein: >> Ok, here we go. My draft of a formal policy for dep changes and the >CI: >> >> https://community.kde.org/Policies/Dependency_Changes_and_CI >>

Re: CI Requirements - Lessons Not Learnt?

2017-01-13 Thread Eike Hein
Quick follow-up notes: I improved the formatting a little more, please refresh if you were reading already - now waiting for comments, though. Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-13 Thread Eike Hein
, dry document. Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-13 Thread Eike Hein
and I'll try my best to moderate that process since I'm already a k-c-d list mod, and both a Plasma dev and a (albeit largely inactive) sysadmin. Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Eike Hein
On 01/13/2017 02:07 AM, Martin Gräßlin wrote: > Fedora devs don't want it. Since it might help: Kevin Kofler isn't part of the Fedora KDE SIG, so his opinion in the thread is his own rather than representative of that team/community. > Martin Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Eike Hein
break our software. We're having major fight /because the build broke briefly over a new dependency/. That's like setting the factory on fire because a can of paint got knocked over. This is nuts. You have the option not to fight. Cheers, Eike

Re: CI Requirements - Lessons Not Learnt?

2017-01-11 Thread Eike Hein
tically difficult, unless developers are willig to become sysadmins and/or packagers. Cheers, Eike

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-18 Thread Rolf Eike Beer
tps://git.reviewboard.kde.org/r/128941/#comment66843> If Konqueror directly uses these symbols it needs to explicitely link to it, even if libkonq does. - Rolf Eike Beer On Sept. 18, 2016, 11:36 nachm., Andreas Sturmlechner wrote: > > ---

Re: kconfig_compiler help ( reproducible builds )

2016-05-27 Thread Rolf Eike Beer
y outputting UTF8 sequences? I would expect a call to .toUtf8() somewhere in there. Eike signature.asc Description: This is a digitally signed message part.

Re: A new attempt on PyKDE5 binding generation

2016-03-27 Thread Eike Hein
Hi, exciting work! Just the other day I was hoping someone would pick up work on PyKDE5 ... Cheers, Eike

Re: A new attempt on PyKDE5 binding generation

2016-03-27 Thread Eike Hein
Hi, exciting work! Just the other day I was hoping for someone to take up PyKDE5 ... Cheers, Eike

Re: Review Request 104960: KJS: fix behaviour on allocation errors

2016-02-07 Thread Rolf Eike Beer
used for calculations (which is (void*)-1), other will have 0. This will make the allocator have a sane default behaviour: just return 0. Diffs - kjs/collector.cpp 70e4757 Diff: https://git.reviewboard.kde.org/r/104960/diff/ Testing --- Thanks, Rolf Eike Beer

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-04 Thread Rolf Eike Beer
Am Freitag, 4. Dezember 2015, 16:14:10 schrieb Nicolás Alvarez: > 2015-12-04 16:07 GMT-03:00 Rolf Eike Beer : > > Ben Cooksley wrote: > >> It is an extreme pity these mailing list providers have demonstrated > >> such an extreme disregard for standards which aim to e

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-04 Thread Rolf Eike Beer
t has become worse in the last month, as it seems that the usual filters do not work that good anymore. You as postmaster of such a public domain are likely receiving even more of that crap. But that proposal is going to cause collateral damage. Eike signature.asc Description: This is a digitally signed message part.

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-04 Thread Rolf Eike Beer
Am 04.12.2015 11:08, schrieb Ben Cooksley: On Fri, Dec 4, 2015 at 9:01 AM, Rolf Eike Beer wrote: Think of SPF: I sent an email to a kde.org email address only some weeks ago. My domain sets a SPF policy. The KDE server accepts this (it's actually correct), and then sends the ma

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-03 Thread Rolf Eike Beer
be rejected if there is _no_ signature, or a malformed one. If a domain publishs that it does DKIM signing and mails are expected to be correctly signed, then rejecting on a invalid signature is actually fine (and the sole purpose of this RfC). Greetings, Eike signature.asc Description: This is a digitally signed message part.

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-25 Thread Eike Hein
hot to Extragear? > > Cheers, > Boudhayan Gupta Cheers, Eike

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-19 Thread Rolf Eike Beer
is indeed to put cmake_minimum_required() into your project. But not into a project you include, but into the main project you are trying to build. Greetings, Eike signature.asc Description: This is a digitally signed message part.

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Eike Hein
cently, but overall walked away with a favorable impression of the code. > Cheers > Martin Cheers, Eike

Re: Distros and QtWebEngine

2015-04-21 Thread Eike Hein
good has come from Debian forcing projects to play nice with others. Cheers, Albert Cheers, Eike

Re: The Future or KDE PIM Releases

2015-04-13 Thread Eike Hein
On 04/13/2015 03:04 PM, Sebastian Kügler wrote: This sounds awesome. +1 - just speaking as a user even, that's great news. Cheers, Eike

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Rolf Eike Beer
. No, the file is in an include path, not in the same directory as the source file (binary vs. source dir). - Rolf Eike --- This is an automatically generated e-mail. To reply, visit: http

Re: kio-extras

2015-02-24 Thread Eike Hein
slave that Folder View in Plasma Desktop defaults to. (Perhaps it shouldn't.) Jonathan Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-02-02 Thread Eike Hein
JIRA and gerrit have been made to inter- play for auth. 2) I've posted other criticizims of gerrit in the thread for a fuller picture of how gerrit adds to the unhappiness. Jumping on this bit, hand- waving it away and claiming we're now left with "gerrit is OK" is incorrect. Bye Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Eike Hein
DE picking tooling other than gerrit would arguably contribute to the combined ecosystem by making a resource available that is otherwise lacking. Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Eike Hein
one bullet from a long mail that addresses many other points, though ... I agree that the KDE community has concerns and ambitions unrelated to its relation- ship with Qt and a broader activity scope than the Qt project, and our tooling needs to be evaluated in that broader context. Boudewijn Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Eike Hein
something gerrit will actually regress us on afaics) (b) the very reason we entertain shaking up our infra is because we're unhappy with limitations in our tools. Alex Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Eike Hein
personally. Christoph Feck (kdepepo) Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Eike Hein
process. I think we should proceed with setting up a test instance and giving it a spin, this should help with getting things into clearer focus. Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Eike Hein
"we need to fix this if we adopt it" takes manpower, and historically, we've relied to some degree to getting that manpower *from upstream*. This is is in my book a world of difference from "upstream might accept our patches ... maybe". Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Eike Hein
nd 1-2 hours a day five-six days a week in the review web UI, and Phabricator's is pretty nice off the shelf. It's tricky. Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Eike Hein
sysadmin (you're administrating infra used by KDE, after all), so I meant the "kde.org" more general. Thanks. Cheers, Jan Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Eike Hein
I design, like replication. Tapping into that work is definitely attractive. * I like that Jan is looking ahead at using tooling to improve our process, rather than just re-ticking boxes for things we already have. Cheers, Eike

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Eike Hein
On 01/29/2015 06:16 PM, Milian Wolff wrote: FWIW, this document reads like a fairy tale to me. The fact that so much is already tested and deployed One thing I'm unclear on: Does the gerrit test instance run on machines administrated by kde.org these days? Cheers, Eike

Apps 14.12 release aftermath / Running KF5 apps in KDE 4

2015-01-26 Thread Eike Hein
d make sure we don't ship anything without that QA check again on future ports. I cross-posted this to k-c-d and r-t for visibility - I suggest we discuss the Frameworks side on k-c-d and the release QA side on r-t. Cheers, Eike

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Eike Hein
On 01/21/2015 10:18 PM, Ivan Čukić wrote: Hi, I'm volunteering KActivities for the test. Konversation, too. Cheerio, Ivan Cheers, Eike

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Eike Hein
heers, Ben Cooksley KDE Sysadmin Cheers, Eike

Re: KDE4 & SSL

2014-10-20 Thread Rolf Eike Beer
ocols in > > KDE4 libraries? > > That would be QtNetwork, by way of kdecore and kio. SSLv2 is already > disabled by default. To disable SSLv3 by default, you need to modify > QtNetwork. What happens if OpenSSL is built with no-ssl3? Greetings, Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 120543: Update FindPostgreSQL.cmake

2014-10-10 Thread Rolf Eike Beer
Am 10.10.2014 08:46, schrieb Jaroslaw Staniek: On 10 October 2014 08:05, Rolf Eike Beer wrote: Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from libpredicate (master). I see no upstrea

Re: Review Request 120543: Update FindPostgreSQL.cmake

2014-10-09 Thread Rolf Eike Beer
> Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one > but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from > libpredicate (master). I see no upstream bug report for this. Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-21 Thread Rolf Eike Beer
g it in KWallet::Wallet). Yes, I did update the connect call > to pass in the pointer to the parent class Use Q_PRIVATE_SLOT in the public header? Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 120287: [OS X] make kde-workspace build

2014-09-20 Thread Rolf Eike Beer
a matching argument to the last if or elseif, or an entirely empty argument. Eike signature.asc Description: This is a digitally signed message part.

Re: Using Gerrit for code review in KDE

2014-09-13 Thread Eike Hein
ions to put everyone into the right state of responsibility read on the good points you raised. * = http://joeyh.name/blog/entry/thread_patterns/ is making me paranoid now. Cheers Martin Cheers, Eike

Re: Using Gerrit for code review in KDE

2014-09-13 Thread Eike Hein
cases, and I think everyone with a KDE dev account is capable of deciding which one to select by himself when reviewing, without a technical restriction on what one can do. Yeah, that's something I'm OK with too. Maybe we can even adapt the UI to use strings like Sven proposes? Greetings! Cheers, Eike

Re: Using Gerrit for code review in KDE

2014-09-13 Thread Eike Hein
se etiquette to do that only if there is already strong agreement or the grace period has passed Seems best to me, assuming we can't change Gerrit to remove the distinction entirely. Cheers, Kevin Cheers, Eike

Re: Using Gerrit for code review in KDE

2014-09-13 Thread Eike Hein
we really want arbitrary design specifics of a tool to dictate how we work together? Cheers, Eike

Re: Using Gerrit for code review in KDE

2014-09-13 Thread Eike Hein
is fine. Social etiquette that entrenches some developers as special on those review tools is not. Cheers, Eike

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Eike Hein
On 09.09.2014 15:51, Jan Kundrát wrote: Hi, we agreed on the Frameworks BoF that the following two repos are now using Gerrit for some initial testing: Exclusively, or do they remain on ReviewBoard as well? Cheers, Eike

Re: Using Gerrit for code review in KDE

2014-09-07 Thread Eike Hein
access and the ability to get the data out if needed? This isn't meant as an attack of any sorts; I think experimentation is good. I'd just like to know the bases are covered. 1= The online services bit on http://manifesto.kde.org/commitments.html With kind regards, Jan Cheers, Eike

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2)

2014-07-27 Thread Rolf Eike Beer
nal linebreaks in the lines. From what I see the input lines may also contain linebreaks, this is why the internal line map has holes in the key sequence. I suspect the crash you see is somehow related to if the last line itself has \n in it or not or something like that. Looks like this needs

Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-14 Thread Eike Hein
-CREATION src/kcms/webshortcuts/main.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119280/diff/ Testing --- Thanks, Eike Hein

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

2014-07-05 Thread Eike Hein
/knewfilemenu.cpp 4f1ca10 Diff: https://git.reviewboard.kde.org/r/119130/diff/ Testing --- Thanks, Eike Hein

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

2014-07-05 Thread Eike Hein
odebase in kde-baseapps ...). I'm not experienced with writing KIO-related unit tests so I'd likely need help there, and I'd strongly advice against waiting for it right now (my todo is large and frightning). - Eike

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

2014-07-05 Thread Eike Hein
/filewidgets/knewfilemenu.cpp 4f1ca10 Diff: https://git.reviewboard.kde.org/r/119130/diff/ Testing --- Thanks, Eike Hein

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

2014-07-05 Thread Eike Hein
uot;*.desktop", QDir::Files); > > > > Cool huh, one liners? :) entryList() doesn't return full absolute paths, only file names, so your one liner isn't actually functionally equivalent (and full paths are needed the

Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

2014-07-05 Thread Eike Hein
--- Thanks, Eike Hein

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Eike Hein
ed8) at /home/sho/devel/build/kde/applications/konsole/src/konsole_dummy.cpp:3 - Eike Hein On June 18, 2014, 5:50 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2014-06-11 Thread Eike Hein
.h e8e74c3 kwalletd/kwalletd.cpp fa9fc11 Diff: https://git.reviewboard.kde.org/r/110328/diff/ Testing --- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein

Re: Review Request 116097: No longer use strlcpy in kstartupconfig

2014-02-26 Thread Rolf Eike Beer
fopen/fgets/fixed size buffer stuff and replace it with std streams or something like that? - Rolf Eike Beer On Feb. 26, 2014, 6:11 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 115651: Fix HTTP redirection handling (3XX status code)

2014-02-12 Thread Rolf Eike Beer
gt; setMetaData(QLatin1String("redirect-to-get"), > QLatin1String("true")); } > } else { // 303 See Other > if (m_request.method != HTTP_HEAD) { > m_request.method = HTTP_GET; // FORCE a GET >

Re: Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

2014-02-12 Thread Rolf Eike Beer
:56 a.m.) Review request for kdelibs and Andrea Iacovitti. Changes --- Uploaded the patch. It looks to me as if the patch also contains the stuff for RR 115651. Eike

Re: Moving Baloo forward

2014-01-28 Thread Rolf Eike Beer
about someone who accidentially published either metadata or deleted text (remember MS Word document history or something)? I'm absolutely fine if you want this that you do this. But most people will not be aware of it, even less of the implications. So it should be deactivated by default

Re: Moving Baloo forward

2014-01-27 Thread Rolf Eike Beer
map the file to its metadata in the database, maybe together with some sort of checksum to detect modifications. That way no accidential information leak will happen if that thing is copied elsewhere. Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-04 Thread Rolf Eike Beer
nitpick (that doesn't deserve a new diff): you could make the FileName argument to that function "const QString &". - Rolf Eike Beer On Jan. 4, 2014, 4:54 p.m., Wolfgang Bauer wrote: > > --- > This is an automa

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-04 Thread Rolf Eike Beer
tps://git.reviewboard.kde.org/r/114737/#comment33389> This allocates a new object on the heap that is never freed. Just use "QProcess pipe;" - Rolf Eike Beer On Jan. 4, 2014, 9 a.m., Wolfgang Bauer wrote: > > --- > This is an

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Rolf Eike Beer
;. (according to the man page, popen calls "/bin/sh > -c command") To fix this, ReadPipe() should check the return code of the > call to pclose() (see "man pclose"), and return 0 if this is not equal to > 0. Can't this be ported to simply use QProcess instead? Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-29 Thread Eike Hein
http://git.reviewboard.kde.org/r/113447/diff/ Testing --- Thanks, Eike Hein

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Eike Hein
sting --- Thanks, Eike Hein

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Eike Hein
org/r/113447/diff/ Testing --- Thanks, Eike Hein

Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones

2013-09-05 Thread Rolf Eike Beer
Am Donnerstag 05 September 2013, 08:43:48 schrieb Rolf Eike Beer: > > Diffs > > - > > > > kio/kio/job.cpp 8ff088c > > > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ > > Is it reviewboard fooling me or is there no diff? This one does exis

Re: Review Request 112528: Make it possible to preserve mtime for copy jobs not just move ones

2013-09-04 Thread Rolf Eike Beer
> Diffs > - > > kio/kio/job.cpp 8ff088c > > Diff: http://git.reviewboard.kde.org/r/112528/diff/ Is it reviewboard fooling me or is there no diff? Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-25 Thread Eike Hein
discarded. Review request for kde-workspace, Plasma and Eike Hein. Description --- Fix the crash in plasma-desktop caused by newer QML taskbar widget. Simple steps to reproduce this crash. 1) Pin any task/application to taskbar using "show launcher when not running" option

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-25 Thread Eike Hein
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be r

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Eike Hein
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be r

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Eike Hein
patch, but I really still have to find a way to reproduce this bug before just applying this blindly - it might be treating a symptom instead of addressing the root cause. - Eike Hein On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote: > > --

Re: Review Request 111648: Fix for GroupExpander that overlaps application icon

2013-08-08 Thread Rolf Eike Beer
.png Looks like there should be a margin to the right border, no? Eike

Re: KDirWatch bug and the analysis. Help is welcome!

2013-08-01 Thread Rolf Eike Beer
much simpler than adds as you do not need to lookup any new information, so avoiding the whole directory scan on delete sounds like a good idea to me in any case, no? Eike signature.asc Description: This is a digitally signed message part.

Re: Supported Compilers / C++11 Support in KF5

2013-07-22 Thread Rolf Eike Beer
Am Montag, 22. Juli 2013, 19:14:10 schrieb Alexander Neundorf: > On Sunday 21 July 2013, Rolf Eike Beer wrote: > > I totally agree with that. As I said: detection of this is trivial at > > CMake time, maybe I get my C++ feature detection package ready even to be > > included

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Rolf Eike Beer
Am Sonntag, 21. Juli 2013, 14:11:07 schrieb Volker Krause: > On Sunday 21 July 2013 13:52:06 Rolf Eike Beer wrote: > > Volker Krause wrote: > > > - GCC >= 4.5 > > > > > > - override > > > > Explicit virtual overrides require g++ 4.7: > >

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Rolf Eike Beer
Volker Krause wrote: > - GCC >= 4.5 > - override Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html This is trivially to work around by a CMake time check and then just define override to empty. Eike signature.asc Description: This is a digital

Re: Techbase: schedules for playground and extragear

2013-06-05 Thread Eike Hein
delete them as long as the maintainers who don't ignore it provide some value to the translators by doing so. > > Cheers, > Albert Cheers, Eike

  1   2   3   >