https://git.reviewboard.kde.org/media/uploaded/files/2014/11/10/797589bb-56fd-4ee0-a45a-4a9694db1e88__test_qsslcertificate_import.cpp
Thanks,
Dawit Alemayehu
-4a9694db1e88__test_qsslcertificate_import.cpp
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/120975/diff/
Testing
---
File Attachments
Accept dialog with cancel button
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/bb4e2153-f6b3-4ca9-9645-1783578143a3__ssl_cert_accept_dialog.png
Thanks,
Dawit Alemayehu
cancel button
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/bb4e2153-f6b3-4ca9-9645-1783578143a3__ssl_cert_accept_dialog.png
Thanks,
Dawit Alemayehu
.
Thanks,
Dawit Alemayehu
.
Thanks,
Dawit Alemayehu
apache to refuse any further requests.
Diffs
-
kioslave/http/http.cpp 7e2bca7
Diff: https://git.reviewboard.kde.org/r/120439/diff/
Testing
---
Tested on own local apache + mod_dav server.
Thanks,
Dawit Alemayehu
2.
Diffs (updated)
-
kioslave/http/http.h c447b69
kioslave/http/http.cpp 7e2bca7
kioslave/http/webdav.protocol c0fbd11
Diff: https://git.reviewboard.kde.org/r/120418/diff/
Testing
---
Copy file from local directory to a webdav server.
Thanks,
Dawit Alemayehu
rd.kde.org/r/120418/diff/
Testing
---
Copy file from local directory to a webdav server.
Thanks,
Dawit Alemayehu
o a webdav server.
Thanks,
Dawit Alemayehu
dav server.
Thanks,
Dawit Alemayehu
.h c447b69
kioslave/http/http.cpp 7e2bca7
kioslave/http/webdav.protocol c0fbd11
Diff: https://git.reviewboard.kde.org/r/120418/diff/
Testing
---
Copy file from local directory to a webdav server.
Thanks,
Dawit Alemayehu
xists()) {
> >
> >
It is a typo on my part. I will fix it.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66976
---
/kio/copyjob.cpp 713255b
Diff: https://git.reviewboard.kde.org/r/120182/diff/
Testing
---
Mounted Andriod filesystem through sshfs and attempted to copy files through
sftp.
Thanks,
Dawit Alemayehu
1068eb0e7780dd02f3af284e5d1ba932c06f4e1f
Diff: https://git.reviewboard.kde.org/r/120178/diff/
Testing
---
Thanks,
Dawit Alemayehu
)
-
kio/kio/copyjob.cpp 713255b
Diff: https://git.reviewboard.kde.org/r/120182/diff/
Testing
---
Mounted Andriod filesystem through sshfs and attempted to copy files through
sftp.
Thanks,
Dawit Alemayehu
.org/r/120182/#review66775
---
On Sept. 17, 2014, 12:55 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
)
-
kio/kio/copyjob.cpp 713255b
Diff: https://git.reviewboard.kde.org/r/120182/diff/
Testing
---
Mounted Andriod filesystem through sshfs and attempted to copy files through
sftp.
Thanks,
Dawit Alemayehu
automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66682
---
On Sept. 13, 2014, 12:38 p.m., Dawit Alemayehu wrote:
>
> ---
> T
/120182/diff/
Testing
---
Mounted Andriod filesystem through sshfs and attempted to copy files through
sftp.
Thanks,
Dawit Alemayehu
/show_bug.cgi?id=337198
Repository: kdelibs
Description
---
The attached patch sets the HTTP responsecode metadata on error.
Diffs
-
kioslave/http/http.cpp 1068eb0e7780dd02f3af284e5d1ba932c06f4e1f
Diff: https://git.reviewboard.kde.org/r/120178/diff/
Testing
---
Thanks,
Dawit
on.png
Thanks,
Dawit Alemayehu
command if it is ever reused again.
Diffs
-
kio/kio/connection.cpp 99aea0b
Diff: https://git.reviewboard.kde.org/r/119211/diff/
Testing
---
Run the steps given in the bug report before and after the fix.
Thanks,
Dawit Alemayehu
as not sure that was the case for all other commands.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119211/#review62085
------
Diff: https://git.reviewboard.kde.org/r/119211/diff/
Testing
---
Run the steps given in the bug report before and after the fix.
Thanks,
Dawit Alemayehu
I cannot compile and test the
fix myself yet.
Diffs
-
src/klauncher/klauncher.cpp 31498e0
Diff: https://git.reviewboard.kde.org/r/119021/diff/
Testing
---
Thanks,
Dawit Alemayehu
cannot compile and test the
fix myself yet.
Diffs
-
src/widgets/krun.cpp 77708a0
Diff: https://git.reviewboard.kde.org/r/119020/diff/
Testing
---
Thanks,
Dawit Alemayehu
because I cannot compile and test the
fix myself yet.
Diffs (updated)
-
src/klauncher/klauncher.cpp 31498e0
Diff: https://git.reviewboard.kde.org/r/119021/diff/
Testing
---
Thanks,
Dawit Alemayehu
cannot compile and test the
fix myself yet.
Diffs (updated)
-
src/widgets/krun.cpp 77708a0
Diff: https://git.reviewboard.kde.org/r/119020/diff/
Testing
---
Thanks,
Dawit Alemayehu
the
fix myself yet.
Diffs
-
src/klauncher/klauncher.cpp 31498e0
Diff: https://git.reviewboard.kde.org/r/119021/diff/
Testing
---
Thanks,
Dawit Alemayehu
: https://git.reviewboard.kde.org/r/119020/diff/
Testing
---
Thanks,
Dawit Alemayehu
/
Testing
---
Thanks,
Dawit Alemayehu
---
Tested with the example provided in the bug report. Verified the output of the
compile process is in the current working directory instead of $HOME.
Thanks,
Dawit Alemayehu
/
Testing
---
Tested with the example provided in the bug report. Verified the output of the
compile process is in the current working directory instead of $HOME.
Thanks,
Dawit Alemayehu
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118954/#review61122
---
On June 28, 2014, 2:09 a.m., Dawit Alemayehu wrote:
>
> ---
---
Tested with the example provided in the bug report. Verified the output of the
compile process is in the current working directory instead of $HOME.
Thanks,
Dawit Alemayehu
directory instead of $HOME.
Thanks,
Dawit Alemayehu
compile KDE on
rolling release based distros like ArchLinux without this patch.
- Dawit Alemayehu
On June 18, 2014, 11:40 a.m., Milian Wolff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Konqueror's URL combobox.
Diffs
-
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e
Diff: https://git.reviewboard.kde.org/r/118749/diff/
Testing
---
Thanks,
Dawit Alemayehu
s URL combobox.
Diffs (updated)
-
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e
Diff: https://git.reviewboard.kde.org/r/118749/diff/
Testing
---
Thanks,
Dawit Alemayehu
r/src/konqmainwindow.cpp da8c82e
Diff: https://git.reviewboard.kde.org/r/118749/diff/
Testing
---
Thanks,
Dawit Alemayehu
> On May 19, 2014, 12:05 p.m., Frank Reininghaus wrote:
> > We are seeing quite a few bug reports about a severe regression between KDE
> > SC 4.13.0 and KDE SC 4.13.1:
> >
> > https://bugs.kde.org/show_bug.cgi?id=334776
> >
> > According to the reporter of https://bugs.kde.org/show_bug.cgi?id
about the other suggestion I
made.
- Dawit Alemayehu
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
suggested?
- Dawit Alemayehu
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
variables to 64 bits so they can
accomodates dates beyond Feb 7, 2106.
Diffs
-
kioslave/http/http.h dd85622
kioslave/http/http.cpp e4f1eba
Diff: https://git.reviewboard.kde.org/r/116784/diff/
Testing
---
Thanks,
Dawit Alemayehu
tests run for 116524.
Thanks,
Dawit Alemayehu
es! Of course that is clearly wrong. Anyhow, this patch is
specifically intended to fix that issue and nothing else.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116784/
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116783/#review52891
---
On March 13, 2014, 10:15 p.m., Dawit Alemayehu wrote:
>
> --
116524.
Thanks,
Dawit Alemayehu
116524.
Thanks,
Dawit Alemayehu
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116783/#review52887
-------
On March 13, 2014, 12:33 p.m., Dawit Alemayehu wrote:
>
> --
/http.h dd85622
kioslave/http/http.cpp e4f1eba
Diff: https://git.reviewboard.kde.org/r/116784/diff/
Testing
---
Thanks,
Dawit Alemayehu
ftp server listed in the bug report.
Diffs
-
kioslave/ftp/ftp.h cbcd096
kioslave/ftp/ftp.cpp b9d90e6
Diff: https://git.reviewboard.kde.org/r/116783/diff/
Testing
---
Rerun all the tests run for 116524.
Thanks,
Dawit Alemayehu
rver from bug report on an Android device and run tests.
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
eported in the very old bug report #168011.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116523/#review52761
-------
message
that states the file could not be opened.
Diffs (updated)
-
kioslave/ftp/ftp.cpp ddc6eaf
Diff: https://git.reviewboard.kde.org/r/116523/diff/
Testing
---
Attempt to copy an empty file from any ftp server to a remote destination, e.g.
sftp server.
Thanks,
Dawit Alemayehu
remote destination, e.g.
sftp server.
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
Ftp server from bug report on an Android device and run tests.
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
> On March 4, 2014, 7:42 p.m., David Faure wrote:
> > I don't get it. What's the problem with sending a mimetype for empty files?
> > I would think this is actually expected - for all files, including empty
> > ones. Why does this fix the bug?
>
> Dawi
> On March 4, 2014, 7:42 p.m., David Faure wrote:
> > I don't get it. What's the problem with sending a mimetype for empty files?
> > I would think this is actually expected - for all files, including empty
> > ones. Why does this fix the bug?
>
> Dawi
or the fix: make this code relative to the
> > current CWD whatever it is, or call ftpFolder() with the directory name
> > (e.g. /home/dfaure/dir1/dir2) followed by SIZE with just the filename. The
> > latter sounds like it might work better on android (if it doesn't suppo
slave/http/http.cpp b4d64d4
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
For HTTP delete:
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
kioslave/http/http.cpp b4d64d4
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
For HTTP delete:
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
y URL before sending it
to the http ioslave.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review52381
-------
On Mar
dc6eaf
Diff: https://git.reviewboard.kde.org/r/116524/diff/
Testing
---
Installed Ftp server from bug report on an Android device and run tests.
Thanks,
Dawit Alemayehu
ding a cwd request.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116524/#review52013
---
On March 3, 2014,
s.html
File Attachments
POST redirection confirm dialog
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e77dd03e-cb37-49bb-8554-cca991c8c546__post_redirection_confirmation.png
Thanks,
Dawit Alemayehu
iff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
For HTTP delete:
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
> On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote:
> > I tested your patch, no trailing slash is added whether the request refers
> > to a collection or resource (as it was before commit 58294ac).
>
> Dawit Alemayehu wrote:
> Right, but now the webdav serve
y, visit:
https://git.reviewboard.kde.org/r/116122/#review52294
---
On March 5, 2014, 2:01 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail.
lete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
all ftpSendMimeType from ftpGet for empty files.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116523/#review51922
-------
On
> On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote:
> > Still broken for webdav protocol (tested using konq/dolphin), can't delete
> > file.
> > "isFile" is always false whether you try to delete a file or folder so a
> > trailing slash i
> On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote:
> > Still broken for webdav protocol (tested using konq/dolphin), can't delete
> > file.
> > "isFile" is always false whether you try to delete a file or folder so a
> > trailing slash i
e.isEmpty()
? QLatin1String("FALSE") : sslInUse;
- Dawit Alemayehu
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
>
> ---
> This is an automatically generated e-mail. To re
atically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review51879
---
On March 3, 2014, 3:50 p.m., Dawit Alemayehu wrote:
>
> ---
> This is an autom
s (updated)
-
kioslave/http/http.cpp 9eba5d1
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing (updated)
---
For HTTP delete:
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
bb2e8d
Diff: https://git.reviewboard.kde.org/r/116524/diff/
Testing
---
Installed Ftp server from bug report on an Android device and run tests.
Thanks,
Dawit Alemayehu
> On March 2, 2014, 12:14 a.m., Dawit Alemayehu wrote:
> > I am curious if stripping the leading "/" and sending a relative path with
> > the SIZE command would work for every FTP server?
>
> David Faure wrote:
> It's worth a try. I took at look
, e.g.
sftp server.
Thanks,
Dawit Alemayehu
/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html
Thanks,
Dawit Alemayehu
sending a relative path with the
SIZE command would work for every FTP server?
- Dawit Alemayehu
On March 2, 2014, 12:12 a.m., Dawit Alemayehu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://g
t;SIZE somefile" before
giving up. See bug report for details.
Diffs
-
kioslave/ftp/ftp.cpp 5bb2e8d
Diff: https://git.reviewboard.kde.org/r/116524/diff/
Testing
---
Installed Ftp server from bug report on an Android device and run tests.
Thanks,
Dawit Alemayehu
/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html
Thanks,
Dawit Alemayehu
://www.w3.org/People/Bos/Test/redirect307.html
Thanks,
Dawit Alemayehu
iff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
Thanks,
Dawit Alemayehu
. It ensures that the "fix" is only
applicable to webdav and the addition of the trailing slash is communicated to
the client application.
Diffs
-
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
Thanks,
Dawit Alemayehu
/httpredirects/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html
Thanks,
Dawit Alemayehu
kio/kio/job.h aeaffa2
kio/kio/job.cpp edc5fed
Diff: https://git.reviewboard.kde.org/r/116017/diff/
Testing
---
http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
Thanks,
Dawit Alemayehu
: https://git.reviewboard.kde.org/r/116073/diff/
Testing
---
Follow the steps outlined in the bug report to create a symlink to a file whose
path or name contains characters that are not allowed in a URL.
Thanks,
Dawit Alemayehu
is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017/#review50957
-------
On Feb. 26, 2014, 8:34 a.m., Dawit Alemayehu wrote:
>
> ---
&g
/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/116073/diff/
Testing
---
Follow the steps outlined in the bug report to create a symlink to a file whose
path or name contains characters that are not allowed in a URL.
Thanks,
Dawit Alemayehu
proves all this :)
Great! Always fan of unit testing to prove stuff out. I will change the patch
to use QUrl(kurl).toString() then.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard
the bug report to create a symlink to a file whose
path or name contains characters that are not allowed in a URL.
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116048/#review50896
---
Ship it!
Ship It!
- Dawit Alemayehu
On Feb. 25, 2014, 4
/kio/job_p.h 5ead3ed
kioslave/http/http.cpp 9eba5d1
Diff: https://git.reviewboard.kde.org/r/116017/diff/
Testing
---
http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
Thanks,
Dawit Alemayehu
1 - 100 of 759 matches
Mail list logo
