Re: Question about QSslCipher::protocolString

2014-10-21 Thread Dawit A
tion was established using a cipher that was first defined under SSL/TLS protocol SSLv3. 2014-10-21 10:35 GMT-04:00 Thomas Lübking : > On Montag, 20. Oktober 2014 01:13:35 CEST, Thiago Macieira wrote: > >> On Sunday 19 October 2014 18:14:36 Thomas Lübking wrote: >> >>

Question about QSslCipher::protocolString

2014-10-19 Thread Dawit A
Both the protocol and protocolString methods in QSslCipher return a different value than what is expected. For example, in Qt 4.8 if you set the protocol in QSslSocket to QSsl::TlsV1 and connect to blog.mozilla.org port 443, you get the following output from QSslCipher: QSslSocket Information: ===

Re: Porting KUrl::prettyUrl: please do not reintroduce CVE-2013-2074!

2014-10-16 Thread Dawit A
I personally think QUrl should remove the password by default when converting to string and force caller of the API to explicitly request the inclusion of the password say by changing the modifier option to a QUrl::IncludePassword. It is better to be safer out of the box. On Thu, Oct 16, 2014 at 8

Re: Failing testcase in kpasswdservertest [kde-runtime]

2013-12-11 Thread Dawit A
Great. I will commit the patch once I get a chance then. Unless of course either you or Albert has already done so. On Wed, Dec 11, 2013 at 3:30 AM, Ben Cooksley wrote: > On Wed, Dec 11, 2013 at 2:52 PM, Dawit A wrote: > >> On Tue, Dec 10, 2013 at 1:45 PM, Albert Astals Cid wrot

Re: Failing testcase in kpasswdservertest [kde-runtime]

2013-12-10 Thread Dawit A
On Tue, Dec 10, 2013 at 1:45 PM, Albert Astals Cid wrote: > El Dimarts, 10 de desembre de 2013, a les 08:57:47, Dawit A va escriure: > > Sorry for the late response. I did not see this email for some reason. > None > > of the test cases in testRetryDialog hit that assert on

Re: Failing testcase in kpasswdservertest [kde-runtime]

2013-12-10 Thread Dawit A
Sorry for the late response. I did not see this email for some reason. None of the test cases in testRetryDialog hit that assert on my machine. If this unit test fails on your system, can you please enable the debug area for KPasswdServer, run the unit test only for testRetryDialog only and provide

Re: Broken tests in kdelibs due to kio change

2013-08-03 Thread Dawit A
2013, a les 13:39:40, Dawit A va escriure: > > OK. I see why those tests failed and I fixed them not to anymore. > Updating > > the clibpboard in KIO introduced a dependency on QtGui. > > Hence QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed > > to QTEST_KDEMAIN

Re: Broken tests in kdelibs due to kio change

2013-08-03 Thread Dawit A
difficult to split this into core/gui in frameworks? On Sat, Aug 3, 2013 at 1:16 PM, Dawit A wrote: > Hmm... I fail to see how my changes break those unit tests. Perhaps > changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to > look into it. > > > On Sat, Aug 3

Re: Broken tests in kdelibs due to kio change

2013-08-03 Thread Dawit A
Hmm... I fail to see how my changes break those unit tests. Perhaps changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to look into it. On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid wrote: > Dawit, kdelibs people, there are 4 tests that broke in > very-close-to-release >

Re: KIO / KWebView and PrivateBrowsing (Cookies)

2013-04-21 Thread Dawit A
gt; >> On 04/26/2012 05:17 PM, Alex Fiestas wrote: >> >>> On Wednesday, April 25, 2012 04:26:28 PM Dawit A wrote: >>> >>>> >>>> If you wait a litte while I am going to fix this issue once and for all >>>> since I want to add proper s

Re: rekonq 2 merged in rekonq main repository

2012-12-19 Thread Dawit A
> - you cannot no more store cookies (dawit just implemented this, I think) > - you cannot no more use old cookies stored (my first attempt here failed) > - you have to manage your session "session cookies" (that is, use in your > private session and delete them when it (and NO

Re: rekonq 2 merged in rekonq main repository

2012-12-18 Thread Dawit A
Well that is not entirely correct. We can definitely implement support for private mode in the cookiejar itself easily. There are a couple of approaches we can take. The difficult part has always been how to handle the "private session" cookies in the cookie management dialogs. Anyhow, I promised t

Re: Dependency Freeze for 4.10 in two weeks

2012-10-18 Thread Dawit A
Actually kde-baseapps master requires kdelibs 4.10 to work correctly. Otherwise, the new changes to the cookie settings dialog won't function properly. I posted a request asking to update the required dependency, but no one responded. See http://lists.kde.org/?l=kde-core-devel&m=134946200123794&w=2

kde-baseapps master requires kdelibs 4.10 branch

2012-10-05 Thread Dawit A
/r/106618/ https://git.reviewboard.kde.org/r/106619/ I want to change kde-baseapps' CMakeLists.txt to reflect that. Any objections ? Regards, Dawit A.

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-19 Thread Dawit A
On Wed, Sep 19, 2012 at 2:31 AM, Rolf Eike Beer wrote: > > * If all available sessions are unselected, > > presssing "Restore Session" button will behave like "Do not Restore". > > What about just disabling "Restore Session" then? > Well, I guess that can be done as well with a bit more code.

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-13 Thread Dawit A
On Thu, Sep 13, 2012 at 11:39 AM, Ralf Jung wrote: > Hi, > > > First, sorry I confused kdelibs with kde-baseapps in this response. So > > forget what I said about changes being merged back into 4.10 branch by > > David. Anyhow, I have now attempted to fix this issue as reported here. > See > > >

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-12 Thread Dawit A
On Wed, Sep 12, 2012 at 2:50 PM, Allen Winter wrote: > On Wednesday 12 September 2012 08:12:58 PM Thomas Lübking wrote: > > Am 12.09.2012, 20:04 Uhr, schrieb Dawit A : > > > > > Qt's moc processor does not > > > seem to correctly handle #if macros. >

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-12 Thread Dawit A
On Tue, Sep 11, 2012 at 9:05 AM, Dawit A wrote: > > > On Tue, Sep 11, 2012 at 6:22 AM, Ben Cooksley wrote: > >> Hi Dawit, >> >> It has come to my attention that since commit >> 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the >> bu

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Dawit A
On Tue, Sep 11, 2012 at 10:08 AM, Albert Astals Cid wrote: > El Dimarts, 11 de setembre de 2012, a les 09:51:22, Dawit A va escriure: > > On Tue, Sep 11, 2012 at 6:27 AM, Albert Astals Cid > wrote: > > > It seems that the > > > > > > set(KDE_MIN_

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Dawit A
On Tue, Sep 11, 2012 at 6:27 AM, Albert Astals Cid wrote: > It seems that the > > set(KDE_MIN_VERSION "4.7.97") > Was that done intentionally or was it forgotten to be updated for the KDE 4.9 release ? If the former, then have we now started guaranteeing forward compatibility too ? > > that kd

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-11 Thread Dawit A
On Tue, Sep 11, 2012 at 6:22 AM, Ben Cooksley wrote: > Hi Dawit, > > It has come to my attention that since commit > 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the > build for it has been broken. > This is due to it depending on new features, present only in the KDE/4.9 > br

Re: Default file manager and folder associations

2012-06-18 Thread Dawit A
I doubt changing the text would make much more difference. People will simply read what they want to read and ignore everything else just as in warning/message dialog boxes! After all the current option itself says "Remember application associations for this file type" not for this specific file or

Re: kdelibs and Qt version dependency

2012-06-06 Thread Dawit A
On Wed, Jun 6, 2012 at 2:32 PM, Albert Astals Cid wrote: > El Dimecres, 6 de juny de 2012, a les 20:23:48, Laszlo Papp va escriure: > > > Do you have a link for that discussion? > > > > http://lists.kde.org/?l=kde-core-devel&m=132630064116231&w=2 > > That was in January though, people change thei

Re: kdelibs and Qt version dependency

2012-06-05 Thread Dawit A
It is a simple matter to put a #ifdef around the code that does not compile with Qt 4.7. I wish this issue was raised when the code was up for review for more than a month or the Qt documentation mentioned something about those functions only being available in Qt 4.8. Anyhow, I have attached a pa

Re: kio and frameworks 5

2012-05-19 Thread Dawit A
On Fri, May 18, 2012 at 11:31 PM, Ben Martin wrote: > I'm wondering if there is a timeframe for KIO refresh in KDE5? > > Getting improved metadata handling in there would be a great benefit > IMHO. To the point where I might start attaching patches to that > effect ;) > What does improved meta-d

Re: Re: Re: Re: KIO / KWebView and PrivateBrowsing (Cookies)

2012-04-25 Thread Dawit A
On Wed, Apr 25, 2012 at 1:05 PM, Alex Fiestas wrote: > On Wednesday, April 25, 2012 10:23:27 AM Dawit A wrote: > > On Tue, Apr 24, 2012 at 8:13 AM, Alex Fiestas wrote: > > > After reading the patch and understanding a little bit more how this > work > > >

Re: Re: Re: KIO / KWebView and PrivateBrowsing (Cookies)

2012-04-25 Thread Dawit A
checked Chromium) requires a little bit more involved fix. We would need to use the cookiejar and that means we need a way to mark such cookies as private to the cookiejar. The trick is to do that without having to modify any of the KDE cookiejar code. I will see what I can do about that... Regards, Dawit A.

Re: KIO / KWebView and PrivateBrowsing (Cookies)

2012-04-23 Thread Dawit A
On Mon, Apr 23, 2012 at 1:12 PM, Alex Fiestas wrote: > KWebView can't do Private Browsing because of KIO integration, need advice > on > how to fix it but first let me explain the issue. > > What I consider PrivateBrowsing: > Private Browsing should have an empty CookieJar that will keep cookies

Re: Integration QWebView with KDE

2012-04-23 Thread Dawit A
On Mon, Apr 23, 2012 at 1:20 PM, Alex Fiestas wrote: > I'm having some issues with KWebView + Cookies + PrivateBrowsing > http://lists.kde.org/?l=kde-core-devel&m=133520146629307&w=2 > > and I need to workaround that issues at least until we fix them. > Ahh... why have another post about a same

Re: Bugzilla upgrade.

2012-03-14 Thread Dawit A
Am I the only one that finds the new KDE bugzilla front end utterly confusing ? All the conveient shortcuts in the front page that showed things like weekly summary broken down by product are no longer available. Will those things available in the old front page be restored in the future or are the

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-02-01 Thread Dawit A
On Mon, Jan 30, 2012 at 4:48 AM, Thiago Macieira wrote: > On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: >> > Diffs >> > - >> > >> >   kio/bookmarks/kbookmarkmanager.cc d8a9cb7 >> >   kio/kio/fileundomanager.cpp f580c29 >> >   kio/kio/scheduler.cpp 6b36d9d >> > >> > Diff: http

Re: KDE Frameworks 5: Rhythm

2012-01-24 Thread Dawit A
On Sun, Jan 22, 2012 at 7:18 PM, Thiago Macieira wrote: > On Saturday, 21 de January de 2012 16.17.38, Stephen Kelly wrote: >> * Thiagos stuff - I don't know. > > Thiago's stuff is: > > - new atomics (wasn't a KDE request): done, just waiting for integration > because of stupid stuff like the copy

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

2012-01-02 Thread Dawit A
have not wasted my time attempting to fix this bug. On the other hand not addressing this bug because it adds a new API in KTcpSocket means that the issue would linger for at least another year and even then it will only be addressed if someone remembers to address it. We still have few SSL related regressions from KDE 3 that have not yet been resolved in KDE 4 to this day. Oh well... Regards, Dawit A.

Re: This starts to become a dangerous path (Was: New Feature for kdelibs)

2011-11-16 Thread Dawit A
On Wed, Nov 16, 2011 at 11:31 AM, Aaron J. Seigo wrote: > the best way to "deal with it" is not to consider it a fork of kdelibs but > the next version of kdelibs (that's what it is) and help out with it :) > > another way of putting is: please don't fighting your own teammates (the > ones, in thi

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

2011-11-08 Thread Dawit A
On Tue, Nov 8, 2011 at 11:18 AM, Aaron J. Seigo wrote: > On Monday, November 7, 2011 19:32:15 Dawit A wrote: >> >> Well this is over a month too late, but I have a enhancement change >> >> for kcookiejar that needs to go into kdelibs/kioslave for KDE 4.8. The >> &

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

2011-11-07 Thread Dawit A
On Mon, Nov 7, 2011 at 5:09 PM, Allen Winter wrote: > On Monday 07 November 2011 10:18:15 AM Dawit A wrote: >> On Fri, Sep 30, 2011 at 9:54 AM, David Faure wrote: >> > On Thursday 29 September 2011 20:01:00 Kevin Kofler wrote: >> >> But one of my points is that

Re: The case for a kdelibs 4.8

2011-11-07 Thread Dawit A
On Fri, Sep 30, 2011 at 9:54 AM, David Faure wrote: > On Thursday 29 September 2011 20:01:00 Kevin Kofler wrote: >> But one of my points is that we need features too, not just bugfixes. >> Continuing 4.7.x releases solves the problem of bugfixes just fine, but >> entirely fails to address the issu

Re: -Wunused-but-set-variable warnings

2011-08-26 Thread Dawit A
On Fri, Aug 26, 2011 at 11:25 AM, David Faure wrote: > On Monday 04 July 2011 12:02:47 Dawit A wrote: >> The following files all contain set but unused variables: >> >> kdelibs/kdecore/io/kar.cpp:109:19: warning: variable ‘uid’ set but not >> used [-Wunused-but-set-vari

Re: Where is kmix hidden?

2011-08-19 Thread Dawit A
kmultimedia and hence kmix are still in svn and have not been moved over to git ; so you have to look there instead. See http://websvn.kde.org/trunk/KDE/kdemultimedia/ On Fri, Aug 19, 2011 at 8:40 AM, Mark wrote: > Hi, > > In git i can only find some kmix scratch repos, but it seems nowhere > to

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Dawit A
On Mon, Aug 8, 2011 at 3:56 PM, Thomas Zander wrote: > On Monday 08 August 2011 21.28.45 Dawit A wrote: >> On Mon, Aug 8, 2011 at 3:20 PM, Thomas Zander wrote: >> > On Monday 08 August 2011 21.02.02 Dawit A wrote: >> >> On Mon, Aug 8, 2011 at 2:31 PM, Thomas Zande

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Dawit A
On Mon, Aug 8, 2011 at 3:20 PM, Thomas Zander wrote: > On Monday 08 August 2011 21.02.02 Dawit A wrote: >> On Mon, Aug 8, 2011 at 2:31 PM, Thomas Zander wrote: >> > On Monday 08 August 2011 18.35.13 Dawit A wrote: >> >> #2. The original functions in this class

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Dawit A
On Mon, Aug 8, 2011 at 2:31 PM, Thomas Zander wrote: > On Monday 08 August 2011 18.35.13 Dawit A wrote: >> #2. The original functions in this class were non-blocking. It is only >> the new function I added that is a blocking call. And that is required >> because of the ne

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Dawit A
On Mon, Aug 8, 2011 at 11:25 AM, Thiago Macieira wrote: > On Monday, 8 de August de 2011 14:25:13 David Faure wrote: >> And since I just fixed the crash (missing wait() after terminate(), see >> commit log), I don't think we need this change. However reusing threads >> might be a good idea (separa

Review Request: Do not terminate threads

2011-08-06 Thread Dawit A
On Sat, Aug 6, 2011 at 7:46 AM, Albert Astals Cid wrote: > On Dijous 04 Agost 2011 15:28:49 Dawit A wrote: >> On Thu, Aug 4, 2011 at 5:31 AM, Albert Astals Cid wrote: >> >    This is an automatically generated e-mail. To reply, visit: >> > http://git.reviewboard.kde

Re: Review Request: Do not terminate threads

2011-08-04 Thread Dawit A
On Thu, Aug 4, 2011 at 9:11 AM, Thiago Macieira wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102179/ > > Ok, then there's something wrong. QHostInfo has had a blocking method since > Qt 4.0. > > Thiago, you must have forgotten but you

Re: Review Request: Do not terminate threads

2011-08-04 Thread Dawit A
On Thu, Aug 4, 2011 at 5:31 AM, Albert Astals Cid wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102179/ > > On August 4th, 2011, 3:19 a.m., *Dawit Alemayehu* wrote: > > I do not like this patch for the very reason you stated. I do not w

Re: cpp includes in http ioslave

2011-07-17 Thread Dawit A
o needed to kept in sync if anyone goes and > touches this. So putting the tests into the http directory would allow the > tests to simply use the same settings that kio_http uses. This makes sense to me too, but please wait until I commit my changes. Regards, Dawit A.

Re: Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

2011-07-11 Thread Dawit A
On Wed, Jun 15, 2011 at 6:03 AM, Sebastian Kügler wrote: > On Friday, June 03, 2011 20:53:43 Dawit A wrote: >> Do you have any plans for pushing this into git master/KDE 4.6 branch >> ? Either your patch or mine needs to make it into KDE 4.7. > > I'd prefer Dawit's

Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Dawit A
On Mon, Jul 4, 2011 at 2:07 PM, Albert Astals Cid wrote: > A Monday, July 04, 2011, Dawit A va escriure: > >> The following files all contain set but unused variables: > >> > >> snip > >> > >> Unlike the -Wunused-parameter fixing this warning mes

Re: -Wunused-but-set-variable warnings

2011-07-04 Thread Dawit A
On Mon, Jul 4, 2011 at 5:05 PM, Matthias Fuchs wrote: > Am Montag 04 Juli 2011, 20:07:20 schrieb Albert Astals Cid: >> A Monday, July 04, 2011, Dawit A va escriure: >> > The following files all contain set but unused variables: >> > >> > snip >> > &

-Wunused-but-set-variable warnings

2011-07-04 Thread Dawit A
The following files all contain set but unused variables: kdelibs/kdecore/io/kar.cpp:109:19: warning: variable ‘uid’ set but not used [-Wunused-but-set-variable] kdelibs/kdecore/io/kar.cpp:109:24: warning: variable ‘gid’ set but not used [-Wunused-but-set-variable] kdelibs/kdecore/util/kshareddat

Re: kdewebkit compilation fails for Mobile profile in trunk

2011-06-22 Thread Dawit A
On Wed, Jun 22, 2011 at 3:36 PM, David Faure wrote: > On Sunday 22 May 2011, Kevin Ottens wrote: >> Well, I proposed a workaround in january already, and somehow it got >> forgotten  along the way, reattaching it here for reference. If that fixes >> the issue for you guys, I think we really should

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread Dawit A
On Tue, Jun 21, 2011 at 2:23 PM, David Faure wrote: >This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6681/ > > OK for url() then. > > Re the code above, you're probably right, it wasn't tested with > Ctrl+Shift+Tab, only with Ctrl+Tab. > > >

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread Dawit A
There is one particular issue with this patch. When you first start konqueror, the introduction page is shown with a blank location bar. If you then simply press escape in location bar, the location bar switches to "about:konqueror" because that is the url of the current view. Perhaps the patch nee

Re: SSL in KDE going forward

2011-06-08 Thread Dawit A
Would asking for client certficate authentication support be out of the scope or does Qt's SSL already support that ? Last I checked it did not and there is a pending but report about this against kio_http. See https://bugs.kde.org/show_bug.cgi?id=167668. On Wed, Jun 8, 2011 at 4:12 PM, Richard Mo

Re: Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

2011-06-03 Thread Dawit A
Hello Maksim, Do you have any plans for pushing this into git master/KDE 4.6 branch ? Either your patch or mine needs to make it into KDE 4.7. On Sat, May 28, 2011 at 11:02 AM, Maksim Orlovich wrote: > Or you could just do this 1-line + comments change: > commit 4c65ecb9fb5ca6aba393189a818e2cfcb

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Dawit A
Isn't this problem easily solvable by changing those slots defined in Q_PRIVATE_SLOT to actual private slots of KIO::Scheduler and forwarding the call to the existing code ? See attached patch. On Wed, Jun 1, 2011 at 10:47 AM, Jeremy Whiting wrote: > Until those that know the code get this issue

Re: Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

2011-05-31 Thread Dawit A
Maksim, Did you push this commit ? I guess this is from your own local commit because I do not see the change after an update. Anyhow, please include BUG: 252818 when you decide to push this fix. I have withdrawn my review request since this is a much smaller change and quicker fix. On Sat, May

Re: kdewebkit compilation fails for Mobile profile in trunk

2011-05-21 Thread Dawit A
On Sat, May 21, 2011 at 5:50 PM, Andreas Pakulat wrote: > On 21.05.11 13:25:32, Dawit A wrote: >> No that is a moc issue. The code is properly @ifdef'ed out in the >> code, but the generated moc file does not seem to exclude it. That is >> why you get the message: >&g

Re: solid/networking.h: No such file or directory

2011-05-21 Thread Dawit A
Fixed. On Sat, May 21, 2011 at 1:29 PM, Dawit A wrote: > Does compiling with that profile exclude Solid ? If so, then that is > the problem. Otherwise, the solid includes should be there... > > On Sat, May 21, 2011 at 12:37 PM, Andriy Rysin wrote: >> pulled from git seconds a

Re: solid/networking.h: No such file or directory

2011-05-21 Thread Dawit A
Does compiling with that profile exclude Solid ? If so, then that is the problem. Otherwise, the solid includes should be there... On Sat, May 21, 2011 at 12:37 PM, Andriy Rysin wrote: > pulled from git seconds ago, compiled  with Profile=Mobile > > [ 62%] Building CXX object > kio/misc/kpac/CMak

Re: kdewebkit compilation fails for Mobile profile in trunk

2011-05-21 Thread Dawit A
ATED >    KDE_DEPRECATED void selectionClipboardUrlPasted(const KUrl &url); > #endif > > > On 05/21/2011 11:04 AM, Dawit A wrote: >> >> Those classes have not changed from KDE 4.6. Most likely you need to >> do a clean build. At lease a clean kdewebkit build. >> >> On Sat

Re: kdewebkit compilation fails for Mobile profile in trunk

2011-05-21 Thread Dawit A
Those classes have not changed from KDE 4.6. Most likely you need to do a clean build. At lease a clean kdewebkit build. On Sat, May 21, 2011 at 10:59 AM, Andriy Rysin wrote: > > In file included from > /home/arysin/work/OSS/KDE/kdelibs/kdewebkit/kgraphicswebview.cpp:85:0: > /home/arysin/kde/buil

Fwd: [4.7 Beta1 blocker] KIO Broken.

2011-05-21 Thread Dawit A
On Sat, May 21, 2011 at 7:46 AM, Tom Albers wrote: > Hi, > > According to http://bugs.kde.org/273783 KIO is broken. Although this could be > introduced after Dirks tag, but that would mean someone broke the tag freeze. > > Can someone confirm and find a solution ASAP? The offending commit, which

Re: Review Request: Ark doesn't recognize zip files from websites when using KHTML

2011-05-20 Thread Dawit A
t;> > KParts::BrowserRun. > > Maybe this is also why using kdewebkit in konqueror is broken when clicking on > any link to a pdf/od*/whatever non-html file? Nope. This only affects khtml. No such problems should exist in kdewebkit. What exactly happens for you when you click on a pdf/od*/ or any other non-html file ? The only bug that existed in kdewebkit was the generic "Open With..." option was never handled, but that has now been fixed. Regards, Dawit A.

Re: Upcoming freezes KDE 4.7

2011-05-10 Thread Dawit A
t;GUI:" and also sending a message about the changes to the appropriate list. >> On Tuesday, May 10, 2011 01:49:01 pm Dawit A wrote: >> > The KDE 4.7 Hard Freeze date is still a couple of days away, but I am >> > going to ask for an exception. I have pending UI changes for

Re: Upcoming freezes KDE 4.7

2011-05-10 Thread Dawit A
The KDE 4.7 Hard Freeze date is still a couple of days away, but I am going to ask for an exception. I have pending UI changes for the proxy configuration dialog that will not make that date and it cannot be pushed until 4.8. This item is already on the features list, but I get held up fixing rathe

Re: Changing the defaults for HTTP ACCEPT, ACCEPT-LANGUAGE and USERAGENT headers

2011-05-08 Thread Dawit A
id. > 3) It would be incorrect to add xhtml accepts to khtml's accept-type. > XHTML parsing is buggy, and isn't really worth prioritizing fixing (on > accounts on basically no-one using it) Ok. This would be left alone too then. Regards, Dawit A.

Changing the defaults for HTTP ACCEPT, ACCEPT-LANGUAGE and USERAGENT headers

2011-05-08 Thread Dawit A
anguage header duplicates the utf8 entry by appending the default onto whatever the application specified. The fix is to change the code to not do that. Instead it will simply append the default *;q=0.5 if it is missing from the charset value defined by the application. Input, suggestion, objections are welcome... Regards, Dawit A.

Re: konqueror, "embedded text editor" and my future research

2011-05-06 Thread Dawit A
This has already been discussed before. See https://bugs.kde.org/show_bug.cgi?id=259338 http://lists.kde.org/?t=13029066215&r=1&w=2 http://lists.kde.org/?t=13028914564&r=1&w=2 On Fri, May 6, 2011 at 9:38 AM, Mehmet Topsakal wrote: > I'm a PhD student from Turkey working on computational

Re: Review Request: Fix for a couple of KIO put-slave-on-hold bugs

2011-04-28 Thread Dawit A
before you continue. I know it's not really "your" > bug, but it's probably not really "mine" either. > Contact me if you'd prefer me to have a look. I am trying not to spend much > time on coding right now so I can spend more time on university stuff. Well, since my original patch was reverted, if you never got the above message before my changes then you should not get them now either ; due to the revert of course. Anyhow, the process of putting the ioslave on hold first kills the job and most importantly emits a slaveDied signal ; so I do not understand why the job accounting stuff would be affected any differently than the standard normal way a slave finishes its job and ceases to exist. Regards, Dawit A.

Why KIO's put-ioslave-on-hold feature sometimes does not work...

2011-04-19 Thread Dawit A
As can be seen with my recent commit [1] that reverted my own previous patch, I recently spent sometime trying to find out how KIO's ioslave-on-hold feature was originally designed to work and more importantly why it reliably fails in certain situations. Here is what I found out: #1. The ioslave-o

Re: Review Request: Using KWallet to store Cookies

2011-04-19 Thread Dawit A
On Tue, Apr 19, 2011 at 11:55 AM, todd rme wrote: > On Tue, Apr 19, 2011 at 7:40 AM, Leo Savernik wrote: >> Am Freitag, 21. Januar 2011 schrieb José Millán Soto: >>> Currently cookies are stored in a plain text file. This patch allows >>> KCookieJar to store the cookies securely using KWallet. >>

Re: Review Request: Using KWallet to store Cookies

2011-04-18 Thread Dawit A
Would you be able to create a new request in git.reviewboard.kde.org for this so that it won't fall through the cracks ? Perhaps there is still a chance for this making the KDE 4.7 release. The only reservation I have is the ability to unit test things when cookies are stored in the kwallet. Have y

Re: Review Request: GUI configuration for the 'Do Not Track'?feature...

2011-04-17 Thread Dawit A
On Sun, Apr 17, 2011 at 5:43 AM, Oswald Buddenhagen wrote: > On Sat, Apr 16, 2011 at 03:52:39PM -0400, Dawit Alemayehu wrote: >> First, the idea that DNT affects most sites lively hood is something >> that has already been dispelled. For most sites, there is no reason to >> track your browsing hab

Re: Review Request: GUI configuration for the 'Do Not Track'?feature...

2011-04-16 Thread Dawit A
hey get bitten by it. Hence, the more reason why software should strive more to do right by them as much as possible. > fwiw, the firefox 4 default is opt-in. and for some reason the setting > isn't even under "privacy", but under "advanced". They will change it soon enough. For the life of me, I cannot imagine of a single person that would voluntarily opt-in to be tracked online. They have to be completely ignorant about the matter or threatened with lack of access to capitulate on this issue. Regards, Dawit A.

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-15 Thread Dawit A
o the draft spec secion 8.3, no header present is an OPT-IN. However, since we always send "DNT:1" or OPT-OUT by default, this should not be an issue. A user can then uncheck the box to OPT-IN (DNT:0) if they so desire. And since not sending the header is the same as "DNT:0", then there is no reason why we should not explicitly include it in the header sent to the server. Regards, Dawit A.

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-15 Thread Dawit A
ou advocate here. Look at the anti-virus business as an example. It is a constant arms race. Anyhow, if adding this feature means just few sites will leave you along because they honor the header name, then personally I think it is worth the minuscule effort it requires to implement it. Regards, Dawit A.

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-15 Thread Dawit A
does not have to do anything! If on the other hand the user does not mind being tracked, then they can uncheck, or if we change the label of the checkbox, check the option to send "DNT:0". That is exactly what firefox does. I do not know what is so confusing about this. I would be the last person to turn on privacy invading functionality by default! Regards, Dawit A.

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-15 Thread Dawit A
On Thu, Apr 14, 2011 at 6:26 PM, Maksim Orlovich wrote: > Ah, I misread the default. But still, I don't think we want to send > DNT:0 if the user unchecks the checkbox, given how the label is worded > -- IMHO we wouldn't want to send the header at all. That makes no sense especially since not sen

Re: Review Request: GUI configuration for the 'Do Not Track' feature...

2011-04-14 Thread Dawit A
On Thu, Apr 14, 2011 at 12:42 PM, Maksim Orlovich wrote: > Very cool. But re: original change. Are you sure we want to be sending > the opt-in header by default? No. We are sending the opt-out header by default. The "DNT: 1" which will be sent, when the "DoNotTrack" is set to "true" (the default)

Behavior of SlaveBase::openPasswordDialog...

2011-04-13 Thread Dawit A
walletmanager! *sigh* Regards, Dawit A.

Preservation of the original url username on redirections in KIO

2011-04-13 Thread Dawit A
I cannot find the reason why we wanted to added code to preserve user name on redirection in KIO::Job some 9 years ago [1], but to me it seems to be an easy fix / workaround for the failings of ioslaves that do not properly preserve user name when they request redirections. Unfortunately this gets

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-04-13 Thread Dawit A
On Wed, Apr 13, 2011 at 4:10 AM, Thiago Macieira wrote: > I can't reproduce the crash anymore. > > I'm getting a different error with Qt 4.8. I still get the crash on exit using Qt 4.7.2, KDE 4.6.41 (lastest master) and VLC v1.1.9 by following the steps outlined in the following bug report: https

Re: Bug #115487 - automatic proxy discovery problems

2011-03-26 Thread Dawit A
It has been a long while since this discussion, but would anyone be interested in testing changes I made to kpac_dhcp_helper.c ?? I now have a version that uses getifaddrs instead of gethostname()+gethostbyname(). On Sat, Jun 5, 2010 at 11:54 AM, Dawit A wrote: > On Thursday, June 03, 2010 21

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-03-26 Thread Dawit A
On Sat, Feb 5, 2011 at 2:46 PM, Thiago Macieira wrote: > On Saturday, 5 de February de 2011 14:15:03 Dawit A wrote: >> On Sat, Feb 5, 2011 at 12:57 PM, Thiago Macieira wrote: >> > On Saturday, 5 de February de 2011 17:39:35 Dawit Alemayehu wrote: >> >> was that in

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit A
On Wed, Mar 9, 2011 at 6:32 PM, Andreas Hartmetz wrote: > On Wednesday 09 March 2011 23:43:23 Dawit A wrote: [snipped] >> Yes, it is, but not for those reasons. That entry was not put there >> simply because we had an HTTP proxy implementation, but because FTP >> requests can

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit A
On Wed, Mar 9, 2011 at 2:53 PM, Andreas Hartmetz wrote: > On Wednesday 09 March 2011 20:06:40 Dawit A wrote: >> On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: >> > On Wednesday 09 March 2011, Dawit Alemayehu wrote: >> >> proxiedBy always returns true since ftp

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit A
ow, if the incorrect commit mentioned above gets reverted, the problem away. Any objections with me doing that ? Regards, Dawit A.

Re: A Qt replacement for KGlobal::ref and deref

2011-02-09 Thread Dawit A
On Wed, Feb 9, 2011 at 3:29 PM, Stephen Kelly wrote: > Christoph Feck wrote: > >> On Wednesday 09 February 2011 21:01:09 Stephen Kelly wrote: >>> KJob would be a Qt only library >> >> ? KJob is not a library, but a class in kdecore. > > I should have been more clear I guess. When I wrote kjob ther

Re: Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-06 Thread Dawit A
erstood your entire suggestion. On the other hand I think I get the KUrl parameter idea if it meant that the client app will have to create the encoded data to POST/PUT to the remove server, e.g. a temporary file, and provides that URL to the job. The key word here being that it must do the necessary encoding itself even when the request is to simply upload a bunch of files to a server. Was that the idea ? If so, I do not see why that could not be done in addition to these two new APIs either. Regards, Dawit A.

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-02-05 Thread Dawit A
On Sat, Feb 5, 2011 at 12:57 PM, Thiago Macieira wrote: > On Saturday, 5 de February de 2011 17:39:35 Dawit Alemayehu wrote: >> was that in both cases the backtrace shows QtDBus attempting to invoke or >> access some method or slot in the object that was just destroyed. At this > > That's supposed

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit A
On Fri, Feb 4, 2011 at 5:00 PM, Thiago Macieira wrote: > On Friday, 4 de February de 2011 16:35:32 Dawit A wrote: >> Let us take out terminate from the equation. It is my mistake I >> included it here because its documentation states that "The process >> may not exit a

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit A
On Fri, Feb 4, 2011 at 3:32 PM, Thiago Macieira wrote: > On Friday, 4 de February de 2011 14:06:58 Dawit A wrote: >> BTW, there is one side issue I noticed in QProcess through this whole >> process. Why does QProcess not exit immediately if I invoke kill or >> terminate or ev

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit A
On Fri, Feb 4, 2011 at 11:41 AM, Thiago Macieira wrote: > Em sexta-feira, 4 de fevereiro de 2011, às 05:24:26, Dawit A escreveu: >> > In the meantime, I've been discussing with Rémi about the issue and he's >> > not budging from his position that libraries shoul &

Re: Merge or Cherry-Pick?

2011-02-04 Thread Dawit A
Can somone please clarify the proper rule to follow for committing bug fixes as it relates to the KDE 4.6 branch ? The conclusion from the discussion here is rather confusing as to what should be done going forward. Should we still commit new bug fixes to the 4.6 branch first and merge into master

Re: Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-04 Thread Dawit A
the ioslave. However, besides having the same downfall as the first solution this one is also rather inefficient when posting small content, which is the majority use case. Regards, Dawit A.

Re: Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-04 Thread Dawit A
Ahh... I think you misunderstood the purpose of the patch or rather the title of this review. The new APIs simply overload the existing http post APIs such that the data you are going to post is sent through a QIODevice (QFile or QBuffer) rather than a QByteArray. To be clear here is the new overlo

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit A
On Fri, Feb 4, 2011 at 2:46 AM, Thiago Macieira wrote: > On Thursday, 3 de February de 2011 22:44:56 Dawit Alemayehu wrote: >> The attached patch is a workaround to the much discussed issue with VLC >> hanging when opening a KDE file dialog. For the details about the causes of >> this bug, see htt

Re: Initial support for kde_projects.xml in kdesrc-build

2011-02-03 Thread Dawit A
On Thu, Feb 3, 2011 at 6:29 PM, David Faure wrote: > On Wednesday 02 February 2011, Dawit A wrote: >> There never was any >> dependency, neither compile time nor run time, between kdebase and >> kwebkitpart. Never! > > Wrong. > kttsplugin was testing for kweb

  1   2   >