Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread David Narváez
/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread David Narváez
o_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez

Review Request 122471: Enable Compilation of about Protocol

2015-02-07 Thread David Narváez
/david/kio-install/ -name "*about*" /home/david/kio-install/lib64/plugins/kio_about.so /home/david/kio-install/share/kservices5/about.protocol Thanks, David Narváez

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-07 Thread David Narváez
it&h=a5d223221e802b057833e780cdca7cca65c06b52 - David Narváez On Feb. 7, 2015, 8:56 p.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewbo

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-07 Thread David Narváez
39e8de5 Diff: https://git.reviewboard.kde.org/r/122341/diff/ Testing --- Only tested compilation. Thanks, David Narváez

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-06 Thread David Narváez
) - thumbnail/thumbnail.cpp 39e8de5 Diff: https://git.reviewboard.kde.org/r/122341/diff/ Testing --- Only tested compilation. Thanks, David Narváez

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-05 Thread David Narváez
features in KFileMetadata? Diffs (updated) - thumbnail/thumbnail.cpp 39e8de5 Diff: https://git.reviewboard.kde.org/r/122341/diff/ Testing --- Only tested compilation. Thanks, David Narváez

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-05 Thread David Narváez
The first arg is a mimetype, therefore you need KMimeTypeTrader. > > > > It compiles with KServiceTypeTrader by stuffing the mimetype into > > "const QString& serviceType" and by stuffing the servicetype into "const > > QString &constraint"... &g

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-02 Thread David Narváez
into "const > > QString &constraint"... So how do you do this in KF5? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75090 --- On Jan. 31, 2015, 11:07

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-01-31 Thread David Narváez
/thumbnail.cpp 39e8de5 Diff: https://git.reviewboard.kde.org/r/122341/diff/ Testing --- Only tested compilation. Thanks, David Narváez

Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-01-31 Thread David Narváez
compilation. Thanks, David Narváez

Re: Review Request 114615: Fix Build of kwalletd Without QGPGME

2013-12-23 Thread David Narváez
. Thanks, David Narváez

Review Request 114615: Fix Build of kwalletd Without QGPGME

2013-12-23 Thread David Narváez
/kwalletwizard.cpp e97057c Diff: https://git.reviewboard.kde.org/r/114615/diff/ Testing --- 1. Removed kdepimlibs and built kwalletd Before this patch, build would fail. After this patch build succeeds. Thanks, David Narváez

Re: Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread David Narváez
for kwallet Before this patch, CMake would fail to find package KConfigCore Thanks, David Narváez

Re: Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread David Narváez
I fixed my other reviews accordingly. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113644/#review43056 -----------

Review Request 113643: Fix Standalone Configuration for KJobWidgets

2013-11-05 Thread David Narváez
build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Narváez

Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread David Narváez
Description --- Fix name of package to find. Diffs - tier2/kwallet/CMakeLists.txt 8700907 Diff: http://git.reviewboard.kde.org/r/113644/diff/ Testing --- 1. Configure a standalone build for kwallet Before this patch, CMake would fail to find package KConfigCore Thanks, David

Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

2013-11-05 Thread David Narváez
x27;org.qtproject.QtDBus.QtTypeName.Out0' Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Thanks, David Narváez

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread David Narváez
/kmimetypetest.h c38b036 kdecore/tests/kmimetypetest.cpp da32e2c Diff: http://git.reviewboard.kde.org/r/111852/diff/ Testing --- Executed the same code posted in the bug report, here's the output: ("Name", "Comment", "Patterns", "Icon") QVariant(QString, "PNG image") Thanks, David Narváez

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread David Narváez
t; > > Diffs > - > > kdecore/services/kmimetype.cpp d748523 > kdecore/services/kmimetype_p.h 6ffee71 > kdecore/tests/kmimetypetest.h c38b036 > kdecore/tests/kmimetypetest.cpp da32e2c > > Diff: http://git.reviewboard.kde.org/r/111852/diff/ > > > Testing > --- > > Executed the same code posted in the bug report, here's the output: > > ("Name", "Comment", "Patterns", "Icon") > QVariant(QString, "PNG image") > > > Thanks, > > David Narváez > >

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-04 Thread David Narváez
/diff/ Testing --- Executed the same code posted in the bug report, here's the output: ("Name", "Comment", "Patterns", "Icon") QVariant(QString, "PNG image") Thanks, David Narváez

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-04 Thread David Narváez
ecore/tests/kmimetypetest.cpp da32e2c Diff: http://git.reviewboard.kde.org/r/111852/diff/ Testing --- Executed the same code posted in the bug report, here's the output: ("Name", "Comment", "Patterns", "Icon") QVariant(QString, "PNG image") Thanks, David Narváez

Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-03 Thread David Narváez
/show_bug.cgi?id=322578 Diffs - kdecore/services/kmimetype.cpp d748523 Diff: http://git.reviewboard.kde.org/r/111852/diff/ Testing --- Executed the same code posted in the bug report, here's the output: ("Name", "Comment", "Patterns", "Icon") QVa