Re: FileCopyrightText...

2024-01-29 Thread David Jarvie
ng to put money on the fact that 9/10 it is > more complete than whatever the license headers proclaim to be the > case. Although copyright only applies to non-trivial changes, so the actual set of copyright holders is likely to lie somewhere between the authors list in the headers and the full list provided from git commits. -- David Jarvie KAlarm author, KDE developer

Re: CI system maintainability

2019-03-28 Thread David Jarvie
ode as coding style I will wait that > someone > wants to review... I agree. Mandatory reviews might work if there is a team of active people working on a project, but if there is only one person with real knowledge of the code, or there is nobody else with much time to spare, who is going to do the review? It is likely to just sit waiting indefinitely. If getting code reviewed is too difficult, the developer may have to give up and abandon the project. Mandatory reviewing could only work if individual projects can decide whether to adopt it or not. -- David Jarvie KAlarm author, KDE developer http://www.astrojar.org.uk/kalarm

Re: Review Request 127629: Fix KDateTime::isValid() for ClockTime values

2016-05-05 Thread David Jarvie
marked as submitted. Review request for kdelibs. Changes --- Submitted with commit af320ed5599cb0737c0601e26126c39e64780de0 by David Jarvie to branch master. Bugs: 336738 https://bugs.kde.org/show_bug.cgi?id=336738 Repository: kdelibs4support Description --- KDateTime::isValid

Re: Review Request 127629: Fix KDateTime::isValid() for ClockTime values

2016-05-04 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127629/#review95193 --- Can I commit this? - David Jarvie On April 10, 2016, 6:43

Review Request 127629: Fix KDateTime::isValid() for ClockTime values

2016-04-10 Thread David Jarvie
/kdatetimetest.cpp a8e7749 src/kdecore/kdatetime.cpp c530db1 Diff: https://git.reviewboard.kde.org/r/127629/diff/ Testing --- Test added to kdatetimetest, all tests pass. Thanks, David Jarvie

Re: Replacement for KDateTime

2015-08-10 Thread David Jarvie
se theoretically country can split and each part change to > different timezone. I think you misunderstand what is meant by time zone as defined by iCalendar and as it is used in the other mails in this thread. It means the set of offsets from UTC used officially in a country or region and wh

Re: Replacement for KDateTime

2015-08-03 Thread David Jarvie
On Monday 03 Aug 2015 19:49:52 Thomas Lübking wrote: > On Sonntag, 2. August 2015 20:32:43 CEST, David Jarvie wrote: > > > Having a date-only attribute in KDateTime is very useful > > because it allows both date-time and date-only values to be > > encapsulated in a s

Re: Replacement for KDateTime

2015-08-03 Thread David Jarvie
On Monday 03 Aug 2015 18:22:28 you wrote: > 2015-08-03 17:33 GMT+03:00 David Jarvie : > > On Monday 03 Aug 2015 14:29:41 Dāvis Mosāns wrote: > > > >> 2015-08-03 15:26 GMT+03:00 David Jarvie : > > > >> > On Monday 03 Aug 2015 12:59:59 you wrote: > &g

Re: Replacement for KDateTime

2015-08-03 Thread David Jarvie
On Monday 03 Aug 2015 14:29:41 Dāvis Mosāns wrote: > 2015-08-03 15:26 GMT+03:00 David Jarvie : > > On Monday 03 Aug 2015 12:59:59 you wrote: > > > >> 2015-08-02 21:32 GMT+03:00 David Jarvie : > > > >> > > > > >> > Date-on

Re: Replacement for KDateTime

2015-08-03 Thread David Jarvie
On Monday 03 Aug 2015 12:59:59 you wrote: > 2015-08-02 21:32 GMT+03:00 David Jarvie : > > > > Date-only KDateTime instances are not only used for Event start/end > > timestamps. In KAlarm they are also used among other things for alarm snooze > > times (independently o

Re: Replacement for KDateTime

2015-08-02 Thread David Jarvie
For a date-only value, the time component of the QDateTime should be set to 00:00:00, to avoid the problem of what an invalid value indicates. -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm

Re: KDE Applications Versioning

2015-06-09 Thread David Jarvie
dealing with bug reports, to know the state of the program at the version in question. For maintainers who want to use some other scheme, that's also fine. The important thing is to leave the choice. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Alternative to QDateTime::isDateOnly ?

2015-04-29 Thread David Jarvie
e for date-only values - it is then possible to determine whether a date-time value falls within that date-only value. For example, 2015-02-27T00:30 in an Australian time zone is during 2015-02-26 for a European time zone; it is earlier than 2015-02-27 in a European time zone. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Another proposal for modernization of our infrastructure

2015-02-02 Thread David Jarvie
past to Qt, but since the current gerrit setup was introduced I've never even contemplated doing so because it looks too much effort to get to grips with. It's far too off-putting for occasional contributors. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: kdepimlibs Coverity Scan Report, Oct 14 2014

2014-10-16 Thread David Jarvie
s configurable in Coverity interface. You can invite people and > attribute role. > > Web interface is so far more powerful to use than CSV, and permit a > time gain to fix issues. The CSV version doesn't contain line numbers, so it's impossible to know what code some of the issues refer to. I seem to remember that the web interface doesn't have that problem. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: kdecore-ktimezonestest broken

2014-06-04 Thread David Jarvie
imezones fail tonight and hope to get it fixed. If I have time, I'll try looking at the ktimezonetests fail too, although it seems a relatively unimportant issue. Cheers, David. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-16 Thread David Jarvie
the apidox. Diffs - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-14 Thread David Jarvie
, David Jarvie

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-13 Thread David Jarvie
the apidox. Diffs (updated) - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie

Re: KF5: Parsing times with timezone abbreviations

2014-03-31 Thread David Jarvie
hey can't just be ignored for small countries, since they may contain a daylight savings time indication. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-03-21 Thread David Jarvie
. Diffs (updated) - kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-03-21 Thread David Jarvie
/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie

Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-03-21 Thread David Jarvie
://git.reviewboard.kde.org/r/116951/diff/ Testing --- Tested this scenario, and it now returns the error string. Thanks, David Jarvie

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-14 Thread David Jarvie
g/r/116784/#comment37258> Need to convert to UTC first, since it will produce the wrong value if it's in some random time zone: dt.toUtc().dateTime() - David Jarvie On March 13, 2014, 12:49 p.m., Dawit Alemayehu wrote: > > -

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-14 Thread David Jarvie
> On March 13, 2014, 5:30 p.m., David Jarvie wrote: > > The handling of return values from KDateTime::toTime_t() in the existing > > kio_http code is not correct, because the return value's type is implicitly > > cast to other types before being checked. For e

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-13 Thread David Jarvie
should be fixed instead of changing code elsewhere, since kio_http is unlikely to be the only module that will have trouble if that is happening. - David Jarvie On March 13, 2014, 12:49 p.m., Dawit Alemayehu wrote: > > --- > This

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-15 Thread David Jarvie
On Monday 15 Jul 2013 09:46:49 Aaron J. Seigo wrote: > On Friday, July 12, 2013 17:48:50 David Jarvie wrote: > > best of intentions) for old habits to take over and to accidentally use > > master again. This happened to me more than once. > > So how can we make that cleare

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-12 Thread David Jarvie
ur > users. Don't go away from processes that people learned to take for > granted unless there is a > VERY good reason. Especially if nothing breaks for those thinking the old > process is still valid. > > Example given: Build-tool failed to follow the repository switch

Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-10 Thread David Jarvie
h branch to use, without having to search through config files which you don't have a copy of, or past blogs. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.

2013-02-21 Thread David Jarvie
tually possible, I think it might be worth adding the following comment where the patch sets mLocalIdFile: If under BSD it is possible for /etc/localtime to be missing but created later, we should also watch for its creation. - David Jarvie On Feb. 3, 2013, 4:30 a.m., Kev

Re: What is the git workflow for kdelibs ?

2012-10-30 Thread David Jarvie
n't techbase be more appropriate? It's technical information, plus techbase is where other policies are kept. I must say that the split between community.kde.org and techbase.kde.org isn't very satisfactory because the boundaries are blurred, and it's easy to miss information i

Re: [PATCH] kdecore: Fix a bug in KDateTime utc offset string parsing.

2012-10-08 Thread David Jarvie
// Restore the original local time zone > if (originalZone.isEmpty()) > The patches look good to commit. However, can you please move the new tests in kdatetimetest.cpp to start at line 3740, before the existing group of tests for UTC offsets. This will keep related tests grouped together. -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread David Jarvie
> SC of existing API and only adding (and hopefully also keeping > existing behaviour). If someone runs with an older version of kdelibs, they should realise that that version may contain some bugs which are fixed in later versions. So if they build an up-to-date application against that kdelibs, it's at their own risk to some degree. But if it helps some developers to do their work, it is surely a good thing to provide (via #ifdef or whatever) backwards compatibility to applications. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Compiler version

2012-07-06 Thread David Jarvie
the distros to watch in this > case. > > Debian stable will not ship 4.10 in any form, and from my experience, people > who use debian on the desktop, and care about having latest kde packages, use > testing or sid. (myself included) Not in all cases - I use Debian stable (although I

Re: Proposed adjustments to our release cycles

2012-06-18 Thread David Jarvie
icult problem - it's already the case that a particular distro can sometimes produce a bug which doesn't occur on other distros, and which the developer using another distro can't reproduce and investigate. So from an application developer's point of view, the fewer vari

Re: Review Request: Define tooltips for kdeui standard actions

2012-05-13 Thread David Jarvie
essarily be understandable to a non-tech user in all circumstances, especially when it just refers to a block of text. - David Jarvie On May 13, 2012, 10:08 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-ma

Re: Package Dependcies List on Techbase

2012-05-08 Thread David Jarvie
On Tue, May 8, 2012 1:07 pm, Allen Winter wrote: >> On Tuesday 08 May 2012 6:55:01 AM David Jarvie wrote: >> On Mon, May 7, 2012 4:36 pm, Allen Winter wrote: >> > Howdy, >> > >> > I started putting the list of package dependences (arranged b

Re: Package Dependcies List on Techbase

2012-05-08 Thread David Jarvie
y other dependencies which are similarly marked as Required, when in fact they are optional? -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Review Request: Fix wrong time zone abbreviation being returned for early dates

2012-04-14 Thread David Jarvie
/date/ktimezone.cpp 076d459 kdecore/date/ktzfiletimezone.cpp 1ebca9d kdecore/tests/ktimezonestest.cpp 3a2402e Diff: http://git.reviewboard.kde.org/r/104599/diff/ Testing --- KTimeZone unit test now works after removing the temporary bodge put in because of this bug. Thanks, David

Re: RFC: i18n: drop KUIT tags in KDE Frameworks 5.0?

2012-03-23 Thread David Jarvie
On Thu, March 22, 2012 5:47 pm, Chusslove Illich wrote: >> [: David Jarvie :] >> I understand from your email that you are only proposing to remove KUIT >> semantic tags, not KUIT context markers. Can you confirm this? > > I confirm. They are used much more than tags,

Re: RFC: i18n: drop KUIT tags in KDE Frameworks 5.0?

2012-03-22 Thread David Jarvie
d have to do some manual > checking and modification in existing code.) I understand from your email that you are only proposing to remove KUIT semantic tags, not KUIT context markers. Can you confirm this? -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Bugzilla upgrade.

2012-03-15 Thread David Jarvie
nt on my small screen, > the new version fews snappier but the theme needs polishing > imo. I also renders the footer strange using Chrome, > but I hope someone is still working on this... :D Yes, the header fields waste a _lot_ of space. The old theme was far better in that respect.

Re: DrKonqi improvement idea

2012-03-12 Thread David Jarvie
he status of the bug is, even in a bug report containing long winded discussion or lots of duplicate reports. 2) It could be used when crash reporting, to provide the user-intelligible feedback which Niko is proposing. In this case, of course, there would need to be a link between any crashes.kde.org and bugs.kde.org. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Review Request: Limit KDateComboBox date keywords to the date range set for the widget

2012-03-08 Thread David Jarvie
discussed at the KDEPIM meeting. Diffs - kdeui/widgets/kdatecombobox.cpp 74b54f2 Diff: http://git.reviewboard.kde.org/r/104198/diff/ Testing --- Tested using KAlarm for minimum date of today or later. Thanks, David Jarvie

Re: hard-dep for Qt 4.8

2012-01-13 Thread David Jarvie
doesn't > release new versions for nothing. It's new, generally better, thus should > be used. And you are welcome to use it - no-one is suggesting that people shouldn't use Qt 4.8 if they choose to do so. However, this is not the issue - the issue is whether they should be _forced_ to use Qt 4.8. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Review Request: Fix KStatusNotifierItem not updating its icon when set by pixmap

2011-12-15 Thread David Jarvie
kdeui/notifications/kstatusnotifieritem.cpp aecb81c Diff: http://git.reviewboard.kde.org/r/103425/diff/diff Testing --- Tested switching setIconByPixmap()/setIconByName() in KAlarm. Thanks, David Jarvie

Re: Review Request: Fix KDateComboBox shrinking in size after a date is entered

2011-11-27 Thread David Jarvie
this patch on 30th November to meet the 4.7.4 deadline. - David Jarvie On Nov. 14, 2011, 10:58 p.m., David Jarvie wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Provide extra options for date keyword display in KDateComboBox

2011-11-21 Thread David Jarvie
-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103103/#review8351 ------- On Nov. 10, 2011, 12:36 a.m., David Jarvie wrote: > > ---

Re: Review Request: Provide extra options for date keyword display in KDateComboBox

2011-11-17 Thread David Jarvie
is essentially a bug fix, since without this the keyword facility is unusable for some applications. - David Jarvie On Nov. 10, 2011, 12:36 a.m., David Jarvie wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request: Fix KDateComboBox shrinking in size after a date is entered

2011-11-14 Thread David Jarvie
atecombobox.cpp fc239bc Diff: http://git.reviewboard.kde.org/r/103133/diff/diff Testing --- Tested successfully in KAlarm's alarm edit dialog. Thanks, David Jarvie

Review Request: Provide extra options for date keyword display in KDateComboBox

2011-11-09 Thread David Jarvie
diff Testing --- Tested in KAlarm. Thanks, David Jarvie

Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-10-28 Thread David Jarvie
ed API to 4.x, you have to do it with > > a new name, deprecating (but not removing!) toLocalFile. > > Let's just say I disagree. > > This change was for 4.7, but it was reverted and added to 4.8, giving you > well > over ONE YEAR to adapt. Only for those who knew ab

Re: The future of Power Management - together with Activities

2011-10-02 Thread David Jarvie
#x27;t manually select the presentation profile any more. I want to just click on a link in the browser I already have running, and select presentation mode, not restart the browser in another activity to view the video. Or perhaps I have misunderstood your proposal? -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-09 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/ --- (Updated Aug. 9, 2011, 8:39 a.m.) Review request for kdelibs. Changes --

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-08 Thread David Jarvie
only to display application modal instances just isn't acceptable in some cases. - David On Aug. 7, 2011, 3:18 p.m., David Jarvie wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-08 Thread David Jarvie
ard.kde.org/r/102246/#review5492 --- On Aug. 7, 2011, 3:18 p.m., David Jarvie wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102246/ > -

Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-07 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/ --- Review request for kdelibs. Summary --- According to the apidocs, KMe

Re: Formal complaint concerning the use of the name "System Settings"

2011-07-27 Thread David Jarvie
ll translations will be coordinated - sending an email round translators might help to fix things at the time, but what about future translations (e.g. for new languages) - how could you ensure that they would also be coordinated?) -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Formal complaint concerning the use of the name "System Settings" by GNOME

2011-07-26 Thread David Jarvie
On Mon, July 25, 2011 8:08 pm, Nicolas Alvarez wrote: > David Jarvie wrote: >> On Mon, July 25, 2011 12:50 pm, Ambroz Bizjak wrote: >>> Hi Mark, >>> have you seen my proposed improvement on your suggestion? >>> >>> http://lists.kde.org/?l=kde-core-devel

Re: Formal complaint concerning the use of the name "System Settings" by GNOME

2011-07-25 Thread David Jarvie
from. See http://lists.kde.org/?l=kde-core-devel&m=131159889604990&w=2. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Formal complaint concerning the use of the name "System Settings" by GNOME

2011-07-25 Thread David Jarvie
pplication. The only long term solution for ordinary users is to have interoperability of settings between desktops, so that it won't matter which system settings application they use. Applications with more specialist needs, i.e. settings which aren't (yet) interoperable, would need to

Re: Fixes in Git (first in stable, then merge to master)

2011-07-22 Thread David Jarvie
to me). During the stable branch freeze before a minor version release (such as currently before the 4.7 release), it isn't possible to commit bug fixes to stable first and then merge to master. Only master can be committed to, so presumably we'll have to continue to commit to master

Re: RFC: replacing MacroLogFeature.cmake with FeatureSummary.cmake

2011-07-19 Thread David Jarvie
On Mon, July 18, 2011 8:48 pm, Alexander Neundorf wrote: > On Monday 18 July 2011, David Jarvie wrote: >> On Wednesday 13 July 2011 20:16:58 Alexander Neundorf wrote: > ... >> > What do you think of this ? >> > More wishes ? >> > Should it do it in a dif

Re: RFC: replacing MacroLogFeature.cmake with FeatureSummary.cmake

2011-07-17 Thread David Jarvie
different way ? Something else which would be useful would be to output the actual file names (library files, header files etc.) which were checked for but not found when looking for the missing packages. Trying to determine which distro package to install to satisfy the dependency isn&#

Re: Date/Time in KF5 / Qt5

2011-07-06 Thread David Jarvie
On Wednesday 06 July 2011 23:01:13 Thiago Macieira wrote: > Em Wednesday, 6 de July de 2011, às 22:54:39, David Jarvie escreveu: > > I've added a comment to the merge request suggesting that instead of a > > reference date/time, the units in which the time span was specified

Re: Date/Time in KF5 / Qt5

2011-07-06 Thread David Jarvie
On Wednesday 06 July 2011 22:25:05 Sean Harmer wrote: > On 06/07/2011 21:18, David Jarvie wrote: > > On Wednesday 06 July 2011 21:10:06 Thiago Macieira wrote: > >> Em Wednesday, 6 de July de 2011, às 20:54:54, David Jarvie escreveu: > >>>> Duration is simply the

Re: Date/Time in KF5 / Qt5

2011-07-06 Thread David Jarvie
hat I'd want to contribute significant new code to Qt unless the licence was purely (L)GPL, or unless (and I wouldn't have time even in that case) I was paid for it. I would be willing to review other people's code, though. Cheers, -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm signature.asc Description: This is a digitally signed message part.

Re: Date/Time in KF5 / Qt5

2011-07-06 Thread David Jarvie
On Wednesday 06 July 2011 21:10:06 Thiago Macieira wrote: > Em Wednesday, 6 de July de 2011, às 20:54:54, David Jarvie escreveu: > > > Duration is simply the number of seconds or milliseconds between two > > > dates, appropriately given in their universal time. So duration

Re: Date/Time in KF5 / Qt5

2011-07-06 Thread David Jarvie
On Wednesday 06 July 2011 19:52:50 Thiago Macieira wrote: > Em Wednesday, 6 de July de 2011, às 18:54:37, David Jarvie escreveu: > > On Wednesday 06 July 2011 18:26:16 Sean Harmer wrote: > > > Hi, > > > > > > On 29/06/2011 20:54, John Layt wrote: > &g

Re: Date/Time in KF5 / Qt5

2011-07-06 Thread David Jarvie
s time changes when it is specified in terms of days. Even if the Qt class doesn't do this itself, it needs to make the appropriate methods virtual to allow us to override them. -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm signature.asc Description: This is a digitally signed message part.

Re: Intended organization of KDE Frameworks

2011-07-05 Thread David Jarvie
shouldn't > > provide any user visible texts either. Just like UI this should be > > outsourced to Tier 2 or 3 if necessary at all. > > Many classes that one may reasonably think that use no translations, > like KPluginLoader, contain many user-visible string

Re: Review Request: Shared empty private class for KTimeZoneBackend

2011-06-13 Thread David Jarvie
iewboard.kde.org/r/101593/ > --- > > (Updated June 13, 2011, 9:38 a.m.) > > > Review request for kdelibs, John Layt and David Jarvie. > > > Summary > --- > > This patch makes KTimeZoneBackend use a sh

Re: Review Request: Shared empty private class for KTimeZoneBackend

2011-06-13 Thread David Jarvie
ote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101593/ > --- > > (Updated June 12, 2011, 12:19 p.m.) > &g

Re: KDE git workflow

2011-06-09 Thread David Jarvie
sting coverage will be split between the competing integration branches. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: KDE git workflow

2011-06-09 Thread David Jarvie
interested in those areas are likely to use them, and it's only once they eventually reach master that they will be widely used by developers. In one way, that's a good thing, since there should be less bugs encountered by those not directly involved. But the overall effect could be t

Review Request: Fix KAuth::Action::execute() not returning error description string

2011-05-08 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101314/ --- Review request for kdelibs and Dario Freddi. Summary --- KAuth::Actio

Re: Deploying new kdelibs classes

2011-04-26 Thread David Jarvie
king of the rule in kdepim which says that it must build against the previous version of kdepimlibs? -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Minor Point Relase Policy

2011-03-07 Thread David Jarvie
ow I'll make a review request, for > good measure :-) It says that API changes to public libraries must be approved by kde-core-devel. Shouldn't kdepimlibs changes be approved on the kde-pim list instead? -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm signature.asc Description: This is a digitally signed message part.

Re: Moving stuff upstream (was: A Qt replacement for KGlobal::ref and deref)

2011-02-16 Thread David Jarvie
def support for two config systems in such libraries. > > Anyway, I've started a page to document such things at > http://community.kde.org/KDE_Core/QtMerge , feel free to add stuff there. > David Jarvie, could you add something to the KDateTime entry? Done. I hope it contains enou

Re: A Qt replacement for KGlobal::ref and deref

2011-02-16 Thread David Jarvie
ng to worry about whether they might accidentally introduce a dependence on platformy stuff. Having all the kdecore classes mixed together in a single library, as now, would mean that Qt developers have to check all the time which classes are "safe" to use and which aren'

Re: Usage of pull rebasing and merges

2011-02-08 Thread David Jarvie
s done after the pull. But I don't understand any part of your explanation above - why would it increase the repository size? don't commit hooks run on EVERY commit anyway? what's wrong with the example "wrong" commit, which did change one source line (not just metadata)? -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Merge or Cherry-Pick?

2011-02-02 Thread David Jarvie
er local branches, and only merge/cherry-pick changes from them into the local 'master' once you are ready to push to the remote. That way, your local master always mirrors the remote, and you can choose exactly when and which commits to push. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Merge or Cherry-Pick?

2011-02-01 Thread David Jarvie
e in master can get rewritten, features added or removed, so the changes won't be applicable there. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm

Re: Action icons in menus

2010-12-14 Thread David Jarvie
On Tue, December 14, 2010 2:52 pm, Ingo Klöcker wrote: > On Tuesday 14 December 2010, David Jarvie wrote: >> On Monday 13 December 2010 20:32:30 Albert Astals Cid wrote: >> > 5. There is no space to show the shortcut (i.e. Ctrl+C for Copy) >> >> IMO, this is a very i

Re: Review Request: KDateEdit moving into kdelibs

2010-11-30 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6014/#review9054 --- The code is based on an old version of KDateEdit - the feature in

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/#review8535 --- /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp

Re: Review Request: Four simple patches for kdecore

2010-11-06 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/#review8523 --- /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp