Re: Move Licentia to KDEREVIEW

2022-07-11 Thread David Hurka
On Monday, July 11, 2022 7:47:36 AM CEST David Redondo wrote: > I am not entirely happy about the Instruction to use a license being 'put a > LICENSE file in the root directory' when it's a pattern we are going away > from and towards reuse compliance. > Maybe display the SPDX tag instead? Interes

Re: Reviewing the process for giving people commit rights

2022-04-01 Thread David Hurka
> I would like to add that GitLab has made it *significantly* easier to > contribute without commit access. Think about what it was like in > Phabricator era (or even Reviewboard). [...] As a contributor who used Invent with and without commit access, I agree with this statement. Commit access wa

Re: Changing Original Library API when writing Wrappers

2022-01-30 Thread David Hurka
On Sunday, January 30, 2022 2:20:10 PM CET Ayush Singh wrote: > An example of this situation: > `QString readGenericName () const` > method of KDesktopFile > (https://api.kde.org/frameworks/kconfig/html/classKDesktopFile.html#aaf263b7 > 9cce3125c9e6e52428e05c524). If I am doing a one-to-one wrappin

Re: New repo in kdereview: kasts

2021-05-29 Thread David Hurka
Hi Bart, just reading this thread, without looking at kasts: > > - something is wonky with the colors on desktop. in all listviews it > > looks like the delegates are inactive/disabled colors for some reason. > > e.g. https://i.imgur.com/xkgigs4.png > > Ah, yes, this is intended behaviour. > Whe

Re: Is there (going to be) an auto-retracer service for KDE?

2021-04-25 Thread David Hurka
On Sunday, April 25, 2021 2:09:03 PM CEST Lyubomir Parvanov wrote: > Currently to be able to submit bug reports with stacktraces one has to > install the debug symbols locally for each package. As far as I know Gnome > doesn't suffer from this issue because Apport is invoked and when it > uploads

kconfig_compiler question: reusing the enum of a previous config entry

2021-03-20 Thread David Hurka
Hi all, I am working on https://invent.kde.org/graphics/okular/-/merge_requests/366, where I am trying to get two config entries that use the same enum. The entry EnumColorMode defines an enum with values like “Normal” = 0 and “InvertLuma” = 6. I can reuse the enum in these two ways: 1. Write