Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote: > El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > > Hi all, > > > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt > > KCM for Plasma. I initia

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > > Thus I'd kindly ask you to take one more look at the codebase [1] and let > > me know if there are any more issues to fix, or

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
re release? I think having FindBolt in ECM makes sense if there's a chance that some other components will use it. Right now I don't think anyone else is going to look for the Bolt daemon (as a runtime dependency). Dan > > Nate > > On 5/15/19 7:27 AM, Daniel Vrátil wrote: &g

Review Request: plasma-thunderbolt

2019-05-15 Thread Daniel Vrátil
[0] https://phabricator.kde.org/D19011 [1] https://cgit.kde.org/plasma-thunderbolt.git -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683 sig

Re: CI system maintainability

2019-03-28 Thread Daniel Vrátil
On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > > I'm completely fine with mandatory code review for everything and I'd be > > happy to have this in PIM. I think the biggest p

Re: CI system maintainability

2019-03-28 Thread Daniel Vrátil
nefits clearly out-weight the cost. Btw we practice this policy at work and I do truly appreciate it, not only as a huge learning experience but so many times just having a second pair of eyes to glance over my code has revealed issues that sometimes almost make me question my career

Re: Review request: plasma-pass

2019-01-04 Thread Daniel Vrátil
Hi Albert, thanks for the review! All the issues you mentioned are fixed in master now. Dan On Sunday, 16 December 2018 20:14:37 CET Albert Astals Cid wrote: > El dilluns, 10 de desembre de 2018, a les 14:49:28 CET, Daniel Vrátil va escriure: > > Hi folks, > > > >

Review request: plasma-pass

2018-12-10 Thread Daniel Vrátil
s :) Looking forward to your feedback, Dan [0] https://www.passwordstore.org/ [1] https://www.dvratil.cz/2018/05/plasma-pass/ -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD

Re: kdereview: ksmtp

2017-05-30 Thread Daniel Vrátil
Hi Rolf, thanks for the review, sorry it took me so long to get to you. On Tuesday, May 16, 2017 8:05:17 PM CEST Rolf Eike Beer wrote: > Am Donnerstag, 11. Mai 2017, 17:03:01 schrieb Daniel Vrátil: > > Hi, > > > > please review ksmtp, which is now in kdereview. > >

Re: kdereview: ksmtp

2017-05-13 Thread Daniel Vrátil
On Thursday, May 11, 2017 11:11:11 PM CEST Albert Astals Cid wrote: > El dijous, 11 de maig de 2017, a les 17:03:01 CEST, Daniel Vrátil va escriure: > > Hi, > > > > please review ksmtp, which is now in kdereview. > > Are tests supposed to pass? > > 2: QFATAL :

Re: kdereview: ksmtp

2017-05-11 Thread Daniel Vrátil
ith(). Dan > On Thursday, May 11, 2017 11:03:01 AM EDT Daniel Vrátil wrote: > > Hi, > > > > please review ksmtp, which is now in kdereview. > > > > KSMTP is a small simple library with a KJob-based API similar to KIMAP or > > KDAV to send mime messages vi

kdereview: ksmtp

2017-05-11 Thread Daniel Vrátil
ch is hard to maintain and extend. Having a Job-based library like KSmtp will make it much easier for us to introduce support for example for Google XOAUTH2 authentication mechanism. Thanks, Dan -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #f

Re: RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread Daniel Vrátil
ove. Having a weekly/bi-weekly nags to developers would IMO work ("hey, you have 10 new bugs this week that you did not comment on or confirmed yet, please look at them asap"). If the developer ignores the bugs even after that then it becomes a different problem, but that I don't kn

Re: RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread Daniel Vrátil
ere). Especially for KDE PIM, given the size of the userbase and the amount of developers (3), bugs often take more than a year to get to and to be fixed. > I think this would make a lot of time consuming bug triaging much easier. Cannot agree more :) Cheers, Daniel > > Greetings

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-24 Thread Daniel Vrátil
On Friday, July 24, 2015 10:24:10 AM laurent Montel wrote: > Le Friday 24 July 2015, 00:13:48 Albert Astals Cid a écrit : > > El Dimarts, 21 de juliol de 2015, a les 13:52:01, Daniel Vrátil va escriure: > > > On Monday, July 20, 2015 04:17:16 PM Daniel Vrátil wro

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-21 Thread Daniel Vrátil
On Monday, July 20, 2015 04:17:16 PM Daniel Vrátil wrote: > Hi all, > > we (the KDE PIM team) kinda screwed up when we forgot to communicate our > intentions about > next KDE PIM release with the release team and we ended up in a > situation that we have > some repositories

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-20 Thread Daniel Vrátil
On 20.07.2015 16:44, Martin Sandsmark wrote: On Mon, Jul 20, 2015 at 04:17:16PM +0200, Daniel Vrátil wrote: We only ported the code to KF5 Unless I'm misunderstanding something, isn't this a quite significant change? From experience even seemingly simple ports can introduce prett

Moving akonadi from kdesupport and akonadi-search from playground

2015-07-20 Thread Daniel Vrátil
tself well enough in during the years :) I'd like to move both repositories to kde/pim module where other KDE PIM repos (mostly those split from kdepimlibs) currently live. If that's fine with everyone I'd request the move ASAP. Cheers, Daniel -- Daniel Vrátil www.dvratil.c

Re: [Kde-pim] KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Daniel Vrátil
g/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

Re: The Future or KDE PIM Releases

2015-04-14 Thread Daniel Vrátil
On Tuesday, April 14, 2015 12:17:39 AM Albert Astals Cid wrote: > El Diumenge, 12 d'abril de 2015, a les 11:31:26, Daniel Vrátil va escriure: > > Greetings from Toulouse! > > > > Instead we will aim towards releasing KF5-based KDE PIM with "Akonadi 1"

The Future or KDE PIM Releases

2015-04-12 Thread Daniel Vrátil
nt PIM team and help make KDE PIM awesome again. We would welcome feedback and opinions from other PIM devs who are not here in Toulouse. If everyone is fine with this proposal, we will put this plan to work as soon as possible. Regards, Daniel -- Daniel Vrátil www.dvratil.cz | dvra...@k

Re: Plasma 5.2 bits for kdereview

2014-12-23 Thread Daniel Vrátil
only to get DPI info, which was not provided by QScreen in Qt 4. In Qt 5 you already have DPI API in QScreen, so you should not need KScreen anymore. Dan -- Daniel Vrátil | dvra...@redhat.com | dvratil on #kde-devel, #kontact, #akonadi Software Engineer - KDE Desktop Team, Red Hat Inc. GPG K

Re: [Kde-pim] kdepimlibs splitting done

2014-12-12 Thread Daniel Vrátil
t read-tree --empty > git read-tree --prefix qgpgme/src/ $GIT_COMMIT:qgpgme/src > true > ' master --all --tags > ___ > KDE PIM mailing list kde-..

Re: Moving KScreen and libkscreen to extragear

2013-10-18 Thread Daniel Vrátil
e updating can get messy. Fixed, thanks. > > -Generator::biggestOutput > rename the local variable "total"...it's not a total of anything, I had to > re-read it 10 times to realise the code was correct. Right, confused me too :-) Fixed. > In general though +1

Re: Fwd: looking for phonon gstreamer maintainer

2013-10-07 Thread Daniel Vrátil
it alive and push it over the hill to gstreamer-1.0 (come on, how hard can it be? ;-)) Luckily for me, we have a GStreamer guy in the office, so I can get some help from him if necessary :) Cheers, Dan > > HS -- Daniel Vrátil KDE Desktop Team Associate Software Engineer, Red Hat, Inc

Re: Help solving an IMAP SSL bug

2013-08-22 Thread Daniel Vrátil
On Tuesday 20 of August 2013 20:42:05 Richard Moore wrote: > On 19 August 2013 10:58, Daniel Vrátil wrote: > > Because it's a socket error KSslSocket will emit socketError() and IMAP > > resource will try to reconnect. The interesting part here is, that calling > > Q

Help solving an IMAP SSL bug

2013-08-19 Thread Daniel Vrátil
/?l=kde-core-devel&m=137050526303582&w=2 -- Daniel Vrátil Associate Software Engineer, KDE Desktop Team Red Hat, Inc GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 signature.asc Description: This is a digitally signed message part.

Re: Moving KScreen and libkscreen to extragear

2013-07-08 Thread Daniel Vrátil
s://bugs.kde.org/show_bug.cgi?id=316548#c1 Hi, it should be fixed now. I replaced qsTr calls with i18nc and added some context descriptions. Cheers, Dan > > > -A library that offers a good abstraction so we can support multiple > > > > backends. At the mo

Re: Buy Sprint tickets !

2013-03-03 Thread Daniel Vrátil
g forward to meet you all there :-) Dan -- Daniel Vrátil Associate Software Engineer, KDE Desktop Team Red Hat, Inc GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 signature.asc Description: This is a digitally signed message part.