Re: Tokodon in KDE Review

Hello, On jeudi 24 novembre 2022 15:00:44 CET Carl Schwan wrote: > Hello everyone, > > I would like to put Tokodon in KDE Review. Tokodon is mastodon client, I > have been working for some time already. I already did some unstable > release and I would like to soon release the first stable releas

Re: ghostwriter is ready for your review

Hello, On jeudi 13 octobre 2022 08:52:26 CEST Megan wrote: > Hello everyone, > > The /ghostwriter/ Markdown editor has finally hatched from its > incubation and is ready for you to review at your convenience. > > Project repo: https://invent.kde.org/office/ghostwriter https://invent.kde.org/off

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

On lundi 19 octobre 2020 12:30:59 CEST Milian Wolff wrote: > On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: > > Yo > > > > On 18.10.20 10:11, Milian Wolff wrote: > > > Hey all, > > > > > > since some time now I'm only compiling parts of KF5 selectively into a > > > custom prefix.

Re: KDEReview for Kontrast

On lundi 3 août 2020 23:12:25 CEST Albert Astals Cid wrote: > > I added the icon and I hope I installed it to the correct location: > > https://invent.kde.org/accessibility/kontrast/-/commit/8a008c1387c0234d5e > > 1d537bdd331007d7b1ff07. It was already stored in breeze-icons but I guess > > it is b

Re: Kup in KDE Review

On lundi 6 avril 2020 12:32:54 CEST Simon Persson wrote: > Hello! > > > Please help to review kup. > 'COPYING' only covers the GPL-2.0-only part of the code. You also need the GPL-3.0-only and the LicenseRef-KDE-Accepted-GPL reference. Note that we're slowly moving from the monolithic license

Re: Review Kid3

Hello, On jeudi 13 février 2020 07:11:45 CET Urs Fleisch wrote: > Hello everybody, > > As you may know, Kid3, an audio tagger, has moved from SourceForge.net to > kde.org. Jonathan Riddell is attending the incubation process as a sponsor. > To complete the incubation, I would kindly ask you to ex

Re: KDE Itinerary in kdereview

Hey, On dimanche 8 décembre 2019 13:14:43 CET Volker Krause wrote: > Hi, > > KDE Itinerary has been moved to kdereview: > > Code: https://invent.kde.org/kde/itinerary > Workboard: https://phabricator.kde.org/project/board/280/query/all/ > COPYING.LIB contains the LGPL 2.1 license. The files in

Re: plasma-nano and plasma-phone-components are now in kdereview

On Friday, November 8, 2019 10:36:39 AM CET Alexander Potashev wrote: > пт, 8 нояб. 2019 г. в 10:10, Bhushan Shah : > > Hello! > > > > plasma-nano: https://invent.kde.org/kde/plasma-nano > COPYING.LIB contains the LGPL 2.1 license. The LGPL code in this repo is LGPL-2.0-or-later > > plasma-phon

Re: KTrip in kdereview

On dimanche 27 octobre 2019 15:29:10 CET Nicolas Fella wrote: > Hi, > > KTrip (https://invent.kde.org/kde/ktrip) has been moved to kdereview. > Some files don't have a license header (ClockFace.qml, DateInput.qml, TimezoneTable.qml, plugin.cpp). Christophe

Re: ELF Dissector in kdereview

Hello, Minor issue with the license file. COPYING.LIB contains the LGPL 2.1 license text while elf-dissector is LGPL-2.0-or-later COPYING has a few differences compared to https://www.gnu.org/licenses/old-licenses/gpl-2.0-standalone.html. Does it come from treemap?

Re: Plasma-Mycroft is in kdereview

Hi, On mardi 5 décembre 2017 08:52:18 CET Aditya Mehra wrote: > Hi all, > > This is a request email for the review process of the mycroft plasmoid, the > plasma-mycroft project has been moved to kdereview > > The repository url: https://cgit.kde.org/plasma-mycroft.git/ > Just commenting on the

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

LOADED DICTIONARY: /usr/share/hunspell/fr_FR.aff /usr/share/hunspell/fr_FR.dic src/plugins/hunspell/CMakeLists.txt <https://git.reviewboard.kde.org/r/122987/#comment53312> endif() - Christophe Giboudeaux On March 17, 2015, 1:09 p.m., Eugene Sh

Re: Review Request 120782: Allow stand-alone build of konqueror

<https://git.reviewboard.kde.org/r/120782/#comment48507> Not related to your patch, but the build fails without KDED. It's not really optional - Christophe Giboudeaux On oct. 28, 2014, 3:22 après-midi, Dan Vrátil wrote: > > -

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

tps://git.reviewboard.kde.org/r/120781/#comment48485> kbookmarkmodel/tests/CMakeLists.txt already looks for Qt5Test - Christophe Giboudeaux On oct. 28, 2014, 3:24 après-midi, Dan Vrátil wrote: > > --- > This is an automatica

Re: Review Request 120782: Allow stand-alone build of konqueror

konqueror/CMakeLists.txt <https://git.reviewboard.kde.org/r/120782/#comment48322> Already enabled by KDECompilerSettings - Christophe Giboudeaux On oct. 24, 2014, 3:12 après-midi, Dan Vrátil wrote: > > --- > This is an automat

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

tps://git.reviewboard.kde.org/r/120781/#comment48317> not needed keditbookmarks/CMakeLists.txt <https://git.reviewboard.kde.org/r/120781/#comment48316> KDEFrameworkCompilerSettings.cmake already enables QT_USE_FAST_OPERATOR_PLUS - Christophe Giboudeaux On oct. 24, 2014, 2:50 après-midi, Dan

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/#review47802 --- Ship it! Ship It! - Christophe Giboudeaux On Jan. 20

Re: Review Request 115140: Adapt to new attica name

, you could just remove these lines. - Christophe Giboudeaux On Jan. 20, 2014, 9:59 a.m., Stefano Avallone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Review Request 112038: Look for LibAttica where needed

'find_package(LibAttica NO_MODULE) line'. Thanks, Christophe Giboudeaux

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

-applets.h.cmake:#cmakedefine HAVE_STRIGIDBUS 1 this line is not needed anymore with this change - Christophe Giboudeaux On June 9, 2013, 1:53 a.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: KF5 Update Meeting 2013-w20

On Monday 03 June 2013 12:34:46 David Faure wrote: > On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote: > > there was a review request for a find-module for libusb1 here a few days > > ago, which we have already in e-c-m, but he can't use it because it is > > not > > released > > Could we m

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

> On May 2, 2013, 8:49 a.m., Christophe Giboudeaux wrote: > > LibKFbAPI-KDEPIMConfig.cmake.in, line 24 > > <http://git.reviewboard.kde.org/r/110083/diff/4/?file=141385#file141385line24> > > > > CMake will stop at this point. > > > >

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

EXPORT kfbapiLibraryTargets ${INSTALL_TARGETS_DEFAULT_ARGS}) to use a different export name for kfbapikdepim (and then install a different export file for this library) but then you also have to require a different CMake version (multiple export-sets in a given project is a 2.8.10 feature iirc) - Chri

Re: Review Request 109245: Remove duplicated calendar classes from calendar plasmoid

minimum version in the main CMakeLists.txt - Christophe Giboudeaux On March 2, 2013, 2:12 p.m., Sergio Luis Martins wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Review Request: Port kdelibs to feature_summary

solid/solid/CMakeLists.txt b7dcc97 sonnet/plugins/CMakeLists.txt 9d69005 Diff: http://git.reviewboard.kde.org/r/108002/diff/ Testing --- No issue detected. CMake detects the same dependencies as before. Thanks, Christophe Giboudeaux

Re: Review Request: Install additional headers from libkonq

headers is not necessary. - Christophe Giboudeaux On April 23, 2012, 3:08 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Patch to build only kmime + kimap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100698/#review1549 --- CMakeLists.txt

Re: Review Request: Patch to build only kdecore

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100697/#review1548 --- CMakeLists.txt

Re: Please test: [CMake] CMake 2.8.4-rc1 ready for testing!

Hi, On Tuesday 18 January 2011 21:58:24 Alexander Neundorf wrote: > > So please, give this release candidate a good try, and let me know if > something fails. > Quick feedback. Thanks for finally turning off the verbose makefile when using the codeblock generator. I didn't notice any regressi