Re: Review Request 111480: Notifications are shown multiple times

2013-07-16 Thread Cedric Bellegarde
it&h=9a96b9512579215bcddd8fc88041fdd7130dbb0f This addresses bug 313440. http://bugs.kde.org/show_bug.cgi?id=313440 Diffs - plasma/generic/applets/notifications/contents/ui/Notifications.qml ce3f8de Diff: http://git.reviewboard.kde.org/r/111480/diff/ Testing --- Working here Thanks, Cedric Bellegarde

Re: Review Request 111480: Notifications are shown multiple times

2013-07-16 Thread Cedric Bellegarde
enerated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/#review35959 --- On July 15, 2013, 9:18 a.m., Cedric Bellegarde wrote: > > --- > This is an automati

Re: Review Request 111480: Notifications are shown multiple times

2013-07-15 Thread Cedric Bellegarde
Working here Thanks, Cedric Bellegarde

Re: Review Request 111480: Notifications are shown multiple times

2013-07-12 Thread Cedric Bellegarde
king here Thanks, Cedric Bellegarde

Re: Review Request 111480: Notifications are shown multiple times

2013-07-11 Thread Cedric Bellegarde
http://bugs.kde.org/show_bug.cgi?id=313440 Diffs - plasma/generic/applets/notifications/contents/ui/Notifications.qml ce3f8de Diff: http://git.reviewboard.kde.org/r/111480/diff/ Testing --- Working here Thanks, Cedric Bellegarde

Review Request 111480: Notifications are shown multiple times

2013-07-11 Thread Cedric Bellegarde
plasma/generic/applets/notifications/contents/ui/Notifications.qml ce3f8de Diff: http://git.reviewboard.kde.org/r/111480/diff/ Testing --- Working here Thanks, Cedric Bellegarde

Re: Kded and DBus

2013-01-04 Thread Cedric Bellegarde
Le jeudi 3 janvier 2013 23:30:28 Weng Xuetian a écrit : > Why appmenu-qt doesn't use static dbus interface (generate from XML)? From > Qt code that can avoid synchronous introspection. You are right, it fixes the issue, will try to get my patch in appmenu-qt for KDE 4.10 release ;) regards, --

Kded and DBus

2013-01-03 Thread Cedric Bellegarde
Hello, i'm kded-appmenu maintainer and i've got issues with Kded and DBus... When appmenu support is enabled, some applications hangs on startup: VLC, Clementine. After some investigations, and using clementine as an exemple, this is happening: kded (kmix) do a DBus Introspection on clementi

Re: Cleaning house: KDE Review

2012-11-06 Thread Cedric Bellegarde
Hello, kded-appmenu in KDE review should be removed, it's 4.9 version and i do not plan to work on this anymore. 4.10 version is in trunk: http://quickgit.kde.org/index.php?p=kde- workspace.git&a=tree&f=appmenu regards, -- Cédric

Re: Review request reminder: kded-appmenu

2012-10-02 Thread Cedric Bellegarde
Le samedi 29 septembre 2012 18:05:45 Alex Fiestas a écrit : > I was wondering, can't the kded be loaded on demand? what if somebody > doesn't care about appmenu? Hello, kded-appmenu was loaded on demand but with last version, i disable this because with Export/TopMenubar mode, nobody is using k

Re: Review request reminder: kded-appmenu

2012-09-27 Thread Cedric Bellegarde
Le mercredi 26 septembre 2012 16:30:11 Albert Astals Cid a écrit : > And where you read there that the code can be GPL3 only? Hello, that's fixed, all code is now GPLv2. registrar.* (plasma-widget-menubar code from Aurelien Gateau for Canonical) has been rewritten. About common code between re

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Le mercredi 26 septembre 2012 16:04:30 vous avez écrit : > Really, where does it say that? « Any other source files must be licensed under one of the terms listed under 4) or one of the following terms: GPL version 2 as listed in kdelibs/COPYING or later GPL version 2 or version 3 or later versio

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Le mercredi 26 septembre 2012 15:37:53 Albert Astals Cid a écrit : > You still have GPLv2 vs GPLv3 issues in the code. Hello, from your last mail, GPLv3 is disallowed by: http://techbase.kde.org/Policies/Licensing_Policy but i can read that for "Source files that aren't part of a library with a

Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Hello, i'm waiting for some code review on kded-appmenu module: https://projects.kde.org/projects/kdereview/kded-appmenu Martin Gräßlin tells me to send a reminder here before commiting. I need to put this in kde-workspace before patching with: https://git.reviewboard.kde.org/r/104344/ As i'm n

Re: Appmenu support for KDE 4.10

2012-09-14 Thread Cedric Bellegarde
Le mercredi 12 septembre 2012 16:16:27 Alex Fiestas a écrit : > I have a long TODO list so I can't make promises, but I will try to help > you out with this, a kick'ass appmenu support is something we really need. This is not urgent, only plasma-widget-menubar need libkappmenu. Aurelien Gateau g

Appmenu support for KDE 4.10

2012-09-11 Thread Cedric Bellegarde
Hello, since last mail, many changes. Kded-appmenu: https://projects.kde.org/projects/kdereview/kded-appmenu - DBus interface allowing KWin to ask for applications menu to popup - New Top menubar: * Auto hide with glow effect for easy access * Multihead: me

Re: Review request: AppMenu support for KDE

2012-05-02 Thread Cedric Bellegarde
Le vendredi 27 avril 2012 17:58:24 Alex Fiestas a écrit : > We should provide a way of accessing more easily to the data (thinking on a > model) and ideally would be awesome to have this before releasing. https://gitorious.org/kde-workspace-appmenu/krunner-kdedappmenu Here an old port of krunner