Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-16 Thread Andrey Bondrov
src/cursorthemesmodel.cpp PRE-CREATION src/gtkconfigkcmodule.h 032a5ef src/gtkconfigkcmodule.cpp 3d70f6e src/ui/gui.ui ebfacdf Diff: https://git.reviewboard.kde.org/r/126704/diff/ Testing --- Tested on my local machine. Seems to do what it should properly. Thanks, Andrey Bondrov

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-16 Thread Andrey Bondrov
nerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review91183 --- On Янв. 16, 2016, 4:14 п.п., Andrey Bondrov wrote: > > --- > This is an automatically ge

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-16 Thread Andrey Bondrov
src/gtkconfigkcmodule.h 032a5ef src/gtkconfigkcmodule.cpp 3d70f6e src/ui/gui.ui ebfacdf Diff: https://git.reviewboard.kde.org/r/126704/diff/ Testing --- Tested on my local machine. Seems to do what it should properly. Thanks, Andrey Bondrov

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-16 Thread Andrey Bondrov
his is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review90985 --- On Янв. 13, 2016, 6:03 д.п., Andrey Bondrov wrote: > > -

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-13 Thread Andrey Bondrov
> weirdly specific logic. > > > > Also I'd say it would be really good to be able to show some preview of the > > theme somehow, otherwise it's hard to tell them apart. > > Andrey Bondrov wrote: > Yes, I'll do it. > > Andrey Bondrov wrote: >

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-13 Thread Andrey Bondrov
So I removed "if(!theme.name().isEmpty())" from this review request. - Andrey --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review90985 --------

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
src/gtkconfigkcmodule.h 032a5ef src/gtkconfigkcmodule.cpp 3d70f6e src/ui/gui.ui ebfacdf Diff: https://git.reviewboard.kde.org/r/126704/diff/ Testing --- Tested on my local machine. Seems to do what it should properly. Thanks, Andrey Bondrov

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
> weirdly specific logic. > > > > Also I'd say it would be really good to be able to show some preview of the > > theme somehow, otherwise it's hard to tell them apart. > > Andrey Bondrov wrote: > Yes, I'll do it. Hmm, looks like there's no e

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
hould properly. Thanks, Andrey Bondrov

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
gtk.h f797a08 src/gtkconfigkcmodule.cpp 3d70f6e src/iconthemesmodel.cpp 07c7ad7 src/ui/gui.ui ebfacdf Diff: https://git.reviewboard.kde.org/r/126704/diff/ Testing --- Tested on my local machine. Seems to do what it should properly. Thanks, Andrey Bondrov

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-12 Thread Andrey Bondrov
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review90964 ----------- On Янв. 10, 2016, 1:43 п.п., Andrey Bondrov wrote: > > ---

Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

2016-01-10 Thread Andrey Bondrov
Diff: https://git.reviewboard.kde.org/r/126704/diff/ Testing --- Tested on my local machine. Seems to do what it should properly. Thanks, Andrey Bondrov

Re: Review Request 123965: Encode KBookmark URL to fix compatibility with KDE4 applications

2015-06-14 Thread Andrey Bondrov
sion), checked if it's properly stored in new user-places.xbel and if Dolphin (KDE4 build) can open it from Places panel. Seems to work properly. Thanks, Andrey Bondrov

Re: Review Request 123965: Encode KBookmark URL to fix compatibility with KDE4 applications

2015-05-31 Thread Andrey Bondrov
aces.xbel and if Dolphin (KDE4 build) can open it from Places panel. Seems to work properly. Thanks, Andrey Bondrov

Review Request 123965: Encode KBookmark URL to fix compatibility with KDE4 applications

2015-05-31 Thread Andrey Bondrov
quick testing is done. I deleted user-places.xbel, added bookmark with kwrite (KF5 version), checked if it's properly stored in new user-places.xbel and if Dolphin (KDE4 build) can open it from Places panel. Seems to work properly. Thanks, Andrey Bondrov

Re: Review Request 123186: Add autohint checkbox to KCM fonts

2015-03-31 Thread Andrey Bondrov
> On Март 30, 2015, 5:01 п.п., Thomas Lübking wrote: > > From my own experience, autohinting is no "yes or no" question. > > => Should downstream not rather provide global fontconfig snippets that > > enable autohinting for fonts with (known) crap BC

Re: Review Request 123186: Add autohint checkbox to KCM fonts

2015-03-30 Thread Andrey Bondrov
onts. BC for LS fonts is a matter of taste. - Andrey --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123186/#review78234 ---------

Review Request 123186: Add autohint checkbox to KCM fonts

2015-03-30 Thread Andrey Bondrov
. Seems to work fine for me. Thanks, Andrey Bondrov

Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
view70605 --- On Ноя. 19, 2014, 1:52 д.п., Andrey Bondrov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
/r/121169/diff/ Testing --- This patch is used in ROSA and ALT Linux for a long time. http://bugs.rosalinux.ru/show_bug.cgi?id=1902 Thanks, Andrey Bondrov

Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

2014-11-18 Thread Andrey Bondrov
. http://bugs.rosalinux.ru/show_bug.cgi?id=1902 Thanks, Andrey Bondrov