Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2017-10-19 Thread Andreas Sturmlechner
s an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129233/#review101423 ------- On Dec. 11, 2016, 3:07 p.m., Andreas Sturmlechner wrote: > > --- >

Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2016-12-11 Thread Andreas Sturmlechner
://git.reviewboard.kde.org/r/129233/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 129339: Allow building kwalletd against gpgme++ from gpgme 1.7

2016-11-10 Thread Andreas Sturmlechner
> On Nov. 5, 2016, 10:39 a.m., Andreas Sturmlechner wrote: > > kwalletd/CMakeLists.txt, line 8 > > <https://git.reviewboard.kde.org/r/129339/diff/1/?file=484099#file484099line8> > > > > Please do this in reverse logic, same as in the kwallet.git commit you

Re: Review Request 129339: Allow building kwalletd against gpgme++ from gpgme 1.7

2016-11-06 Thread Andreas Sturmlechner
> On Nov. 5, 2016, 10:39 a.m., Andreas Sturmlechner wrote: > > kwalletd/CMakeLists.txt, line 8 > > <https://git.reviewboard.kde.org/r/129339/diff/1/?file=484099#file484099line8> > > > > Please do this in reverse logic, same as in the kwallet.git commit you

Re: Review Request 129339: Allow building kwalletd against gpgme++ from gpgme 1.7

2016-11-05 Thread Andreas Sturmlechner
> On Nov. 5, 2016, 10:39 a.m., Andreas Sturmlechner wrote: > > kwalletd/CMakeLists.txt, line 8 > > <https://git.reviewboard.kde.org/r/129339/diff/1/?file=484099#file484099line8> > > > > Please do this in reverse logic, same as in the kwallet.git commit you

Re: Review Request 129339: Allow building kwalletd against gpgme++ from gpgme 1.7

2016-11-05 Thread Andreas Sturmlechner
own to kdepimlibs-4 and GpgME++) to make sure there is no bogus linking and to avoid confusion in FEATURE_SUMMARY output. - Andreas Sturmlechner On Nov. 5, 2016, 9:35 a.m., Antonio Rojas wrote: > > --- > This is an automatically gener

Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2016-10-21 Thread Andreas Sturmlechner
tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129233/#review100189 --- On Oct. 20, 2016, 8:50 p.m., Andreas Sturmlechner wrote: > > --- > This is

Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2016-10-20 Thread Andreas Sturmlechner
kdewidgets/CMakeLists.txt 51536017ac0a3a86e164e30b80840a89aa3a8248 plasma/CMakeLists.txt b9214388d72122ae9c5709b6956a8b8e13ccd3aa Diff: https://git.reviewboard.kde.org/r/129233/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread Andreas Sturmlechner
marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit 8f6fe819ff3fe03e2715877aeaffe0d03442d040 by Andreas Sturmlechner to branch master. Repository: kde-baseapps Description --- builds and runs fine without the dependency Diffs

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-18 Thread Andreas Sturmlechner
it.reviewboard.kde.org/r/128941/#review99266 ------- On Sept. 18, 2016, 11:36 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-18 Thread Andreas Sturmlechner
: https://git.reviewboard.kde.org/r/128941/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 127823: Allow building without strigi on Linux

2016-05-21 Thread Andreas Sturmlechner
> On May 3, 2016, 12:58 p.m., Aleix Pol Gonzalez wrote: > > Why touch the `if(WIN32)` though? If needed, just make it optional on all > > platforms. > > Antonio Rojas wrote: > That's what I'm doing... Currently it's only optional on WIN32, I'm > changing it to be optional regardless of the

Re: Review Request 122212: [baseapps] Make tests optional

2015-02-18 Thread Andreas Sturmlechner
Sorry about that and thanks for the quick fix, konqueror tests were actually not built on my setup so it went unnoticed. Regards, Andreas On 18 February 2015 at 01:57, Albert Astals Cid wrote: > > Now we have optional tests and a broken the build > > http://build.kde.org/job/kde-baseapps_master

Re: Review Request 122212: [baseapps] Make tests optional

2015-02-17 Thread Andreas Sturmlechner
- CMakeLists.txt 6df90151166ae5b042518b3b91daaf1dde83118b dolphin/src/CMakeLists.txt d2ea4931431bf6b73ec9fa46ae84a7a65d142d6b lib/konq/CMakeLists.txt cd61c5b7c7e1bb005449626b44665f4fa31b275d Diff: https://git.reviewboard.kde.org/r/122212/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

2015-02-11 Thread Andreas Sturmlechner
://git.reviewboard.kde.org/r/122534/diff/ Testing --- Thanks, Andreas Sturmlechner

Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

2015-02-11 Thread Andreas Sturmlechner
--- [konq-plugins] fsview: Add missing include(ECMMarkAsTest) Diffs - konq-plugins/fsview/tests/CMakeLists.txt 4ee03006999dfb62c25a36bb643f92c3078697b6 Diff: https://git.reviewboard.kde.org/r/122534/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 122212: [baseapps] Make tests optional

2015-02-01 Thread Andreas Sturmlechner
, visit: https://git.reviewboard.kde.org/r/122212/#review74587 --- On Jan. 22, 2015, 9:24 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated

Review Request 122212: [baseapps] Make tests optional

2015-01-23 Thread Andreas Sturmlechner
d2ea4931431bf6b73ec9fa46ae84a7a65d142d6b lib/konq/CMakeLists.txt cd61c5b7c7e1bb005449626b44665f4fa31b275d Diff: https://git.reviewboard.kde.org/r/122212/diff/ Testing --- Thanks, Andreas Sturmlechner