Re: Fwd: KF5 CMake usage question

On Samstag, 13. Mai 2017 23:48:33 CEST Shaheed Haque wrote: > Hi, > > On 13 May 2017 at 22:04, Sven Brauch wrote: > > Hi, > > > > On 05/13/2017 06:06 PM, Shaheed Haque wrote: > >> The printed output shows that the variable KF5KIO_INCLUDE_DIRS is > >> not > >> set. In poking around, I see referen

Solved: missing dependencies when compiling with Ninja generator

Hello, I did some research to find out why builds with Ninja sometimes miss dependencies, thus producing build failures unless the failing repository is recompiled from scratch. It was a bug (or somewhat justifiable behavior difference between Make and Ninja if you like) in CMake that has been

Re: The curious case of stuck systemd poweroff

On Donnerstag, 14. Juli 2016 16:19:15 CEST Harald Sitter wrote: > On Thu, Jul 14, 2016 at 3:43 PM, Andreas Hartmetz wrote: > > Hello, > > > > Am Donnerstag, 14. Juli 2016, 11:11:26 CEST schrieb Harald Sitter: > >> Hola! > >> > >> ever since

Re: The curious case of stuck systemd poweroff

Hello, Am Donnerstag, 14. Juli 2016, 11:11:26 CEST schrieb Harald Sitter: > Hola! > > ever since systemd and or sddm started not killing all our session > processes we have had problems of poweroff/reboot getting hung up > waiting for processes to quit. > Recently systemd then started sending the

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

marked as submitted. Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin. Changes --- Submitted with commit 85cc90b65ed8a9aa110018b01813fe1fd6772d48 by Andreas Hartmetz to branch master. Repository: kpackage Description --- That was a problem in a scenario such as

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

"add applets" and tray config dialog, no duplicates anymore. Also no duplicates anymore in KWin effects KCM. Thanks, Andreas Hartmetz

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

g by > > the id (the plugin name). > > Andreas Hartmetz wrote: > Depends on the scope in which an ID is guaranteed to be unique. If it's > guaranteed to be globally unique and independent of category, sure, I'm all > for not making it more complicated than ne

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

category, sure, I'm all for not making it more complicated than necessary. - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 ---

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 --- On Jan. 7, 2016, 3:21 p.m., Andreas Hartmetz wrote: > >

Review Request 126660: Avoid finding the same package multiple times from different paths.

cpp 9f7dd48 Diff: https://git.reviewboard.kde.org/r/126660/diff/ Testing --- Checked for duplicate entries in "add applets" and tray config dialog, no duplicates anymore. Also no duplicates anymore in KWin effects KCM. Thanks, Andreas Hartmetz

Re: Causes of session management problems in Plasma 5

On Donnerstag, 26. November 2015 08:55:19 CET Thomas Lübking wrote: > On Donnerstag, 26. November 2015 05:19:34 CEST, Nicolás Alvarez wrote: > > What do you mean with "konsole asks"? Things like "You have > > multiple tabs open, are you sure you want to quit?" and "You > > have unsaved changes"? >

Remove legacy session management support?

Hello, While looking at ksmserver, which is already a bit too big to be easy to understand, I noticed that it still has about 500 lines of code to deal with applications that don't yet speak the "modern" (from 1993) XSMP session management protocol. kwin seems to have some more code for legacy

Re: Causes of session management problems in Plasma 5

On Mittwoch, 25. November 2015 18:05:26 CET Thomas Lübking wrote: > On Dienstag, 24. November 2015 02:02:46 CEST, Andreas Hartmetz wrote: > > - The session manager not "locking down" or better copying the list > > of> > > clients *while* logging out. T

Re: Causes of session management problems in Plasma 5

ike the use case exists. > On November 23, 2015 7:02:46 PM CST, Andreas Hartmetz wrote: > >Hello, > > > >As apparently one of the last users of session management, because I > >shut down my computers about once every day, I run into problems > >about as often as

Causes of session management problems in Plasma 5

Hello, As apparently one of the last users of session management, because I shut down my computers about once every day, I run into problems about as often as I log into a session that is supposed to be restored. The number one problem is Konsole just not restoring. So I took some time to invest

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: > Hey all, > > in massif-visualizer's framework branch, and now also kate, I > sometimes notice GUI lockups when I try to open files via Ctrl + O. > The backtraces look like the following: > > https://paste.kde.org/pbzhkgx8r > > Any idea what m

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

in and then it's good to have everything in chronological / topical order top to bottom. > On 21 June 2015 at 20:29, Andreas Hartmetz wrote: > > On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: > >> Hey all, > >> > >> in massif-visualizer's framewo

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: > Hey all, > > in massif-visualizer's framework branch, and now also kate, I > sometimes notice GUI lockups when I try to open files via Ctrl + O. > The backtraces look like the following: > > https://paste.kde.org/pbzhkgx8r > > Any idea what m

Re: KDiagram libs (KChart, KGantt) in KDE Review

On Wednesday 11 February 2015 14:59:50 Adriaan de Groot wrote: > On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: > > Yes, nearly copy&paste: the copies of KDChart in Calligra & KMyMoney > > are older (2.4.1, based on Qt4) versions, while the copy of > > KDChart in Massif-Visual

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35523 --- Ship it! Congratulations :P - Andreas Hartmetz On July 3

Re: Review Request 111370: system_tray: initialize uninitialized members

ject(parent), m_someVariable(0), m_someOtherVariable("bar") { } - Andreas Hartmetz On July 3, 2013, 11:58 a.m., Jiri Slaby wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 111370: system_tray: initialize uninitialized members

ttp://git.reviewboard.kde.org/r/111370/#comment26086> Please don't use tabs and align it with the previous item. - Andreas Hartmetz On July 3, 2013, 10:54 a.m., Jiri Slaby wrote: > > --- > This is an automatically genera

Re: Review Request 111370: system_tray: initialize uninitialized members

ttp://git.reviewboard.kde.org/r/111370/#comment26060> Two style issues: put the m_applet initialization on a new line (with the comma on the previous line), and use 0, not NULL. - Andreas Hartmetz On July 2, 2013, 6:15 p.m., Jiri Slaby

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

comment26048> Should be easier to just make it a child of the public class. kio/kio/slaveinterface.cpp <http://git.reviewboard.kde.org/r/111335/#comment26049> Early return for less nesting - Andreas Hartmetz

Re: Finalized proposal for i18n in KF5, second iteration

On Tuesday 02 April 2013 15:46:52 Chusslove Illich wrote: > After considering comments from the previous iteration: > > > http://mail.kde.org/pipermail/kde-frameworks-devel/2012-December/001358.htm > l > > here is the updated version: > > http://nedohodnik.net/misc/ki18n-kf5-02/html/prg_guid

Re: Review Request 109748: kioslave/sftp: Show correct port number when connecting to default port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109748/#review3 --- Ship it! Ship It! - Andreas Hartmetz On March 26, 2013, 8

Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

ation scripts. That is before startkde runs, so startkde never touched XDG_DATA_DIRS. But it should, and now it does. Diffs (updated) - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz

Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

never touched XDG_DATA_DIRS. But it should, and now it does. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz

Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

does. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: > Hi fellow kde-core-develers, i was thinking that from time to time someone > commits some code that breaks the building of the tests. > > This happens because people is not aware that those parts are unit tested. > > I think that by en

Re: Review Request: Cleanup the use of HTTPProtocol::httpClose

> On Oct. 12, 2011, 10:51 p.m., Andreas Hartmetz wrote: > > This changeset changes some important parts without obvious (to me) gain. > > Before I spend an hour or two thinking through all the cases, which may or > > may not catch potential regressions, I'd like to

Re: Review Request: kio_http: fix keepalive timeout parsing

> On Oct. 12, 2011, 10:58 p.m., Andreas Hartmetz wrote: > > kioslave/http/http.cpp, line 3107 > > <http://git.reviewboard.kde.org/r/102822/diff/1/?file=38514#file38514line3107> > > > > I guess the parser just lowercases the key ("keep-alive"), n

Re: Review Request: kio_http: fix keepalive timeout parsing

ashtable. In many cases the values are case sensitive (usernames, something Base64-encoded for example), so the parser better leaves them alone. So you need to normalize the case yourself. - Andreas Hartmetz On Oct. 10, 2011, 10:35 p.m., Andrea

Re: Review Request: Cleanup the use of HTTPProtocol::httpClose

me) gain. Before I spend an hour or two thinking through all the cases, which may or may not catch potential regressions, I'd like to know what this does for us. The current approach of acting a bit dumb seems more robust. - Andreas Hartmetz On Oct. 8, 2011, 5:16 a.m., Dawit Alemayehu

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

> On Sept. 25, 2011, 2:20 p.m., Andreas Hartmetz wrote: > > I'd actually be interested to hear which testing you did. > > > > The "ResolveHostNamesBeforeProxyCheck" option seems strange. In which > > situations is this supposed to be set / not

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/#review6927 --- Ship it! Ship It! - Andreas Hartmetz On Sept. 25, 2011, 4

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

aces are already a big problem in this ioslave, which is why I'm very sensitive to such things. - Andreas Hartmetz On Sept. 27, 2011, 9:12 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically gener

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

unclear to me. If there is too much in between, it is hard to guarantee that the variable has the correct value where it is used. - Andreas Hartmetz On Sept. 25, 2011, 2:28 a.m., Dawit Alemayehu wrote: > > --- > This is an

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

the use case here? Do you expect ioslaves to try all proxies from the list? Is the list ordered in some way? How is the list of proxy server addresses related to @p url? It's obvious from the name, but it is good practice to state all the important facts in the apidox. kio/kio/kp

Re: Qt5 -> KDE5?

On Monday 09 May 2011 18:03:18 Olivier Goffart wrote: > Hi, > > With Qt5 around the corner[1], I think it is time to start thinking about > KDE5 > > > Raw summary: > - Qt5 is planed to be released in about one year from now if everything > goes well. > - It should be mostly source compatible w

Re: Review Request: Fix for a couple of KIO put-slave-on-hold bugs

On Thursday 28 April 2011 16:05:51 Dawit Alemayehu wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101244/ > --- > > (Update

Re: 4.6 branches created in git again

On Sunday 20 March 2011 15:59:55 Parker Coates wrote: > On Sun, Mar 20, 2011 at 10:09, Andreas Hartmetz wrote: > > On Sunday 20 March 2011 14:38:40 Albert Astals Cid wrote: > >> Can you please be careful and do not create incorrectly 4.6 branches in > >> places where t

Re: 4.6 branches created in git again

On Sunday 20 March 2011 15:17:11 Ian Monroe wrote: > On Sun, Mar 20, 2011 at 09:09, Andreas Hartmetz wrote: > > On Sunday 20 March 2011 14:38:40 Albert Astals Cid wrote: > >> Can you please be careful and do not create incorrectly 4.6 branches in > >> places where t

Re: 4.6 branches created in git again

On Sunday 20 March 2011 14:38:40 Albert Astals Cid wrote: > Can you please be careful and do not create incorrectly 4.6 branches in > places where the branch is called KDE/4.6 (e.g kdelibs and kde-runtime) > > Ian can you kill them? > > Albert Maybe we can go through with renaming the branches t

Re: Review Request: Fix handling of FTP urls whose path name ends with a type code

On Friday 18 March 2011 20:58:52 David Faure wrote: > On Wednesday 16 March 2011, Thiago Macieira wrote: > > Suggestion: > > path.left(path.length() - sizeof ";type="); > > Unreadable. > > > sizeof(";type=") == strlen(";type=X") > > A hidden off-by-one, how nice to have in our co

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Thursday 10 March 2011 08:14:04 Dawit A wrote: > On Wed, Mar 9, 2011 at 6:32 PM, Andreas Hartmetz wrote: > > On Wednesday 09 March 2011 23:43:23 Dawit A wrote: > [snipped] > > >> Yes, it is, but not for those reasons. That entry was not put there > >> si

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wednesday 09 March 2011 23:43:23 Dawit A wrote: > On Wed, Mar 9, 2011 at 2:53 PM, Andreas Hartmetz wrote: > > On Wednesday 09 March 2011 20:06:40 Dawit A wrote: > >> On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > >> > On Wednesday 09 Mar

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wednesday 09 March 2011 20:06:40 Dawit A wrote: > On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > > On Wednesday 09 March 2011, Dawit Alemayehu wrote: > >> proxiedBy always returns true since ftp.protocol no longer contains a > >> "ProxiedBy=" entry. > > > > Yes it does, of course. But t

Re: Future of KSysguard - removing remote monitoring

On Wednesday 09 March 2011 15:00:27 Aaron J. Seigo wrote: > On Tuesday, March 8, 2011, John Tapsell wrote: > > So unless anyone can talk me out of it now, I am going to remove the > > > > ability to monitor remote hosts entirely > > imho: > > instead of eviscerating the application of the prim

Re: Profiles for all KDE-applications

On Wednesday 02 March 2011 15:31:21 Anders Lund wrote: > On Onsdag den 2. marts 2011, Stefan Majewsky wrote: > > On Wed, Mar 2, 2011 at 10:40 AM, Marco Martin wrote: > > > what about having two config file, a primary one that is the "real one" > > > and a set of secondary ones that can be loaded a

Re: Profiles for all KDE-applications

On Saturday 26 February 2011 10:58:23 Jonathan Schmidt-Dominé wrote: > Hi! > > In Mozilla-applications so called “profiles”, sets of user-configuration, > are a quite common feature, Konqueror implements them, too. But wouldn't it > be possibe to provide this feature for all KDE-applications by ch

Re: git workflow draft

On Thursday 17 February 2011 09:01:05 Johannes Sixt wrote: > Am 2/16/2011 22:10, schrieb Stephen Kelly: > > As one of the people asked to describe my idea of the workflow (which > > should focus on rebasing, not merging) I put write up here: > > > > http://community.kde.org/20110213_GitWorkflowAg

Re: Merge or Cherry-Pick?

On Thursday 03 February 2011 08:57:00 Johannes Sixt wrote: > Am 2/3/2011 6:10, schrieb Dawit A: > > What happens if I tested a bug fix and wanted it to push it upstream > > so that it can receive even wider testing, but it just so happens the > > time to tag the next bug fix release is right around

Re: Merge or Cherry-Pick?

On Wednesday 02 February 2011 21:15:31 Aaron J. Seigo wrote: > On Wednesday, February 2, 2011, Thiago Macieira wrote: > > I still think the current procedure is wrong. You're not testing the > > stable release, there's no guarantee that you're solving the problem at > > all, or worse, that you're n

Re: Merge or Cherry-Pick?

On Monday 31 January 2011 23:27:15 Thiago Macieira wrote: > On Monday, 31 de January de 2011 22:58:52 Andreas Pakulat wrote: > > Hi, > > > > something that hasn't been written down as far as I can see (if I > > overlooked it, please point me to it) is what the policy on kdelibs is > > to be now wr

Re: Usefulness of Subject-header of git commit mails

On Monday 24 January 2011 00:13:26 Eike Hein wrote: > > Yep - for the benefit of those who aren't used to the git > jargon (sorry for that), in git the convention is to for- > mat the commit message like this: > > > > > > While deviating from this format is not particularly harm- > ful, git a

Re: KDE library compile error (on the ARM CORTEX-A8)

On Monday 17 January 2011 22:56:47 Thiago Macieira wrote: > On Monday, 17 de January de 2011 22:04:46 АлексаМЎр КузеЌкП wrote: > > Hello! > > I have beagleboard-xm with Gentoo distributive on it. I compile and can > > run Qt 4.7.1 demo. Now I decide install kde from 4.6 branch svn.

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves on hold...

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/#review9523 --- Ship it! I didn't test or review anything in depth, but the analy

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/#review9510 --- /trunk/KDE/kdelibs/kio/kio/scheduler.cpp

Re: kdelibs/kio/kssl/kcm

On Tuesday 23 November 2010 18:28:57 Aaron J. Seigo wrote: > On Tuesday, November 23, 2010, Jonathan Riddell wrote: > > KControl modules are best in kdebase, kdelibs is for libraries not UIs. > > even more specifically: if a KDE application can not be reliably used > without that kcontrol module b