Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-13 Thread Andrea Scarpino
On Sat, May 6, 2017 at 11:37 AM, Ben Cooksley wrote: > Which brings me to the third point of attention. We'll only be adding > projects to the Next Gen CI system at their request going forward. For > Frameworks, Applications and Plasma this is something which we're > essentially assuming we're goi

Re: kde-open5 bug help needed

2017-05-13 Thread Andrea Scarpino
On Tue, May 9, 2017 at 3:14 PM, Albert Astals Cid wrote: > The problem I think is that you need to make the slave aware that it should > not do the redirection, i.e. > void redirection(const QUrl &_url); > should turn into > bool redirection(const QUrl &_url); > > And then on http.cpp set m_is

kde-open5 bug help needed

2017-05-05 Thread Andrea Scarpino
Hi all, I hit a bug[1][2] in kde-open5 when using QDesktopServices::openUrl(myUrl) to open the system browser. The issue is that, since myUrl redirects to another page, kde-open5 (used under the hood by QDesktopServices because XDG_CURRENT_DESKTOP=KDE is set) "fetches" the redirection url and the

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-30 Thread Andrea Scarpino
one. I'm sorry for the mess. - Andrea Scarpino On Aug. 31, 2013, 8:49 a.m., Harald Hvaal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: openSUSE packagers' take on the 3 month release cycle

2013-07-08 Thread Andrea Scarpino
On Monday 08 July 2013 21:55:28 Albert Astals Cid wrote: > From total ignorace, how much time do you need to change a 4.12 to a 4.13 in > a spec file? What is consuming your time doing a packaging of a new > release? We don't just run a sed rule on each spec (pkgbuild, in my case) file. We check

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-06-22 Thread Andrea Scarpino
agebutton.h PRE-CREATION staging/kwidgets/src/widgets/klanguagebutton.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-06-22 Thread Andrea Scarpino
g/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Review Request 111183: Move KLanguageButton to KWidgets

2013-06-22 Thread Andrea Scarpino
utton.h feb2b5b kdeui/widgets/klanguagebutton.cpp c5d8e4b staging/kwidgets/src/CMakeLists.txt 03a7d7a Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-06-22 Thread Andrea Scarpino
946ebf kdeui/widgets/klanguagebutton.h feb2b5b kdeui/widgets/klanguagebutton.cpp c5d8e4b staging/kwidgets/src/CMakeLists.txt 03a7d7a Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-19 Thread Andrea Scarpino
On Tuesday 18 June 2013 19:19:24 Albert Astals Cid wrote: > Sure we could do all that, but given the black magic that is involved in > startkde (or so I've been told), i'd prefer to go for a simpler solution > like the attached patch. > > If anyone is running without qdbus on the path can you give

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Andrea Scarpino
To reply, visit: http://git.reviewboard.kde.org/r/111072/#review34519 --- On June 17, 2013, 5:35 p.m., Andrea Scarpino wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 111071: Drop internal RUBY cmake module

2013-06-17 Thread Andrea Scarpino
x27;s not used. - Andrea --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111071/#review34518 --- On June 17, 2013, 5:30 p

Review Request 111080: Macro*.cmake changes

2013-06-17 Thread Andrea Scarpino
kio/CMakeLists.txt 6af7b6d kio/kio/thumbcreator.h 6cf19d6 kioslave/file/CMakeLists.txt 3237aad staging/kio/src/core/ConfigureChecks.cmake 7e3dca5 staging/knotifications/src/CMakeLists.txt 72d2999 Diff: http://git.reviewboard.kde.org/r/111080/diff/ Testing --- Thanks, Andrea

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wr

Re: Review Request 111070: Drop internal PostgreSQL cmake module

2013-06-17 Thread Andrea Scarpino
-------- On June 17, 2013, 5:27 p.m., Andrea Scarpino wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111070/ >

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wr

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34508 --- On June 17, 2013, 5:26 p.m., Andrea Scarpino wrote: > > ---

Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Andrea Scarpino
--- Use upstream one. Diffs - cmake/modules/CMakeLists.txt 25ea009 cmake/modules/FindX11.cmake f2f879d Diff: http://git.reviewboard.kde.org/r/111072/diff/ Testing --- Thanks, Andrea Scarpino

Review Request 111071: Drop internal RUBY cmake module

2013-06-17 Thread Andrea Scarpino
--- Use upstream FindRuby instead. Diffs - cmake/modules/CMakeLists.txt 25ea009 cmake/modules/FindRUBY.cmake b5d3c0f Diff: http://git.reviewboard.kde.org/r/111071/diff/ Testing --- Thanks, Andrea Scarpino

Review Request 111070: Drop internal PostgreSQL cmake module

2013-06-17 Thread Andrea Scarpino
--- Use upstream one. Diffs - cmake/modules/CMakeLists.txt 25ea009 cmake/modules/FindPostgreSQL.cmake 7955612 Diff: http://git.reviewboard.kde.org/r/111070/diff/ Testing --- Thanks, Andrea Scarpino

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
://git.reviewboard.kde.org/r/111068/diff/ Testing --- Thanks, Andrea Scarpino

Review Request 111068: Drop internal Msgfmt

2013-06-17 Thread Andrea Scarpino
--- Use GETTEXT_MSGFMT_EXECUTABLE from #FindGettext.cmake coming with CMake instead. Diffs - cmake/modules/CMakeLists.txt 25ea009 cmake/modules/FindMsgfmt.cmake 47c6121 Diff: http://git.reviewboard.kde.org/r/111068/diff/ Testing --- Thanks, Andrea Scarpino

Re: Review Request 111067: Drop internal Flex cmake module

2013-06-17 Thread Andrea Scarpino
://git.reviewboard.kde.org/r/111067/diff/ Testing --- Thanks, Andrea Scarpino

Review Request 111067: Drop internal Flex cmake module

2013-06-17 Thread Andrea Scarpino
--- Use upstream FLEX provided by upstream. Diffs - cmake/modules-tests/Flex/CMakeLists.txt 38b6656 cmake/modules/FindFlex.cmake 1b43ae5 Diff: http://git.reviewboard.kde.org/r/111067/diff/ Testing --- Thanks, Andrea Scarpino

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-04-02 Thread Andrea Scarpino
--- > > (Updated March 29, 2013, 1:09 a.m.) > > > Review request for Build System, kdelibs, David Faure, Alexander Neundorf, > and Andrea Scarpino. > > > Description > --- > > Recently ArchLinux decided to ship Qt5 and they did so by making qmak

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-12 Thread Andrea Scarpino
> On March 11, 2013, 6:19 a.m., Andrea Scarpino wrote: > > "I was quite clear: "qmake" must point by default to Qt 4 if Qt 4 present." > > While qtchooser sounds like a great solution to handle this, it only adds > > more confusion from a p

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-11 Thread Andrea Scarpino
> On March 11, 2013, 6:19 a.m., Andrea Scarpino wrote: > > "I was quite clear: "qmake" must point by default to Qt 4 if Qt 4 present." > > While qtchooser sounds like a great solution to handle this, it only adds > > more confusion from a p

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-11 Thread Andrea Scarpino
> On March 11, 2013, 6:19 a.m., Andrea Scarpino wrote: > > "I was quite clear: "qmake" must point by default to Qt 4 if Qt 4 present." > > While qtchooser sounds like a great solution to handle this, it only adds > > more confusion from a p

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

2013-03-11 Thread Andrea Scarpino
setup for qtchooser. Also, every binary points to the latest version in Arch (e.g. python points to python3 not python2) However all this discussion isn't related to Arch itself: I think that binaries with specific version takes precedence, don't they? - Andrea Scarpino On March

Review Request: Respect PYTHONDONTWRITEBYTECODE env variable

2012-11-06 Thread Andrea Scarpino
uses it since 4.8.4 Thanks, Andrea Scarpino