Re: KDE Review: Arianna

2023-02-27 Thread Jonathan Riddell
The epub.js is not in preferred modifiable form. It's cleartext but it's not the source as anyone would want to edit it. The comment at the end says it comes from a mapping called sourceMappingURL=epub.js.map so the full source of this should be included. Jonathan On Sat, 25 Feb 2023 at 13:59,

Re: Re : New repo in kdereview: PlasmaTube

2023-02-27 Thread Jonathan Riddell
Oh yes now I remember it needs a new version of the fork yt-dlp, give that it works fine. So might be worth adding a compile time and/or runtime check for the right version there. Jonathan On Mon, 27 Feb 2023 at 13:14, Jonathan Riddell wrote: > When I compile this and play a video I get an er

Re: Re : New repo in kdereview: PlasmaTube

2023-02-27 Thread Jonathan Riddell
When I compile this and play a video I get an error suggesting youtube-dl isn't happy. I'm using youtube-dl from Ubuntu which is versioned 2021.12.17-1 and looking at the https://ytdl-org.github.io/youtube-dl/download.html site that is the latest version Hspell: can't open /usr/share/hspell/hebr

KDE Review for Kaidan

2023-02-27 Thread Linus Jahn
Hello, I moved Kaidan from playground to kdereview a few days ago and I now created an issue on invent for reviews and comments as the new process suggests. https://invent.kde.org/network/kaidan/-/issues/440 Kaidan is a kirigami chat app for the decentralized XMPP protocol with end-to-end encr

Re: KDE Review: Arianna

2023-02-27 Thread Kevin Kofler
Carl Schwan wrote: > I want to move Arianna to KDE review. Arianna is an ebook reader > currently only supporting epubs. This is based on top of epub.js > and QtWebEngine for the actualy rendering of ebooks as doing that > from scratch in Qt would be too much work. Okular has an EPub backend using