Re: KJournald in KDE-Review

2022-11-03 Thread Kai Uwe Broulik
Hi, nice work! Here's some comments, nitpicks, etc on the code (might apply to other files than the one mentioned, too): * bootmodel.cpp: I don't think you need to call beginResetModel() when you populate it in the constructor * bootmodel.cpp: QAbstractListModel is a flat list with a single

Re: Move Licentia to KDEREVIEW

2022-11-03 Thread Jonathan Riddell
Same question on this one Felipe, are you still interested in working on the app? It seems stuck in kdereview with no recent development. Jonathan On Fri, 8 Jul 2022 at 06:37, Felipe Kinoshita wrote: > Hey, I'd like to move Licentia to > KDEREVIEW. > > Li

Re: Eloquens now on KDEREVIEW)

2022-11-03 Thread Jonathan Riddell
Hi Felipe, there doesn't seem to have been any movement on this for some months, are you still interested in working on it? If it's a useful app it can be added to KDE gear to get releases done for example. Jonathan On Sat, 3 Sept 2022 at 10:40, Tomaz Canabrava wrote: > Hello All, > > All dis