Re: New repo in kdereview: KRecorder

2022-10-21 Thread Albert Astals Cid
El divendres, 21 d’octubre de 2022, a les 23:55:28 (CEST), Devin va escriure: > > make install doesn't install any icon for me with the current master. > > I just checked and indeed, the method I changed to using > ecm_install_icons doesn't seem to have the behaviour I thought it did. > I hadn't v

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Devin
> make install doesn't install any icon for me with the current master. I just checked and indeed, the method I changed to using ecm_install_icons doesn't seem to have the behaviour I thought it did. I hadn't verified it properly because the icon was already preinstalled for me. I reverted to the

Re: New repo in kdereview: QMLKonsole

2022-10-21 Thread Devin
> qrc:/SavedCommandsDialog.qml:44:9: QML PlaceholderMessage: Cannot specify > left, right, and horizontalCenter anchors at the same time. Fixed > When run on X11 doesn't seem to have an icon. Added one explicitly in the app > How happy are with the name given it has "nothing" to do with konsol

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Albert Astals Cid
El divendres, 21 d’octubre de 2022, a les 23:00:46 (CEST), Devin va escriure: > > The app doesn't have an icon when run in X11 > > Hmm, the location the icon installed to might be non-standard. I think > I've fixed it on master now by copying the way other KDE apps install > the icon. make instal

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Devin
> Why the mov vs ogg dance? Seems to have been a bug with the saved audio format not getting applied until the settings model was initialized (in this case, when the dialog opened). It has been fixed now, thanks! > The app doesn't have an icon when run in X11 Hmm, the location the icon installed

Re: New repo in kdereview: QMLKonsole

2022-10-21 Thread Albert Astals Cid
El divendres, 21 d’octubre de 2022, a les 4:28:13 (CEST), Devin va escriure: > Hi everyone, > > I would like to put qmlkonsole through kdereview: > > https://invent.kde.org/plasma-mobile/qmlkonsole > > QMLKonsole is an Qt Quick based terminal emulator application for Plasma > Mobile. qrc:/Save

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Albert Astals Cid
El divendres, 21 d’octubre de 2022, a les 4:25:44 (CEST), Devin va escriure: > Hi everyone, > > There will be some Plasma Mobile Gear applications going through here since > it seems some did not make it through kdereview. Our eventual goal is to > hopefully move them to the KDE Gear release :) >

Re: Plasma Welcome Center on KDEReview

2022-10-21 Thread Nate Graham
Any more concerns or objections? Nate On 10/19/22 11:56, Nate Graham wrote: On 10/19/22 10:03, Albert Astals Cid wrote: El dimecres, 19 d’octubre de 2022, a les 5:22:09 (CEST), Nate Graham va escriure: Ping; if there are no objections I'd consider it approved. I can't still see the tool