Re: Eloquens now on KDEREVIEW

2022-06-21 Thread Felipe Kinoshita
> Could you elaborate why your config.kcfg uses Ints for everything when > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) The API expects ones and zeros for its params, I chose to convert them to booleans to make the API call easier to write and change. I've fixed all the othe

Re: Eloquens now on KDEREVIEW)

2022-06-21 Thread Felipe Kinoshita
> Could you elaborate why your config.kcfg uses Ints for everything when > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) The API expects ones and zeros for its params, I chose to convert them to booleans to make the API call easier to write and change. I've fixed all the othe

Re: Eloquens now on KDEREVIEW

2022-06-21 Thread Nate Graham
On 6/21/22 13:24, Harald Sitter wrote: some desktop file validation: (the last point is because SingleMainWindow isn't actually a valid key, you should remove it I guess) org.kde.eloquens.desktop: hint: value "Qt;KDE;Development;Utility;" for key "Categories" in group "Desktop Entry" contains mo

Re: Eloquens now on KDEREVIEW

2022-06-21 Thread Harald Sitter
On Mon, Jun 20, 2022 at 10:30 PM Felipe Kinoshita wrote: > > For those who don't know, Eloquens is a simple application targeted at > developers/designers, it generates the lorem ipsum text and allows you to > customize it a little bit like adding heading, bullet lists, etc... > > I would also l

Re: Eloquens now on KDEREVIEW

2022-06-21 Thread Felipe Kinoshita
Everything should be fixed now! Thanks, Felipe