Re: Haruna in kdereview

2021-08-09 Thread Albert Astals Cid
El dilluns, 9 d’agost de 2021, a les 22:02:29 (CEST), George Florea Banus va escriure: > On 09.08.2021 22:22, Albert Astals Cid wrote: > > El dilluns, 9 d’agost de 2021, a les 16:23:27 (CEST), George Florea Banus > > va escriure: > >> Or where to go from here. > > Which are your doubts? > > I'd

Re: Haruna in kdereview

2021-08-09 Thread George Florea Banus
On 09.08.2021 22:22, Albert Astals Cid wrote: El dilluns, 9 d’agost de 2021, a les 16:23:27 (CEST), George Florea Banus va escriure: Or where to go from here. Which are your doubts? I'd like to get the review done so I can make a new release. Also, after review, how do I version the app? Do

Re: Haruna in kdereview

2021-08-09 Thread Albert Astals Cid
El dilluns, 9 d’agost de 2021, a les 16:23:27 (CEST), George Florea Banus va escriure: > Or where to go from here. Which are your doubts? Cheers, Albert > > On 19.07.2021 15:54, George Florea Banus wrote: > > Hello > > > > I would like to move Haruna to KDEReview. > > > > Haruna is a media p

Re: Skanpage moved to kdereview

2021-08-09 Thread Albert Astals Cid
El dilluns, 9 d’agost de 2021, a les 17:34:52 (CEST), Harald Sitter va escriure: > it works amazingly well. good job! I mostly only have some nitpicky stuff > > - since the code base is really close to > complete reuse coverage, it might be nice to push it over the finishing > line and then `reuse

Re: Skanpage moved to kdereview

2021-08-09 Thread Harald Sitter
it works amazingly well. good job! I mostly only have some nitpicky stuff - since the code base is really close to complete reuse coverage, it might be nice to push it over the finishing line and then `reuse lint` it to not have it fall behind again - your cmake code is GPL but policy-wise it shou

Re: Haruna in kdereview

2021-08-09 Thread George Florea Banus
On 21.07.2021 19:38, Jonah Brüchert wrote: In AudioTube I've been using this FindYoutubeDl module. Maybe you can make use of it too. And if someone on the list finds a problem with it, let me know so I can also fix it in AudioTube. Sorry for ignoring. I already made a FindYouTubeDl module

Re: Haruna in kdereview

2021-08-09 Thread George Florea Banus
I have addressed everything that was brought to my attention. Let me know if there's more. Or where to go from here. On 19.07.2021 15:54, George Florea Banus wrote: Hello I would like to move Haruna to KDEReview. Haruna is a media player based on mpv, focus is on video playback. https://inve