Re: Blacklisting of PIM from the CI system

2019-12-05 Thread Harald Sitter
It's a good idea. I thought about that briefly. Two problems immediately came to mind that made me discard the idea: a) for builds that are not from git we'd not know the commit count (unless we glue that into the git release commit / tag - which I am not sure we actually want, but is certainly a

Re: Blacklisting of PIM from the CI system

2019-12-05 Thread Harald Sitter
The point is not to do a version compare against it, but to have the actually available sha reported in the build logs. e.g. cmake reports ``` -- Found KF5I18n: /usr/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.64.0.abcd123") ``` On Thu, Dec 5, 2019 at 1:23 AM Kevin Ko

Re: Blacklisting of PIM from the CI system

2019-12-05 Thread Luca Beltrame
Il giorno Thu, 05 Dec 2019 01:23:28 +0100 Kevin Kofler ha scritto: > The git SHA is not going to work for this, because it is not > monotonic. What you really want to know is whether you have something > >= 5.65.0.abcd123, and having a 5.65.0.commithash version is not > >going to tell you that.