HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

2019-11-03 Thread Friedrich W. H. Kossebau
Hi, with KF 5.64 now branched and thus the new deprecation macros going to be released for the first time, now please make sure when in the future marking API as deprecated to use the correct current version, i.e. the one where the deprecation will be made public the first time. So if pushing

Re: KTrip in kdereview

2019-11-03 Thread Nicolas Fella
On Dienstag, 29. Oktober 2019 23:25:44 CET Albert Astals Cid wrote: > El diumenge, 27 d’octubre de 2019, a les 15:29:10 CET, Nicolas Fella va escriure: > You're not calling > KLocalizedString::setApplicationDomain > as far as i can see so translations won't work. Fixed. > It would be good for i

Re: KTrip in kdereview

2019-11-03 Thread Nicolas Fella
On Mittwoch, 30. Oktober 2019 08:57:19 CET Christophe Giboudeaux wrote: > On dimanche 27 octobre 2019 15:29:10 CET Nicolas Fella wrote: > > Hi, > > > > KTrip (https://invent.kde.org/kde/ktrip) has been moved to kdereview. > > Some files don't have a license header (ClockFace.qml, DateInput.qml, > T

Re: KTrip in kdereview

2019-11-03 Thread Nicolas Fella
On Mittwoch, 30. Oktober 2019 12:04:55 CET Jonathan Riddell wrote: > There's a file called LICENSE with the text of the GPL 2. We usually call > this COPYING in KDE. > > Some of the source code files are under the LGPL 2+ so there should be a > copy of that licence too usually in a file called COP

Re: KTrip in kdereview

2019-11-03 Thread Christophe Giboudeaux
On dimanche 27 octobre 2019 15:29:10 CET Nicolas Fella wrote: > Hi, > > KTrip (https://invent.kde.org/kde/ktrip) has been moved to kdereview. > Some files don't have a license header (ClockFace.qml, DateInput.qml, TimezoneTable.qml, plugin.cpp). Christophe