Re: ELF Dissector in kdereview

2019-10-01 Thread Volker Krause
On Tuesday, 1 October 2019 14:06:57 CEST Jonathan Riddell wrote: > The file src/3rdparty/treemap/treemap.cpp is GPL while the rest of the > application is LGPL. This makes the whole application copyable under only > the terms of the GPL. It would be good to have COPYING moved to > COPYING.LIB and

Re: ELF Dissector in kdereview

2019-10-01 Thread Volker Krause
On Tuesday, 1 October 2019 17:28:03 CEST Thiago Macieira wrote: > On Tuesday, 1 October 2019 05:06:57 PDT Jonathan Riddell wrote: > > -isystem > > /usr/include/capstone/.. > > [...] > > > /usr/include/c++/7/cstdlib:75:15: fatal error: stdlib.h: No such file or > > directory > > That -isystem is

Re: ELF Dissector in kdereview

2019-10-01 Thread Michael Reeves
On Tue, Oct 1, 2019, 7:24 AM Elv1313 . wrote: > Hello, > > This tool looks very useful. I am wondering if the Qt 5.11 requirement > isn't a bit overkill given only 2 lines of code require it (git grep > "horizontalAdvance"; > See kdiff3 for the old name of this method. That will work at least to

Re: ELF Dissector in kdereview

2019-10-01 Thread Elv1313 .
> I couldn't compile it, I get The hack for this is to replace all `-isystem` by `-I` in /usr/lib/x86_64-linux-gnu/qt5/mkspecs/ using `sed -i`. However, right, it didn't compile for me either. On Tue, 1 Oct 2019 at 05:07, Jonathan Riddell wrote: > The file src/3rdparty/treemap/treemap.cpp is GP

Re: ELF Dissector in kdereview

2019-10-01 Thread Thiago Macieira
On Tuesday, 1 October 2019 05:06:57 PDT Jonathan Riddell wrote: > -isystem > /usr/include/capstone/.. [...] > /usr/include/c++/7/cstdlib:75:15: fatal error: stdlib.h: No such file or > directory That -isystem is the mistake. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org

Re: ELF Dissector in kdereview

2019-10-01 Thread Jonathan Riddell
The file src/3rdparty/treemap/treemap.cpp is GPL while the rest of the application is LGPL. This makes the whole application copyable under only the terms of the GPL. It would be good to have COPYING moved to COPYING.LIB and a GPL text put in COPYING. src/ui/org.kde.elf-dissector.appdata.xml shou

Re: HiDPI issues with KDE applications

2019-10-01 Thread Alexander Volkov
28.09.2019 18:04, Christoph Cullmann пишет: Hi, I just checked again the HIDPI support of Kate/KWrite on Windows and it "sucked". It seems we never properly did setup the stuff to auto-scale, e.g. the  QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true); call was missing, we o

Re: ELF Dissector in kdereview

2019-10-01 Thread Elv1313 .
Hello, This tool looks very useful. I am wondering if the Qt 5.11 requirement isn't a bit overkill given only 2 lines of code require it (git grep "horizontalAdvance"; using the boundingRect can do something close enough) and this version of Qt isn't very common in major LTS distributions. With th

Re: HiDPI issues with KDE applications

2019-10-01 Thread Alexander Volkov
28.09.2019 18:04, Christoph Cullmann пишет: Hi, I just checked again the HIDPI support of Kate/KWrite on Windows and it "sucked". It seems we never properly did setup the stuff to auto-scale, e.g. the  QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true); call was missing, we o