Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Albert Astals Cid
El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > Hi all, > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ulti

Re: Craft missing icon on start menu shortcut

2019-05-15 Thread Michael Reeves
Yes thanks. On Thu, May 9, 2019, 2:36 PM Ben Cooksley wrote: > On Fri, May 10, 2019 at 3:19 AM Michael Reeves > wrote: > > > > This message has been stuck waiting for approval for three days. Will > someone kindly address this? > > Hi Michael, > > There are currently no messages pending approva

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Nate Graham
+1 from me; the original was good and this looks good too. One minor thing that I don't think should be a blocker: Could we copy FindBolt.cmake into ECM with an eye towards not needing it here in a future release? Nate On 5/15/19 7:27 AM, Daniel Vrátil wrote: Hi all, plasma-thunderbolt is

Re: ksnapshot to unmaintained

2019-05-15 Thread Nate Graham
+1, clearly it is unmaintained, and in fact development has been abandoned given Spectacle's existence. Nate On 5/9/19 5:06 PM, Jonathan Riddell wrote: One would think so, but one would be wrong, at least on the labelling :) https://projects.kde.org/api/v1/projects/extragear/graphics Jonath

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Friedrich W. H. Kossebau
Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. Pushed some small fixes to toplevel CMakeLis

Review Request: plasma-thunderbolt

2019-05-15 Thread Daniel Vrátil
Hi all, plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM for Plasma. I initially submitted the code as a patch against plasma-desktop [0], where it got reviewed, but it was ultimately decided to better put it into a separate repository, since it's not just a KCM but