Re: EBN Still Needed?

2019-03-29 Thread Alexander Semke
On Mittwoch, 27. März 2019 11:26:58 CET Robby Stephenson wrote: > On Tue, Mar 26, 2019 at 4:15 PM Allen Winter wrote: > > I was notified today that the Krazy runs on the EBN have been stuck (due > > to a stale lockfile) > > for over 3 months. Is this an indication that nobody looks at the EBN >

Re: CI system maintainability

2019-03-29 Thread Kevin Ottens
Hello, On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote: > I and others tried to get more reviews done in the past, but actually I > merged more than once stuff that I reviewed but it did break the CI. That I hope we'll get fixed at some point. It's a big big advantage wh

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 9:56 PM Kevin Ottens wrote: > > Hello, > > On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote: > > I and others tried to get more reviews done in the past, but actually I > > merged more than once stuff that I reviewed but it did break the CI. > > Tha

Re: CI system maintainability

2019-03-29 Thread Ovidiu-Florin Bogdan
Hello, A Merge Request in GitLab does not necessarily imply the need for a review by e person. It can just run a pipeline to validate that the code isn't broken. If the pipeline fails, the merge button is not available. We use GitLab at work and we have it set up like this: * Main branches (de

Re: CI system maintainability

2019-03-29 Thread Andrius Štikonas
+1 for this. I think running tests before merging is more acceptable than having mandatory reviews. On 29 March 2019 11:10:52 GMT+00:00, Ovidiu-Florin Bogdan wrote: >Hello, > >A Merge Request in GitLab does not necessarily imply the need for a >review by e person. It can just run a pipeline to

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 10:35 PM David Faure wrote: > > On jeudi 28 mars 2019 16:56:33 CET laurent Montel wrote: > > CI: sometime I look at it, sometime not, sometime some guys informs me that > > it's broken (I remember that Luca told me some days ago that a package > > didn't compile, so I fixed

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 10:33 PM Friedrich W. H. Kossebau wrote: > > Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > > Le jeu

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl wrote: > > Hi, Hi, > > (Sorry for top-posting) > > I fear that a mandatory reviews would add too juch strain on smaller teams. > If there's just one person with an intimate knowledge of the code-base, plus > two co-developers, then who should

Re: CI system maintainability

2019-03-29 Thread David Faure
On jeudi 28 mars 2019 16:56:33 CET laurent Montel wrote: > CI: sometime I look at it, sometime not, sometime some guys informs me that > it's broken (I remember that Luca told me some days ago that a package > didn't compile, so I fixed it). I think the solution to all this is quite simple. If you

Re: CI system maintainability

2019-03-29 Thread Friedrich W. H. Kossebau
Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > > > Giv

Re: CI system maintainability

2019-03-29 Thread Kevin Ottens
Hello, On Friday, 29 March 2019 09:43:44 CET Volker Krause wrote: > On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > > Having mandatory reviews for a central and complex component like > > > akonadi > > > looks like

Re: EBN Still Needed?

2019-03-29 Thread Thomas Baumgart
On Mittwoch, 27. März 2019 11:26:58 CET Robby Stephenson wrote: > On Tue, Mar 26, 2019 at 4:15 PM Allen Winter wrote: > > > I was notified today that the Krazy runs on the EBN have been stuck (due > > to a stale lockfile) > > for over 3 months. Is this an indication that nobody looks at the EB

Re: CI system maintainability

2019-03-29 Thread Volker Krause
On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > Having mandatory reviews for a central and complex component like akonadi > > looks like a very good and obvious idea. > > Yep. Looking at the 18.12 -> 19.04 timeframe

Re: CI system maintainability

2019-03-29 Thread David Faure
[cutting the cross-post by half] On jeudi 28 mars 2019 16:45:51 CET Daniel Vrátil wrote: > That said, I do put up for review everything that is not Akonadi/PIM core > (even changes to PIM components that are not "mine"). The reason I don't do > this for Akonadi is that there's no-one really to rev

Re: CI system maintainability

2019-03-29 Thread Kevin Ottens
Hello, On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > On 2019 M03 28, Thu 16:04:01 CET Boudhayan Gupta wrote: > > As a user, I simply do not want unreviewed crap running on my computer. > > Yes, crap, because no software engineer writes bug-free code all the time, > > and if y