Re: kdereview - xdg-desktop-portal-kde

2017-05-12 Thread Jan Grulich
Hi, thank you so much for the review!! On pátek 12. května 2017 13:21:00 CEST Lamarque Souza wrote: > Hi, > > My review: > > . there are several code style inconsistencies, like "QDialog* parent" and > "Ui::AppChooserDialog * m_dialog". In some places you use app_id while in > other places you

Re: Next Gen CI - frameworks requirements for plasma

2017-05-12 Thread Ben Cooksley
On Fri, May 12, 2017 at 11:09 PM, David Edmundson wrote: > Following up from Ben's email where we won't have master of frameworks in > buidling master of Plasma. > >> If this affects you, please start a > new thread (CC'ing sysadmin and kde-core-devel along with your > Product's main list) stating

Re: kdereview - xdg-desktop-portal-kde

2017-05-12 Thread Lamarque Souza
Hi, My review: . there are several code style inconsistencies, like "QDialog* parent" and "Ui::AppChooserDialog * m_dialog". In some places you use app_id while in other places you use appId. . you use 0 in same places that you should use nullptr. . there is no doxygen documentation at all. .

RE: Next Gen CI - frameworks requirements for plasma

2017-05-12 Thread David Edmundson
Following up from Ben's email where we won't have master of frameworks in buidling master of Plasma. > If this affects you, please start a new thread (CC'ing sysadmin and kde-core-devel along with your Product's main list) stating which specific repositories you need and providing one to two lines

Re: Next Gen CI: framework dependencies for KWin

2017-05-12 Thread Ben Cooksley
On Sun, May 7, 2017 at 4:55 AM, Martin Flöser wrote: > Am 2017-05-06 11:37, schrieb Ben Cooksley: >> Hi Martin, >> This is the second point that requires your attention. If your >> development process is dependent on using the latest development >> version of something which is located in anothe

Re: kdereview - xdg-desktop-portal-kde

2017-05-12 Thread Jan Grulich
Hi, it's been now three weeks and nobody either looked at the code or found any problem and raised objections. Can we proceed next and move this to place where is the rest of Plasma repositories? Or is there a longer period for which I have to wait until this can move on? Regards, Jan On páte