Re: Review Request 114448: kjs: reogranize basic math functions & function checking

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114448/#review102638 --- The patch was not commited 3 years ago. It still applies but

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2017-02-25 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113152/ --- (Updated Feb. 26, 2017, 12:37 a.m.) Status -- This change has been d

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113152/#review102632 --- Patch wasn't commited for years so i guess it wasn't that im

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127866/ --- (Updated Feb. 26, 2017, 12:28 a.m.) Status -- This change has been m

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/ --- (Updated Feb. 26, 2017, 12:26 a.m.) Status -- This change has been d

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review102629 --- Since Samuel did not respond to the improvement requests by

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122252/#review102624 --- No progress here in 2 years and kdelibs is in very-life-supp

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Hugo Pereira Da Costa
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > err. Wait ... > There are rendering issues here once the patch is applied. > See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png > (left is "before", right is "afte

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Albert Astals Cid
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > err. Wait ... > There are rendering issues here once the patch is applied. > See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png > (left is "before", right is "afte