Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2016-10-21 Thread Andreas Sturmlechner
> On Oct. 21, 2016, 5:59 a.m., Martin Gräßlin wrote: > > I think that's too much a change for a bug-fix only library. Is it, really? There's buildsystem changes only, akin to existing switches, and default shipment of kdelibs remains 100% the same, although arguably it's a bigger change than r

Re: Review Request 118366: Porting keyboard module to Framework5

2016-10-21 Thread shivam makkar
> On Oct. 21, 2016, 11:12 a.m., Albert Astals Cid wrote: > > Seems this was somehow forgotten, sadly the patch does not apply anymore > > (or maybe it was commited and this was never closed?). > > > > Could you either upload a new patch if it's still needed or close the > > review if it is now

Re: Review Request 118366: Porting keyboard module to Framework5

2016-10-21 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated Oct. 21, 2016, 11:23 a.m.) Status -- This change has been d

Re: Review Request 118366: Porting keyboard module to Framework5

2016-10-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review100194 --- Seems this was somehow forgotten, sadly the patch does not a