Re: announcement: Kwave is in kdereview

2016-10-17 Thread Jan Kundrát
On úterý 11. října 2016 21:41:09 CEST, Thomas Eschenbacher wrote: the _(...) macro has nothing to do with i18n Isn't that a bit confusing? Underscore is used by gettext to mean the *opposite* from what Kwave uses it for. It is also a reserved identifier in C++. Inventing non-standard idioms w

Re: Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

2016-10-17 Thread Gerhard Gappmeier
> On Oct. 17, 2016, 12:13 p.m., Aleix Pol Gonzalez wrote: > > I'm not sure it's a very good idea to introduce behavior changes in kdelibs > > 4. Why can't you use kde-open from kf5? Because I'm running KDE4 on many machines and want this bug fixed. It's not a solution to switch the newer OS an

Re: Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

2016-10-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129208/#review100093 --- I'm not sure it's a very good idea to introduce behavior cha

Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

2016-10-17 Thread Gerhard Gappmeier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129208/ --- Review request for kdelibs. Repository: kdelibs Description --- RF