Solved: missing dependencies when compiling with Ninja generator

2016-09-19 Thread Andreas Hartmetz
Hello, I did some research to find out why builds with Ninja sometimes miss dependencies, thus producing build failures unless the failing repository is recompiled from scratch. It was a bug (or somewhat justifiable behavior difference between Make and Ninja if you like) in CMake that has been

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/ --- (Updated Sept. 19, 2016, 11:46 a.m.) Status -- This change has been

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread David Faure
> On Sept. 19, 2016, 6:32 a.m., Sune Vuorela wrote: > > konqueror/src/CMakeLists.txt, line 18 > > > > > > I think the comment is wrong. I can't find any zlib references in > > konqueror itself. Also note that th

Re: Review Request 128941: ZLIB dependency is in libkonq since 7635179

2016-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/#review99271 --- Ship it! I cleaned up the toplevel CMakeLists.txt meanwhil