Re: Review Request 128909: initial, minimal support for OS X

2016-09-14 Thread Thiago Macieira
On quarta-feira, 14 de setembro de 2016 17:58:26 PDT René J.V. Bertin wrote: > > On Sept. 14, 2016, 7:33 p.m., Anthony Fieroni wrote: > > > processcore/processes_darwin_p.cpp, line 104 > > > > > line104>> > > > > *inlin

Re: Review Request 128909: initial, minimal support for OS X

2016-09-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128909/#review99182 --- Other than that, the patch LGTM. processcore/helper.cpp (li

Re: Review Request 128909: initial, minimal support for OS X

2016-09-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128909/ --- (Updated Sept. 14, 2016, 9:37 p.m.) Review request for KDE Base Apps and

Review Request 128910: [kio_trash] Fill in UDS_LOCAL_PATH in UDSEntry

2016-09-14 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128910/ --- Review request for KDE Runtime, KDE Frameworks and David Faure. Bugs: 208

Re: Review Request 128909: initial, minimal support for OS X

2016-09-14 Thread René J . V . Bertin
> On Sept. 14, 2016, 7:33 p.m., Anthony Fieroni wrote: > > processcore/processes_darwin_p.cpp, line 104 > > > > > > *inline* must be used in function definition not in declaration. I didn't see the point of the

Re: Review Request 128909: initial, minimal support for OS X

2016-09-14 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128909/#review99173 --- processcore/processes_darwin_p.cpp (line 104)

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

2016-09-14 Thread Christoph Feck
> On Aug. 16, 2016, 9:05 a.m., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but the

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

2016-09-14 Thread Burkhard Lück
> On Aug. 16, 2016, 7:05 vorm., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but th

Review Request 128909: initial, minimal support for OS X

2016-09-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128909/ --- Review request for KDE Base Apps and KDE Software on Mac OS X. Repository

Re: Review Request 128685: Proofread + update performance kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128685/ --- (Updated Sept. 14, 2016, 2:25 nachm.) Status -- This change has been

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

2016-09-14 Thread Burkhard Lück
> On Aug. 16, 2016, 7:05 vorm., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but th

Re: Splitting kde-baseapps?

2016-09-14 Thread Luigi Toscano
On Wednesday, 14 September 2016 15:46:28 CEST Burkhard Lück wrote: > Hi, > > what is the future of the kde-basapps repo? > > It consists of: > > 1) Konqueror code + docbooks in subdirs doc, konq-plugins, konqueror + lib > > 2) kfind code + docbook in subdir kfind > > 3) kdepasswd (don't we h

Re: Review Request 128693: Proofread + update khtml-java-js kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128693/ --- (Updated Sept. 14, 2016, 1:49 nachm.) Status -- This change has been

Re: Review Request 128690: Proofread + update khtml-adblock kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128690/ --- (Updated Sept. 14, 2016, 1:48 nachm.) Status -- This change has been

Re: Review Request 128691: Proofread + update history kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128691/ --- (Updated Sept. 14, 2016, 1:49 nachm.) Status -- This change has been

Re: Review Request 128689: Proofread + update kcmcss kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128689/ --- (Updated Sept. 14, 2016, 1:48 nachm.) Status -- This change has been

Re: Review Request 128688: Proofread + update khtml-behavior kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128688/ --- (Updated Sept. 14, 2016, 1:48 nachm.) Status -- This change has been

Re: Review Request 128687: Proofread + update filemanager kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128687/ --- (Updated Sept. 14, 2016, 1:47 nachm.) Status -- This change has been

Re: Review Request 128686: Proofread + update bookmarks kcm docbook

2016-09-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128686/ --- (Updated Sept. 14, 2016, 1:46 nachm.) Status -- This change has been

Splitting kde-baseapps?

2016-09-14 Thread Burkhard Lück
Hi, what is the future of the kde-basapps repo? It consists of: 1) Konqueror code + docbooks in subdirs doc, konq-plugins, konqueror + lib 2) kfind code + docbook in subdir kfind 3) kdepasswd (don't we have already a similar dialog in frameworks/ kwidgetaddons?) 4) kdialog 5) keditbookmark